From 9ab2a3ae3df5e0342b6fb030c183012e23e972f2 Mon Sep 17 00:00:00 2001 From: Gaetan Craig-Riou Date: Mon, 11 Nov 2024 16:19:54 +1100 Subject: [PATCH] Per review, fix a some minor issues --- app/controllers/checkout_controller.rb | 2 +- spec/requests/spree/admin/payments_spec.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/app/controllers/checkout_controller.rb b/app/controllers/checkout_controller.rb index 904d0d5b05..b41eeb5265 100644 --- a/app/controllers/checkout_controller.rb +++ b/app/controllers/checkout_controller.rb @@ -80,7 +80,7 @@ class CheckoutController < BaseController # Redeem VINE voucher vine_voucher_redeemer = Vine::VoucherRedeemerService.new(order: @order) - if vine_voucher_redeemer.redeem == false + unless vine_voucher_redeemer.redeem # rubocop:disable Rails/DeprecatedActiveModelErrorsMethods flash[:error] = if vine_voucher_redeemer.errors.keys.include?(:redeeming_failed) vine_voucher_redeemer.errors[:redeeming_failed] diff --git a/spec/requests/spree/admin/payments_spec.rb b/spec/requests/spree/admin/payments_spec.rb index 7992064410..f8e9f6e3c6 100644 --- a/spec/requests/spree/admin/payments_spec.rb +++ b/spec/requests/spree/admin/payments_spec.rb @@ -47,7 +47,7 @@ RSpec.describe Spree::Admin::PaymentsController, type: :request do end end - context "when a getway error happens" do + context "when a gateway error happens" do let(:payment_method) do create(:stripe_sca_payment_method, distributors: [order.distributor]) end