raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-01-24 20:36:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove some usage of guard clauses for OC update

Browse Source
This commit is contained in:
Kristina Lim
2019-05-28 20:28:37 +08:00
parent 56a2347ea0
commit 75fdfb3c6a
1 changed files with 12 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
lib/open_food_network/order_cycle_form_applicator.rb
View File

@@ -79,26 +79,23 @@ module OpenFoodNetwork
def update_exchange(sender_id, receiver_id, incoming, attrs = {})
exchange = @order_cycle.exchanges.where(sender_id: sender_id, receiver_id: receiver_id, incoming: incoming).first
return unless permission_for(exchange)
remove_unauthorized_exchange_attributes(exchange, attrs)
variant_ids = attrs.delete :variant_ids
exchange.update_attributes!(attrs)
ExchangeVariantBulkUpdater.new(exchange).update!(variant_ids) unless variant_ids.nil?
if permission_for exchange
variant_ids = attrs.delete :variant_ids
exchange.update_attributes!(attrs)
ExchangeVariantBulkUpdater.new(exchange).update!(variant_ids) unless variant_ids.nil?
@touched_exchanges << exchange
end
@touched_exchanges << exchange
end
def remove_unauthorized_exchange_attributes(exchange, exchange_attrs)
unless manages_coordinator? || manager_for(exchange)
exchange_attrs.delete :enterprise_fee_ids
exchange_attrs.delete :pickup_time
exchange_attrs.delete :pickup_instructions
exchange_attrs.delete :tag_list
end
return if manages_coordinator? || manager_for(exchange)
exchange_attrs.delete :enterprise_fee_ids
exchange_attrs.delete :pickup_time
exchange_attrs.delete :pickup_instructions
exchange_attrs.delete :tag_list
end
def destroy_untouched_exchanges