raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-03-21 05:09:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

Extract removal of unauthorized OC exchange attributes to method

Browse Source
This commit is contained in:
Kristina Lim
2019-05-28 20:27:03 +08:00
parent ea8d189d6c
commit 56a2347ea0
1 changed files with 10 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
lib/open_food_network/order_cycle_form_applicator.rb
View File

@@ -79,13 +79,7 @@ module OpenFoodNetwork
def update_exchange(sender_id, receiver_id, incoming, attrs = {})
exchange = @order_cycle.exchanges.where(sender_id: sender_id, receiver_id: receiver_id, incoming: incoming).first
unless manages_coordinator? || manager_for(exchange)
attrs.delete :enterprise_fee_ids
attrs.delete :pickup_time
attrs.delete :pickup_instructions
attrs.delete :tag_list
end
remove_unauthorized_exchange_attributes(exchange, attrs)
if permission_for exchange
variant_ids = attrs.delete :variant_ids
@@ -98,6 +92,15 @@ module OpenFoodNetwork
end
end
def remove_unauthorized_exchange_attributes(exchange, exchange_attrs)
unless manages_coordinator? || manager_for(exchange)
exchange_attrs.delete :enterprise_fee_ids
exchange_attrs.delete :pickup_time
exchange_attrs.delete :pickup_instructions
exchange_attrs.delete :tag_list
end
end
def destroy_untouched_exchanges
if manages_coordinator?
untouched_exchanges.each(&:destroy)