Merge pull request #3960 from mkllnk/test-spec-stability

Remove retries from previously flaky specs

spec/features/admin/orders_spec.rb

@@ -84,7 +84,7 @@ feature '
     expect(o.order_cycle).to eq(@order_cycle)
   end
 
-  scenario "can add a product to an existing order", retry: 3 do
+  scenario "can add a product to an existing order" do
     quick_login_as_admin
     visit '/admin/orders'
 

spec/features/admin/variant_overrides_spec.rb

@@ -426,7 +426,7 @@ feature "
           select2_select hub.name, from: 'hub_id'
         end
 
-        it "alerts the user to the presence of new products, and allows them to be added or hidden", retry: 3 do
+        it "alerts the user to the presence of new products, and allows them to be added or hidden" do
           expect(page).to have_no_selector "table#variant-overrides tr#v_#{variant1.id}"
           expect(page).to have_no_selector "table#variant-overrides tr#v_#{variant2.id}"
 

spec/features/consumer/shopping/checkout_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-feature "As a consumer I want to check out my cart", js: true, retry: 3 do
+feature "As a consumer I want to check out my cart", js: true do
   include AuthenticationWorkflow
   include ShopWorkflow
   include CheckoutWorkflow

spec/features/consumer/shopping/variant_overrides_spec.rb

@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-feature "shopping with variant overrides defined", js: true, retry: 3 do
+feature "shopping with variant overrides defined", js: true do
   include AuthenticationWorkflow
   include WebHelper
   include ShopWorkflow