raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-01-30 21:27:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #12298 from mkllnk/devise-links

Browse Source 
Remove unused Devise login links partial
This commit is contained in:
David Cook
2024-03-25 12:57:39 +11:00
committed by GitHub
parent 42520216aa c6e88e70c3
commit 52a36f33bc
1 changed files with 8 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
app/views/devise/shared/_links.html.erb
View File

@@ -1,19 +1,11 @@
<%- if controller_name != 'sessions' %>
<%= link_to t(".sign_in"), new_session_path(resource_name) %><br />
<% end %>
<%# Override Devise partial
<%- if devise_mapping.registerable? && controller_name != 'registrations' %>
<%= link_to t(".sign_up"), new_registration_path(resource_name) %><br />
<% end %>
While this partial is unused in our app, Devise still renders it during
password reset and it fails to find `omniauth_authorize_path` which tries
to call `spree_user_openid_connect_omniauth_authorize_path` on our main app
while that helper is only defined on `Spree::Core::Engine.routes.url_helpers`.
<%- if devise_mapping.recoverable? && controller_name != 'passwords' && controller_name != 'registrations' %>
<%= link_to t(".forgot_your_password"), new_password_path(resource_name) %><br />
<% end %>
This is just a workaround and the proper solution would be to include all Spree
routes in our main Rails app instead of having a separate Spree::Core engine.
<%- if devise_mapping.confirmable? && controller_name != 'confirmations' %>
<%= link_to t('.didn_t_receive_confirmation_instructions'), new_confirmation_path(resource_name) %><br />
<% end %>
<%- if devise_mapping.lockable? && resource_class.unlock_strategy_enabled?(:email) && controller_name != 'unlocks' %>
<%= link_to t('.didn_t_receive_unlock_instructions'), new_unlock_path(resource_name) %><br />
<% end %>
%>