raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-02-05 22:26:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove unused Devise login links partial content

Browse Source 
The purpose of this file was unclear and it was flagging additional
maintenance like missing translations.
This commit is contained in:
Maikel Linke
2024-03-21 09:49:11 +11:00
parent 4ada3edc4e
commit c6e88e70c3
1 changed files with 8 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
app/views/devise/shared/_links.html.erb
View File

@@ -1,19 +1,11 @@
<%- if controller_name != 'sessions' %>
<%= link_to t(".sign_in"), new_session_path(resource_name) %><br />
<% end %>
<%# Override Devise partial
<%- if devise_mapping.registerable? && controller_name != 'registrations' %>
<%= link_to t(".sign_up"), new_registration_path(resource_name) %><br />
<% end %>
While this partial is unused in our app, Devise still renders it during
password reset and it fails to find `omniauth_authorize_path` which tries
to call `spree_user_openid_connect_omniauth_authorize_path` on our main app
while that helper is only defined on `Spree::Core::Engine.routes.url_helpers`.
<%- if devise_mapping.recoverable? && controller_name != 'passwords' && controller_name != 'registrations' %>
<%= link_to t(".forgot_your_password"), new_password_path(resource_name) %><br />
<% end %>
This is just a workaround and the proper solution would be to include all Spree
routes in our main Rails app instead of having a separate Spree::Core engine.
<%- if devise_mapping.confirmable? && controller_name != 'confirmations' %>
<%= link_to t('.didn_t_receive_confirmation_instructions'), new_confirmation_path(resource_name) %><br />
<% end %>
<%- if devise_mapping.lockable? && resource_class.unlock_strategy_enabled?(:email) && controller_name != 'unlocks' %>
<%= link_to t('.didn_t_receive_unlock_instructions'), new_unlock_path(resource_name) %><br />
<% end %>
%>