raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-03-18 04:39:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add section for prioritization of PRs

Kristina Lim
2019-02-05 17:43:26 +08:00
parent 6d13e20a90
commit d5dfc65721
1 changed files with 30 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
Code-review-process.md Normal file

@@ -0,0 +1,30 @@
## Prioritization of Pull Requests
We manage the priority of PRs in the "Code Review" pipeline in Zenhub.
### Choosing a PR to review
A reviewer should choose the next PR from the top which they haven't reviewed yet in the PR's current round of reviews.
### Adding a PR to the pipeline
When adding a PR to the pipeline, do not simply add it to the top (LIFO) or the bottom (FIFO) of the pipeline.
From the following list, identify the first category that the PR meets, and add the PR to the bottom (FIFO) of the section of the pipeline for this category. The categories would follow the same order as below.
1. General blockers - For example, if the PR fixes a bug that prevents deployment or fixes failing tests in `master`.
2. S1 and S2 bugs
3. PRs no longer in 1st round of reviews
4. PRs with minimal review needed
5. Other bugs and features
Let's say that, in the pipeline, there is a PR for an S2 bug and a feature PR that is already in its 2nd round of reviews. See the following examples:
Category | PR in Pipeline |  
--- | --- | ---
S1 and S2 bugs | PR for S2 bug |
S1 and S2 bugs |   | <- Insert PR for S1 bug
S1 and S2 bugs |   | <- Insert another PR for S2 bug
PRs no longer in 1st round of reviews | PR in 2nd round of reviews |
PRs no longer in 1st round of reviews |   | <- Insert another PR in 2rd round of reviews
Other bugs and features |   | <- Insert new PR for feature