mirror of
https://github.com/openfoodfoundation/openfoodnetwork
synced 2026-04-05 07:19:14 +00:00
ca3c0c98bf
Grouping is a nice feature, but it wasn't helpful here. If there's an error in rubocop for example, the rubocop section will be collapsed, and because we didn't close the group, the haml group was always open. So it wasn't clear where the error was. Better to just show all the output, which isn't very long, so you can see where the problem is straight away. Even better would be to add support for GitHub Actions annotations. I thought we used to have that turned on, not sure why it's not working now.
57 lines
1.4 KiB
Bash
Executable File
57 lines
1.4 KiB
Bash
Executable File
#!/bin/bash
|
|
|
|
#
|
|
# Runs linters and pipes their output to reviewdog so it annotates a pull request with the issues found
|
|
#
|
|
|
|
set -o pipefail
|
|
|
|
echo -e "\nRunning prettier with reviewdog 🐶 ..."
|
|
|
|
"$(npm root)/.bin/prettier" --check . 2>&1 | sed --regexp-extended 's/(\[warn\].*)$/\1 File is not properly formatted./' \
|
|
| reviewdog \
|
|
-efm="%-G[warn] Code style issues found in %s. Run Prettier to fix. File is not properly formatted." \
|
|
-efm="[%tarn] %f %m" \
|
|
-efm="%E[%trror] %f: %m (%l:%c)" \
|
|
-efm="%C[error]%r" \
|
|
-efm="%Z[error]%r" \
|
|
-efm="%-G%r" \
|
|
-name="prettier" \
|
|
-reporter="github-pr-annotations" \
|
|
-filter-mode="nofilter" \
|
|
-fail-level="any" \
|
|
-level="error" \
|
|
-tee
|
|
|
|
prettier=$?
|
|
|
|
echo -e "\nRunning rubocop with reviewdog 🐶 ..."
|
|
|
|
bundle exec rubocop \
|
|
--fail-level info \
|
|
| reviewdog -f="rubocop" \
|
|
-name="rubocop" \
|
|
-reporter="github-pr-annotations" \
|
|
-filter-mode="nofilter" \
|
|
-level="error" \
|
|
-fail-level="any" \
|
|
-tee
|
|
|
|
rubocop=$?
|
|
|
|
echo -e "\nRunning haml-lint with reviewdog 🐶 ..."
|
|
|
|
bundle exec haml-lint \
|
|
--fail-level warning \
|
|
| reviewdog -f="haml-lint" \
|
|
-name="haml-lint" \
|
|
-reporter="github-pr-annotations" \
|
|
-filter-mode="nofilter" \
|
|
-level="error" \
|
|
-fail-level="any" \
|
|
-tee
|
|
|
|
haml_lint=$?
|
|
|
|
! (( prettier || rubocop || haml_lint ))
|