Maikel
1e1706d371
Merge pull request #7280 from Matt-Yorkley/atomic
...
Remove atomic gem
2021-05-20 17:53:36 +10:00
Andy Brett
70ac719725
Merge pull request #7649 from andrewpbrett/payments-when-out-of-stock
...
Check stock before doing anything related to admin payments
2021-05-19 14:45:38 -07:00
Luis Ramos
f7726e552a
Adapt code coming from master to the new order api with update_order!
2021-05-19 10:09:42 -07:00
Luis Ramos
a1ac4e85ed
Replace update_attributes with update
2021-05-19 09:54:25 -07:00
Luis Ramos
f8e5370b0b
Replace update_attributes with update
2021-05-19 09:54:25 -07:00
Luis Ramos
fb560089b9
Replace usages of update_attributes! with usage of update!
2021-05-19 09:54:25 -07:00
Luis Ramos
b2e97fe1d2
Rename order.update! to order.update_order! and adjustment.update! to adjustment.update_adjustment!
2021-05-19 09:54:22 -07:00
Matt-Yorkley
5dd24623f7
Merge pull request #7479 from Matt-Yorkley/payment-callbacks
...
Update Payment after_save callback
2021-05-18 16:19:29 +02:00
Matt-Yorkley
794216713a
Ensure payment is processed if order is in completed state
2021-05-16 23:03:07 +01:00
Matt-Yorkley
8429da3d2a
Remove unused argument from ProcessPaymentIntent
2021-05-16 22:19:01 +01:00
Matt-Yorkley
381b0e78d5
Improve ProcessPaymentIntent specs
2021-05-16 20:14:14 +01:00
Matt-Yorkley
05ed98aa0c
Use :order_with_totals in ProcessPaymentIntent
...
If we just use the :order factory here, it has no line items and no total, which means when we try to push it into complete state, the #requires_payment? check fails because the order total is zero, which means the call to #process_payments is ignored
2021-05-16 20:11:45 +01:00
Matt-Yorkley
16e3af9b49
Update OrderController spec
2021-05-16 20:11:45 +01:00
Matt-Yorkley
227bdd7d4c
Update ProcessPaymentIntent spec
2021-05-16 12:55:48 +01:00
Matt-Yorkley
471a7903f6
Update PaymentIntentValidator spec
2021-05-16 12:19:04 +01:00
Matt-Yorkley
37177e7207
Add test coverage to StripeSCA spec
2021-05-16 12:19:04 +01:00
Andy Brett
ca38948e21
check stock before doing anything related to admin payments
2021-05-14 17:42:37 -07:00
Matt-Yorkley
2e248744c0
Merge pull request #7520 from Matt-Yorkley/shipment-controller
...
Shipment controller: test coverage and improvements
2021-05-13 20:26:51 +02:00
Matt-Yorkley
99cf23df26
Merge pull request #7530 from Matt-Yorkley/email-after-commit
...
Email after commit
2021-05-12 21:22:55 +02:00
Matt-Yorkley
f49d4592a0
Merge pull request #7506 from guidoDutra/5546-prevent-deleting-only-item-in-confirmed-order
...
prevent deleting only item in confirmed order
2021-05-12 21:10:09 +02:00
Matt-Yorkley
e60a513c88
Merge pull request #7571 from coopdevs/make-specs-accurate
...
Properly mock validator and extend tests
2021-05-11 22:24:01 +02:00
Matt-Yorkley
902bbf7dc4
Merge pull request #7576 from Matt-Yorkley/bulk-line-items
...
Add test coverage to BulkLineItemsController actions
2021-05-11 01:47:17 +02:00
Andy Brett
d29ef0d7b1
Merge branch 'master' into make-specs-accurate
2021-05-10 16:10:33 -07:00
Andy Brett
d2a3d9049f
Merge pull request #7588 from andrewpbrett/enterprise-permalink-spec
...
[Rails 6.0] Fix enterprise permalink spec
2021-05-10 15:30:45 -07:00
Andy Brett
17a0063b40
Merge pull request #7402 from filipefurtad0/products_spec_add_ons
...
Adds coverage for product deletion and cloning
2021-05-10 06:26:11 -07:00
Andy Brett
cbefa5f882
Merge pull request #7589 from andrewpbrett/order-adjustments-spec
...
[Rails 6.0] Fix order adjustments spec
2021-05-09 10:38:19 -07:00
Andy Brett
231f01dad2
fix order adjustments spec
2021-05-09 10:09:22 -07:00
Matt-Yorkley
24a5407c8f
Merge pull request #7565 from luisramos0/rails6_success
...
[Rails 6.0] Replace be_success on test_response with status 200
2021-05-09 02:33:49 +02:00
Andy Brett
dd851edbdc
fix enterprise permalink spec
2021-05-08 14:21:45 -07:00
Matt-Yorkley
43e41f4980
Add more explicit test coverage to BulkLineItemsController acitons
...
This spec includes taxes on line items, fees on the order and on line items, taxes on fees (inherited and non-inherited), shipping and payment fees and taxes on shipping. It checks all of these things are correctly updated after the order is changed via BOM.
2021-05-07 11:54:04 +01:00
Pau Pérez Fabregat
8d8abed529
Merge pull request #7496 from jibees/4957-flaky-specs
...
Uncomment flaky spec on variant_overrides_spec.rb
2021-05-07 10:29:36 +02:00
Pau Perez
fd5e0fd60f
Properly mock validator and extend tests
...
Tests were passing but not due to the expected reason. While at it, we
extended the assertions to be more precise.
2021-05-07 08:35:54 +02:00
Luis Ramos
a2de86c23e
Replace be_success on test_reponse with status 200
...
In rails 6 response.success? is not supported.
2021-05-06 23:51:30 +01:00
Pau Perez
9a63f38790
I18n-ize error messages.
2021-05-06 16:34:29 +02:00
Pau Perez
69b91ea136
Wait until the end to mark payment as processed
...
This gives us the opportunity to retry the operation in case the
processing fails.
2021-05-06 16:19:01 +02:00
Pau Perez
dea6a01e61
Handle SCA payments that can't complete
2021-05-06 16:19:01 +02:00
Pau Perez
2147584daf
Validate intents against Stripe and display errors
...
Now the existing validation is redundant. It's Stripe's API who does
that now. It's up to them to decide what's a valid intent.
2021-05-06 16:19:01 +02:00
Matt-Yorkley
00c4a28d22
Extract order-updating logic to Order::Updater
2021-05-04 16:40:10 +01:00
Matt-Yorkley
8e10f7af0e
Update payments controller test setup
...
We need to use a completed order in the test setup here or it doesn't behave correctly. `order.completed_at` is nil, for example.
2021-05-04 16:40:10 +01:00
Matt-Yorkley
135a311c05
Update void payments
...
Backport from Spree 2.4 stable: 4121992398
2021-05-04 16:40:10 +01:00
Matt-Yorkley
13bb5aa8dd
Update Payment after_save callback
...
Backport from Spree 2.4 stable: 4d652a77fd
2021-05-04 16:40:09 +01:00
filipefurtad0
a476416dc4
Removes html tr tag; Clarifies it block
2021-05-03 17:03:34 +01:00
Matt-Yorkley
4888f1cd06
Stub OrderPaymentFinder to return correct object
...
OrderPaymentFinder was re-fetching the payment object from the database, so the subsequent line that stubs #authorize! on that payment was not being applied to the correct object.
2021-05-03 14:17:54 +01:00
Matt-Yorkley
ab65b01fcf
Rename payments helper
2021-05-03 14:17:54 +01:00
Luis Ramos
279c15c306
Adapt spec to rails 5.2
2021-05-03 14:17:54 +01:00
Luis Ramos
47a5809100
Fix rspec syntax
2021-05-03 14:17:54 +01:00
Luis Ramos
aaf4710694
Fix cart_service_spec to adapt to the actual usage of it from cart_controller, params are now sent inside a Parameters object, not as a hash
2021-05-03 14:17:54 +01:00
Andy Brett
ea5f9c6747
Revert "Fix cart_service_spec to adapt to the actual usage of it from cart_controller, params are now sent inside a Parameters object, not as a hash"
...
This reverts commit bb465b5715
2021-05-03 14:17:54 +01:00
Andy Brett
be0eb5f5f9
ignore nil in payment report spec expectation
2021-05-03 14:17:54 +01:00
Matt-Yorkley
943c00c924
WIP - Update loading of helpers in controllers
...
Rails has changed the way helpers are loaded. It's a bit weird. It was throwing lots of errors, and recommended using this setting, but now requires that all helpers are loaded explicitly. I'm not sure about this.
2021-05-03 14:17:54 +01:00
