David Cook
e50bd196d0
Update spec/system/admin/configuration/states_spec.rb
...
Co-authored-by: Maikel <maikel@email.org.au >
2025-02-13 09:11:55 +11:00
David Cook
c29b15d5f6
Wait less for condition
...
This code was waiting up to 20 seconds, but only checking every two seconds, which means it could be wasting up to 2s everytime it runs.
Instead, we can use Capybara's waiting mechanism, which by default waits up to 20 seconds (but no doubt is optimised to be much more responsive).
2025-02-12 15:09:46 +11:00
David Cook
f55cdcdd34
Ensure pages have contextual navigation
...
It would be good to know if it breaks!
I didn't think it worth updating every single settings specs to test for this...
But I've tested on the 'general settings' page because this is the default page when clicking on 'Configuration'.
2025-02-12 15:01:54 +11:00
David Cook
177445521c
Move most images to asset pipeline
...
Webpacker still needs to know about them in order to build links.
2025-02-03 17:44:13 +11:00
Filipe
54fad01a91
Merge pull request #13104 from mkllnk/test-seeds
...
Remove unused preference default_country_id
2025-01-30 21:59:46 -06:00
Filipe
32c4b4557b
Merge pull request #13086 from rioug/fix-tax-rate-refund
...
Remove tax rate refund code path
2025-01-30 21:54:30 -06:00
Filipe
e2161660b3
Merge pull request #13090 from mkllnk/replace-spree-roles
...
Replace spree roles
2025-01-30 21:30:56 -06:00
Maikel Linke
6885184bcc
Remove unused preference default_country_id
2025-01-28 16:31:45 +11:00
Gaetan Craig-Riou
fa4785bc85
Merge pull request #13096 from mkllnk/assets
...
Compile assets on demand in test local environment
2025-01-27 13:00:10 +11:00
Gaetan Craig-Riou
be78c2ac41
Fix system admin adjustment spec
2025-01-27 11:02:50 +11:00
Gaetan Craig-Riou
900b751559
Revert change from d58aa2b14f44fa15b67a18cf3457eccaaca5a56c
...
Turns out there seem to be a legitimate use for this code, see
spec/system/admin/adjustments_spec.rb ie, adding a manual discount to an
order using an adjustment.
2025-01-27 11:02:50 +11:00
Gaetan Craig-Riou
cd7e92c6ca
Fix various spec
2025-01-27 11:02:41 +11:00
Gaetan Craig-Riou
6b7373e4cf
Clean up spec syntax
2025-01-27 11:01:07 +11:00
Gaetan Craig-Riou
6e8eb443c1
Consolidate .adjust specs
2025-01-27 11:01:07 +11:00
Gaetan Craig-Riou
42df158669
Fix TaxRate#compute_amount
...
Remove the code path that can create a tax refund, it is unlikely to
happen with the configuration our instances are using. Instead return 0
do that no adjustment gets created
2025-01-27 11:01:07 +11:00
Gaetan Craig-Riou
5e42a9be55
Fix TaxRate spec to work with the zone changes
2025-01-27 11:01:07 +11:00
Gaetan Craig-Riou
d4a060c6a2
Fix Zone system spec
2025-01-27 11:01:07 +11:00
Gaetan Craig-Riou
a953e3dde3
Fix Spree::Zone spec and factory
2025-01-27 11:01:07 +11:00
Gaetan Craig-Riou
75c0752340
Sree::Zone, require at least one member
...
Add validations and specs
2025-01-27 11:01:07 +11:00
Gaetan Craig-Riou
bcb4525cdd
Clean up spec, use describe instead of context
...
Although `describe` and `context` are functionally equivalent, they
don't convey the same message
2025-01-27 11:01:07 +11:00
Konrad
01036e6321
Merge pull request #13087 from mkllnk/stock-location
...
Remove class Spree::StockLocation
2025-01-25 12:41:37 +01:00
David Cook
09fe6d7542
Merge pull request #13091 from mkllnk/flaky-ship
...
Fix flaky spec of order shipment
2025-01-24 15:02:19 +11:00
David Cook
f6bd1c49ee
Apply suggestions from code review
2025-01-24 14:52:54 +11:00
David Cook
bb040812aa
Refactor spec
2025-01-24 14:49:18 +11:00
David Cook
e38d305ca1
Merge pull request #13089 from mkllnk/haml-up-remove
...
Remove unneeded HAML upgrade script
2025-01-24 14:23:56 +11:00
Maikel Linke
f21f8f38da
Compile assets on demand in test environment
...
We still do it in CI to prevent flaky specs. Otherwise, when a spec
needs to compile assets, it may time out.
2025-01-24 12:10:09 +11:00
Filipe
5d360730c7
Merge pull request #13023 from rioug/12907-fix-checkout-shipping-fee
...
[Checkout] Shipping fees update, remove order callback
2025-01-23 18:50:31 -06:00
Konrad
0b8807146e
Merge pull request #13058 from mkllnk/currency-config
...
Remove unused app config options
2025-01-22 11:27:12 +01:00
Maikel
c258bee44d
Merge pull request #13065 from mkllnk/dfc-amend-nothing
...
Admin updates can trigger new backorders until the order cycle is closed
2025-01-22 16:32:23 +11:00
Maikel Linke
c975a2c8c4
Fix flaky spec of order shipment
...
I found that a delay in the reflex handling the request could fail the
spec. Added a sleep in the reflex to reproduce the fail. The I added
expectations for the page content to wait until the page was updated and
that fixed the specs.
2025-01-22 15:34:09 +11:00
Maikel Linke
d49cea5e3d
Use admin flag instead of user role
2025-01-22 14:59:49 +11:00
Maikel Linke
920002e084
Copy admin attribute to users
2025-01-22 14:05:50 +11:00
Maikel Linke
64608beaa8
Remove DefaultStockLocation created in setup
2025-01-22 12:01:57 +11:00
Maikel Linke
70ebe7b964
Remove stock location from specs
2025-01-22 11:52:25 +11:00
Maikel Linke
f098327808
Remove now useless wrapper method
2025-01-22 11:31:27 +11:00
Maikel Linke
d5ff1f5c71
Remove StockItem#stock_location
2025-01-22 11:20:05 +11:00
Maikel Linke
87d20877ad
Remove Shipment#stock_location
2025-01-22 11:20:05 +11:00
Maikel Linke
33c6f3b94f
Remove StockLocation#stock_item
2025-01-22 11:20:05 +11:00
Maikel Linke
aa9daed66e
Remove unused StockLocation#stock_items
...
And the reverse association.
2025-01-22 11:20:05 +11:00
Maikel Linke
450576a938
Remove unused StockLocation#count_on_hand
2025-01-22 11:20:04 +11:00
Maikel Linke
1650ccd55a
Remove unused StockLocation#backorderable?
2025-01-22 11:20:04 +11:00
Maikel Linke
531c068347
Remove StockLocation#fill_status, now on Variant
2025-01-22 11:20:04 +11:00
Maikel Linke
a4b92f289c
Move fill_status spec to prepare removal from StockLocation
2025-01-22 11:20:04 +11:00
Maikel Linke
68a0f8df1f
Remove detour via StockLocation updating stock
2025-01-22 11:20:04 +11:00
Maikel Linke
248110cfb3
Make stock location association optional
...
Prepare for removal
2025-01-22 11:20:04 +11:00
Maikel Linke
917e0ff01a
Remove unnecessary storage of currency
2025-01-21 20:11:05 +01:00
Maikel Linke
ed926e9e26
Remove unnecessary storage of checkout zone
2025-01-21 20:11:05 +01:00
Maikel
229ee7028c
Merge pull request #13064 from mkllnk/negative-stock
...
Don't show stock for on-demand inventory items
2025-01-21 11:05:50 +11:00
Gaetan Craig-Riou
fcd366cc06
Fix spec
...
Payment needs to be linked to the order, in order for the payment
callback to update `order.payment_total`
2025-01-21 10:52:32 +11:00
Gaetan Craig-Riou
0ca164a354
Fix spec
...
Use a completed payment, instead of trying to complete a payment
2025-01-21 10:51:08 +11:00
