Merge pull request #13096 from mkllnk/assets

Compile assets on demand in test local environment

.github/workflows/build.yml

@@ -66,7 +66,8 @@ jobs:
 
       - name: Set up database
         run: |
-          bin/rake db:create db:schema:load
+          bin/rails db:create db:schema:load
+          bin/rails runner spec/support/seeds.rb # Asset compile needs a country.
 
       - name: Run tests
         env:
@@ -84,7 +85,7 @@ jobs:
           KNAPSACK_PRO_TEST_FILE_PATTERN: "{spec/controllers/**/*_spec.rb}"
         run: |
           git show --no-patch # the commit being tested (which is often a merge due to actions/checkout@v3)
-          bin/rake knapsack_pro:rspec
+          bin/rails assets:precompile knapsack_pro:rspec
 
       - name: Save SimpleCov file
         uses: actions/upload-artifact@v4
@@ -135,7 +136,7 @@ jobs:
 
       - name: Set up database
         run: |
-          bin/rake db:create db:schema:load
+          bin/rails db:create db:schema:load
 
       - name: Run tests
         env:
@@ -211,7 +212,8 @@ jobs:
 
       - name: Set up database
         run: |
-          bin/rake db:create db:schema:load
+          bin/rails db:create db:schema:load
+          bin/rails runner spec/support/seeds.rb # Asset compile needs a country.
 
       - name: Run tests
 
@@ -230,7 +232,7 @@ jobs:
           KNAPSACK_PRO_TEST_FILE_PATTERN: "{spec/system/admin/**/*_spec.rb}"
 
         run: |
-          bin/rake knapsack_pro:queue:rspec
+          bin/rails assets:precompile knapsack_pro:queue:rspec
 
       - name: Save SimpleCov file
         uses: actions/upload-artifact@v4
@@ -298,7 +300,8 @@ jobs:
 
       - name: Set up database
         run: |
-          bin/rake db:create db:schema:load
+          bin/rails db:create db:schema:load
+          bin/rails runner spec/support/seeds.rb # Asset compile needs a country.
 
       - name: Run tests
 
@@ -317,7 +320,7 @@ jobs:
           KNAPSACK_PRO_TEST_FILE_PATTERN: "{spec/system/consumer/**/*_spec.rb}"
 
         run: |
-          bin/rake knapsack_pro:queue:rspec
+          bin/rails assets:precompile knapsack_pro:queue:rspec
 
       - name: Save SimpleCov file
         uses: actions/upload-artifact@v4
@@ -386,7 +389,8 @@ jobs:
 
       - name: Set up database
         run: |
-          bin/rake db:create db:schema:load
+          bin/rails db:create db:schema:load
+          bin/rails runner spec/support/seeds.rb # Asset compile needs a country.
 
       - name: Run tests
 
@@ -405,7 +409,7 @@ jobs:
           KNAPSACK_PRO_TEST_FILE_PATTERN: "{spec/lib/**/*_spec.rb,spec/migrations/**/*_spec.rb,spec/serializers/**/*_spec.rb,engines/**/*_spec.rb}"
 
         run: |
-          bin/rake knapsack_pro:rspec
+          bin/rails assets:precompile knapsack_pro:rspec
 
       - name: Save SimpleCov file
         uses: actions/upload-artifact@v4
@@ -465,7 +469,8 @@ jobs:
 
       - name: Set up database
         run: |
-          bin/rake db:create db:schema:load
+          bin/rails db:create db:schema:load
+          bin/rails runner spec/support/seeds.rb # Asset compile needs a country.
 
       - name: Run tests
         env:
@@ -482,7 +487,7 @@ jobs:
           #KNAPSACK_PRO_RSPEC_SPLIT_BY_TEST_EXAMPLES: true
           KNAPSACK_PRO_TEST_FILE_EXCLUDE_PATTERN: "{engines/**/*_spec.rb,spec/models/**/*_spec.rb,spec/controllers/**/*_spec.rb,spec/serializers/**/*_spec.rb,spec/lib/**/*_spec.rb,spec/migrations/**/*_spec.rb,spec/system/**/*_spec.rb}"
         run: |
-          bin/rake knapsack_pro:rspec
+          bin/rails assets:precompile knapsack_pro:rspec
 
       - name: Save SimpleCov file
         uses: actions/upload-artifact@v4

config/webpacker.yml

@@ -93,7 +93,4 @@ production: &production
   cache_manifest: true
 
 test:
-  <<: *production
-
-  # Compile test packs to a separate directory
-  public_output_path: packs-test
+  <<: *default

spec/support/precompile_assets.rb

@@ -1,18 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.configure do |config|
-  config.before(:all) do
-    # We can use webpack-dev-server for tests, too!
-    # Useful if you working on a frontend code fixes and want to verify them via system tests.
-    next if Webpacker.dev_server.running?
-
-    specs_needing_assets = %i[controller feature mailer request system view]
-    examples = RSpec.world.filtered_examples.values.flatten
-    types = examples.map(&:metadata).pluck(:type).uniq
-
-    if types.intersect?(specs_needing_assets)
-      $stdout.puts "\n Precompiling assets.\n"
-      Webpacker.compile
-    end
-  end
-end