Luis Ramos
f7726e552a
Adapt code coming from master to the new order api with update_order!
2021-05-19 10:09:42 -07:00
Luis Ramos
a1ac4e85ed
Replace update_attributes with update
2021-05-19 09:54:25 -07:00
Luis Ramos
f8e5370b0b
Replace update_attributes with update
2021-05-19 09:54:25 -07:00
Luis Ramos
fb560089b9
Replace usages of update_attributes! with usage of update!
2021-05-19 09:54:25 -07:00
Luis Ramos
341f6c9f62
Now that adjustment.update! has been renamed to adjustment.update_adjustment! we can use AR's update! on adjustment
2021-05-19 09:54:25 -07:00
Luis Ramos
b2e97fe1d2
Rename order.update! to order.update_order! and adjustment.update! to adjustment.update_adjustment!
2021-05-19 09:54:22 -07:00
Matt-Yorkley
096847ea07
Merge pull request #7618 from openfoodfoundation/dependabot/npm_and_yarn/hosted-git-info-2.8.9
...
Bump hosted-git-info from 2.8.8 to 2.8.9
2021-05-19 13:51:01 +02:00
Pau Pérez Fabregat
faf6a37c9f
Merge pull request #7631 from openfoodfoundation/dependabot/bundler/ddtrace-0.49.0
...
Bump ddtrace from 0.48.0 to 0.49.0
2021-05-19 12:32:52 +02:00
Pau Pérez Fabregat
d4ec1bda54
Merge pull request #7652 from openfoodfoundation/dependabot/bundler/webmock-3.13.0
...
Bump webmock from 3.12.2 to 3.13.0
2021-05-19 12:32:08 +02:00
Pau Pérez Fabregat
5560a99423
Merge pull request #7663 from openfoodfoundation/transifex
...
Transifex
2021-05-19 11:50:02 +02:00
Andy Brett
2bb38619ea
Merge pull request #7656 from openfoodfoundation/dependabot/bundler/rubocop-1.15.0
...
Bump rubocop from 1.14.0 to 1.15.0
2021-05-18 13:36:56 -07:00
Andy Brett
4b352da402
Merge pull request #7630 from apricot12/persistent_flash_after_reload
...
Persistent flash after reload
2021-05-18 12:55:37 -07:00
Transifex-Openfoodnetwork
75243b8e6a
Updating translations for config/locales/en_US.yml
2021-05-19 05:54:38 +10:00
Matt-Yorkley
6427a3846b
Merge pull request #7651 from openfoodfoundation/dependabot/bundler/activerecord-import-1.1.0
...
Bump activerecord-import from 1.0.8 to 1.1.0
2021-05-18 20:06:21 +02:00
Matt-Yorkley
5dd24623f7
Merge pull request #7479 from Matt-Yorkley/payment-callbacks
...
Update Payment after_save callback
2021-05-18 16:19:29 +02:00
Matt-Yorkley
befb6f632f
Merge pull request #7659 from openfoodfoundation/dependabot/bundler/nokogiri-1.11.4
...
Bump nokogiri from 1.11.3 to 1.11.4
2021-05-18 11:14:32 +02:00
dependabot[bot]
92e0f8349c
Bump nokogiri from 1.11.3 to 1.11.4
...
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri ) from 1.11.3 to 1.11.4.
- [Release notes](https://github.com/sparklemotion/nokogiri/releases )
- [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md )
- [Commits](https://github.com/sparklemotion/nokogiri/compare/v1.11.3...v1.11.4 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-05-18 08:37:29 +00:00
dependabot[bot]
ffbba01c41
Bump rubocop from 1.14.0 to 1.15.0
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.14.0 to 1.15.0.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.14.0...v1.15.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-05-18 05:24:48 +00:00
Pau Pérez Fabregat
5f9679655c
Merge pull request #7645 from Matt-Yorkley/stripe-payment-processing
...
Stripe payment processing
v3.7.1
2021-05-17 16:17:21 +02:00
dependabot[bot]
6ded80d2c6
Bump webmock from 3.12.2 to 3.13.0
...
Bumps [webmock](https://github.com/bblimke/webmock ) from 3.12.2 to 3.13.0.
- [Release notes](https://github.com/bblimke/webmock/releases )
- [Changelog](https://github.com/bblimke/webmock/blob/master/CHANGELOG.md )
- [Commits](https://github.com/bblimke/webmock/compare/v3.12.2...v3.13.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-05-17 05:51:55 +00:00
dependabot[bot]
eb3c33b091
Bump activerecord-import from 1.0.8 to 1.1.0
...
Bumps [activerecord-import](https://github.com/zdennis/activerecord-import ) from 1.0.8 to 1.1.0.
- [Release notes](https://github.com/zdennis/activerecord-import/releases )
- [Changelog](https://github.com/zdennis/activerecord-import/blob/master/CHANGELOG.md )
- [Commits](https://github.com/zdennis/activerecord-import/compare/v1.0.8...v1.1.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-05-17 05:51:01 +00:00
Matt-Yorkley
794216713a
Ensure payment is processed if order is in completed state
2021-05-16 23:03:07 +01:00
Matt-Yorkley
a2862e604c
Find relevant payment that matches the payment intent, not the last payment
2021-05-16 23:00:31 +01:00
Matt-Yorkley
8429da3d2a
Remove unused argument from ProcessPaymentIntent
2021-05-16 22:19:01 +01:00
Matt-Yorkley
381b0e78d5
Improve ProcessPaymentIntent specs
2021-05-16 20:14:14 +01:00
Matt-Yorkley
2e63cd8116
Add explanatory comment on payment processing flow
2021-05-16 20:11:45 +01:00
Matt-Yorkley
52e0d84238
Reload in-memory payment before checking it's new state
...
The state should have changed in the database if the payment was processed successfully, and the memoized version here will not know that without a reload.
2021-05-16 20:11:45 +01:00
Matt-Yorkley
5725535715
Fix payment state checking
2021-05-16 20:11:45 +01:00
Matt-Yorkley
05ed98aa0c
Use :order_with_totals in ProcessPaymentIntent
...
If we just use the :order factory here, it has no line items and no total, which means when we try to push it into complete state, the #requires_payment? check fails because the order total is zero, which means the call to #process_payments is ignored
2021-05-16 20:11:45 +01:00
Matt-Yorkley
fd021d4778
Refactor payment intent status checking and return "ok" if the payment has already been processed successfully in a previous request
...
If the page is reloaded after the payment has already gone through, we can skip the processing and give a non-error response; the payment is already completed and Stripe's response confirms it was successful.
2021-05-16 20:11:45 +01:00
Matt-Yorkley
2b9f9fce86
Fix flash session memory-effect when showing errors after payment processing
...
We're not doing a redirect after setting this flash message, so we need to ensure it's discarded after the current page load.
2021-05-16 20:11:45 +01:00
Matt-Yorkley
81aac442f2
Improve conditional in raise_if_not_in_capture_state
2021-05-16 20:11:45 +01:00
Matt-Yorkley
16e3af9b49
Update OrderController spec
2021-05-16 20:11:45 +01:00
Matt-Yorkley
227bdd7d4c
Update ProcessPaymentIntent spec
2021-05-16 12:55:48 +01:00
Matt-Yorkley
471a7903f6
Update PaymentIntentValidator spec
2021-05-16 12:19:04 +01:00
Matt-Yorkley
37177e7207
Add test coverage to StripeSCA spec
2021-05-16 12:19:04 +01:00
Matt-Yorkley
5805104d13
Tidy up controller and add explanatory comment
2021-05-16 12:19:04 +01:00
Matt-Yorkley
e686a4f627
Move raising of errors when payment intent state != "requires_capture" out of PaymentIntentValidator service
...
When we're fetching the payment intent via PaymentIntentValidator in StripeSCA#purhcase (to capture it), we want it to fail loudly if it's not in "requires_capture" state. We're now also re-using the same PaymentIntentValidator service to check if payment processing was *successful*, in which case we need it *not* to fail loudly if the state == "succeeded", eg != "requires_capture".
2021-05-16 12:19:04 +01:00
Andy Brett
c7f80d86a8
Merge pull request #7638 from Matt-Yorkley/dead-code-order-distribution
...
Delete dead code in OrdersController#update_distribution
2021-05-15 12:40:25 -07:00
Andy Brett
19187583e1
Merge pull request #7643 from openfoodfoundation/dependabot/bundler/test-prof-1.0.5
...
Bump test-prof from 1.0.3 to 1.0.5
2021-05-15 12:28:22 -07:00
Andy Brett
f2c3b096a0
Merge pull request #7566 from luisramos0/erb
...
[Rails 6.0] Fix problem in erb template by explicitly setting format to js
2021-05-15 10:45:01 -07:00
Andy Brett
816d752dc8
Merge pull request #7439 from openfoodfoundation/dependabot/bundler/jwt-2.2.3
...
Bump jwt from 2.2.2 to 2.2.3
2021-05-15 10:36:13 -07:00
dependabot[bot]
2bb5a4b11f
Bump test-prof from 1.0.3 to 1.0.5
...
Bumps [test-prof](https://github.com/test-prof/test-prof ) from 1.0.3 to 1.0.5.
- [Release notes](https://github.com/test-prof/test-prof/releases )
- [Changelog](https://github.com/test-prof/test-prof/blob/master/CHANGELOG.md )
- [Commits](https://github.com/test-prof/test-prof/compare/v1.0.3...v1.0.5 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-05-14 05:17:23 +00:00
Maikel Linke
cea3ee4ef9
Transifex updates
2021-05-14 10:06:31 +10:00
Andy Brett
ebdbfe0027
Merge pull request #7639 from drummer83/patch-1
...
Remove Ruby version from WIKI
2021-05-13 13:26:34 -07:00
Konrad
b680697af6
Remove Ruby version
...
Let's remove the Ruby version from the text. It changes regularly and have the link where to find it right behind it.
2021-05-13 21:16:02 +02:00
Matt-Yorkley
2e248744c0
Merge pull request #7520 from Matt-Yorkley/shipment-controller
...
Shipment controller: test coverage and improvements
2021-05-13 20:26:51 +02:00
Matt-Yorkley
82a6befce7
Delete dead code in OrdersController#update_distribution
...
I can't see any evidence that these params ever get sent to this action...
2021-05-13 15:29:53 +01:00
dependabot[bot]
e4a670da5a
Bump ddtrace from 0.48.0 to 0.49.0
...
Bumps [ddtrace](https://github.com/DataDog/dd-trace-rb ) from 0.48.0 to 0.49.0.
- [Release notes](https://github.com/DataDog/dd-trace-rb/releases )
- [Changelog](https://github.com/DataDog/dd-trace-rb/blob/master/CHANGELOG.md )
- [Commits](https://github.com/DataDog/dd-trace-rb/compare/v0.48.0...v0.49.0 )
Signed-off-by: dependabot[bot] <support@github.com >
2021-05-13 05:24:45 +00:00
Nihal Mohammed
c930b2ee60
Fix persistet flash after /cart page reload
2021-05-13 05:57:25 +05:30