28203 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Neal Chambers	f47f6efcd0	Safely autocorrect Rails/DurationArithmetic ... Inspecting 1481 files ...........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C.............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C.C.................................................................................................................................................................................................................................................................................C..............C..........................................................C...............................C....C..........CC................................................................ Offenses: app/services/create_order_cycle.rb:41:24: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration. orders_close_at: Time.zone.now + 1.month ^^^^^^^^^^^^^^^^^^^^^^^ spec/jobs/order_cycle_closing_job_spec.rb:7:74: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration. create(:order_cycle, automatic_notifications: true, orders_close_at: Time.zone.now - 1.minute) ^^^^^^^^^^^^^^^^^^^^^^^^ spec/jobs/order_cycle_closing_job_spec.rb:10:74: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration. create(:order_cycle, automatic_notifications: true, orders_close_at: Time.zone.now + 1.minute) ^^^^^^^^^^^^^^^^^^^^^^^^ spec/jobs/order_cycle_closing_job_spec.rb:13:75: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration. create(:order_cycle, automatic_notifications: false, orders_close_at: Time.zone.now - 1.minute) ^^^^^^^^^^^^^^^^^^^^^^^^ spec/jobs/order_cycle_opened_job_spec.rb:7:42: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration. create(:order_cycle, orders_open_at: Time.zone.now - 1.hour) ^^^^^^^^^^^^^^^^^^^^^^ spec/jobs/order_cycle_opened_job_spec.rb:13:42: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration. create(:order_cycle, orders_open_at: Time.zone.now + 1.minute) ^^^^^^^^^^^^^^^^^^^^^^^^ spec/services/permissions/order_spec.rb:26:58: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration. completed_at: Time.zone.now - 1.year) ^^^^^^^^^^^^^^^^^^^^^^ spec/services/terms_of_service_spec.rb:21:71: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration. allow(customer).to receive(:terms_and_conditions_accepted_at) { Time.zone.now - 1.week } ^^^^^^^^^^^^^^^^^^^^^^ spec/services/terms_of_service_spec.rb:22:59: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration. allow(TermsOfServiceFile).to receive(:updated_at) { Time.zone.now - 2.weeks } ^^^^^^^^^^^^^^^^^^^^^^^ spec/services/terms_of_service_spec.rb:36:71: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration. allow(customer).to receive(:terms_and_conditions_accepted_at) { Time.zone.now - 1.week } ^^^^^^^^^^^^^^^^^^^^^^ spec/services/terms_of_service_spec.rb:38:45: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration. ActiveStorage::Blob.new(created_at: Time.zone.now - 2.weeks) ^^^^^^^^^^^^^^^^^^^^^^^ spec/system/admin/bulk_order_management_spec.rb:647:57: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration. completed_at: Time.zone.now + 1.week, ^^^^^^^^^^^^^^^^^^^^^^ spec/system/admin/bulk_order_management_spec.rb:652:57: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration. completed_at: Time.zone.now + 2.weeks, ^^^^^^^^^^^^^^^^^^^^^^^ spec/system/admin/bulk_order_management_spec.rb:661:40: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration. oc3.update!(orders_close_at: Time.zone.now + 2.weeks) ^^^^^^^^^^^^^^^^^^^^^^^ spec/system/admin/bulk_order_management_spec.rb:662:39: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration. oc3.update!(orders_open_at: Time.zone.now + 1.week) ^^^^^^^^^^^^^^^^^^^^^^ spec/system/admin/order_cycles/list_spec.rb:128:18: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration. oc_open_at = Time.zone.now - 2.weeks ^^^^^^^^^^^^^^^^^^^^^^^ spec/system/admin/order_cycles/list_spec.rb:129:19: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration. oc_close_at = Time.zone.now + 2.weeks ^^^^^^^^^^^^^^^^^^^^^^^ spec/system/admin/orders_spec.rb:289:40: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration. order2.update!(completed_at: Time.zone.now - 2.weeks) ^^^^^^^^^^^^^^^^^^^^^^^ spec/system/admin/orders_spec.rb:290:40: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration. order3.update!(completed_at: Time.zone.now - 3.weeks) ^^^^^^^^^^^^^^^^^^^^^^^ spec/system/admin/orders_spec.rb:291:40: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration. order4.update!(completed_at: Time.zone.now - 4.weeks) ^^^^^^^^^^^^^^^^^^^^^^^ spec/system/admin/orders_spec.rb:292:40: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration. order5.update!(completed_at: Time.zone.now - 5.weeks) ^^^^^^^^^^^^^^^^^^^^^^^ spec/system/admin/reports/orders_and_fulfillment_spec.rb:113:31: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration. let(:completed_at1) { Time.zone.now - 1500.hours } # 1500 hours in the past ^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/system/admin/reports/orders_and_fulfillment_spec.rb:114:31: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration. let(:completed_at2) { Time.zone.now - 1700.hours } # 1700 hours in the past ^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/system/admin/reports/orders_and_fulfillment_spec.rb:115:33: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration. let(:datetime_start1) { Time.zone.now - 1600.hours } # 1600 hours in the past ^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/system/admin/reports/orders_and_fulfillment_spec.rb:116:33: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration. let(:datetime_start2) { Time.zone.now - 1800.hours } # 1600 hours in the past ^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/system/admin/reports/orders_and_fulfillment_spec.rb:117:30: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration. let(:datetime_end) { Time.zone.now - 1400.hours } # 1400 hours in the past ^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/system/admin/reports/packing_report_spec.rb:13:26: C: [Corrected] Style/RedundantParentheses: Don't use parentheses around a method call. let!(:open_datetime) { (1.month.ago).strftime("%Y-%m-%d 00:00") } ^^^^^^^^^^^^^ spec/system/admin/reports/packing_report_spec.rb:13:27: C: [Corrected] Rails/DurationArithmetic: Do not add or subtract duration. let!(:open_datetime) { (Time.zone.now - 1.month).strftime("%Y-%m-%d 00:00") } ^^^^^^^^^^^^^^^^^^^^^^^ 1481 files inspected, 28 offenses detected, 28 offenses corrected	2023-08-01 22:50:21 +09:00
Neal Chambers	a263110799	Safely autocorrect Rails/DotSeparatedKeys ... Inspecting 1481 files ........................................................................C................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................ Offenses: app/controllers/api/v1/base_controller.rb:72:66: C: [Corrected] Rails/DotSeparatedKeys: Use the dot-separated keys instead of specifying the :scope option. message = I18n.t(:missing_parameter, param: error.param, scope: :api) ^^^^^^^^^^^ app/controllers/api/v1/base_controller.rb:79:84: C: [Corrected] Rails/DotSeparatedKeys: Use the dot-separated keys instead of specifying the :scope option. message = I18n.t(:unpermitted_parameters, params: error.params.join(", "), scope: :api) ^^^^^^^^^^^ 1481 files inspected, 2 offenses detected, 2 offenses corrected	2023-08-01 22:50:21 +09:00
Neal Chambers	44cf2faa1e	Safely autocorrect Rails/ActiveRecordCallbacksOrder ... Inspecting 1481 files ...........................................................................................................................................................................................................................................................C..C.CC........................................................................C...C..........C..C..................CC........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................ Offenses: app/models/customer.rb:32:3: C: [Corrected] Rails/ActiveRecordCallbacksOrder: before_validation is supposed to appear before before_destroy. before_validation :downcase_email ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/models/customer.rb:33:3: C: [Corrected] Rails/ActiveRecordCallbacksOrder: before_validation is supposed to appear before before_destroy. before_validation :empty_code ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/models/customer.rb:34:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected. app/models/customer.rb:49:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected. app/models/customer.rb:49:3: C: [Corrected] Rails/ActiveRecordCallbacksOrder: before_create is supposed to appear before before_destroy. before_create :associate_user ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/models/enterprise.rb:129:3: C: [Corrected] Rails/ActiveRecordCallbacksOrder: after_create is supposed to appear before after_touch. after_create :set_default_contact ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/models/enterprise.rb:130:3: C: [Corrected] Rails/ActiveRecordCallbacksOrder: after_create is supposed to appear before after_touch. after_create :relate_to_owners_enterprises ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/models/enterprise.rb:133:3: C: [Corrected] Rails/ActiveRecordCallbacksOrder: after_rollback is supposed to appear before after_touch. after_rollback :restore_permalink ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/models/enterprise.rb:134:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected. app/models/enterprise_group.rb:18:3: C: [Corrected] Rails/ActiveRecordCallbacksOrder: after_save is supposed to appear before after_find. after_save :unset_undefined_address_fields ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/models/enterprise_group.rb:18:3: C: [Corrected] Rails/ActiveRecordCallbacksOrder: before_validation is supposed to appear before after_save. before_validation :sanitize_permalink ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/models/enterprise_group.rb:19:3: C: [Corrected] Rails/ActiveRecordCallbacksOrder: before_validation is supposed to appear before after_find. before_validation :sanitize_permalink ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/models/enterprise_group.rb:23:3: C: [Corrected] Rails/ActiveRecordCallbacksOrder: before_validation is supposed to appear before after_save. before_validation :sanitize_permalink ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/models/enterprise_relationship.rb:15:3: C: [Corrected] Rails/ActiveRecordCallbacksOrder: before_destroy is supposed to appear before after_save. before_destroy :revoke_all_child_variant_overrides ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/models/enterprise_relationship.rb:16:3: C: [Corrected] Rails/ActiveRecordCallbacksOrder: before_destroy is supposed to appear before after_save. before_destroy :destroy_related_exchanges ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/models/spree/order.rb:108:5: C: [Corrected] Rails/ActiveRecordCallbacksOrder: before_save is supposed to appear before before_create. before_save :update_shipping_fees!, if: :complete? ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/models/spree/order.rb:109:5: C: [Corrected] Rails/ActiveRecordCallbacksOrder: before_save is supposed to appear before before_create. before_save :update_payment_fees!, if: :complete? ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/models/spree/payment.rb:30:5: C: [Corrected] Rails/ActiveRecordCallbacksOrder: after_initialize is supposed to appear before before_create. after_initialize :build_source ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/models/spree/payment.rb:32:5: C: [Corrected] Rails/ActiveRecordCallbacksOrder: after_initialize is supposed to appear before after_create. after_initialize :build_source ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/models/spree/payment.rb:33:5: C: [Corrected] Rails/ActiveRecordCallbacksOrder: after_create is supposed to appear before after_save. after_create :invalidate_old_payments ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/models/spree/payment.rb:34:5: C: [Corrected] Rails/ActiveRecordCallbacksOrder: after_initialize is supposed to appear before after_save. after_initialize :build_source ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/models/spree/payment.rb:35:5: C: [Corrected] Rails/ActiveRecordCallbacksOrder: after_create is supposed to appear before after_save. after_create :invalidate_old_payments ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/models/spree/payment.rb:36:5: C: [Corrected] Rails/ActiveRecordCallbacksOrder: after_initialize is supposed to appear before after_save. after_initialize :build_source ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/models/spree/payment.rb:46:5: C: [Corrected] Rails/ActiveRecordCallbacksOrder: after_initialize is supposed to appear before after_create. after_initialize :build_source ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/models/spree/payment.rb:47:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected. app/models/spree/product.rb:87:5: C: [Corrected] Rails/ActiveRecordCallbacksOrder: after_create is supposed to appear before after_save. after_create :ensure_standard_variant ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/models/spree/return_authorization.rb:12:5: C: [Corrected] Rails/ActiveRecordCallbacksOrder: before_save is supposed to appear before before_create. before_save :force_positive_amount ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/models/spree/user.rb:49:5: C: [Corrected] Rails/ActiveRecordCallbacksOrder: after_create is supposed to appear before before_destroy. after_create :associate_customers, :associate_orders ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/models/spree/user.rb:50:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected. app/models/spree/variant.rb:88:5: C: [Corrected] Rails/ActiveRecordCallbacksOrder: after_create is supposed to appear before after_save. after_create :create_stock_items ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/models/spree/variant.rb:89:5: C: [Corrected] Rails/ActiveRecordCallbacksOrder: after_create is supposed to appear before after_save. after_create :set_position ^^^^^^^^^^^^^^^^^^^^^^^^^^ app/models/spree/variant.rb:90:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected. app/models/spree/variant.rb:91:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected. app/models/spree/variant.rb:91:5: C: [Corrected] Rails/ActiveRecordCallbacksOrder: around_destroy is supposed to appear before after_save. around_destroy :destruction ^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/models/spree/variant.rb:92:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected. 1481 files inspected, 35 offenses detected, 35 offenses corrected	2023-08-01 22:50:21 +09:00
Neal Chambers	a1560263a1	Safely autocorrect Rails/ActionOrder ... Inspecting 1481 files .........................................C.................C.........................................................CC........C..........C.C.........C.................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................. Offenses: app/controllers/admin/resource_controller.rb:39:5: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0. def update ^^^^^^^^^^ app/controllers/admin/resource_controller.rb:39:5: C: [Corrected] Rails/ActionOrder: Action create should appear before update. def create ... ^^^^^^^^^^ app/controllers/admin/resource_controller.rb:51:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected. app/controllers/admin/resource_controller.rb:52:5: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 2. def update_positions ^^^^^^^^^^^^^^^^^^^^ app/controllers/api/v0/orders_controller.rb:13:7: C: [Corrected] Rails/ActionOrder: Action index should appear before show. def index ... ^^^^^^^^^ app/controllers/api/v0/orders_controller.rb:23:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0. def show ^^^^^^^^ app/controllers/api/v0/orders_controller.rb:28:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected. app/controllers/api/v0/orders_controller.rb:29:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 2. def update ^^^^^^^^^^ app/controllers/spree/admin/images_controller.rb:26:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0. def create ^^^^^^^^^^ app/controllers/spree/admin/images_controller.rb:37:7: C: [Corrected] Rails/ActionOrder: Action edit should appear before create. def edit ... ^^^^^^^^ app/controllers/spree/admin/images_controller.rb:40:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected. app/controllers/spree/admin/images_controller.rb:41:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 2. def update ^^^^^^^^^^ app/controllers/spree/admin/invoices_controller.rb:19:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0. def create ^^^^^^^^^^ app/controllers/spree/admin/invoices_controller.rb:43:7: C: [Corrected] Rails/ActionOrder: Action show should appear before create. def show ... ^^^^^^^^ app/controllers/spree/admin/invoices_controller.rb:49:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected. app/controllers/spree/admin/invoices_controller.rb:50:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 2. def poll ^^^^^^^^ app/controllers/spree/admin/products_controller.rb:23:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0. def new ^^^^^^^ app/controllers/spree/admin/products_controller.rb:23:7: C: [Corrected] Rails/ActionOrder: Action show should appear before new. def show ... ^^^^^^^^ app/controllers/spree/admin/products_controller.rb:24:7: C: [Corrected] Rails/ActionOrder: Action index should appear before show. def index ... ^^^^^^^^^ app/controllers/spree/admin/products_controller.rb:27:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected. app/controllers/spree/admin/products_controller.rb:27:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0. def create ^^^^^^^^^^ app/controllers/spree/admin/products_controller.rb:28:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected. app/controllers/spree/admin/products_controller.rb:28:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0. def new ^^^^^^^ app/controllers/spree/admin/products_controller.rb:28:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 2. def index ^^^^^^^^^ app/controllers/spree/admin/products_controller.rb:28:7: C: [Corrected] Rails/ActionOrder: Action index should appear before new. def index ... ^^^^^^^^^ app/controllers/spree/admin/products_controller.rb:29:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 2. def new ^^^^^^^ app/controllers/spree/admin/products_controller.rb:32:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected. app/controllers/spree/admin/products_controller.rb:32:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0. def create ^^^^^^^^^^ app/controllers/spree/admin/products_controller.rb:33:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 2. def edit ^^^^^^^^ app/controllers/spree/admin/products_controller.rb:36:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0. def create ^^^^^^^^^^ app/controllers/spree/admin/products_controller.rb:38:7: C: [Corrected] Rails/ActionOrder: Action show should appear before create. def show ... ^^^^^^^^ app/controllers/spree/admin/products_controller.rb:42:7: C: [Corrected] Rails/ActionOrder: Action index should appear before create. def index ... ^^^^^^^^^ app/controllers/spree/admin/products_controller.rb:43:7: C: [Corrected] Rails/ActionOrder: Action index should appear before create. def index ... ^^^^^^^^^ app/controllers/spree/admin/products_controller.rb:43:7: C: [Corrected] Rails/ActionOrder: Action index should appear before show. def index ... ^^^^^^^^^ app/controllers/spree/admin/products_controller.rb:47:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected. app/controllers/spree/admin/products_controller.rb:48:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 2. def edit ^^^^^^^^ app/controllers/spree/admin/products_controller.rb:48:7: C: [Corrected] Rails/ActionOrder: Action edit should appear before create. def edit ... ^^^^^^^^ app/controllers/spree/admin/products_controller.rb:51:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected. app/controllers/spree/admin/products_controller.rb:52:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 2. def update ^^^^^^^^^^ app/controllers/spree/admin/taxons_controller.rb:13:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0. def create ^^^^^^^^^^ app/controllers/spree/admin/taxons_controller.rb:29:7: C: [Corrected] Rails/ActionOrder: Action edit should appear before create. def edit ... ^^^^^^^^ app/controllers/spree/admin/taxons_controller.rb:34:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected. app/controllers/spree/admin/taxons_controller.rb:35:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 2. def update ^^^^^^^^^^ app/controllers/spree/admin/variants_controller.rb:17:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0. def edit ^^^^^^^^ app/controllers/spree/admin/variants_controller.rb:18:7: C: [Corrected] Rails/ActionOrder: Action new should appear before edit. def new ... ^^^^^^^ app/controllers/spree/admin/variants_controller.rb:21:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected. app/controllers/spree/admin/variants_controller.rb:21:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0. def update ^^^^^^^^^^ app/controllers/spree/admin/variants_controller.rb:22:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 2. def create ^^^^^^^^^^ app/controllers/spree/admin/variants_controller.rb:31:7: C: [Corrected] Rails/ActionOrder: Action new should appear before update. def new ... ^^^^^^^ app/controllers/spree/admin/variants_controller.rb:34:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected. app/controllers/spree/admin/variants_controller.rb:35:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 2. def create ^^^^^^^^^^ app/controllers/spree/admin/variants_controller.rb:35:7: C: [Corrected] Rails/ActionOrder: Action create should appear before update. def create ... ^^^^^^^^^^ app/controllers/spree/admin/variants_controller.rb:42:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0. def update ^^^^^^^^^^ app/controllers/spree/admin/variants_controller.rb:55:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected. app/controllers/spree/admin/variants_controller.rb:56:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 2. def search ^^^^^^^^^^ app/controllers/user_confirmations_controller.rb:14:3: C: [Corrected] Rails/ActionOrder: Action show should appear before new. def show ... ^^^^^^^^ app/controllers/user_confirmations_controller.rb:15:3: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0. def new ^^^^^^^ app/controllers/user_confirmations_controller.rb:19:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected. app/controllers/user_confirmations_controller.rb:20:3: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0. def create ^^^^^^^^^^ app/controllers/user_confirmations_controller.rb:21:3: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 2. def create ^^^^^^^^^^ app/controllers/user_confirmations_controller.rb:37:3: C: [Corrected] Rails/ActionOrder: Action show should appear before create. def show ... ^^^^^^^^ app/controllers/user_confirmations_controller.rb:42:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected. app/controllers/user_confirmations_controller.rb:43:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected. 1481 files inspected, 63 offenses detected, 63 offenses corrected	2023-08-01 22:50:21 +09:00
Neal Chambers	e49c9e9061	Regenerate Rubocop's TODO file	2023-08-01 22:50:21 +09:00
David Cook	f7a137049f	Merge pull request #11296 from dacook/hide-git-errors ... Prevent git errors from showing in command output	2023-08-01 12:16:53 +10:00
Maikel	c8ad6d7d1c	Merge pull request #11300 from macanudo527/fix_rubocop_layout_3 ... Fix rubocop layout 4 v4.4.5	2023-07-31 11:26:53 +10:00
Maikel	aa92aac5a9	Style FrozenStringLiteralComment ... Co-authored-by: jibees <jb.bellet@gmail.com>	2023-07-31 11:19:10 +10:00
Neal Chambers	60cd84d565	Safely autocorrect Naming/BlockForwarding ... Inspecting 1480 files ...................................................................................................................................................................C.......C..........C...............................................................................................................................................................................................................C...........................................................................................................C.........C...............................................................................................................................................................................................................................................................C........................................CC...C............................................................................................................................................................................................................................................................................................................................C.....................................................................................................................................................................................................C..............C.........C..CC.......C.....................................................................................................C............... Offenses: app/helpers/application_helper.rb:41:32: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding. def ng_form_for(name, *args, &block) ^^^^^^ app/helpers/application_helper.rb:44:75: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding. form_for(name, *(args << options.merge(builder: AngularFormBuilder)), &block) ^^^^^^ app/helpers/application_helper.rb:49:37: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding. def method_missing(method, *args, &block) ^^^^^^ app/helpers/link_helper.rb:4:57: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding. def link_to_service(baseurl, name, html_options = {}, &block) ^^^^^^ app/helpers/link_helper.rb:8:51: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding. link_to ext_url(baseurl, name), html_options, &block ^^^^^^ app/helpers/spree/admin/base_helper.rb:6:56: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding. def field_container(model, method, options = {}, &block) ^^^^^^ app/helpers/spree/admin/base_helper.rb:13:29: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding. capture(&block), ^^^^^^ app/reflexes/application_reflex.rb:29:19: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding. def with_locale(&block) ^^^^^^ app/reflexes/application_reflex.rb:30:43: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding. I18n.with_locale(current_user.locale, &block) ^^^^^^ app/services/cache_service.rb:8:43: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding. def self.cache(cache_key, options = {}, &block) ^^^^^^ app/services/cache_service.rb:9:48: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding. Rails.cache.fetch cache_key.to_s, options, &block ^^^^^^ app/services/cache_service.rb:14:58: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding. def self.cached_data_by_class(cache_key, cached_class, &block) ^^^^^^ app/services/cache_service.rb:16:23: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding. &block ^^^^^^ app/services/cache_service.rb:25:34: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding. def self.home_stats(statistic, &block) ^^^^^^ app/services/cache_service.rb:28:47: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding. race_condition_ttl: 10, &block) ^^^^^^ app/services/current_order_locker.rb:12:31: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding. def self.around(controller, &block) ^^^^^^ app/services/current_order_locker.rb:13:55: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding. lock_order_and_variants(controller.current_order, &block) ^^^^^^ lib/reporting/reports/enterprise_fee_summary/scope.rb:392:28: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding. def chain_to_scope(&block) ^^^^^^ lib/reporting/reports/enterprise_fee_summary/scope.rb:393:41: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding. @scope = @scope.instance_eval(&block) ^^^^^^ lib/spree/core/controller_helpers/respond_with.rb:7:34: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding. def respond_with(*resources, &block) ^^^^^^ lib/spree/core/controller_helpers/respond_with.rb:13:64: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding. return unless (collector = retrieve_collector_from_mimes(&block)) ^^^^^^ lib/spree/core/delegate_belongs_to.rb:80:39: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding. def class_def(name, method = nil, &blk) ^^^^ lib/spree/core/delegate_belongs_to.rb:81:54: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding. class_eval { method.nil? ? define_method(name, &blk) : define_method(name, method) } ^^^^ lib/spree/core/environment_extension.rb:22:31: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding. def create_method(name, &block) ^^^^^^ lib/spree/core/environment_extension.rb:23:51: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding. self.class.__send__(:define_method, name, &block) ^^^^^^ spec/models/enterprise_caching_spec.rb:144:13: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding. def later(&block) ^^^^^^ spec/models/enterprise_caching_spec.rb:145:36: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding. Timecop.travel(1.day.from_now, &block) ^^^^^^ spec/support/embedded_pages_helper.rb:5:26: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding. def on_embedded_page(&block) ^^^^^^ spec/support/embedded_pages_helper.rb:6:28: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding. within_frame :frame, &block ^^^^^^ spec/support/preferences_helper.rb:11:31: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding. def reset_spree_preferences(&config_block) ^^^^^^^^^^^^^ spec/support/preferences_helper.rb:16:33: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding. configure_spree_preferences(&config_block) if block_given? ^^^^^^^^^^^^^ spec/support/request/shop_workflow.rb:87:37: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding. def within_variant(variant = nil, &block) ^^^^^^ spec/support/request/shop_workflow.rb:90:22: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding. within(selector, &block) ^^^^^^ spec/support/request/ui_component_helper.rb:4:23: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding. def browse_as_small(&block) ^^^^^^ spec/support/request/ui_component_helper.rb:5:39: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding. browse_with_window_size(640, 480, &block) ^^^^^^ spec/support/request/ui_component_helper.rb:8:24: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding. def browse_as_medium(&block) ^^^^^^ spec/support/request/ui_component_helper.rb:9:40: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding. browse_with_window_size(1024, 768, &block) ^^^^^^ spec/support/request/web_helper.rb:52:23: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding. def within_row(num, &block) ^^^^^^ spec/support/request/web_helper.rb:53:54: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding. within("table.index tbody tr:nth-child(#{num})", &block) ^^^^^^ spec/swagger_helper.rb:77:19: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding. def param(args, &block) ^^^^^^ spec/swagger_helper.rb:78:45: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding. public_send(:let, args) { instance_eval(&block) } ^^^^^^ spec/system/support/capybara_setup.rb:20:27: C: [Corrected] Naming/BlockForwarding: Use anonymous block forwarding. def using_session(name, &block) ^^^^^^ 1480 files inspected, 42 offenses detected, 42 offenses corrected	2023-07-30 21:29:19 +09:00
Neal Chambers	ae8a5b7f93	Safely autocorrect Lint/UnusedMethodArgument ... Inspecting 1480 files ........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................W............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................... Offenses: lib/reporting/queries/query_interface.rb:18:30: W: [Corrected] Lint/UnusedMethodArgument: Unused method argument - default. If it's necessary, use _ or _default as an argument name to indicate that it won't be used. If it's unnecessary, remove it. def sum_grouped(field, default = 0) ^^^^^^^ lib/reporting/queries/query_interface.rb:22:26: W: [Corrected] Lint/UnusedMethodArgument: Unused method argument - default. If it's necessary, use _ or _default as an argument name to indicate that it won't be used. If it's unnecessary, remove it. def sum_new(field, default = 0) ^^^^^^^ 1480 files inspected, 2 offenses detected, 2 offenses corrected	2023-07-30 21:29:19 +09:00
Neal Chambers	2a76b1972f	Safely autocorrect Lint/SafeNavigationChain ... Inspecting 1480 files ........................................................................................................................................................................................................................................................................................................................................W............................W.................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................. Offenses: app/models/spree/line_item.rb:283:55: W: [Corrected] Lint/SafeNavigationChain: Do not chain ordinary method call after safe navigation operator. self.final_weight_volume = variant&.unit_value * quantity ^^^^^^^^^^^ app/models/spree/line_item.rb:283:57: C: [Corrected] Layout/SpaceAroundMethodCallOperator: Avoid using spaces around a method call operator. self.final_weight_volume = variant&.unit_value&. * quantity ^ app/models/spree/stock/availability_validator.rb:31:77: W: [Corrected] Lint/SafeNavigationChain: Do not chain ordinary method call after safe navigation operator. return line_item.order.shipments.first if line_item.order&.shipments.any? ^^^^^ 1480 files inspected, 3 offenses detected, 3 offenses corrected	2023-07-30 21:29:19 +09:00
Neal Chambers	e7d53753e4	Safely autocorrect Lint/RedundantCopDisableDirective ... Inspecting 1480 files ..............W......................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................... Offenses: app/components/product_component.rb:23:51: W: [Corrected] Lint/RedundantCopDisableDirective: Unnecessary disabling of Metrics/MethodLength. # rubocop:disable Metrics/CyclomaticComplexity, Metrics/MethodLength ^^^^^^^^^^^^^^^^^^^^ app/components/product_component.rb:50:50: W: [Corrected] Lint/RedundantCopEnableDirective: Unnecessary enabling of Metrics/MethodLength. # rubocop:enable Metrics/CyclomaticComplexity, Metrics/MethodLength ^^^^^^^^^^^^^^^^^^^^ 1480 files inspected, 2 offenses detected, 2 offenses corrected	2023-07-30 21:29:19 +09:00
Neal Chambers	e9f448fad9	Safely autocorrect Lint/AmbiguousOperatorPrecedence ... Inspecting 1480 files ...................................................................................................................................................................................................................................W..........................W........................................................W................W..............W................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................ Offenses: app/models/calculator/flexi_rate.rb:38:7: W: [Corrected] Lint/AmbiguousOperatorPrecedence: Wrap expressions with varying precedence with parentheses to avoid ambiguity. count * preferred_additional_item.to_f + preferred_first_item.to_f ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/models/enterprise.rb:362:12: W: [Corrected] Lint/AmbiguousOperatorPrecedence: Wrap expressions with varying precedence with parentheses to avoid ambiguity. cat << "sells_" + sells ^^^^^^^^^^^^^^^^ app/models/enterprise.rb:496:21: W: [Corrected] Lint/AmbiguousOperatorPrecedence: Wrap expressions with varying precedence with parentheses to avoid ambiguity. phone_number && "https://wa.me/" + phone_number.tr('+ ', '') ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/models/spree/ability.rb:27:33: W: [Corrected] Lint/AmbiguousOperatorPrecedence: Wrap expressions with varying precedence with parentheses to avoid ambiguity. order.user == user || order.token && token == order.token ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/models/spree/ability.rb:30:33: W: [Corrected] Lint/AmbiguousOperatorPrecedence: Wrap expressions with varying precedence with parentheses to avoid ambiguity. order.user == user || order.token && token == order.token ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/models/spree/line_item.rb:205:16: W: [Corrected] Lint/AmbiguousOperatorPrecedence: Wrap expressions with varying precedence with parentheses to avoid ambiguity. (price + fees / quantity).round(2) ^^^^^^^^^^^^^^^ app/models/spree/preferences/store.rb:28:11: W: [Corrected] Lint/AmbiguousOperatorPrecedence: Wrap expressions with varying precedence with parentheses to avoid ambiguity. should_persist? && Spree::Preference.where(key: key).exists? ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 1480 files inspected, 7 offenses detected, 7 offenses corrected	2023-07-30 21:29:19 +09:00
filipefurtad0	0bcde2dbda	Update all locales with the latest Transifex translations	2023-07-28 16:33:49 +01:00
Filipe	5d624ef4be	Merge pull request #11278 from mkllnk/swagger-fix ... Fix swagger-api integration after last update	2023-07-28 16:27:32 +01:00
Filipe	1ddbb1c4e1	Merge pull request #11294 from Matt-Yorkley/connect-src ... Update CSP configuration for Safari	2023-07-28 16:16:02 +01:00
Filipe	a975e2bd93	Merge pull request #11247 from jibees/9123-inconsistent-default-visibility-setting-for-newly-created-enterprises ... Admin, Enterprise creation : set visibility to "Hidden" by default	2023-07-28 12:15:32 +01:00
Filipe	ef947f8749	Merge pull request #11282 from jibees/11025-white-label-trix-quotes-code-and-links-cant-be-identified-in-the-editor ... White label: Customize rendering inside the trix-editor, to match the shopfront rendering	2023-07-28 11:23:50 +01:00
Filipe	21690670f5	Merge pull request #11292 from jibees/11108-dashboard-supplier-profile-inconsistent-indentation-on-deployed-version ... Admin: improve platform version displaying on admin homepage	2023-07-28 11:01:07 +01:00
David Cook	febe6501c0	Prevent git errors from showing in command output ... This would be a very rare case, but one time the git command failed, printing out an obscure "fatal" message to stderr which caused confusion.	2023-07-28 12:07:52 +10:00
Maikel	774bb7a607	Merge pull request #11238 from filipefurtad0/legal_invoices_spec ... Adds coverage to Invoices (system specs)	2023-07-28 08:41:01 +10:00
filipefurtad0	98f29dcd9b	Adds coverage on invoices section/table	2023-07-27 17:27:41 +01:00
Matt-Yorkley	dd9b28787c	Update CSP configuration for Safari ... Apparently some versions of Safari have issues with Websockets if the CSP doesn't explicitly define the `connect_src` in a certain way (including specifying the host). This issue is fixed in later versions of Safari and doesn't affect other browsers, for which the `default_src` with `:self` is sufficient.	2023-07-27 16:20:42 +01:00
filipefurtad0	35dfdc8bdc	Adds coverage on Invoice tab ... which should be visible as a function of the order state Corrects cancelled case	2023-07-27 15:47:40 +01:00
Jean-Baptiste Bellet	8b4de3ddc7	Add version into its own .row .columns with centered text	2023-07-27 15:41:54 +02:00
jibees	55fbab4c0d	Merge pull request #11287 from openfoodfoundation/dependabot/bundler/rexml-3.2.6 ... chore(deps): bump rexml from 3.2.5 to 3.2.6	2023-07-27 12:00:28 +02:00
Jean-Baptiste Bellet	a179c006fc	Default design for ul and ol into the custom tab ... `ul` and `old` default design already been reset, reactivate default design only for `.custom-tab`	2023-07-27 11:53:47 +02:00
Jean-Baptiste Bellet	4485490b0b	Customize rendering inside the trix-editor, to match the shopfront rendering	2023-07-27 11:53:47 +02:00
jibees	b3949965fc	Merge pull request #11288 from openfoodfoundation/dependabot/bundler/knapsack_pro-5.3.4 ... chore(deps-dev): bump knapsack_pro from 5.3.3 to 5.3.4	2023-07-27 11:34:37 +02:00
dependabot[bot]	79d0728fdd	chore(deps-dev): bump knapsack_pro from 5.3.3 to 5.3.4 ... Bumps [knapsack_pro](https://github.com/KnapsackPro/knapsack_pro-ruby) from 5.3.3 to 5.3.4. - [Changelog](https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md) - [Commits](https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v5.3.3...v5.3.4) --- updated-dependencies: - dependency-name: knapsack_pro dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>	2023-07-27 09:25:02 +00:00
dependabot[bot]	4e9dae6817	chore(deps): bump rexml from 3.2.5 to 3.2.6 ... Bumps [rexml](https://github.com/ruby/rexml) from 3.2.5 to 3.2.6. - [Release notes](https://github.com/ruby/rexml/releases) - [Changelog](https://github.com/ruby/rexml/blob/master/NEWS.md) - [Commits](https://github.com/ruby/rexml/compare/v3.2.5...v3.2.6) --- updated-dependencies: - dependency-name: rexml dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>	2023-07-27 09:21:38 +00:00
jibees	96418dcde6	Merge pull request #11284 from mkllnk/caching-spec ... Compile JS before testing caching	2023-07-27 09:41:22 +02:00
David Cook	fdb80fe87c	Merge pull request #11283 from macanudo527/fix_rubocop_layout_2 ... Fix rubocop layout 3	2023-07-27 10:29:29 +10:00
Neal Chambers	e923defd55	Safely autocorrect Layout/TrailingWhitespace ... Inspecting 1479 files ...................................................................................................................................................C..C.......................................................................................................C.................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C.....C..................C.............................................................................................C...................................................................C.......................................................................................................................................................................C....................................................C.............C...........CC.........C......C.CC.C....................C........................................................ Offenses: app/controllers/spree/users_controller.rb:36:37: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. partial("layouts/alert", ^ app/controllers/spree/users_controller.rb:51:35: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. partial("layouts/alert", ^ app/controllers/user_confirmations_controller.rb:27:33: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. partial("layouts/alert", ^ app/models/enterprise.rb:117:24: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. validates :instagram, ^ spec/controllers/spree/credit_cards_controller_spec.rb:250:64: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. create(:stored_credit_card, user_id: user.id, ^ spec/controllers/user_confirmations_controller_spec.rb:45:44: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. session[:confirmation_return_url] = ^ spec/factories/order_factory.rb:40:67: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. order.payments << build(:payment, amount: order.total, ^ spec/lib/reports/packing/packing_report_spec.rb:59:40: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. build(:line_item_with_shipment, ^ spec/lib/reports/packing/packing_report_spec.rb:63:40: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. build(:line_item_with_shipment, ^ spec/models/enterprise_spec.rb:521:67: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. expect(Enterprise.supplying_variant_in([p1.variants.first, ^ spec/models/enterprise_spec.rb:906:77: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. create(:enterprise_relationship, parent: distributor, child: supplier, ^ spec/services/products_renderer_spec.rb:22:73: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. create(:product, name: "banana bread", primary_taxon_id: cakes.id, ^ spec/services/products_renderer_spec.rb:88:88: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. product_apples.product_properties.create!({ property_id: property_organic.id, ^ spec/services/products_renderer_spec.rb:90:87: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. products_renderer = ProductsRenderer.new(distributor, order_cycle, customer, ^ spec/services/products_renderer_spec.rb:97:90: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. fruits_supplier.producer_properties.create!({ property_id: property_organic.id, ^ spec/services/products_renderer_spec.rb:99:87: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. products_renderer = ProductsRenderer.new(distributor, order_cycle, customer, ^ spec/services/products_renderer_spec.rb:109:93: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. product_apples.product_properties.create!({ property_id: property_conventional.id, ^ spec/services/products_renderer_spec.rb:111:94: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. product_banana_bread.product_properties.create!({ property_id: property_organic.id, ^ spec/services/products_renderer_spec.rb:113:90: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. product_cherries.product_properties.create!({ property_id: property_organic.id, ^ spec/services/products_renderer_spec.rb:115:91: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. product_doughnuts.product_properties.create!({ property_id: property_organic.id, ^ spec/services/products_renderer_spec.rb:117:87: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. products_renderer = ProductsRenderer.new(distributor, order_cycle, customer, ^ spec/support/request/stripe_stubs.rb:17:81: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. def stub_payment_intent_get_request(response: {}, stripe_account_header: true, ^ spec/support/request/stripe_stubs.rb:172:6: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. { ^ spec/support/request/stripe_stubs.rb:175:24: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. object: "list", ^ spec/support/request/stripe_stubs.rb:176:25: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. has_more: false, ^ spec/system/admin/bulk_order_management_spec.rb:792:99: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. it "displays only line items whose orders meet the date restriction criteria, when changed", ^ spec/system/admin/bulk_order_management_spec.rb:1071:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/system/admin/bulk_order_management_spec.rb:1121:82: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. shared_examples "display only group by information for selected variant" do ^^^^^^^^^^ spec/system/admin/bulk_order_management_spec.rb:1143:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/system/admin/bulk_order_management_spec.rb:1166:12: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. end ^ spec/system/admin/customers_spec.rb:18:98: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. create(:customer, first_name: 'John', last_name: 'Doe', enterprise: managed_distributor1, ^ spec/system/admin/enterprise_fees_spec.rb:102:37: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. select 'Inherit From Product', ^ spec/system/admin/enterprise_fees_spec.rb:128:38: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. select 'Weight (per kg or lb)', ^ spec/system/admin/enterprise_fees_spec.rb:132:37: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. select 'Flat Rate (per item)', ^ spec/system/admin/enterprise_fees_spec.rb:153:1: C: [Corrected] Layout/EmptyLinesAroundBlockBody: Extra empty line detected at block body beginning. spec/system/admin/enterprise_fees_spec.rb:153:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/system/admin/enterprise_fees_spec.rb:157:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/system/admin/enterprise_fees_spec.rb:159:38: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. select 'Flat Rate (per order)', ^ spec/system/admin/enterprise_fees_spec.rb:222:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/system/admin/flatpickr_spec.rb:22:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/system/admin/flatpickr_spec.rb:27:32: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. find("#admin-menu").click ^^^^^^^ spec/system/admin/flatpickr_spec.rb:32:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/system/admin/flatpickr_spec.rb:34:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/system/admin/flatpickr_spec.rb:41:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/system/admin/order_cycles/complex_editing_spec.rb:74:33: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. expect(page).to have_select( ^ spec/system/admin/order_cycles/complex_editing_spec.rb:110:33: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. expect(page).to have_select( ^ spec/system/admin/order_cycles/list_spec.rb:147:46: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. expect(find('input.datetimepicker', ^ spec/system/admin/order_cycles/list_spec.rb:160:46: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. expect(find('input.datetimepicker', ^ spec/system/admin/order_cycles/list_spec.rb:188:46: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. expect(find('input.datetimepicker', ^ spec/system/admin/order_cycles/simple_spec.rb:447:43: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. expect(page).not_to have_selector( ^ spec/system/admin/order_spec.rb:92:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/system/admin/order_spec.rb:207:30: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. within(".modal") do ^ spec/system/admin/order_spec.rb:235:21: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. login_as_admin ^^ spec/system/admin/order_spec.rb:240:16: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. before do ^ spec/system/admin/order_spec.rb:247:62: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. context "when using the cancel option in the dropdown" do ^^ spec/system/admin/order_spec.rb:248:16: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. before do ^ spec/system/admin/order_spec.rb:299:53: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. expect(page).to have_content "Are you sure?" ^^^^^^^^ spec/system/admin/order_spec.rb:327:36: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. find("a.delete-item").click ^ spec/system/admin/order_spec.rb:401:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/system/admin/order_spec.rb:405:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/system/admin/order_spec.rb:598:59: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. expect(page).to have_link "Resend Confirmation", ^ spec/system/admin/order_spec.rb:617:52: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. expect(page).to have_link "Cancel Order", ^ spec/system/admin/order_spec.rb:633:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/system/admin/order_spec.rb:635:1: C: [Corrected] Layout/EmptyLinesAroundBlockBody: Extra empty line detected at block body beginning. spec/system/admin/order_spec.rb:635:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/system/admin/order_spec.rb:674:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/system/admin/order_spec.rb:735:35: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. within "#order-total" do ^ spec/system/admin/order_spec.rb:762:39: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. within "#order-total" do ^ spec/system/admin/order_spec.rb:778:41: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. within "#order-total" do ^ spec/system/admin/order_spec.rb:780:20: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. end ^^ spec/system/admin/order_spec.rb:796:39: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. within "#order-total" do ^ spec/system/admin/order_spec.rb:807:88: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. # Since the order is completed, the price is not supposed to be updated ^ spec/system/admin/order_spec.rb:813:41: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. within "#order-total" do ^ spec/system/admin/order_spec.rb:815:20: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. end ^^ spec/system/admin/order_spec.rb:924:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/system/admin/order_spec.rb:959:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/system/admin/order_spec.rb:981:16: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. before do ^^ spec/system/admin/order_spec.rb:992:8: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. end ^^ spec/system/admin/order_spec.rb:1002:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/system/admin/shipping_methods_spec.rb:50:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/system/admin/shipping_methods_spec.rb:92:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. 1479 files inspected, 81 offenses detected, 81 offenses corrected	2023-07-27 09:58:33 +10:00
Neal Chambers	e0206a0be6	Safely autocorrect Layout/TrailingEmptyLines ... Inspecting 1479 files ..C.................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................... Offenses: Rakefile:10:1: C: [Corrected] Layout/TrailingEmptyLines: 1 trailing blank lines detected. 1479 files inspected, 1 offense detected, 1 offense corrected	2023-07-27 09:58:33 +10:00
Neal Chambers	2dbaa7f89d	Safely autocorrect Layout/MultilineMethodCallIndentation ... Inspecting 1479 files ............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C.......................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C.......CC......................C.................................................. Offenses: spec/controllers/api/v0/orders_controller_spec.rb:150:13: C: [Corrected] Layout/MultilineMethodCallIndentation: Use 2 (not 0) spaces for indenting an expression spanning multiple lines. .map{ |o| o["id"] } ^^^^ spec/system/admin/order_cycles/complex_editing_spec.rb:30:9: C: [Corrected] Layout/MultilineMethodCallIndentation: Use 2 (not 4) spaces for indenting an expression spanning multiple lines. .to eq(oc.orders_open_at.strftime("%Y-%m-%d %H:%M")) ^^^ spec/system/admin/order_cycles/complex_editing_spec.rb:32:9: C: [Corrected] Layout/MultilineMethodCallIndentation: Use 2 (not 4) spaces for indenting an expression spanning multiple lines. .to eq(oc.orders_close_at.strftime("%Y-%m-%d %H:%M")) ^^^ spec/system/admin/overview_spec.rb:16:62: C: [Corrected] Layout/MultilineMethodCallIndentation: Use 2 (not 55) spaces for indenting an expression spanning multiple lines. .and_return @enterprise_user ^^^^^^^^^^^ spec/system/admin/payment_method_spec.rb:62:22: C: [Corrected] Layout/MultilineMethodCallIndentation: Use 2 (not 13) spaces for indenting an expression spanning multiple lines. .to_return(body: JSON.generate(stripe_account_mock)) ^^^^^^^^^^ spec/system/admin/variant_overrides_spec.rb:214:64: C: [Corrected] Layout/MultilineMethodCallIndentation: Use 2 (not 51) spaces for indenting an expression spanning multiple lines. .and_return(build(:user)) ^^^^^^^^^^^ 1479 files inspected, 6 offenses detected, 6 offenses corrected	2023-07-27 09:58:33 +10:00
Neal Chambers	164385ad13	Safely autocorrect Layout/MultilineMethodCallBraceLayout ... Inspecting 1479 files ...........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C.....C..................................................................... Offenses: spec/system/admin/orders_spec.rb:485:80: C: [Corrected] Layout/MultilineMethodCallBraceLayout: Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument. "#listing_orders tbody tr td:first-child input[type=checkbox]") ^ spec/system/admin/orders_spec.rb:486:1: C: [Corrected] Layout/ClosingParenthesisIndentation: Indent ) to column 15 (not 0) )).to be_checked ^ spec/system/admin/orders_spec.rb:486:15: C: [Corrected] Layout/MultilineMethodCallBraceLayout: Closing method call brace must be on the same line as the last argument when opening brace is on the same line as the first argument. ).to be_checked ^ spec/system/admin/orders_spec.rb:493:80: C: [Corrected] Layout/MultilineMethodCallBraceLayout: Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument. "#listing_orders tbody tr td:first-child input[type=checkbox]") ^ spec/system/admin/orders_spec.rb:494:1: C: [Corrected] Layout/ClosingParenthesisIndentation: Indent ) to column 15 (not 0) )).to_not be_checked ^ spec/system/admin/orders_spec.rb:494:15: C: [Corrected] Layout/MultilineMethodCallBraceLayout: Closing method call brace must be on the same line as the last argument when opening brace is on the same line as the first argument. ).to_not be_checked ^ spec/system/admin/products_spec.rb:346:54: C: [Corrected] Layout/MultilineMethodCallBraceLayout: Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument. product.id, filter))) ^ spec/system/admin/products_spec.rb:347:1: C: [Corrected] Layout/ClosingParenthesisIndentation: Indent ) to column 33 (not 0) ))) ^ spec/system/admin/products_spec.rb:352:54: C: [Corrected] Layout/MultilineMethodCallBraceLayout: Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument. product.id, filter))) ^ spec/system/admin/products_spec.rb:354:1: C: [Corrected] Layout/ClosingParenthesisIndentation: Indent ) to column 33 (not 0) ))) ^ 1479 files inspected, 10 offenses detected, 10 offenses corrected	2023-07-27 09:58:33 +10:00
Neal Chambers	a97e208881	Safely autocorrect Layout/MultilineBlockLayout ... Inspecting 1479 files ....................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C.................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................. Offenses: engines/order_management/app/services/order_management/subscriptions/validator.rb:101:9: C: [Corrected] Layout/IndentationWidth: Use 2 (not 12) spaces for indentation. sli.quantity > 0 && !sli.marked_for_destruction? ^^^^^^^^^^^^ engines/order_management/app/services/order_management/subscriptions/validator.rb:101:11: C: [Corrected] Layout/MultilineBlockLayout: Block argument expression is not on the same line as the block start. |sli| sli.quantity > 0 && !sli.marked_for_destruction? ^^^^^ 1479 files inspected, 2 offenses detected, 2 offenses corrected	2023-07-27 09:58:05 +10:00
Maikel Linke	f7d5217ef6	Compile JS before testing caching ... That avoids flakiness.	2023-07-27 09:40:08 +10:00
Neal Chambers	ffda639629	Regenerate Rubocop's TODO file	2023-07-27 08:35:27 +09:00
Maikel	f9589b8b23	Merge pull request #11280 from filipefurtad0/fix_flaky_caching_spec ... Comments out flaky caching example	2023-07-27 08:50:06 +10:00
Maikel	5e94c038dc	Merge pull request #11227 from filipefurtad0/update_several_enterprise_fees ... Updates spec to cover #11150 (regression spec)	2023-07-27 08:45:27 +10:00
Maikel	16d28ab797	Merge pull request #11277 from mkllnk/greek ... Add greek locale	2023-07-27 08:38:51 +10:00
filipefurtad0	5ed9583048	Rubocop fixes - not seen locally ... Not sure why these were triggered remotly, but not locally - even after making sure I'm up-to-date with master?	2023-07-26 18:35:12 +01:00
filipefurtad0	f7301b72aa	Adds test case for updating multiple fees ... Adds values, updates and asserts these are saved correctly	2023-07-26 18:35:09 +01:00
filipefurtad0	83f1266b8a	Comments out flaky example ... Sets example to xit pending is not suitable for flaky specs, as we'll get a red build anyway, each time the spec passes; commenting out should be the right approach till we fix this one	2023-07-26 12:05:06 +01:00
jibees	f5564a5947	Merge pull request #11279 from openfoodfoundation/dependabot/bundler/rubocop-1.55.0 ... chore(deps-dev): bump rubocop from 1.54.2 to 1.55.0	2023-07-26 12:56:01 +02:00
filipefurtad0	d4d8941117	Reverts #11019 ... As discussed here (https://github.com/openfoodfoundation/openfoodnetwork/issues/11010#issuecomment-1594153860), reset_spree_preferences already does Rails.cache.clear	2023-07-26 11:49:41 +01:00
dependabot[bot]	45edda9bf6	chore(deps-dev): bump rubocop from 1.54.2 to 1.55.0 ... Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.54.2 to 1.55.0. - [Release notes](https://github.com/rubocop/rubocop/releases) - [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md) - [Commits](https://github.com/rubocop/rubocop/compare/v1.54.2...v1.55.0) --- updated-dependencies: - dependency-name: rubocop dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>	2023-07-26 08:43:15 +00:00
jibees	ad7ec1e6d0	Merge pull request #11271 from openfoodfoundation/dependabot/bundler/aws-sdk-s3-1.132.0 ... chore(deps): bump aws-sdk-s3 from 1.131.0 to 1.132.0	2023-07-26 10:41:38 +02:00