jibees
eeae67e2d0
Merge pull request #8935 from mkllnk/clean-rubocop
...
Relax our style guide
2022-02-28 15:16:46 +01:00
Filipe
499ad982c3
Merge pull request #8938 from filipefurtad0/controller_spec_checkout_split
...
Adds controller coverage for stock restrictions on split checkout
2022-02-28 10:32:46 +00:00
filipefurtad0
f6304892c2
Adds controller coverage for stock restrictions
2022-02-27 22:01:48 +00:00
Matt-Yorkley
50ab0731d7
Bump nokogiri to 1.13.2
2022-02-26 14:39:56 +00:00
Maikel Linke
e6b4f462ef
Revert "Add rubocop config to allow specs to be 300 lines long"
...
This reverts commit 0b51d8b297
2022-02-25 12:05:04 +11:00
Maikel Linke
cee6a0f17f
Declare blocklength rules as agreed upon
...
The acceptance of this pull request will be the "agree" part. :-)
2022-02-25 11:57:43 +11:00
Maikel Linke
7acae6522b
Relax cyclomatic complexity to community default
...
Why should we be more strict than the rest of the world?
2022-02-25 11:56:33 +11:00
Maikel Linke
2d1e746c64
Remove default values from contested settings
...
We can just use what the Rubocop community uses as default and we don't
need to spell it out again.
2022-02-25 11:51:35 +11:00
Maikel Linke
3382c1d0bb
Relax some contested metrics rules
...
Rubocop often complains while we think that the code is totally fine. I
would like to achieve the default values one day but there are more
important issues at the moment.
2022-02-25 11:45:15 +11:00
Maikel Linke
0c89479de4
Update rubocop todo list
2022-02-25 11:05:36 +11:00
Maikel Linke
b999673dfc
Remove old version of relaxed styled guide
...
We had an old version under "contested settings" and it looks like some
of them were modified. I hope that our new, separate file will
discourage manual tweaks.
We can include the relaxed rules from a gem as well. Let's see if we
need that complexity one day.
2022-02-25 10:51:54 +11:00
Maikel Linke
1d15f35522
Remove now unnecessary inline rubocop config
2022-02-25 10:46:51 +11:00
Maikel Linke
decab911bd
Use relaxed Rubocop styleguide as basis
...
We then refine it with our own rules.
2022-02-25 10:44:32 +11:00
Matt-Yorkley
0b616aa9ce
Update all locales with the latest Transifex translations
2022-02-24 23:34:16 +00:00
Filipe
36e3f1b7a6
Merge pull request #8883 from jibees/8475-send-email-when-payment-needs-authorization
...
Backoffice order, using stripe payment: when card requires auth, send authorization email to guest user
2022-02-24 13:07:31 +00:00
Matt-Yorkley
d945e69404
Merge pull request #8918 from openfoodfoundation/dependabot/npm_and_yarn/url-parse-1.5.7
...
Bump url-parse from 1.5.3 to 1.5.7
2022-02-22 08:17:02 +00:00
Filipe
385cd49964
Merge pull request #8876 from SarvarKh/product-import-validation
...
Fix product import on existing, empty unit_type and variant_unit
2022-02-21 23:20:04 +00:00
Filipe
28ac9d980c
Merge pull request #8849 from jibees/render-pdf-with-stylesheet
...
Create a new method pdf_stylesheet_pack_tag that actually include CSS in PDF files
2022-02-21 23:09:21 +00:00
Filipe
dbf5eb76f8
Merge pull request #8689 from apricot12/Transaction_fee_when_crediting
...
Revoke transaction fee if there is an amount to be credited in order
2022-02-21 20:30:19 +00:00
Filipe
89dc9b938b
Merge pull request #8864 from jibees/7934-display-tax-rate-for-shipping-on-invoice
...
Display tax rate for shipping in alternative invoice model
2022-02-21 20:02:44 +00:00
Filipe
7590b3ecf8
Merge pull request #8756 from jibees/8075-take-into-account-the-inherits_properties-attribute
...
Product that don't inherits from "producer"/"enterprise" properties should be filtered out by user on shop page
2022-02-21 19:04:08 +00:00
Filipe
9966b5b33c
Merge pull request #8565 from jibees/8171-group-by-imperial-unit
...
Handle imperial units in the Bulk Order Management interface
2022-02-21 14:47:38 +00:00
dependabot[bot]
07d20d2ba0
Bump url-parse from 1.5.3 to 1.5.7
...
Bumps [url-parse](https://github.com/unshiftio/url-parse ) from 1.5.3 to 1.5.7.
- [Release notes](https://github.com/unshiftio/url-parse/releases )
- [Commits](https://github.com/unshiftio/url-parse/compare/1.5.3...1.5.7 )
---
updated-dependencies:
- dependency-name: url-parse
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2022-02-19 09:25:58 +00:00
Matt-Yorkley
6c695df917
Merge pull request #8895 from Matt-Yorkley/cloned-subscription-syncing
...
Sync subscriptions on newly-cloned order cycles
2022-02-17 12:44:39 +00:00
Matt-Yorkley
9a27addd14
Merge pull request #8763 from openfoodfoundation/8577-split-name-column-in-customers-table
...
Split name column in customers table
2022-02-17 11:57:01 +00:00
Filipe
a6c5d8ca73
Merge pull request #8673 from filipefurtad0/split_checkout_auth_spec
...
Adds split-checkout toggling lines
2022-02-17 11:10:44 +00:00
Filipe
4dbf047647
Merge pull request #8871 from jibees/8827-preselect-shipping-method
...
SplitCheckout: preselect the shipping/payment method if the only one available
2022-02-17 10:54:20 +00:00
Jean-Baptiste Bellet
bcd306ebd4
Authorize payment email could be send to guest user
...
Always send the email to the order.email value
2022-02-17 09:40:28 +01:00
Jean-Baptiste Bellet
012e91879a
preselect the only available shipping method
2022-02-17 09:33:23 +01:00
Jean-Baptiste Bellet
716286497e
Add test to cover "preselect the shipping method" if only one is available
...
+ do not preselect if more than one are available
2022-02-17 09:33:23 +01:00
Jean-Baptiste Bellet
7be2f418d0
preselect the only available payment method
2022-02-17 09:33:23 +01:00
Jean-Baptiste Bellet
0e053a2601
Add test to cover "preselect the payment method" if only one is available
...
+ do not preselect if more than one
2022-02-17 09:33:23 +01:00
Matt-Yorkley
00fa84e3b5
Sync when switching from nil dates to open
2022-02-16 21:45:43 +00:00
Matt-Yorkley
5913720c85
Sync for both open and upcoming OCs when switching from closed
2022-02-16 18:33:09 +00:00
Matt-Yorkley
4592827261
Sync OC subscriptions if transitioning from closed to open
2022-02-16 13:03:27 +00:00
Matt-Yorkley
4260422ea7
Remove a couple of unnecessary memory assignments
2022-02-16 12:55:19 +00:00
Matt-Yorkley
d4488fdb3f
Return early if OC is closed
2022-02-16 12:53:22 +00:00
Matt-Yorkley
8c8b9d1b23
Sync subscriptions on newly-cloned order cycles
2022-02-16 10:44:22 +00:00
SarvarKhalimov
22de758e3a
Add spec for product import validation
2022-02-16 14:17:35 +05:00
Maikel Linke
33969de371
Allow shared_examples to have more than 25 lines
2022-02-16 11:41:28 +11:00
Maikel Linke
a6dee77071
Style
2022-02-16 10:33:49 +11:00
filipefurtad0
78946f908a
Adds shared examples; sets conditional filters on test cases
2022-02-15 23:23:31 +00:00
Matt-Yorkley
4c50ca69ea
Improve data migration logic and add test coverage
2022-02-16 10:23:24 +11:00
Matt-Yorkley
fd815a6af6
Don't change Customer factory name generating logic
2022-02-16 10:23:24 +11:00
Matt-Yorkley
feaa92406a
Split migration into two parts for easier testing
2022-02-16 10:23:24 +11:00
Maikel Linke
68193efcf6
Keep old customers.name column for compatibilty
...
Our app code will try to access the old attribute while the migration is
running. That would lead to errors during checkout.
2022-02-16 10:23:24 +11:00
François Turbelin
9a12957e27
Handle the empty-space name on customers
2022-02-16 10:23:23 +11:00
François Turbelin
de4d074cb3
Remove bill_address fetching logic
2022-02-16 10:23:23 +11:00
Maikel Linke
d09ba16411
Associate customers again
...
And simplify the before_validation actions.
2022-02-16 10:23:23 +11:00
Maikel Linke
07314af3f6
Spec customer record association more realistically
...
The newly added specs were tested on the master branch and passed. But
the previous commit broke one test case which I marked as pending here.
The removed specs are completely replaced by the new ones. Their main
downside was to test only small bits of internal behaviour without
considering the whole callback chain of the order. The new specs are
more realistic and catch bugs like mentioned above.
2022-02-16 10:23:23 +11:00
