804 Commits

Author	SHA1	Message	Date
Neal Chambers	70e765bff6	Safely autocorrect Style/GuardClause ... Inspecting 1488 files ......................C....C.C..........................C.........C.........................C............................................C..............................................................................................................C.C........................................CC..............................C...........C...........................................................................................................................................................................................................C........................................................................................................C.......................................................C.............C...........................................................................................C..................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C...C....................................................................................................................C............. Offenses: app/controllers/admin/enterprises_controller.rb:50:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause. return unless params[:stimulus] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/controllers/admin/enterprises_controller.rb:50:7: C: [Corrected] Style/GuardClause: Use a guard clause (return unless params[:stimulus]) instead of wrapping the code inside a conditional expression. if params[:stimulus] ^^ app/controllers/admin/enterprises_controller.rb:51:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. @enterprise.is_primary_producer = params[:is_primary_producer] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/controllers/admin/enterprises_controller.rb:52:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. @enterprise.sells = params[:enterprise_sells] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/controllers/admin/enterprises_controller.rb:53:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. render cable_ready: cable_car.morph("#side_menu", partial("admin/shared/side_menu")) ... ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/controllers/admin/enterprises_controller.rb:55:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. app/controllers/admin/enterprises_controller.rb:56:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end. app/controllers/admin/enterprises_controller.rb:266:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause. return unless user_id.positive? && @enterprise.user_ids.include?(user_id) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/controllers/admin/enterprises_controller.rb:266:7: C: [Corrected] Style/GuardClause: Use a guard clause (return unless user_id.positive? && @enterprise.user_ids.include?(user_id)) instead of wrapping the code inside a conditional expression. if user_id.positive? && @enterprise.user_ids.include?(user_id) ^^ app/controllers/admin/enterprises_controller.rb:267:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. @enterprise.update_contact(user_id) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/controllers/admin/enterprises_controller.rb:268:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. app/controllers/admin/enterprises_controller.rb:270:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end. app/controllers/admin/enterprises_controller.rb:272:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause. return unless attrs[:calculator_type].present? && attrs[:calculator_attributes].present? ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/controllers/admin/enterprises_controller.rb:272:7: C: [Corrected] Style/GuardClause: Use a guard clause (return unless attrs[:calculator_type].present? && attrs[:calculator_attributes].present?) instead of wrapping the code inside a conditional expression. if attrs[:calculator_type].present? && attrs[:calculator_attributes].present? ^^ app/controllers/admin/enterprises_controller.rb:273:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. rule.update(calculator_type: attrs[:calculator_type]) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/controllers/admin/enterprises_controller.rb:274:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. attrs[:calculator_attributes].merge!( id: rule.calculator.id ) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/controllers/admin/enterprises_controller.rb:275:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. app/controllers/admin/enterprises_controller.rb:278:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end. app/controllers/admin/enterprises_controller.rb:279:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause. return if spree_current_user.admin? ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/controllers/admin/enterprises_controller.rb:279:7: C: [Corrected] Style/GuardClause: Use a guard clause (return if spree_current_user.admin?) instead of wrapping the code inside a conditional expression. unless spree_current_user.admin? ^^^^^^ app/controllers/admin/enterprises_controller.rb:280:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. params[:sets_enterprise_set][:collection_attributes].each do |_i, enterprise_params| ... ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/controllers/admin/enterprises_controller.rb:285:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. app/controllers/admin/enterprises_controller.rb:289:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end. app/controllers/admin/enterprises_controller.rb:289:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause. return if spree_current_user.admin? || spree_current_user == @enterprise.owner ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/controllers/admin/enterprises_controller.rb:289:7: C: [Corrected] Style/GuardClause: Use a guard clause (return if spree_current_user.admin? || spree_current_user == @enterprise.owner) instead of wrapping the code inside a conditional expression. unless spree_current_user.admin? || spree_current_user == @enterprise.owner ^^^^^^ app/controllers/admin/enterprises_controller.rb:290:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. enterprise_params.delete :sells ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/controllers/admin/enterprises_controller.rb:291:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. app/controllers/admin/enterprises_controller.rb:296:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end. app/controllers/admin/enterprises_controller.rb:299:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause. return if spree_current_user.admin? ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/controllers/admin/enterprises_controller.rb:299:7: C: [Corrected] Style/GuardClause: Use a guard clause (return if spree_current_user.admin?) instead of wrapping the code inside a conditional expression. unless spree_current_user.admin? ^^^^^^ app/controllers/admin/enterprises_controller.rb:300:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. has_hub = spree_current_user.owned_enterprises.is_hub.any? ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/controllers/admin/enterprises_controller.rb:301:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. new_enterprise_is_producer = Enterprise.new(enterprise_params).is_primary_producer ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/controllers/admin/enterprises_controller.rb:302:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. enterprise_params[:sells] = has_hub && !new_enterprise_is_producer ? 'any' : 'none' ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/controllers/admin/enterprises_controller.rb:303:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. app/controllers/admin/enterprises_controller.rb:307:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause. return if ( spree_current_user == @enterprise.owner ) || spree_current_user.admin? ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/controllers/admin/enterprises_controller.rb:307:7: C: [Corrected] Style/GuardClause: Use a guard clause (return if ( spree_current_user == @enterprise.owner ) || spree_current_user.admin?) instead of wrapping the code inside a conditional expression. unless ( spree_current_user == @enterprise.owner ) || spree_current_user.admin? ^^^^^^ app/controllers/admin/enterprises_controller.rb:308:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. enterprise_params.delete :owner_id ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/controllers/admin/enterprises_controller.rb:309:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end. app/controllers/admin/enterprises_controller.rb:309:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. app/controllers/admin/enterprises_controller.rb:313:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause. return if spree_current_user.admin? ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/controllers/admin/enterprises_controller.rb:313:7: C: [Corrected] Style/GuardClause: Use a guard clause (return if spree_current_user.admin?) instead of wrapping the code inside a conditional expression. unless spree_current_user.admin? ^^^^^^ app/controllers/admin/enterprises_controller.rb:314:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. bulk_params[:collection_attributes].each do |_i, enterprise_params| ... ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/controllers/admin/enterprises_controller.rb:316:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end. app/controllers/admin/enterprises_controller.rb:317:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. app/controllers/admin/enterprises_controller.rb:321:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause. return if ( spree_current_user == @enterprise.owner ) || spree_current_user.admin? ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/controllers/admin/enterprises_controller.rb:321:7: C: [Corrected] Style/GuardClause: Use a guard clause (return if ( spree_current_user == @enterprise.owner ) || spree_current_user.admin?) instead of wrapping the code inside a conditional expression. unless ( spree_current_user == @enterprise.owner ) || spree_current_user.admin? ^^^^^^ app/controllers/admin/enterprises_controller.rb:322:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. enterprise_params.delete :user_ids ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/controllers/admin/enterprises_controller.rb:323:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. app/controllers/admin/enterprises_controller.rb:325:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end. app/controllers/admin/enterprises_controller.rb:332:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end. app/controllers/admin/order_cycles_controller.rb:185:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause. return unless json_request? ^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/controllers/admin/order_cycles_controller.rb:185:7: C: [Corrected] Style/GuardClause: Use a guard clause (return unless json_request?) instead of wrapping the code inside a conditional expression. if json_request? ^^ app/controllers/admin/order_cycles_controller.rb:188:9: C: [Corrected] Layout/CommentIndentation: Incorrect indentation detected (column 8 instead of 6). # to limit returned ocs to recent or undated ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/controllers/admin/order_cycles_controller.rb:188:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. orders_close_at_gt = raw_params[:q]&.delete(:orders_close_at_gt) || 31.days.ago ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/controllers/admin/order_cycles_controller.rb:189:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. raw_params[:q] = { ... ^^^^^^^^^^^^^^^^^^ app/controllers/admin/order_cycles_controller.rb:194:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. @collection = collection ^^^^^^^^^^^^^^^^^^^^^^^^ app/controllers/admin/order_cycles_controller.rb:195:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. app/controllers/admin/order_cycles_controller.rb:196:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end. app/controllers/admin/order_cycles_controller.rb:248:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause. return if Enterprise.managed_by(spree_current_user).include?(@order_cycle.coordinator) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/controllers/admin/order_cycles_controller.rb:248:7: C: [Corrected] Style/GuardClause: Use a guard clause (return if Enterprise.managed_by(spree_current_user).include?(@order_cycle.coordinator)) instead of wrapping the code inside a conditional expression. unless Enterprise.managed_by(spree_current_user).include?(@order_cycle.coordinator) ^^^^^^ app/controllers/admin/order_cycles_controller.rb:249:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. order_cycle_params.delete_if do |k, _v| ... ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/controllers/admin/order_cycles_controller.rb:252:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. app/controllers/admin/order_cycles_controller.rb:254:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end. app/controllers/admin/product_import_controller.rb:59:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause. return if params[:file] || (params[:filepath] && File.exist?(params[:filepath])) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/controllers/admin/product_import_controller.rb:59:7: C: [Corrected] Style/GuardClause: Use a guard clause (return if params[:file] || (params[:filepath] && File.exist?(params[:filepath]))) instead of wrapping the code inside a conditional expression. unless params[:file] || (params[:filepath] && File.exist?(params[:filepath])) ^^^^^^ app/controllers/admin/product_import_controller.rb:60:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. redirect_to '/admin/product_import', notice: I18n.t(:product_import_file_not_found_notice) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/controllers/admin/product_import_controller.rb:61:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. app/controllers/admin/product_import_controller.rb:62:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end. app/controllers/admin/product_import_controller.rb:93:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause. return if importer.item_count ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/controllers/admin/product_import_controller.rb:93:7: C: [Corrected] Style/GuardClause: Use a guard clause (return if importer.item_count) instead of wrapping the code inside a conditional expression. unless importer.item_count ^^^^^^ app/controllers/admin/product_import_controller.rb:94:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. redirect_to '/admin/product_import', ... ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/controllers/admin/product_import_controller.rb:96:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. true ^^^^ app/controllers/admin/product_import_controller.rb:97:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. app/controllers/admin/product_import_controller.rb:99:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end. app/controllers/api/v0/shipments_controller.rb:48:11: C: Style/GuardClause: Use a guard clause (unless @shipment.can_ready?; render(json: { error: I18n.t(:cannot_ready, scope: "spree.api.shipment") }, status: :unprocessable_entity) && return; end) instead of wrapping the code inside a conditional expression. if @shipment.can_ready? ^^ app/controllers/application_controller.rb:118:5: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause. return if (@distributor = current_distributor) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/controllers/application_controller.rb:118:5: C: [Corrected] Style/GuardClause: Use a guard clause (return if (@distributor = current_distributor)) instead of wrapping the code inside a conditional expression. unless (@distributor = current_distributor) ^^^^^^ app/controllers/application_controller.rb:119:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. redirect_to main_app.root_path ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/controllers/application_controller.rb:120:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. false ^^^^^ app/controllers/application_controller.rb:121:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. app/controllers/application_controller.rb:122:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end. app/controllers/application_controller.rb:125:5: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause. return if current_order_cycle ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/controllers/application_controller.rb:125:5: C: [Corrected] Style/GuardClause: Use a guard clause (return if current_order_cycle) instead of wrapping the code inside a conditional expression. unless current_order_cycle ^^^^^^ app/controllers/application_controller.rb:126:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. redirect_to main_app.shop_path ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/controllers/application_controller.rb:127:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. app/controllers/application_controller.rb:129:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end. app/controllers/application_controller.rb:131:5: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause. return unless current_distributor_closed? ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/controllers/application_controller.rb:131:5: C: [Corrected] Style/GuardClause: Use a guard clause (return unless current_distributor_closed?) instead of wrapping the code inside a conditional expression. if current_distributor_closed? ^^ app/controllers/application_controller.rb:132:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. current_order.empty! ^^^^^^^^^^^^^^^^^^^^ app/controllers/application_controller.rb:133:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. current_order.set_distribution! nil, nil ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/controllers/application_controller.rb:134:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. flash[:info] = I18n.t('order_cycles_closed_for_hub') ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/controllers/application_controller.rb:135:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. redirect_to main_app.root_url ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/controllers/application_controller.rb:136:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. app/controllers/application_controller.rb:139:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end. app/controllers/home_controller.rb:7:5: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause. return unless ContentConfig.home_show_stats ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/controllers/home_controller.rb:7:5: C: [Corrected] Style/GuardClause: Use a guard clause (return unless ContentConfig.home_show_stats) instead of wrapping the code inside a conditional expression. if ContentConfig.home_show_stats ^^ app/controllers/home_controller.rb:8:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. @num_distributors = cached_count('distributors', Enterprise.is_distributor.activated.visible) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/controllers/home_controller.rb:9:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. @num_producers = cached_count('producers', Enterprise.is_primary_producer.activated.visible) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/controllers/home_controller.rb:10:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. @num_orders = cached_count('orders', Spree::Order.complete) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/controllers/home_controller.rb:11:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. @num_users = cached_count( ... ^^^^^^^^^^^^^^^^^^^^^^^^^^ app/controllers/home_controller.rb:14:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. app/controllers/home_controller.rb:15:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end. app/controllers/spree/orders_controller.rb:136:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause. return unless params[:order] && params[:order][:line_items_attributes] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/controllers/spree/orders_controller.rb:136:7: C: [Corrected] Style/GuardClause: Use a guard clause (return unless params[:order] && params[:order][:line_items_attributes]) instead of wrapping the code inside a conditional expression. if params[:order] && params[:order][:line_items_attributes] ^^ app/controllers/spree/orders_controller.rb:137:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. params[:order][:line_items_attributes] = ... ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/controllers/spree/orders_controller.rb:139:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. app/controllers/spree/orders_controller.rb:140:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end. app/controllers/spree/orders_controller.rb:183:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause. return unless items.empty? ^^^^^^^^^^^^^^^^^^^^^^^^^^ app/controllers/spree/orders_controller.rb:183:7: C: [Corrected] Style/GuardClause: Use a guard clause (return unless items.empty?) instead of wrapping the code inside a conditional expression. if items.empty? ^^ app/controllers/spree/orders_controller.rb:184:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. flash[:error] = I18n.t(:orders_cannot_remove_the_final_item) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/controllers/spree/orders_controller.rb:185:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. redirect_to main_app.order_path(order_to_update) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/controllers/spree/orders_controller.rb:186:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. app/controllers/spree/orders_controller.rb:188:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end. app/models/enterprise.rb:518:5: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause. return if owner.can_own_more_enterprises? ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/models/enterprise.rb:518:5: C: [Corrected] Style/GuardClause: Use a guard clause (return if owner.can_own_more_enterprises?) instead of wrapping the code inside a conditional expression. unless owner.can_own_more_enterprises? ^^^^^^ app/models/enterprise.rb:519:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. errors.add(:owner, I18n.t(:enterprise_owner_error, email: owner.email, ... ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/models/enterprise.rb:521:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. app/models/enterprise.rb:522:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end. app/models/enterprise.rb:546:5: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause. return unless is_hub ^^^^^^^^^^^^^^^^^^^^ app/models/enterprise.rb:546:5: C: [Corrected] Style/GuardClause: Use a guard clause (return unless is_hub) instead of wrapping the code inside a conditional expression. if is_hub ^^ app/models/enterprise.rb:547:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. enterprises.is_primary_producer.each do |enterprise| ... ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/models/enterprise.rb:553:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. app/models/enterprise.rb:555:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end. app/models/enterprise.rb:557:5: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause. return if preferred_shopfront_taxon_order =~ /\A((\d+,)*\d+)?\z/ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/models/enterprise.rb:557:5: C: [Corrected] Style/GuardClause: Use a guard clause (return if preferred_shopfront_taxon_order =~ /\A((\d+,)*\d+)?\z/) instead of wrapping the code inside a conditional expression. unless preferred_shopfront_taxon_order =~ /\A((\d+,)*\d+)?\z/ ^^^^^^ app/models/enterprise.rb:558:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. errors.add(:shopfront_category_ordering, "must contain a list of taxons.") ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/models/enterprise.rb:559:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. app/models/enterprise.rb:562:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end. app/models/enterprise.rb:563:5: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause. return if preferred_shopfront_producer_order =~ /\A((\d+,)*\d+)?\z/ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/models/enterprise.rb:563:5: C: [Corrected] Style/GuardClause: Use a guard clause (return if preferred_shopfront_producer_order =~ /\A((\d+,)*\d+)?\z/) instead of wrapping the code inside a conditional expression. unless preferred_shopfront_producer_order =~ /\A((\d+,)*\d+)?\z/ ^^^^^^ app/models/enterprise.rb:564:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. errors.add(:shopfront_category_ordering, "must contain a list of producers.") ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/models/enterprise.rb:565:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. app/models/enterprise.rb:569:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end. app/models/enterprise_group.rb:80:5: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause. return unless permalink.blank? || permalink_changed? ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/models/enterprise_group.rb:80:5: C: [Corrected] Style/GuardClause: Use a guard clause (return unless permalink.blank? || permalink_changed?) instead of wrapping the code inside a conditional expression. if permalink.blank? || permalink_changed? ^^ app/models/enterprise_group.rb:81:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. requested = permalink.presence || permalink_was.presence || name.presence || 'group' ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/models/enterprise_group.rb:82:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. self.permalink = create_unique_permalink(requested.parameterize) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/models/enterprise_group.rb:83:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. app/models/enterprise_group.rb:84:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end. app/models/producer_property.rb:16:5: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause. return unless name.present? ^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/models/producer_property.rb:16:5: C: [Corrected] Style/GuardClause: Use a guard clause (return unless name.present?) instead of wrapping the code inside a conditional expression. if name.present? ^^ app/models/producer_property.rb:16:12: C: [Correctable] Rails/Blank: Use if name.blank? instead of unless name.present?. return unless name.present? ^^^^^^^^^^^^^^^^^^^^ app/models/producer_property.rb:17:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. self.property = Spree::Property.find_by(name: name) || ... ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/models/producer_property.rb:19:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. app/models/producer_property.rb:20:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end. app/models/product_import/entry_processor.rb:42:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause. return unless total_saved_count.zero? ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/models/product_import/entry_processor.rb:42:7: C: [Corrected] Style/GuardClause: Use a guard clause (return unless total_saved_count.zero?) instead of wrapping the code inside a conditional expression. if total_saved_count.zero? ^^ app/models/product_import/entry_processor.rb:43:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. @importer.errors.add(:importer, ... ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/models/product_import/entry_processor.rb:45:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. app/models/product_import/entry_processor.rb:46:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end. app/models/spree/order.rb:506:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause. return unless !completed? && shipments.any? ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/models/spree/order.rb:506:7: C: [Corrected] Style/GuardClause: Use a guard clause (return unless !completed? && shipments.any?) instead of wrapping the code inside a conditional expression. if !completed? && shipments.any? ^^ app/models/spree/order.rb:507:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. shipments.destroy_all ^^^^^^^^^^^^^^^^^^^^^ app/models/spree/order.rb:508:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. restart_checkout_flow ^^^^^^^^^^^^^^^^^^^^^ app/models/spree/order.rb:509:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. app/models/spree/order.rb:510:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end. app/models/spree/preferences/preferable_class_methods.rb:67:9: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause. return unless method_defined? preference_description_getter_method(name) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/models/spree/preferences/preferable_class_methods.rb:67:9: C: [Corrected] Style/GuardClause: Use a guard clause (return unless method_defined? preference_description_getter_method(name)) instead of wrapping the code inside a conditional expression. if method_defined? preference_description_getter_method(name) ^^ app/models/spree/preferences/preferable_class_methods.rb:68:11: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. remove_method preference_description_getter_method(name) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/models/spree/preferences/preferable_class_methods.rb:69:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. app/models/spree/preferences/preferable_class_methods.rb:70:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end. app/services/order_syncer.rb:90:5: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause. return unless !pickup_to_delivery || order.shipment.blank? ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/services/order_syncer.rb:90:5: C: [Corrected] Style/GuardClause: Use a guard clause (return unless !pickup_to_delivery || order.shipment.blank?) instead of wrapping the code inside a conditional expression. if !pickup_to_delivery || order.shipment.blank? ^^ app/services/order_syncer.rb:91:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. order.updater.shipping_address_from_distributor ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/services/order_syncer.rb:92:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. app/services/order_syncer.rb:93:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end. engines/order_management/app/services/order_management/order/updater.rb:166:9: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause. return unless payment.completed? || order.completed? ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ engines/order_management/app/services/order_management/order/updater.rb:166:9: C: [Corrected] Style/GuardClause: Use a guard clause (return unless payment.completed? || order.completed?) instead of wrapping the code inside a conditional expression. if payment.completed? || order.completed? ^^ engines/order_management/app/services/order_management/order/updater.rb:167:11: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. persist_totals ^^^^^^^^^^^^^^ engines/order_management/app/services/order_management/order/updater.rb:168:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. engines/order_management/app/services/order_management/order/updater.rb:169:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end. lib/discourse/single_sign_on.rb:33:9: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause. raise "Bad signature for payload #{diags}" unless parsed["sso"] =~ %r{[^a-zA-Z0-9=\r\n/+]}m ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ lib/discourse/single_sign_on.rb:33:9: C: [Corrected] Style/GuardClause: Use a guard clause (raise "Bad signature for payload #{diags}" unless parsed["sso"] =~ %r{[^a-zA-Z0-9=\r\n/+]}m) instead of wrapping the code inside a conditional expression. if parsed["sso"] =~ %r{[^a-zA-Z0-9=\r\n/+]}m ^^ lib/discourse/single_sign_on.rb:34:11: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. raise "The SSO field should be Base64 encoded, using only A-Z, a-z, 0-9, +, /, " \ ... ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ lib/discourse/single_sign_on.rb:37:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/discourse/single_sign_on.rb:38:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/discourse/single_sign_on.rb:39:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected. lib/discourse/single_sign_on.rb:39:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/discourse/single_sign_on.rb:40:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected. lib/open_food_network/order_cycle_form_applicator.rb:76:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause. return unless manages_coordinator? ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ lib/open_food_network/order_cycle_form_applicator.rb:76:7: C: [Corrected] Style/GuardClause: Use a guard clause (return unless manages_coordinator?) instead of wrapping the code inside a conditional expression. if manages_coordinator? ^^ lib/open_food_network/order_cycle_form_applicator.rb:77:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. exchange.save! ^^^^^^^^^^^^^^ lib/open_food_network/order_cycle_form_applicator.rb:78:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. ExchangeVariantBulkUpdater.new(exchange).update!(variant_ids) unless variant_ids.nil? ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ lib/open_food_network/order_cycle_form_applicator.rb:80:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. @touched_exchanges << exchange ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ lib/open_food_network/order_cycle_form_applicator.rb:81:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/open_food_network/order_cycle_form_applicator.rb:82:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end. lib/open_food_network/order_cycle_form_applicator.rb:107:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause. return unless manages_coordinator? ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ lib/open_food_network/order_cycle_form_applicator.rb:107:7: C: [Corrected] Style/GuardClause: Use a guard clause (return unless manages_coordinator?) instead of wrapping the code inside a conditional expression. if manages_coordinator? ^^ lib/open_food_network/order_cycle_form_applicator.rb:108:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. untouched_exchanges.each(&:destroy) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ lib/open_food_network/order_cycle_form_applicator.rb:109:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/open_food_network/order_cycle_form_applicator.rb:111:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end. lib/spree/core/controller_helpers/respond_with.rb:42:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause. raise ActionController::UnknownFormat unless format ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ lib/spree/core/controller_helpers/respond_with.rb:42:7: C: [Corrected] Style/GuardClause: Use a guard clause (raise ActionController::UnknownFormat unless format) instead of wrapping the code inside a conditional expression. if format ^^ lib/spree/core/controller_helpers/respond_with.rb:43:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. _process_format(format) ^^^^^^^^^^^^^^^^^^^^^^^ lib/spree/core/controller_helpers/respond_with.rb:44:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. collector ^^^^^^^^^ lib/spree/core/controller_helpers/respond_with.rb:45:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/spree/core/controller_helpers/respond_with.rb:46:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end. lib/spree/core/controller_helpers/respond_with.rb:46:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/spree/core/controller_helpers/respond_with.rb:47:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected. lib/spree/core/controller_helpers/respond_with.rb:47:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. lib/spree/core/controller_helpers/respond_with.rb:48:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected. lib/spree/core/controller_helpers/respond_with.rb:48:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end. spec/support/request/distribution_helper.rb:10:7: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause. return unless order_cycle && page.has_select?('order_order_cycle_id') ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/support/request/distribution_helper.rb:10:7: C: [Corrected] Style/GuardClause: Use a guard clause (return unless order_cycle && page.has_select?('order_order_cycle_id')) instead of wrapping the code inside a conditional expression. if order_cycle && page.has_select?('order_order_cycle_id') ^^ spec/support/request/distribution_helper.rb:11:9: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. select_by_value order_cycle.id, from: 'order_order_cycle_id' ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/support/request/distribution_helper.rb:12:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/support/request/distribution_helper.rb:13:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end. spec/support/request/shop_workflow.rb:127:5: C: [Corrected] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause. return unless oc.exchanges.from_enterprise(supplier).incoming.empty? ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/support/request/shop_workflow.rb:127:5: C: [Corrected] Style/GuardClause: Use a guard clause (return unless oc.exchanges.from_enterprise(supplier).incoming.empty?) instead of wrapping the code inside a conditional expression. if oc.exchanges.from_enterprise(supplier).incoming.empty? ^^ spec/support/request/shop_workflow.rb:128:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. create(:exchange, order_cycle: oc, incoming: true, ... ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/support/request/shop_workflow.rb:130:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/support/request/shop_workflow.rb:131:1: C: [Corrected] Layout/EmptyLinesAroundMethodBody: Extra empty line detected at method body end. spec/system/support/precompile_assets.rb:18:5: C: [Corrected] Style/GuardClause: Use a guard clause (next if Webpacker.dev_server.running?) instead of wrapping the code inside a conditional expression. if Webpacker.dev_server.running? ^^ spec/system/support/precompile_assets.rb:19:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/system/support/precompile_assets.rb:20:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected. spec/system/support/precompile_assets.rb:20:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. spec/system/support/precompile_assets.rb:21:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. $stdout.puts "\n Precompiling assets.\n" ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/system/support/precompile_assets.rb:23:7: C: [Corrected] Layout/IndentationConsistency: Inconsistent indentation detected. Webpacker.compile ^^^^^^^^^^^^^^^^^ spec/system/support/precompile_assets.rb:24:1: C: [Corrected] Layout/EmptyLinesAroundBlockBody: Extra empty line detected at block body end. spec/system/support/precompile_assets.rb:24:1: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. 1488 files inspected, 220 offenses detected, 218 offenses corrected, 1 more offense can be corrected with `rubocop -A`	2023-09-01 08:55:56 +09:00
Filipe	c5e1444613	Merge pull request #11206 from macanudo527/fix_class_length ... Add Form Object to Schedules Controller	2023-08-24 09:28:50 +01:00
Konrad	6ec022b731	Merge pull request #11391 from rioug/11362-fix-error-creating-percentage-voucher ... [Vouchers] fix error when creating a percentage voucher	2023-08-24 09:09:30 +02:00
Neal Chambers	a363f88f2c	Put Subscriptions back into Schedules Controller	2023-08-24 09:18:35 +09:00
Neal Chambers	134cbb4f04	Add Form Object to Fix Metrics/ClassLength	2023-08-24 09:17:53 +09:00
Neal Chambers	b60fd6b572	Safely autocorrect Rails/I18nLazyLookup ... Inspecting 1484 files .......................................C.................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................... Offenses: app/controllers/admin/proxy_orders_controller.rb:16:35: C: [Corrected] Rails/I18nLazyLookup: Use "lazy" lookup for the text used in controllers. render json: { errors: [t('admin.proxy_orders.cancel.could_not_cancel_the_order')] }, ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/controllers/admin/proxy_orders_controller.rb:25:35: C: [Corrected] Rails/I18nLazyLookup: Use "lazy" lookup for the text used in controllers. render json: { errors: [t('admin.proxy_orders.resume.could_not_resume_the_order')] }, ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 1484 files inspected, 2 offenses detected, 2 offenses corrected	2023-08-14 17:29:11 +09:00
Maikel Linke	efe2dfff8e	Let Rails handle Voucher type building	2023-08-14 11:51:34 +10:00
Maikel Linke	4d5e1ffb3b	Simplify VouchersController with single param name ... The Voucher form now deals with a generic Voucher instead of a subclass which makes the naming easier and is less confusing when changing types.	2023-08-14 11:39:59 +10:00
Rachel Arnould	5afe45d922	Merge pull request #11382 from jibees/11273-buu-remove-new_products_page-feature-toggle ... 🔧 Remove `new_products_page` and all associated controllers/components/...	2023-08-11 11:43:49 +02:00
Gaetan Craig-Riou	06f986ff52	Allow for creating a voucher with either flat or percentage rate ... In the scenario when you get an error when trying to create a percentage voucher, on the subsequent try we would be dealing with a "percentage rate voucher". The code now handle any type of voucher	2023-08-11 16:09:48 +10:00
Gaetan Craig-Riou	a2def2424c	Add a comment around the use of safe_constantize ... It triggers a Brakeman error that can be safely ignored	2023-08-11 15:41:45 +10:00
Gaetan Craig-Riou	e6b53c0a42	Per review , Simplify creation of Voucher ... We now check against known type to instanciate the correct voucher instead of using a case	2023-08-11 15:41:45 +10:00
Gaetan Craig-Riou	29a38467d2	Fix admin pages to work with refactored vouchers	2023-08-11 14:54:23 +10:00
Gaetan Craig-Riou	cc9069e9c6	Add voucher type to admin screen ... Plus specs	2023-08-11 14:19:26 +10:00
Jean-Baptiste Bellet	3b68674896	Remove new_products_page and all associated controller/components/ ... new_products_page` is dead, long live `admin_style_v3` !	2023-08-10 10:02:45 +02:00
David Cook	42230c07b2	Merge pull request #11312 from macanudo527/fix_rubocop_5 ... Fix autocorrect Rails Cops	2023-08-04 11:13:52 +10:00
Filipe	69dfd53658	Merge pull request #11254 from rioug/11130-add-product-filter-order-report ... 11130 add product filter order report	2023-08-03 16:08:44 +01:00
Neal Chambers	a1560263a1	Safely autocorrect Rails/ActionOrder ... Inspecting 1481 files .........................................C.................C.........................................................CC........C..........C.C.........C.................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................. Offenses: app/controllers/admin/resource_controller.rb:39:5: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0. def update ^^^^^^^^^^ app/controllers/admin/resource_controller.rb:39:5: C: [Corrected] Rails/ActionOrder: Action create should appear before update. def create ... ^^^^^^^^^^ app/controllers/admin/resource_controller.rb:51:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected. app/controllers/admin/resource_controller.rb:52:5: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 2. def update_positions ^^^^^^^^^^^^^^^^^^^^ app/controllers/api/v0/orders_controller.rb:13:7: C: [Corrected] Rails/ActionOrder: Action index should appear before show. def index ... ^^^^^^^^^ app/controllers/api/v0/orders_controller.rb:23:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0. def show ^^^^^^^^ app/controllers/api/v0/orders_controller.rb:28:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected. app/controllers/api/v0/orders_controller.rb:29:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 2. def update ^^^^^^^^^^ app/controllers/spree/admin/images_controller.rb:26:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0. def create ^^^^^^^^^^ app/controllers/spree/admin/images_controller.rb:37:7: C: [Corrected] Rails/ActionOrder: Action edit should appear before create. def edit ... ^^^^^^^^ app/controllers/spree/admin/images_controller.rb:40:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected. app/controllers/spree/admin/images_controller.rb:41:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 2. def update ^^^^^^^^^^ app/controllers/spree/admin/invoices_controller.rb:19:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0. def create ^^^^^^^^^^ app/controllers/spree/admin/invoices_controller.rb:43:7: C: [Corrected] Rails/ActionOrder: Action show should appear before create. def show ... ^^^^^^^^ app/controllers/spree/admin/invoices_controller.rb:49:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected. app/controllers/spree/admin/invoices_controller.rb:50:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 2. def poll ^^^^^^^^ app/controllers/spree/admin/products_controller.rb:23:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0. def new ^^^^^^^ app/controllers/spree/admin/products_controller.rb:23:7: C: [Corrected] Rails/ActionOrder: Action show should appear before new. def show ... ^^^^^^^^ app/controllers/spree/admin/products_controller.rb:24:7: C: [Corrected] Rails/ActionOrder: Action index should appear before show. def index ... ^^^^^^^^^ app/controllers/spree/admin/products_controller.rb:27:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected. app/controllers/spree/admin/products_controller.rb:27:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0. def create ^^^^^^^^^^ app/controllers/spree/admin/products_controller.rb:28:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected. app/controllers/spree/admin/products_controller.rb:28:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0. def new ^^^^^^^ app/controllers/spree/admin/products_controller.rb:28:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 2. def index ^^^^^^^^^ app/controllers/spree/admin/products_controller.rb:28:7: C: [Corrected] Rails/ActionOrder: Action index should appear before new. def index ... ^^^^^^^^^ app/controllers/spree/admin/products_controller.rb:29:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 2. def new ^^^^^^^ app/controllers/spree/admin/products_controller.rb:32:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected. app/controllers/spree/admin/products_controller.rb:32:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0. def create ^^^^^^^^^^ app/controllers/spree/admin/products_controller.rb:33:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 2. def edit ^^^^^^^^ app/controllers/spree/admin/products_controller.rb:36:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0. def create ^^^^^^^^^^ app/controllers/spree/admin/products_controller.rb:38:7: C: [Corrected] Rails/ActionOrder: Action show should appear before create. def show ... ^^^^^^^^ app/controllers/spree/admin/products_controller.rb:42:7: C: [Corrected] Rails/ActionOrder: Action index should appear before create. def index ... ^^^^^^^^^ app/controllers/spree/admin/products_controller.rb:43:7: C: [Corrected] Rails/ActionOrder: Action index should appear before create. def index ... ^^^^^^^^^ app/controllers/spree/admin/products_controller.rb:43:7: C: [Corrected] Rails/ActionOrder: Action index should appear before show. def index ... ^^^^^^^^^ app/controllers/spree/admin/products_controller.rb:47:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected. app/controllers/spree/admin/products_controller.rb:48:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 2. def edit ^^^^^^^^ app/controllers/spree/admin/products_controller.rb:48:7: C: [Corrected] Rails/ActionOrder: Action edit should appear before create. def edit ... ^^^^^^^^ app/controllers/spree/admin/products_controller.rb:51:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected. app/controllers/spree/admin/products_controller.rb:52:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 2. def update ^^^^^^^^^^ app/controllers/spree/admin/taxons_controller.rb:13:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0. def create ^^^^^^^^^^ app/controllers/spree/admin/taxons_controller.rb:29:7: C: [Corrected] Rails/ActionOrder: Action edit should appear before create. def edit ... ^^^^^^^^ app/controllers/spree/admin/taxons_controller.rb:34:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected. app/controllers/spree/admin/taxons_controller.rb:35:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 2. def update ^^^^^^^^^^ app/controllers/spree/admin/variants_controller.rb:17:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0. def edit ^^^^^^^^ app/controllers/spree/admin/variants_controller.rb:18:7: C: [Corrected] Rails/ActionOrder: Action new should appear before edit. def new ... ^^^^^^^ app/controllers/spree/admin/variants_controller.rb:21:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected. app/controllers/spree/admin/variants_controller.rb:21:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0. def update ^^^^^^^^^^ app/controllers/spree/admin/variants_controller.rb:22:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 2. def create ^^^^^^^^^^ app/controllers/spree/admin/variants_controller.rb:31:7: C: [Corrected] Rails/ActionOrder: Action new should appear before update. def new ... ^^^^^^^ app/controllers/spree/admin/variants_controller.rb:34:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected. app/controllers/spree/admin/variants_controller.rb:35:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 2. def create ^^^^^^^^^^ app/controllers/spree/admin/variants_controller.rb:35:7: C: [Corrected] Rails/ActionOrder: Action create should appear before update. def create ... ^^^^^^^^^^ app/controllers/spree/admin/variants_controller.rb:42:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0. def update ^^^^^^^^^^ app/controllers/spree/admin/variants_controller.rb:55:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected. app/controllers/spree/admin/variants_controller.rb:56:7: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 2. def search ^^^^^^^^^^ app/controllers/user_confirmations_controller.rb:14:3: C: [Corrected] Rails/ActionOrder: Action show should appear before new. def show ... ^^^^^^^^ app/controllers/user_confirmations_controller.rb:15:3: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0. def new ^^^^^^^ app/controllers/user_confirmations_controller.rb:19:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected. app/controllers/user_confirmations_controller.rb:20:3: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 0. def create ^^^^^^^^^^ app/controllers/user_confirmations_controller.rb:21:3: C: [Corrected] Layout/EmptyLineBetweenDefs: Expected 1 empty line between method definitions; found 2. def create ^^^^^^^^^^ app/controllers/user_confirmations_controller.rb:37:3: C: [Corrected] Rails/ActionOrder: Action show should appear before create. def show ... ^^^^^^^^ app/controllers/user_confirmations_controller.rb:42:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected. app/controllers/user_confirmations_controller.rb:43:1: C: [Corrected] Layout/EmptyLines: Extra blank line detected. 1481 files inspected, 63 offenses detected, 63 offenses corrected	2023-08-01 22:50:21 +09:00
Jean-Baptiste Bellet	5a0d4d2a93	Set visible to only_through_links on enterprise registration	2023-07-25 10:57:26 +02:00
Neal Chambers	bede52bdae	Safely autocorrect Layout/LineLength ... Inspecting 1478 files .......C............................C..............................................................................................................C.......................................................................................................C............................................................................C................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C.................C......................................C...................................................................................................................C...........................................................C........................C...C.....C..C..C..........C..................C...............C.....................C...................................................................................C......................................................C........C..C...........C....................C.CC....C....................................C......C.......................... Offenses: app/components/confirm_modal_component.rb:4:88: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. def initialize(id:, confirm_actions: nil, reflex: nil, controller: nil, message: nil, ^ app/components/confirm_modal_component.rb:4:101: C: [Corrected] Layout/LineLength: Line is too long. [110/100] def initialize(id:, confirm_actions: nil, reflex: nil, controller: nil, message: nil, confirm_reflexes: nil) ^^^^^^^^^^ app/components/confirm_modal_component.rb:5:1: C: [Corrected] Layout/ParameterAlignment: Align the parameters of a method definition if they span more than one line. confirm_reflexes: nil) ^^^^^^^^^^^^^^^^^^^^^ app/controllers/admin/product_import_controller.rb:142:43: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. redirect_to '/admin/product_import', ^ app/controllers/admin/product_import_controller.rb:142:101: C: [Corrected] Layout/LineLength: Line is too long. [104/100] redirect_to '/admin/product_import', notice: I18n.t(:product_import_no_data_in_spreadsheet_notice) ^^^^ app/controllers/admin/product_import_controller.rb:143:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line. notice: I18n.t(:product_import_no_data_in_spreadsheet_notice) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ app/controllers/spree/users_controller.rb:53:101: C: Layout/LineLength: Line is too long. [107/100] message: t('devise.user_registrations.spree_user.signed_up_but_unconfirmed') }) ^^^^^^^ app/models/customer.rb:43:101: C: [Corrected] Layout/LineLength: Line is too long. [113/100] scope :managed_by, ->(user) { user&.persisted? ? where(user: user).or(of(Enterprise.managed_by(user))) : none } ^^^^^^^^^^^^^ app/models/customer.rb:44:1: C: [Corrected] Layout/IndentationWidth: Use 2 (not 1) spaces for indentation. user&.persisted? ? where(user: user).or(of(Enterprise.managed_by(user))) : none ^ app/models/customer.rb:44:3: C: [Corrected] Layout/IndentationWidth: Use 2 (not -19) spaces for indentation. user&.persisted? ? where(user: user).or(of(Enterprise.managed_by(user))) : none ^^^^^^^^^^^^^^^^^^^ app/models/customer.rb:44:82: C: [Corrected] Layout/BlockEndNewline: Expression at 44, 82 should be on its own line. user&.persisted? ? where(user: user).or(of(Enterprise.managed_by(user))) : none } ^ app/models/customer.rb:44:101: C: Layout/LineLength: Line is too long. [102/100] user&.persisted? ? where(user: user).or(of(Enterprise.managed_by(user))) : none ^^ app/models/customer.rb:45:1: C: [Corrected] Layout/BlockAlignment: } at 45, 0 is not aligned with ->(user) { at 43, 21 or scope :managed_by, ->(user) { at 43, 2. } ^ app/models/spree/line_item.rb:53:101: C: Layout/LineLength: Line is too long. [110/100] attr_accessor :skip_stock_check, :target_shipment # Allows manual skipping of Stock::AvailabilityValidator ^^^^^^^^^^ spec/controllers/admin/order_cycles_controller_spec.rb:38:101: C: Layout/LineLength: Line is too long. [108/100] it "loads order cycles that closed within the past month, and orders without a close_at date" do ^^^^^^^^ spec/controllers/admin/order_cycles_controller_spec.rb:48:101: C: Layout/LineLength: Line is too long. [111/100] it "loads order cycles that closed after the specified date, and orders without a close_at date" do ^^^^^^^^^^^ spec/controllers/admin/order_cycles_controller_spec.rb:100:101: C: Layout/LineLength: Line is too long. [125/100] expect(flash[:error]).to eq "You don't have permission to create an order cycle coordinated by that enterprise" ^^^^^^^^^^^^^^^^^^^^^^^^^ spec/controllers/admin/order_cycles_controller_spec.rb:125:101: C: Layout/LineLength: Line is too long. [101/100] order_cycle.exchanges.create! sender: distributor, receiver: distributor, incoming: true, ^ spec/controllers/admin/order_cycles_controller_spec.rb:127:101: C: Layout/LineLength: Line is too long. [102/100] order_cycle.exchanges.create! sender: distributor, receiver: distributor, incoming: false, ^^ spec/controllers/admin/order_cycles_controller_spec.rb:284:101: C: Layout/LineLength: Line is too long. [101/100] merge(order_cycle: { preferred_product_selection_from_coordinator_inventory_only: true }) ^ spec/controllers/admin/order_cycles_controller_spec.rb:311:101: C: Layout/LineLength: Line is too long. [104/100] create(:exchange, order_cycle: order_cycle, sender: coordinator, receiver: hub, incoming: false, ^^^^ spec/controllers/admin/order_cycles_controller_spec.rb:374:101: C: Layout/LineLength: Line is too long. [102/100] expect(json_response['errors']).to eq 'Hm, something went wrong. No order cycle data found.' ^^ spec/controllers/admin/order_cycles_controller_spec.rb:460:101: C: Layout/LineLength: Line is too long. [176/100] expect(flash[:error]).to eq 'That order cycle has been selected by a customer and cannot be deleted. To prevent customers from accessing it, please close it instead.' ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/controllers/admin/order_cycles_controller_spec.rb:470:101: C: Layout/LineLength: Line is too long. [147/100] expect(flash[:error]).to eq 'That order cycle is linked to a schedule and cannot be deleted. Please unlink or delete the schedule first.' ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/controllers/api/v0/order_cycles_controller_spec.rb:16:101: C: [Corrected] Layout/LineLength: Line is too long. [106/100] let!(:product1) { create(:product, name: "Kangaroo", primary_taxon: taxon1, properties: [property1]) } ^^^^^^ spec/controllers/api/v0/order_cycles_controller_spec.rb:17:1: C: [Corrected] Layout/IndentationWidth: Use 2 (not 1) spaces for indentation. create(:product, name: "Kangaroo", primary_taxon: taxon1, properties: [property1]) ^ spec/controllers/api/v0/order_cycles_controller_spec.rb:17:3: C: [Corrected] Layout/IndentationWidth: Use 2 (not -2) spaces for indentation. create(:product, name: "Kangaroo", primary_taxon: taxon1, properties: [property1]) ^^ spec/controllers/api/v0/order_cycles_controller_spec.rb:17:85: C: [Corrected] Layout/BlockEndNewline: Expression at 17, 85 should be on its own line. create(:product, name: "Kangaroo", primary_taxon: taxon1, properties: [property1]) } ^ spec/controllers/api/v0/order_cycles_controller_spec.rb:17:101: C: [Corrected] Layout/LineLength: Line is too long. [106/100] let!(:product2) { create(:product, name: "Parsnips", primary_taxon: taxon2, properties: [property2]) } ^^^^^^ spec/controllers/api/v0/order_cycles_controller_spec.rb:18:1: C: [Corrected] Layout/BlockAlignment: } at 18, 0 is not aligned with let!(:product1) { at 16, 4. } ^ spec/controllers/api/v0/order_cycles_controller_spec.rb:19:85: C: [Corrected] Layout/BlockEndNewline: Expression at 19, 85 should be on its own line. create(:product, name: "Parsnips", primary_taxon: taxon2, properties: [property2]) } ^ spec/controllers/api/v0/order_cycles_controller_spec.rb:20:1: C: [Corrected] Layout/IndentationWidth: Use 2 (not 1) spaces for indentation. create(:product, name: "Parsnips", primary_taxon: taxon2, properties: [property2]) ^ spec/controllers/api/v0/order_cycles_controller_spec.rb:20:3: C: [Corrected] Layout/IndentationWidth: Use 2 (not -2) spaces for indentation. create(:product, name: "Parsnips", primary_taxon: taxon2, properties: [property2]) ^^ spec/controllers/api/v0/order_cycles_controller_spec.rb:21:1: C: [Corrected] Layout/BlockAlignment: } at 21, 0 is not aligned with let!(:product2) { at 19, 4. } ^ spec/controllers/spree/admin/orders_controller_spec.rb:232:101: C: [Corrected] Layout/LineLength: Line is too long. [117/100] let!(:order_cycle){ create(:simple_order_cycle, distributors: [distributor], variants: [line_item.variant]) } ^^^^^^^^^^^^^^^^^ spec/controllers/spree/admin/orders_controller_spec.rb:233:1: C: [Corrected] Layout/IndentationWidth: Use 2 (not 1) spaces for indentation. create(:simple_order_cycle, distributors: [distributor], variants: [line_item.variant]) ^ spec/controllers/spree/admin/orders_controller_spec.rb:233:3: C: [Corrected] Layout/IndentationWidth: Use 2 (not -6) spaces for indentation. create(:simple_order_cycle, distributors: [distributor], variants: [line_item.variant]) ^^^^^^ spec/controllers/spree/admin/orders_controller_spec.rb:233:90: C: [Corrected] Layout/BlockEndNewline: Expression at 233, 90 should be on its own line. create(:simple_order_cycle, distributors: [distributor], variants: [line_item.variant]) } ^ spec/controllers/spree/admin/orders_controller_spec.rb:234:1: C: [Corrected] Layout/BlockAlignment: } at 234, 0 is not aligned with let!(:order_cycle){ at 232, 8. } ^ spec/controllers/spree/admin/orders_controller_spec.rb:252:101: C: Layout/LineLength: Line is too long. [109/100] allow_any_instance_of(Spree::Order).to receive(:ensure_available_shipping_rates).and_return(true) ^^^^^^^^^ spec/lib/reports/customers_report_spec.rb:93:88: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. create(:order_with_totals_and_distribution, :completed, distributor: d, ^ spec/lib/reports/customers_report_spec.rb:93:101: C: [Corrected] Layout/LineLength: Line is too long. [125/100] create(:order_with_totals_and_distribution, :completed, distributor: d, bill_address: a, shipping_method: sm) ^^^^^^^^^^^^^^^^^^^^^^^^^ spec/lib/reports/customers_report_spec.rb:94:1: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line. bill_address: a, shipping_method: sm) ^^^^^^^^^^^^^^^ spec/lib/reports/customers_report_spec.rb:94:101: C: Layout/LineLength: Line is too long. [109/100] bill_address: a, shipping_method: sm) ^^^^^^^^^ spec/lib/reports/customers_report_spec.rb:96:101: C: [Corrected] Layout/LineLength: Line is too long. [125/100] create(:order_with_totals_and_distribution, :completed, distributor: d, bill_address: a, shipping_method: sm) ^^^^^^^^^^^^^^^^^^^^^^^^^ spec/lib/reports/customers_report_spec.rb:97:88: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. create(:order_with_totals_and_distribution, :completed, distributor: d, ^ spec/lib/reports/customers_report_spec.rb:98:1: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line. bill_address: a, shipping_method: sm) ^^^^^^^^^^^^^^^ spec/lib/reports/customers_report_spec.rb:98:101: C: Layout/LineLength: Line is too long. [109/100] bill_address: a, shipping_method: sm) ^^^^^^^^^ spec/lib/reports/customers_report_spec.rb:113:101: C: Layout/LineLength: Line is too long. [118/100] [d.address.address1, d.address.address2, d.address.city].join(" "), ^^^^^^^^^^^^^^^^^^ spec/lib/reports/customers_report_spec.rb:120:101: C: [Corrected] Layout/LineLength: Line is too long. [129/100] create(:order_with_totals_and_distribution, :completed, distributor: d2, bill_address: a, shipping_method: sm2) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/lib/reports/customers_report_spec.rb:122:91: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. create(:order_with_totals_and_distribution, :completed, distributor: d2, ^ spec/lib/reports/customers_report_spec.rb:123:1: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line. bill_address: a, shipping_method: sm2) ^^^^^^^^^^^^^^^ spec/lib/reports/customers_report_spec.rb:123:101: C: Layout/LineLength: Line is too long. [112/100] bill_address: a, shipping_method: sm2) ^^^^^^^^^^^^ spec/lib/reports/customers_report_spec.rb:133:101: C: Layout/LineLength: Line is too long. [120/100] [d.address.address1, d.address.address2, d.address.city].join(" "), ^^^^^^^^^^^^^^^^^^^^ spec/lib/reports/customers_report_spec.rb:139:101: C: Layout/LineLength: Line is too long. [123/100] [d2.address.address1, d2.address.address2, d2.address.city].join(" "), ^^^^^^^^^^^^^^^^^^^^^^^ spec/lib/reports/customers_report_spec.rb:145:101: C: [Corrected] Layout/LineLength: Line is too long. [128/100] create(:order_with_totals_and_distribution, :completed, distributor: d, bill_address: a, shipping_method: sm2) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/lib/reports/customers_report_spec.rb:148:90: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. create(:order_with_totals_and_distribution, :completed, distributor: d, ^ spec/lib/reports/customers_report_spec.rb:149:1: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line. bill_address: a, shipping_method: sm2) ^^^^^^^^^^^^^^^ spec/lib/reports/customers_report_spec.rb:149:101: C: Layout/LineLength: Line is too long. [112/100] bill_address: a, shipping_method: sm2) ^^^^^^^^^^^^ spec/migrations/migrate_customer_names_spec.rb:16:101: C: Layout/LineLength: Line is too long. [122/100] value_type: "boolean", key: "/enterprise/show_customer_names_to_suppliers/#{enterprise1.id}") ^^^^^^^^^^^^^^^^^^^^^^ spec/migrations/migrate_customer_names_spec.rb:18:101: C: Layout/LineLength: Line is too long. [122/100] value_type: "boolean", key: "/enterprise/show_customer_names_to_suppliers/#{enterprise2.id}") ^^^^^^^^^^^^^^^^^^^^^^ spec/migrations/migrate_customer_names_spec.rb:20:101: C: Layout/LineLength: Line is too long. [122/100] value_type: "boolean", key: "/enterprise/show_customer_names_to_suppliers/#{enterprise4.id}") ^^^^^^^^^^^^^^^^^^^^^^ spec/models/enterprise_spec.rb:521:101: C: [Corrected] Layout/LineLength: Line is too long. [111/100] expect(Enterprise.supplying_variant_in([p1.variants.first, p2.variants.first])).to match_array [s1, s2] ^^^^^^^^^^^ spec/models/enterprise_spec.rb:522:1: C: [Corrected] Layout/ArrayAlignment: Align the elements of an array literal if they span more than one line. p2.variants.first])).to match_array [s1, s2] ^^^^^^^^^^^^^^^^^ spec/models/order_cycle_spec.rb:207:101: C: Layout/LineLength: Line is too long. [118/100] expect(oc.variants).to match_array [p0.variants.first, p1.variants.first, p2.variants.first, p2_v, p1_v_visible, ^^^^^^^^^^^^^^^^^^ spec/models/order_cycle_spec.rb:220:101: C: Layout/LineLength: Line is too long. [111/100] expect(oc.distributed_variants).to match_array [p1.variants.first, p2.variants.first, p2_v, p1_v_visible, ^^^^^^^^^^^ spec/models/product_importer_spec.rb:782:101: C: Layout/LineLength: Line is too long. [101/100] csv << [" Oats ", "\nPorridge Oats\n", "\r#{enterprise2.name}\r", "\t#{enterprise.name}\t", ^ spec/models/spree/ability_spec.rb:340:69: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. [:admin, :index, :read, :edit, :update, :search, :destroy, ^ spec/models/spree/ability_spec.rb:340:101: C: [Corrected] Layout/LineLength: Line is too long. [101/100] [:admin, :index, :read, :edit, :update, :search, :destroy, :delete], for: p1.variants.first ^ spec/models/spree/ability_spec.rb:341:1: C: [Corrected] Layout/ArrayAlignment: Align the elements of an array literal if they span more than one line. :delete], for: p1.variants.first ^^^^^^^ spec/models/spree/ability_spec.rb:350:101: C: [Corrected] Layout/LineLength: Line is too long. [108/100] [:admin, :index, :read, :edit, :update, :search, :destroy, :delete], for: p_related.variants.first ^^^^^^^^ spec/models/spree/ability_spec.rb:351:69: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. [:admin, :index, :read, :edit, :update, :search, :destroy, ^ spec/models/spree/ability_spec.rb:352:1: C: [Corrected] Layout/ArrayAlignment: Align the elements of an array literal if they span more than one line. :delete], for: p_related.variants.first ^^^^^^^ spec/models/spree/ability_spec.rb:379:101: C: [Corrected] Layout/LineLength: Line is too long. [101/100] [:admin, :index, :read, :create, :edit, :search, :update, :destroy], for: p2.variants.first ^ spec/models/spree/ability_spec.rb:381:68: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. [:admin, :index, :read, :create, :edit, :search, :update, ^ spec/models/spree/ability_spec.rb:382:1: C: [Corrected] Layout/ArrayAlignment: Align the elements of an array literal if they span more than one line. :destroy], for: p2.variants.first ^^^^^^^^ spec/models/spree/adjustment_spec.rb:339:101: C: Layout/LineLength: Line is too long. [106/100] create(:tax_rate, included_in_price: true, calculator: ::Calculator::DefaultTax.new, zone: zone, ^^^^^^ spec/models/spree/adjustment_spec.rb:367:101: C: Layout/LineLength: Line is too long. [101/100] calculator: ::Calculator::FlatRate.new(preferred_amount: 50.0)) ^ spec/models/spree/adjustment_spec.rb:428:101: C: Layout/LineLength: Line is too long. [105/100] context "when enterprise fees inherit their tax_category from the product they are applied to" do ^^^^^ spec/models/spree/adjustment_spec.rb:443:101: C: Layout/LineLength: Line is too long. [101/100] calculator: ::Calculator::FlatRate.new(preferred_amount: 50.0)) ^ spec/models/spree/line_item_spec.rb:208:101: C: Layout/LineLength: Line is too long. [107/100] expect(LineItem.from_order_cycle(oc_order.order_cycle).first.id).to eq oc_order.line_items.first.id ^^^^^^^ spec/models/spree/line_item_spec.rb:342:101: C: Layout/LineLength: Line is too long. [102/100] Spree::Variant.find(variant.id).on_hand ^^ spec/models/spree/product_spec.rb:409:74: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. create(:simple_order_cycle, suppliers: [s], distributors: [d1], ^ spec/models/spree/product_spec.rb:409:101: C: [Corrected] Layout/LineLength: Line is too long. [104/100] create(:simple_order_cycle, suppliers: [s], distributors: [d1], variants: [p1.variants.first]) ^^^^ spec/models/spree/product_spec.rb:410:1: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line. variants: [p1.variants.first]) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/models/spree/product_spec.rb:410:101: C: [Corrected] Layout/LineLength: Line is too long. [104/100] create(:simple_order_cycle, suppliers: [s], distributors: [d2], variants: [p2.variants.first]) ^^^^ spec/models/spree/product_spec.rb:411:74: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. create(:simple_order_cycle, suppliers: [s], distributors: [d2], ^ spec/models/spree/product_spec.rb:412:1: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line. variants: [p2.variants.first]) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/models/spree/product_spec.rb:486:101: C: [Corrected] Layout/LineLength: Line is too long. [104/100] create(:simple_order_cycle, suppliers: [s], distributors: [d1], variants: [p1.variants.first]) ^^^^ spec/models/spree/product_spec.rb:487:101: C: [Corrected] Layout/LineLength: Line is too long. [104/100] create(:simple_order_cycle, suppliers: [s], distributors: [d2], variants: [p2.variants.first]) ^^^^ spec/models/spree/product_spec.rb:488:74: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. create(:simple_order_cycle, suppliers: [s], distributors: [d1], ^ spec/models/spree/product_spec.rb:489:1: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line. variants: [p1.variants.first]) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/models/spree/product_spec.rb:490:74: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. create(:simple_order_cycle, suppliers: [s], distributors: [d2], ^ spec/models/spree/product_spec.rb:491:1: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line. variants: [p2.variants.first]) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/models/spree/product_spec.rb:495:101: C: [Corrected] Layout/LineLength: Line is too long. [102/100] create(:simple_order_cycle, suppliers: [s], distributors: [d], variants: [p.variants.first]) ^^ spec/models/spree/product_spec.rb:499:73: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. create(:simple_order_cycle, suppliers: [s], distributors: [d], ^ spec/models/spree/product_spec.rb:500:1: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line. variants: [p.variants.first]) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/models/spree/variant_spec.rb:356:101: C: Layout/LineLength: Line is too long. [108/100] it "lists any variants that are not listed as visible=false only for the relevant enterprise" do ^^^^^^^^ spec/models/spree/variant_spec.rb:479:101: C: Layout/LineLength: Line is too long. [108/100] expect_any_instance_of(OpenFoodNetwork::EnterpriseFeeCalculator).to receive(:fees_for).with(variant) { ^^^^^^^^ spec/models/spree/variant_spec.rb:494:101: C: Layout/LineLength: Line is too long. [116/100] expect_any_instance_of(OpenFoodNetwork::EnterpriseFeeCalculator).to receive(:fees_by_type_for).with(variant) { ^^^^^^^^^^^^^^^^ spec/models/spree/variant_spec.rb:704:101: C: Layout/LineLength: Line is too long. [115/100] expect_any_instance_of(VariantUnits::OptionValueNamer).to receive(:name).exactly(1).times.and_call_original ^^^^^^^^^^^^^^^ spec/requests/api/orders_spec.rb:167:88: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. create(:order_with_line_items, line_items_count: 1, bill_address_id: nil, ^ spec/requests/api/orders_spec.rb:167:101: C: [Corrected] Layout/LineLength: Line is too long. [109/100] create(:order_with_line_items, line_items_count: 1, bill_address_id: nil, ship_address_id: nil) ^^^^^^^^^ spec/requests/api/orders_spec.rb:168:1: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line. ship_address_id: nil) ^^^^^^^^^^^^^^^^^^^^ spec/services/products_renderer_spec.rb:91:101: C: Layout/LineLength: Line is too long. [101/100] { q: { with_properties: [property_organic.id] } }) ^ spec/services/products_renderer_spec.rb:100:101: C: Layout/LineLength: Line is too long. [101/100] { q: { with_properties: [property_organic.id] } }) ^ spec/services/products_renderer_spec.rb:118:101: C: Layout/LineLength: Line is too long. [101/100] { q: { with_properties: [property_organic.id] } }) ^ spec/support/request/web_helper.rb:96:84: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. tomselect_wrapper.find(:css, '.ts-dropdown.multi .ts-dropdown-content .option', ^ spec/support/request/web_helper.rb:96:101: C: [Corrected] Layout/LineLength: Line is too long. [102/100] tomselect_wrapper.find(:css, '.ts-dropdown.multi .ts-dropdown-content .option', text: value).click ^^ spec/support/request/web_helper.rb:97:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line. text: value).click ^^^^^^^^^^^ spec/system/admin/adjustments_spec.rb:29:101: C: [Corrected] Layout/LineLength: Line is too long. [197/100] let!(:tax_rate2) { create(:tax_rate, name: "TVA 20%", amount: 0.2, zone: default_tax_zone, included_in_price: true, tax_category: tax_category_included, calculator: Calculator::DefaultTax.new ) } ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/system/admin/adjustments_spec.rb:30:1: C: [Corrected] Layout/IndentationWidth: Use 2 (not 1) spaces for indentation. create(:tax_rate, name: "TVA 20%", amount: 0.2, zone: default_tax_zone, included_in_price: true, ^ spec/system/admin/adjustments_spec.rb:30:3: C: [Corrected] Layout/IndentationWidth: Use 2 (not 0) spaces for indentation. create(:tax_rate, name: "TVA 20%", amount: 0.2, zone: default_tax_zone, included_in_price: true, spec/system/admin/adjustments_spec.rb:30:98: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. create(:tax_rate, name: "TVA 20%", amount: 0.2, zone: default_tax_zone, included_in_price: true, ^ spec/system/admin/adjustments_spec.rb:30:101: C: [Corrected] Layout/LineLength: Line is too long. [177/100] create(:tax_rate, name: "TVA 20%", amount: 0.2, zone: default_tax_zone, included_in_price: true, tax_category: tax_category_included, calculator: Calculator::DefaultTax.new ) } ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/system/admin/adjustments_spec.rb:30:177: C: [Corrected] Layout/BlockEndNewline: Expression at 30, 177 should be on its own line. create(:tax_rate, name: "TVA 20%", amount: 0.2, zone: default_tax_zone, included_in_price: true, tax_category: tax_category_included, calculator: Calculator::DefaultTax.new ) } ^ spec/system/admin/adjustments_spec.rb:31:1: C: [Corrected] Layout/HashAlignment: Align the keys of a hash literal if they span more than one line. tax_category: tax_category_included, calculator: Calculator::DefaultTax.new ) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/system/admin/adjustments_spec.rb:32:1: C: [Corrected] Layout/BlockAlignment: } at 32, 0 is not aligned with let!(:tax_rate2) { at 29, 2. } ^ spec/system/admin/adjustments_spec.rb:41:101: C: Layout/LineLength: Line is too long. [134/100] shared_examples "when the enable_localized_number preference" do |adjustment_label, adjustment_amount, tax_category, tax, tax_total| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/system/admin/adjustments_spec.rb:67:101: C: [Corrected] Layout/LineLength: Line is too long. [117/100] it_behaves_like "when the enable_localized_number preference", "Discount", "-2", "TVA 20%", "$0.33", "$-1.67" ^^^^^^^^^^^^^^^^^ spec/system/admin/adjustments_spec.rb:68:100: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. it_behaves_like "when the enable_localized_number preference", "Discount", "-2", "TVA 20%", ^ spec/system/admin/adjustments_spec.rb:69:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line. "$0.33", "$-1.67" ^^^^^^^ spec/system/admin/adjustments_spec.rb:71:101: C: [Corrected] Layout/LineLength: Line is too long. [120/100] it_behaves_like "when the enable_localized_number preference", "Late fee", "100", "TVA 20%", "$-16.67", "$83.33" ^^^^^^^^^^^^^^^^^^^^ spec/system/admin/adjustments_spec.rb:73:90: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. it_behaves_like "when the enable_localized_number preference", "Late fee", "100", ^ spec/system/admin/adjustments_spec.rb:74:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line. "TVA 20%", "$-16.67", "$83.33" ^^^^^^^^^ spec/system/admin/adjustments_spec.rb:77:101: C: [Corrected] Layout/LineLength: Line is too long. [113/100] it_behaves_like "when the enable_localized_number preference", "Discount", "-2", "GST", "$10.00", "$8.00" ^^^^^^^^^^^^^ spec/system/admin/adjustments_spec.rb:80:96: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. it_behaves_like "when the enable_localized_number preference", "Discount", "-2", "GST", ^ spec/system/admin/adjustments_spec.rb:81:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line. "$10.00", "$8.00" ^^^^^^^^ spec/system/admin/adjustments_spec.rb:81:101: C: [Corrected] Layout/LineLength: Line is too long. [113/100] it_behaves_like "when the enable_localized_number preference", "Late fee", "110", "GST", "$10.00", "$120" ^^^^^^^^^^^^^ spec/system/admin/adjustments_spec.rb:85:97: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. it_behaves_like "when the enable_localized_number preference", "Late fee", "110", "GST", ^ spec/system/admin/adjustments_spec.rb:86:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line. "$10.00", "$120" ^^^^^^^^ spec/system/admin/adjustments_spec.rb:93:101: C: [Corrected] Layout/LineLength: Line is too long. [117/100] it_behaves_like "when the enable_localized_number preference", "Discount", "-2", "TVA 20%", "$0.33", "$-1.67" ^^^^^^^^^^^^^^^^^ spec/system/admin/adjustments_spec.rb:97:101: C: [Corrected] Layout/LineLength: Line is too long. [120/100] it_behaves_like "when the enable_localized_number preference", "Late fee", "100", "TVA 20%", "$-16.67", "$83.33" ^^^^^^^^^^^^^^^^^^^^ spec/system/admin/adjustments_spec.rb:98:100: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. it_behaves_like "when the enable_localized_number preference", "Discount", "-2", "TVA 20%", ^ spec/system/admin/adjustments_spec.rb:99:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line. "$0.33", "$-1.67" ^^^^^^^ spec/system/admin/adjustments_spec.rb:103:90: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. it_behaves_like "when the enable_localized_number preference", "Late fee", "100", ^ spec/system/admin/adjustments_spec.rb:103:101: C: [Corrected] Layout/LineLength: Line is too long. [113/100] it_behaves_like "when the enable_localized_number preference", "Discount", "-2", "GST", "$10.00", "$8.00" ^^^^^^^^^^^^^ spec/system/admin/adjustments_spec.rb:104:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line. "TVA 20%", "$-16.67", "$83.33" ^^^^^^^^^ spec/system/admin/adjustments_spec.rb:107:101: C: [Corrected] Layout/LineLength: Line is too long. [113/100] it_behaves_like "when the enable_localized_number preference", "Late fee", "110", "GST", "$10.00", "$120" ^^^^^^^^^^^^^ spec/system/admin/adjustments_spec.rb:110:96: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. it_behaves_like "when the enable_localized_number preference", "Discount", "-2", "GST", ^ spec/system/admin/adjustments_spec.rb:111:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line. "$10.00", "$8.00" ^^^^^^^^ spec/system/admin/adjustments_spec.rb:115:97: C: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. it_behaves_like "when the enable_localized_number preference", "Late fee", "110", "GST", ^ spec/system/admin/adjustments_spec.rb:116:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line. "$10.00", "$120" ^^^^^^^^ spec/system/admin/bulk_order_management_spec.rb:268:101: C: Layout/LineLength: Line is too long. [105/100] text: "#{o1.bill_address.last_name}, #{o1.bill_address.first_name}" ^^^^^ spec/system/admin/bulk_order_management_spec.rb:1036:101: C: Layout/LineLength: Line is too long. [147/100] expect(page).to have_content "This operation will result in one or more empty orders, which will be cancelled. Do you wish to proceed?" ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/system/admin/bulk_order_management_spec.rb:1060:101: C: Layout/LineLength: Line is too long. [138/100] it "the user can confirm + wants to send email confirmation : line item is then deleted, order is canceled and email is sent" do ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/system/admin/bulk_order_management_spec.rb:1072:101: C: Layout/LineLength: Line is too long. [134/100] it "the user can confirm + uncheck the restock option: line item is then deleted and order is canceled without retocking" do ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/system/admin/customers_spec.rb:40:101: C: Layout/LineLength: Line is too long. [126/100] managed_distributor2.name], without_options: [unmanaged_distributor.name] ^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/system/admin/order_cycles/simple_spec.rb:346:101: C: Layout/LineLength: Line is too long. [101/100] with_options: [schedule_of_other_managed_distributor.name] ^ spec/system/admin/order_cycles/simple_spec.rb:623:101: C: Layout/LineLength: Line is too long. [121/100] value: Time.zone.local(2040, 10, 17, 0o6, 0o0, 0o0).strftime("%F %T %z"), visible: false ^^^^^^^^^^^^^^^^^^^^^ spec/system/admin/order_cycles/simple_spec.rb:625:101: C: Layout/LineLength: Line is too long. [120/100] value: Time.zone.local(2040, 10, 24, 17, 0o0, 0o0).strftime("%F %T %z"), visible: false ^^^^^^^^^^^^^^^^^^^^ spec/system/admin/order_cycles/simple_spec.rb:733:101: C: Layout/LineLength: Line is too long. [121/100] value: Time.zone.local(2040, 10, 17, 0o6, 0o0, 0o0).strftime("%F %T %z"), visible: false ^^^^^^^^^^^^^^^^^^^^^ spec/system/admin/order_cycles/simple_spec.rb:735:101: C: Layout/LineLength: Line is too long. [120/100] value: Time.zone.local(2040, 10, 24, 17, 0o0, 0o0).strftime("%F %T %z"), visible: false ^^^^^^^^^^^^^^^^^^^^ spec/system/admin/order_spec.rb:598:101: C: [Corrected] Layout/LineLength: Line is too long. [101/100] expect(page).to have_link "Resend Confirmation", href: spree.resend_admin_order_path(order) ^ spec/system/admin/order_spec.rb:599:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line. href: spree.resend_admin_order_path(order) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/system/admin/order_spec.rb:616:101: C: [Corrected] Layout/LineLength: Line is too long. [105/100] expect(page).to have_link "Cancel Order", href: spree.fire_admin_order_path(order, e: 'cancel') ^^^^^ spec/system/admin/order_spec.rb:618:1: C: [Corrected] Layout/ArgumentAlignment: Align the arguments of a method call if they span more than one line. href: spree.fire_admin_order_path(order, e: 'cancel') ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ spec/system/admin/orders_spec.rb:259:101: C: Layout/LineLength: Line is too long. [109/100] distributor: distributor2, bill_address_id: nil, ship_address_id: nil) ^^^^^^^^^ spec/system/admin/product_import_spec.rb:573:101: C: Layout/LineLength: Line is too long. [106/100] expect(page).to have_content "line 4: Cabbage - On_hand incorrect value - On_demand incorrect value" ^^^^^^ spec/system/admin/product_import_spec.rb:574:101: C: Layout/LineLength: Line is too long. [108/100] expect(page).to have_content "line 5: Aubergine - On_hand incorrect value - On_demand incorrect value" ^^^^^^^^ spec/system/admin/product_import_spec.rb:583:101: C: Layout/LineLength: Line is too long. [102/100] csv << ["name", "producer", "category", "on_hand", "price", "on_demand", "units", "unit_type", ^^ spec/system/admin/product_import_spec.rb:585:101: C: Layout/LineLength: Line is too long. [106/100] csv << ["Beans", "User Enterprise", "Vegetables", "invalid", "3.50", "1", "0.5", "g", "Small Bag", ^^^^^^ spec/system/admin/product_import_spec.rb:587:101: C: Layout/LineLength: Line is too long. [103/100] csv << ["Potatoes", "User Enterprise", "Vegetables", "6", "6", "invalid", "5", "kg", "Big Bag", ^^^ spec/system/admin/product_import_spec.rb:589:101: C: Layout/LineLength: Line is too long. [106/100] csv << ["Cabbage", "User Enterprise", "Vegetables", "invalid", "1.5", "invalid", "1", "kg", "Bag", ^^^^^^ spec/system/admin/product_import_spec.rb:591:101: C: Layout/LineLength: Line is too long. [102/100] csv << ["Aubergine", "User Enterprise", "Vegetables", nil, "1.5", "invalid", "1", "kg", "Bag", ^^ spec/system/admin/product_import_spec.rb:607:101: C: Layout/LineLength: Line is too long. [114/100] expect(page).to have_content "line 4: Cabbage ( Bag ) - On_hand incorrect value - On_demand incorrect value" ^^^^^^^^^^^^^^ spec/system/admin/product_import_spec.rb:608:101: C: Layout/LineLength: Line is too long. [116/100] expect(page).to have_content "line 5: Aubergine ( Bag ) - On_hand incorrect value - On_demand incorrect value" ^^^^^^^^^^^^^^^^ spec/system/admin/product_import_spec.rb:617:101: C: Layout/LineLength: Line is too long. [102/100] csv << ["name", "producer", "category", "on_hand", "price", "on_demand", "units", "unit_type", ^^ spec/system/admin/product_import_spec.rb:619:101: C: Layout/LineLength: Line is too long. [101/100] csv << ["Beans", "User Enterprise", "Vegetables", "-1", "3.50", "1", "500", "g", "Small Bag", ^ spec/system/admin/product_import_spec.rb:641:101: C: Layout/LineLength: Line is too long. [114/100] expect(page).to have_content "line 4: Cabbage ( Bag ) - On_hand incorrect value - On_demand incorrect value" ^^^^^^^^^^^^^^ spec/system/admin/product_import_spec.rb:642:101: C: Layout/LineLength: Line is too long. [116/100] expect(page).to have_content "line 5: Aubergine ( Bag ) - On_hand incorrect value - On_demand incorrect value" ^^^^^^^^^^^^^^^^ spec/system/consumer/shopping/cart_spec.rb:147:101: C: Layout/LineLength: Line is too long. [101/100] preferred_unit_from_list: "kg"), ^ spec/system/consumer/shopping/products_spec.rb:98:101: C: Layout/LineLength: Line is too long. [113/100] "<script>alert('Dangerous!');</script>", truncate: false) ^^^^^^^^^^^^^ 1478 files inspected, 173 offenses detected, 106 offenses corrected	2023-07-24 09:14:13 +09:00
Gaetan Craig-Riou	f9afc0ba96	Fix rubocop warning	2023-07-21 14:51:40 +10:00
Gaetan Craig-Riou	2fff77b2ee	Report, add filtering by product for line items	2023-07-21 14:51:40 +10:00
Gaetan Craig-Riou	ec78de7cea	Add product dropdown on Order and Fulfillment reports ... It includes loading the selected product to populate the dropdown when needed.	2023-07-21 14:51:40 +10:00
Neal Chambers	8fc0a20249	Add Additional Test for Model Creation	2023-07-18 08:17:34 +09:00
Neal Chambers	521af70959	Add Strong Params to Enterprise Fees Form	2023-07-18 08:17:34 +09:00
Neal Chambers	fb1ae855c2	Fix Metrics/ClassLength	2023-07-18 08:17:34 +09:00
Filipe	448d5ea017	Merge pull request #11135 from Matt-Yorkley/vouchers ... Vouchers part 2	2023-07-13 12:50:32 +01:00
David Cook	05a22b80bc	Merge pull request #11123 from dacook/buu-products-table ... [admin_style_v3] Products table with variants	2023-07-06 09:37:31 +10:00
Matt-Yorkley	75e6ccd580	Simplify voucher controller	2023-07-03 11:03:05 +01:00
Filipe	b175793b91	Merge pull request #10704 from abdellani/hide-customers-with-no-completed-orders ... Hide users with no completed orders from a hub's customers list	2023-06-30 10:56:56 +01:00
David Cook	841192fb96	Add new products page ... Hidden behind admin_style_v3 feature toggle.	2023-06-28 09:59:57 +10:00
Maikel	014fb69d4b	Merge pull request #10964 from macanudo527/fix_linelength_bundle1 ... Fix Layout/LineLength - Bundle 1	2023-06-26 12:10:39 +10:00
Maikel	a7915b8089	Merge pull request #10849 from mkllnk/report-cable ... Show "loading" screen for background reports and display when ready	2023-06-26 10:25:48 +10:00
Maikel Linke	ff588cec40	Restore line item ordering ... The line item sorting by id has been replaced by sorting by completed_at time: ccb183d60b While that's a good idea, the query param to order was only defined in the client Javascript and there was no default ordering. Line items also get their completed_at date from the order. So it's the same for all items of the same order and the ordering with that group of line items was random. Now we are adding an order in addition. Items are first sorted by date and then by id if there's any ambiguity.	2023-06-25 19:24:58 +02:00
David Cook	6240baec0d	Update app/controllers/admin/enterprises_controller.rb ... Co-authored-by: Gaetan Craig-Riou <40413322+rioug@users.noreply.github.com>	2023-06-23 16:18:45 +09:00
Neal Chambers	1e4034534c	Fix Layout/LineLength	2023-06-23 09:08:04 +09:00
Matt-Yorkley	7dc1091bc2	Migrate product image from master variant to product	2023-06-16 21:23:44 +01:00
David Cook	d195882645	Use builtin Rails method	2023-06-15 15:26:22 +10:00
Maikel Linke	a655d3d787	Remove unnecessary writes on customer creation ... The form only submits enterprise id and email address. We don't need to assign any other attributes.	2023-06-15 12:02:45 +10:00
Mohamed ABDELLANI	298ae8ffc3	set create_manualll flag if the customer already exists	2023-06-15 12:02:45 +10:00
Mohamed ABDELLANI	ebc3073604	use Customer#visible on the customers listing endpoints ... Update app/models/customer.rb Co-authored-by: Maikel <maikel@email.org.au> Update spec/models/customer_spec.rb Co-authored-by: Maikel <maikel@email.org.au> Update spec/models/customer_spec.rb Co-authored-by: Maikel <maikel@email.org.au> authorize created_manually field to be set on APIv1	2023-06-15 12:02:45 +10:00
Maikel Linke	c2605b2606	Display loading spinner before quick reports ... We had a race condition that could first display the report and then replace it again with the "loading" spinner. That doesn't seem to happen now that we changed the order of cable events.	2023-06-14 15:40:52 +10:00
Neal Chambers	449430cabc	Indent code to be more Readable	2023-06-09 16:39:29 +09:00
Neal Chambers	252697b782	Rewrite If and Unless Statements to be more Readable	2023-06-09 16:39:26 +09:00
Maikel Linke	d312a5912a	Style Layout/MultilineMethodCallIndentation	2023-06-09 14:45:06 +10:00
Maikel Linke	828b2f6f44	Replace too long list of arguments with keywords ... Rubocop was complaining about too many arguments. But `ApplicationJob#perform` needs all arguments handled in one call. While we could allow the `perform` method generally to have more arguments, there could be other methods called `perform` which should still be scrutinised. Instead, it seems acceptable to me to have more arguments as long as they are clearly named as keyword arguments. Rails uses this a lot to document all options including their default values, for example in Active Storage. It's better then bundling several arguments in an undocumented hash just to reduce the number of given arguments. And once we upgraded to Ruby 3.1, we can clean the method calls up as well. `call(user: user)` becomes `call(user:)` without repetition.	2023-06-09 14:44:54 +10:00
Maikel Linke	e56c06571c	Remove outdated report timeout handling ... Since we don't wait for the report any more, a timeout is very unlikely and we don't need special handling for it.	2023-06-09 14:44:54 +10:00
Matt-Yorkley	524d1f0264	Switch to tighter Channel scoping... ... This is not a normal pattern for setting up ActionCable channels, so it might need some notes. It ensures the broadcasts from the ReportJob are unique not just to the user session but also to the specific tab in the user's browser. Otherwise if the user has two different report pages open in separate tabs with the same session, the broadcast would overwrite the #report-table element in both of them.	2023-06-09 14:44:53 +10:00
Matt-Yorkley	a3ef604797	Run reports in background	2023-06-09 14:44:53 +10:00
Neal Chambers	dde775d2b7	Remove Old Code and Comments	2023-06-08 15:20:04 +10:00