Luis Ramos
714bfafede
Merge pull request #6037 from arku/fix/hash-diff-deprecation
...
Remove Hash#diff from cancan helper
2020-09-19 20:21:24 +01:00
Arun Kumar Mohan
08604ae8fd
Remove Hash#diff usage from cancan helper
2020-09-16 12:14:37 -05:00
Luis Ramos
de061b4c54
Make it a keyword argument so it's easier to read
2020-08-31 18:47:24 +01:00
Luis Ramos
42d5344179
Fix checkout spec by fixing wrong default value
2020-08-31 17:40:34 +01:00
Luis Ramos
685a5465f1
Simplify checkout stripe spec
2020-08-31 17:40:34 +01:00
Luis Ramos
86ad31eb5c
Reuse checkout form filling code from CheckoutHelper in checkout paypal spec
2020-08-31 17:40:34 +01:00
Luis Ramos
edfd0fd95c
Move checkout helpers to checkout_helper
2020-08-31 17:40:34 +01:00
Luis Ramos
d1f5828d13
Rename checkout_workflow to checkout_helper
2020-08-31 17:40:34 +01:00
Luis Ramos
23c86a1937
Replace select2_search usages with faster targetted_select2_search and remove select2_search and dependent code
2020-08-26 23:06:25 +01:00
Luis Ramos
fb88cfedcf
Remove unused helpers
2020-08-26 22:49:52 +01:00
Luis Ramos
b227c78aeb
Fix rubocop issues
2020-08-22 18:14:53 +01:00
Luis Ramos
261269bd57
Bring core/lib/spree/testing_support/i18n from spree_core to ofn as i18n_translations_checker
2020-08-22 18:14:53 +01:00
Luis Ramos
d0c07b931a
Bring Spree::TestingSupport::Preferences from spree_core to ofn as PreferencesHelper
2020-08-22 16:50:12 +01:00
Luis Ramos
0ca4d0842a
Remove capybara_ext from spree and bring its helpers that are required in ofn
2020-08-22 16:50:12 +01:00
Pau Pérez Fabregat
6e1dd78e9f
Merge pull request #5828 from luisramos0/ent_user
...
Clean up AuthenticationWorkflow spec helper
2020-08-04 12:07:54 +02:00
Pau Perez
61c14cb61d
Remove unneeded RSpec config block
...
Spec files individually include the module and we specify the type of
spec in each RSpec's describe so none of this settings are needed. They
are just Spree's legacy I bet.
2020-08-04 08:48:08 +02:00
Luis Ramos
c0f9f8c8bf
Remove comment refering to old spree upgrade
2020-07-31 09:05:42 +01:00
Luis Ramos
a002ec1894
Simplify login_as_admin by using existing factory admin_user
2020-07-27 16:02:59 +01:00
Luis Ramos
95a9ca7775
Remove redundant method, login_as is the name of the test helper in warden
2020-07-27 15:32:35 +01:00
Luis Ramos
a2ebc614d9
Rename AuthenticationWorkflow to AuthenticationHelper
2020-07-27 15:32:35 +01:00
Luis Ramos
10b07aabd9
Rename quick_login_as to login_as
2020-07-27 15:32:35 +01:00
Luis Ramos
5738ec0542
Rename login_to_admin_and_visit to login_as_admin_and_visit
2020-07-27 15:32:34 +01:00
Luis Ramos
c6bb756531
Rename quick_login_as_admin to login_as_admin and also re-use login_to_admin_and_visit when applicable
2020-07-27 15:31:23 +01:00
Luis Ramos
8b04e45ea5
Create login_to_admin_and_visit to avoid loading the admin dashboard unnecessarily
...
This commit removes 19 unnecessary page loads of the admin dashboard
2020-07-27 15:31:11 +01:00
Luis Ramos
f1a3814c0d
Rename login_as_enterprise_user to a more specific name controller_login_as_enterprise_user
2020-07-27 14:44:25 +01:00
Luis Ramos
8e84754f35
Rename login_as_admin to a more specific name controller_login_as_admin
2020-07-27 14:44:25 +01:00
Luis Ramos
81710a2704
Remove now dead create_enterprise_user, the user factory should be used instead
2020-07-27 14:44:25 +01:00
Luis Ramos
3217b3ba86
Delete dead commented code
2020-07-27 12:28:53 +01:00
Luis Ramos
fabddbd1c0
Merge pull request #5746 from coopdevs/remove-specs-dead-code
...
Remove dead specs helper method
2020-07-08 12:38:24 +01:00
Matt-Yorkley
d78db16abe
Merge pull request #5718 from Matt-Yorkley/available-locales-bug
...
Available locales bug
2020-07-08 12:30:18 +02:00
Pau Perez
a1e8c8ad03
Remove dead specs helper method
...
I found it while reviewing
https://github.com/openfoodfoundation/openfoodnetwork/pull/5718#discussion_r451390809 .
2020-07-08 10:59:13 +02:00
Luis Ramos
312e78ba61
Merge pull request #5742 from Matt-Yorkley/flaky-spec-shopping
...
Fix flaky shopping_spec
2020-07-07 18:11:00 +01:00
Matt-Yorkley
f2e0b0f35a
Ensure products list has loaded before interacting with product list UI elements
2020-07-07 13:14:11 +02:00
Matt-Yorkley
447a873e5c
Fix flaky embedded spec
...
The new cart sidebar takes 300ms to animate in. If we try to click the button on the left during this time, we may click the button on the right as it slides in.
2020-07-07 00:23:43 +02:00
Matt-Yorkley
3326366c6e
Add specs for applying stored locales during login
2020-07-02 14:35:58 +02:00
Maikel Linke
70347148a1
Stabilise shopping specs and open them for change
...
The way we add items to the cart will change. Encapsulating that code in
a common place will make the mobile ux work clearer and avoid merge
conflicts.
The waiting for background requests has also been improved and made more
consistent which should make these specs more reliable.
2020-06-26 09:55:57 +10:00
Luis Ramos
1c550a594f
Fix rubocop issue
2020-06-22 17:39:20 +01:00
Luis Ramos
3b91dd9dea
Use rubocop auto-correct to fix more issues
2020-06-22 12:51:47 +01:00
Luis Ramos
5d710f1e24
Use ruboccop autocorrect to fix issues
2020-06-22 12:46:07 +01:00
Luis Ramos
8a9dae0ee2
Run rubocop autocorrect
...
This is the result of bundle exec rubocop --auto-correct
2020-06-22 12:23:10 +01:00
Matt-Yorkley
459e53f43d
Adjust specs for new cart display
2020-06-18 22:21:55 +02:00
Luis Ramos
88896b7730
Merge branch 'master' into 3-0-stable-jun-2
2020-06-08 19:17:11 +01:00
Luis Ramos
53a80de503
Improve method names and set use_route with reverse_merge so it can be overridden
2020-06-02 17:32:46 +01:00
Luis Ramos
7b89f4d6c5
Switch controller helper calls routes from spree to main_app, this will include all routes all the time
2020-06-02 15:00:57 +01:00
Luis Ramos
13836a62bb
Rename parameters to params and change default from nil to {}
2020-06-02 14:36:06 +01:00
Luis Ramos
3136aa5a8b
Make api_process use process_spree_action
2020-06-02 14:00:24 +01:00
Luis Ramos
2f76e0b15b
Bring methods from Spree::TestingSupport::ControllerRequests to our ControllerRequestsHelper so we can merge them later
2020-06-02 13:54:33 +01:00
Luis Ramos
5d0856e5a3
Rename ControllerHacks to ControllerRequestsHelper and move it's configuration to spec_helper
2020-06-02 13:47:59 +01:00
Luis Ramos
cd3bc54c37
Remove resource_scoping to make things more simple
2020-06-02 13:43:33 +01:00
Luis Ramos
19da0ba969
Merge branch 'master' into 3-0-stable-may13
2020-05-13 19:50:32 +01:00
