Use rubocop auto-correct to fix more issues

This commit is contained in:
Luis Ramos
2020-06-22 12:51:47 +01:00
parent 5d710f1e24
commit 3b91dd9dea
5 changed files with 5 additions and 5 deletions

View File

@@ -117,7 +117,7 @@ module Spree
def load_order
if params[:id]
@order = Order.includes(:adjustments, :shipments, line_items: :adjustments).
find_by_number!(params[:id])
find_by!(number: params[:id])
end
authorize! action, @order
end

View File

@@ -122,7 +122,7 @@ module Spree
end
def load_order
@order = Order.find_by_number!(params[:order_id])
@order = Order.find_by!(number: params[:order_id])
authorize! action, @order
@order
end

View File

@@ -96,7 +96,7 @@ module Spree
protected
def find_resource
Product.find_by_permalink!(params[:id])
Product.find_by!(permalink: params[:id])
end
def location_after_save

View File

@@ -227,7 +227,7 @@ describe CheckoutController, type: :controller do
spree_post :update, format: :json, order: {}
expect(response.status).to eq(400)
expect(response.body).to eq({ errors: {}, flash: {error: I18n.t("checkout.failed")} }.to_json)
expect(response.body).to eq({ errors: {}, flash: { error: I18n.t("checkout.failed") } }.to_json)
end
describe "stale object handling" do

View File

@@ -38,7 +38,7 @@ module WebHelper
def select_by_value(value, options = {})
from = options.delete :from
page.find_by_id(from).find("option[value='#{value}']").select_option
page.find_by(id: from).find("option[value='#{value}']").select_option
end
def flash_message