Maikel
b50fa216eb
Merge pull request #11117 from rioug/10857-voucher-error-moving-between-summary-and-cart-take2
...
[vouchers] error moving between summary and cart pages
2023-08-09 11:14:52 +10:00
Gaetan Craig-Riou
6ed35f4cc1
Per review, delete only incomplete payments
...
Use destroy_all so we don't have to manually delete the payment fees
adjustment
2023-08-04 17:03:31 +10:00
Gaetan Craig-Riou
85adb9f345
Fix rubocop warning
2023-07-31 15:19:04 +10:00
Gaetan Craig-Riou
089d2b9c84
Clear any existing payment and payment fees when adding a voucher
...
If a user come back to checkout step 2 from step 3, the order
will have payment and possibly payment fee existing. This can
interfere with voucher calculation, so we clear them.
The user can then select a payment method again if needed
2023-07-31 12:05:52 +10:00
Gaetan Craig-Riou
33ef8def08
Update order total after removing a voucher
...
We need to do this to make sure when display the payment method
again.
Plus spec
2023-07-28 14:52:25 +10:00
Gaetan Craig-Riou
f35001dacc
Update voucher adjustment and order total when adding a voucher
...
This is needed so we can check if payment is needed and display
no payment required when no payment needed
2023-07-28 14:27:27 +10:00
David Cook
ef62fb885d
Check if record actually saved
...
I'm not sure if it will ever make a difference, but I think this makes more sense.
2023-07-28 14:11:45 +10:00
Gaetan Craig-Riou
5a59396a41
Remove call to VoucherAdjustmentService when creating a voucher
...
Voucher will be automatically applied when the order transition to
the confirmation step. No need to do the work twice.
2023-07-14 14:47:39 +10:00
Gaetan Craig-Riou
dc711bde78
Fix voucher adjustment delete
...
When using a voucher with tax not incluced in price, we need to delete
both the voucher adjustment and the tax adjustment
2023-07-14 13:37:45 +10:00
Matt-Yorkley
f7912a2240
Fix CSS/layout issues
2023-07-04 13:13:05 +01:00
Matt-Yorkley
672400192f
Update use of params
2023-07-04 13:13:05 +01:00
Matt-Yorkley
37a4c73a12
Fix rubocop complaint
2023-07-04 13:13:05 +01:00
Matt-Yorkley
de97e69e7d
Show/hide payment methods if voucher changes order total to zero
2023-07-04 13:13:05 +01:00
Matt-Yorkley
9e5061fc31
Move voucher processing out of checkout controller
2023-07-04 13:13:05 +01:00
Gaetan Craig-Riou
236f6926d9
Cleaning up left over TODOs
2023-05-15 13:42:39 +10:00
Gaetan Craig-Riou
e5f14177d3
Fix rubocop warning
...
I guess the new cops are effective :)
2023-05-15 13:42:39 +10:00
Gaetan Craig-Riou
3f37554ff9
Add VoucherAdjustmentsController and specs
...
Refactor split checkout to use the new controller. But unfortunately
we can't have nested form, so adding a voucher is still handled by
SplitCheckoutController.
2023-05-15 13:42:39 +10:00
