Gaetan Craig-Riou
f38aa73434
Per review, remove test class
...
It's better to use an anonymous class, and it also prevent the test
class from leaking the global namespace
2025-09-24 10:46:37 +10:00
Gaetan Craig-Riou
3862e0206c
Limit to only one tag per tag rule
2025-09-24 10:46:34 +10:00
Gaetan Craig-Riou
3a0722f39c
Remove tag related methods
2025-09-24 10:40:43 +10:00
Gaetan Craig-Riou
42f7f2606b
Remove reordering testing
...
This functionality has been removed
2025-09-24 10:40:43 +10:00
Gaetan Craig-Riou
9d9f7e8717
Remove Angularjs files related to tag rules
2025-09-24 10:40:43 +10:00
Gaetan Craig-Riou
0cf244b211
Document variant filtering rule behavior
...
Add test to conver scenario where we have conficting rules
2025-09-24 10:40:43 +10:00
Gaetan Craig-Riou
646ba18b8a
Fix bug, load tag rule types when update errors
2025-09-24 10:40:43 +10:00
Gaetan Craig-Riou
8bd631fbb7
Clean up tag rule form component template
...
Consolidate everything in one template and move visibility options to
the component.
2025-09-24 10:40:43 +10:00
Gaetan Craig-Riou
5c3acf38d7
Clean up stimulus usage
...
Use value and parameter when possible instead of relying on hidden
input
2025-09-24 10:40:43 +10:00
Gaetan Craig-Riou
afdc40d230
Move helper function to component
...
It's only used in the component so there is no need to keep it as an
helper.
2025-09-24 10:40:43 +10:00
Gaetan Craig-Riou
771573af1c
Fix system spec to work with refactored screen
2025-09-24 10:40:43 +10:00
Gaetan Craig-Riou
953122b6f6
Fix adding new rule
...
We separate the default tag rules and the various tag rule groups by an
index of 1000. This is so the previous group does not overlap with the
current group. Rails will managed the non continusly numbered
tag_rule_attributes param just fine. It saves us from having to manage
the numbering of tag_rule_attributes in javascript
2025-09-24 10:40:43 +10:00
Gaetan Craig-Riou
75325e2935
Consolidate modal to add rule into a component
2025-09-24 10:40:43 +10:00
Gaetan Craig-Riou
7e48007d09
Add new tag group and add rule to tag group
2025-09-24 10:40:43 +10:00
Gaetan Craig-Riou
50ab0a494c
Move tag rule group form to a component
2025-09-24 10:40:43 +10:00
Gaetan Craig-Riou
d3ef744daf
Display existing grouped tag rules
2025-09-24 10:40:43 +10:00
Gaetan Craig-Riou
ccdd12bf59
Small improvment
...
- add value for preferred customer tags
- allow passing html options to preferred customer tags hidden field
2025-09-24 10:40:43 +10:00
Gaetan Craig-Riou
b66b033999
Small improvement
...
- allow passing html options to the hidden field with the tags values,
to be used to add stimulus directive
- dispatch an input event when the hidden field with tags value gets
updated, it allows stimulus controller (or javascript) to react to
update
2025-09-24 10:40:34 +10:00
Gaetan Craig-Riou
35d37639af
Refactor tag rule filter input
...
Consolidated four partials into one
2025-09-24 10:38:53 +10:00
Gaetan Craig-Riou
6790cad089
Add deleting tag rule
...
TagRuleController is now a subclass of Spree::Admin::BaseController
because Admin::ResourceController did not play well with turbo_stream.
And to be honest we did not need all the functionality provided by the
ResourceController
2025-09-24 10:38:53 +10:00
Gaetan Craig-Riou
7087d1b290
Add default tag rule
...
I tried to leverage turbo as much as possible
2025-09-24 10:38:53 +10:00
Gaetan Craig-Riou
8f0cdf8722
Move individual tag rule form to a component
2025-09-24 10:38:53 +10:00
Gaetan Craig-Riou
25f6db09a5
TagListInputComponent removed dependency on the form
...
This allows us to use the component in a context where there is no form
object defined.
2025-09-24 10:38:47 +10:00
Gaetan Craig-Riou
11006c3a60
Display default rule
2025-09-24 10:36:21 +10:00
Gaetan Craig-Riou
b2a3715a8b
Fix bug
...
Don't add a leading coma when the tag list is empty
2025-09-24 10:36:21 +10:00
Gaetan Craig-Riou
693789d526
Merge pull request #13549 from openfoodfoundation/dependabot/npm_and_yarn/leaflet-geosearch-4.2.2
...
Bump leaflet-geosearch from 4.2.1 to 4.2.2
2025-09-24 09:49:41 +10:00
dependabot[bot]
d26b407801
Bump leaflet-geosearch from 4.2.1 to 4.2.2
...
Bumps [leaflet-geosearch](https://github.com/smeijer/leaflet-geosearch ) from 4.2.1 to 4.2.2.
- [Release notes](https://github.com/smeijer/leaflet-geosearch/releases )
- [Commits](https://github.com/smeijer/leaflet-geosearch/compare/v4.2.1...v4.2.2 )
---
updated-dependencies:
- dependency-name: leaflet-geosearch
dependency-version: 4.2.2
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-09-22 09:12:58 +00:00
Maikel Linke
6d284023fe
Configure rake specs in one place
...
So we don't have to add it to every rake spec file.
2025-09-22 17:27:58 +10:00
Maikel Linke
570b72868b
Simplify task loading code
2025-09-22 17:27:58 +10:00
Maikel Linke
286d9f8e7d
Remove unneeded declaration of Rails environment task in specs
2025-09-22 17:27:58 +10:00
Ahmed Ejaz
b0c3265cdb
update migration test to assert nil cvv_response_message for ineligible payments
2025-09-22 11:57:38 +05:00
Ahmed Ejaz
6bb709e85e
update test description to reflect patching of redirect_auth_url in cvv_result
2025-09-22 11:57:37 +05:00
filipefurtad0
fe257162b7
Update all locales with the latest Transifex translations
2025-09-22 07:56:21 +01:00
Ahmed Ejaz
b510736a8d
refactor migration to use SpreePayment model instead of Spree::Payment
2025-09-22 11:55:43 +05:00
Ahmed Ejaz
2df0078ea9
fix lint issues
2025-09-22 11:55:43 +05:00
Ahmed Ejaz
ca079e6e26
add migration to migrate cvv_message_response value to redirect_auth_url
...
- As per the patch, cvv_message_response contains 3D verification URL for those payments which require it. So need to migrate to the new column to maintain data integrity
2025-09-22 11:55:43 +05:00
Ahmed Ejaz
ac06126f59
replace cvv_response_message usage with redirect_auth_url
2025-09-22 11:55:43 +05:00
Ahmed Ejaz
aecb5f49c9
fix spec as per current response we get for cvv_result
2025-09-22 11:54:20 +05:00
Ahmed Ejaz
a18fd54916
Simplify redirect logic in PaymentsController
2025-09-22 11:54:20 +05:00
Ahmed Ejaz
626b802ea7
add redirect_auth_url column and replace cvv_response_message for redirection
...
- Added redirect_auth_url column to spree_payments table
- Updated payment redirection logic to use redirect_auth_url instead of cvv_response_message
- Cleans up old monkeypatch usage and improves Stripe checkout reliability
2025-09-22 11:54:20 +05:00
Ahmed Ejaz
28ab41c47f
Potential fix for code scanning alert no. 253: Workflow does not contain permissions
...
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
2025-09-18 03:17:22 +05:00
Ahmed Ejaz
17a85e9c1c
Update GitHub Actions workflow to use specific Dependabot token and set organization name explicitly
2025-09-18 03:01:44 +05:00
Maikel
9e746d1b40
Merge pull request #13531 from rioug/better-stimulus-name-for-component
...
Load component stimulus controller with a shorter name
2025-09-17 17:10:37 +10:00
Filipe
273f78b214
Merge pull request #13530 from mkllnk/hub-address-feature
...
Remove retired hub_address feature
2025-09-16 17:23:42 +01:00
Filipe
bd1d9892a2
Merge pull request #13487 from rioug/security-241-fix-url-sanitization
...
Fix url sanitization for Stripe authorisation URL
2025-09-16 16:40:11 +01:00
David Cook
cb825df75b
Merge pull request #13536 from openfoodfoundation/dependabot/npm_and_yarn/leaflet-geosearch-4.2.1
...
Bump leaflet-geosearch from 4.2.0 to 4.2.1
2025-09-16 15:32:29 +10:00
Filipe
bfcadfd7c0
Merge pull request #13404 from cyrillefr/UnsavedChangesMustAppearOnRemovingSingleTagFromOrderCycle
...
Fixes Save button does not enable when removing only tag in OC
2025-09-15 13:27:26 +01:00
dependabot[bot]
255b5f1cd5
Bump leaflet-geosearch from 4.2.0 to 4.2.1
...
Bumps [leaflet-geosearch](https://github.com/smeijer/leaflet-geosearch ) from 4.2.0 to 4.2.1.
- [Release notes](https://github.com/smeijer/leaflet-geosearch/releases )
- [Commits](https://github.com/smeijer/leaflet-geosearch/compare/v4.2.0...v4.2.1 )
---
updated-dependencies:
- dependency-name: leaflet-geosearch
dependency-version: 4.2.1
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2025-09-15 09:27:26 +00:00
Ahmed Ejaz
dffcd446fd
Simplify backorderable priority SQL query in product sorting concern
2025-09-15 12:03:04 +05:00
Ahmed Ejaz
1987f0b667
Remove redundant SQL string checks in product sorting specs for clarity
2025-09-15 11:57:33 +05:00