Neal Chambers
69e7419a45
Safely autocorrect Style/NegatedIfElseCondition
...
Inspecting 1509 files
....................................................................................................................................................................................................................C........................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C.......................................................................................................................................................
Offenses:
app/mailers/spree/shipment_mailer.rb:15:25: C: [Corrected] Style/NegatedIfElseCondition: Invert the negated condition and swap the ternary branches.
default_subject = !@delivery ? t('.picked_up_subject') : default_i18n_subject
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
spec/support/matchers/table_matchers.rb:34:5: C: [Corrected] Style/NegatedIfElseCondition: Invert the negated condition and swap the if-else branches.
if rows.count != expected_table.count ...
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
1509 files inspected, 2 offenses detected, 2 offenses corrected
2023-11-10 09:13:57 +09:00
Neal Chambers
0ec03da30e
Regenerate Rubocop's TODO file
2023-11-10 09:13:57 +09:00
David Cook
95028d5347
Merge pull request #11790 from duleorlovic/11783_add_present
...
Check for .present? for ENV GOOGLE variables
2023-11-10 11:12:57 +11:00
Maikel
72dc00ba5c
Merge pull request #11779 from filipefurtad0/stripe_version_in_sync_with_vcr_tests
...
Stripe version in sync with vcr tests
2023-11-10 10:43:28 +11:00
Ahmed Ejaz
e97676a680
Merge branch 'master' into task/11067-admin_style_v3-product-clone
2023-11-09 19:42:21 +05:00
Dusan Orlovic
0f30836c1d
Check for .present? for ENV GOOGLE variables
2023-11-09 09:45:19 +01:00
David Cook
f754eac3a0
Add script for preparing translations
2023-11-09 17:42:09 +11:00
Maikel
ec1f23a947
Merge pull request #11781 from openfoodfoundation/dependabot/bundler/datafoodconsortium-connector-1.0.0.pre.alpha.9
...
chore(deps): bump datafoodconsortium-connector from 1.0.0.pre.alpha.8 to 1.0.0.pre.alpha.9
2023-11-09 16:46:05 +11:00
David Cook
023eb0633d
Update all locales with the latest Transifex translations
v4.4.19
2023-11-09 16:42:04 +11:00
Maikel Linke
0a88e8b8ac
Update API documentation
2023-11-09 16:17:11 +11:00
Maikel Linke
cde57fcfb4
Update specs for changed attribute URI
2023-11-09 16:16:24 +11:00
Maikel Linke
eac632c81e
Use new DFC Connector API to add an address
2023-11-09 16:16:24 +11:00
Maikel Linke
8d81802f47
Update DFC SKOS Parser monkey patch with current code
2023-11-09 16:16:24 +11:00
Maikel Linke
5d29dee848
Update DFC Importer to use shortened URIs
...
The new Connector code uses shortened URIs now.
2023-11-09 16:16:24 +11:00
dependabot[bot]
3ca426945f
chore(deps): bump datafoodconsortium-connector
...
Bumps datafoodconsortium-connector from 1.0.0.pre.alpha.8 to 1.0.0.pre.alpha.9.
---
updated-dependencies:
- dependency-name: datafoodconsortium-connector
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-11-09 15:46:32 +11:00
Maikel Linke
71c50e1fcf
Update warning message for item quantity
2023-11-09 10:56:41 +11:00
Maikel Linke
efc338aeeb
Don't update order when not enough stock
...
There's a user-facing change here. When you tried to update the quantity
of a line item beyond available stock, two things used to happen:
1. A warning was displayed.
2. The item's quantity was updated to the highest possible.
Unfortunately, the logic to update the line item was also reloading the
page and the warning message disappeared before it could be
acknowledged. The easiest fix was to skip the update request. And in my
opinion, it's even better to let the user decide if they still want to
update or cancel the update.
Eventually, we want to replace all this custom Javascript logic with
StimulusJS anyway. So let's not put too much effort into this. It was
important though to resolve the flaky spec which made many builds fail.
2023-11-09 10:56:41 +11:00
Maikel Linke
d5dca97438
Spec tiny bug which caused a flaky spec
...
It still needs solving.
2023-11-09 10:56:41 +11:00
Maikel
4e52fc28ef
Merge pull request #11756 from rioug/11712_DFC_add_image_to_product
...
[DFC API] add image to product
2023-11-09 09:37:06 +11:00
Maikel Linke
4c1334fb69
Record new version of Stripe requests
2023-11-09 08:56:46 +11:00
Maikel Linke
cb57807466
Streamline stripe test recording updates
2023-11-09 08:52:06 +11:00
Ahmed Ejaz
2af678cb28
Merge branch 'master' into task/11067-admin_style_v3-product-clone
2023-11-08 18:41:31 +05:00
Ahmed Ejaz
851ce281ea
#11067 , implement product clone
2023-11-08 18:36:22 +05:00
Maikel Linke
d0dd6e57ca
Replace variable values with fixed values in Swagger doc
2023-11-08 17:12:42 +11:00
Maikel Linke
7dd0d0581c
Codify re-recording of Stripe cassettes
2023-11-08 15:05:54 +11:00
filipefurtad0
9d50b11090
Adds re-recorded Stripe cassettes within Stripe gem folder name
2023-11-08 14:25:19 +11:00
filipefurtad0
7dac08a0be
Sets flag to create folder with Stripe version
2023-11-08 14:24:19 +11:00
Gaetan Craig-Riou
f76bdf0c6f
Fix rubocop warning
2023-11-08 13:57:35 +11:00
Gaetan Craig-Riou
11ee4b30c2
Update Swagger documentation to include ofn:image
2023-11-08 13:57:35 +11:00
Gaetan Craig-Riou
7987967824
Check product image url is present on supplied product endpoint
2023-11-08 13:57:35 +11:00
Gaetan Craig-Riou
12c6257a0f
Pass the image url to DfcProvider::SuppliedProduct
2023-11-08 13:57:35 +11:00
Gaetan Craig-Riou
424954ec54
Add ofn:image to SuppliedProduct
...
Temporary solution as we wait for the DFC connector to be updated
to support "dfc_b:image" for SuppliedProduct
2023-11-08 13:57:35 +11:00
Maikel
cbc2ef54c8
Merge pull request #11778 from openfoodfoundation/dependabot/bundler/bullet-7.1.3
...
chore(deps-dev): bump bullet from 7.1.2 to 7.1.3
2023-11-08 13:57:04 +11:00
Maikel
13e7448739
Merge pull request #11777 from openfoodfoundation/dependabot/bundler/cuprite-0.15
...
chore(deps-dev): bump cuprite from 0.14.3 to 0.15
2023-11-08 13:56:28 +11:00
Maikel
3eb9cf994b
Merge pull request #11758 from openfoodfoundation/dependabot/bundler/stripe-10.1.0
...
chore(deps): bump stripe from 10.0.0 to 10.1.0
2023-11-08 13:49:19 +11:00
Maikel
dd1f358d36
Merge pull request #11757 from dacook/buu-disabled-button
...
[BUU] Grey out disabled button
2023-11-08 13:48:23 +11:00
David Cook
9172c87fce
Merge pull request #11701 from macanudo527/remove_bogus_gateways
...
Remove bogus gateways
2023-11-08 09:36:36 +11:00
Neal Chambers
af764bd38e
Move payment_intent to Helper
2023-11-07 16:30:50 +09:00
Neal Chambers
31fda7169d
Delete Bogus and BogusSimple Gateways from Locales
2023-11-07 11:19:26 +09:00
Neal Chambers
1456f3b7db
Remove Bogus Gateway from Sample Data
2023-11-07 11:19:26 +09:00
Neal Chambers
3ddf3c05ae
Remove References to Bogus in Pending Specs
2023-11-07 11:19:26 +09:00
Neal Chambers
6ba8c88ea7
Rewrite Specs to Use Paypal or Stripe Gateway instead of Bogus
2023-11-07 11:19:26 +09:00
Neal Chambers
0663f04535
Remove Simple References to Bogus Gateway
2023-11-07 11:19:26 +09:00
Neal Chambers
74870ff0ad
Delete Bogus Gateway Files
2023-11-07 11:19:23 +09:00
dependabot[bot]
1c878e7fa9
chore(deps-dev): bump bullet from 7.1.2 to 7.1.3
...
Bumps [bullet](https://github.com/flyerhzm/bullet ) from 7.1.2 to 7.1.3.
- [Changelog](https://github.com/flyerhzm/bullet/blob/main/CHANGELOG.md )
- [Commits](https://github.com/flyerhzm/bullet/compare/7.1.2...7.1.3 )
---
updated-dependencies:
- dependency-name: bullet
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-11-06 10:00:55 +00:00
dependabot[bot]
19a385b4eb
chore(deps-dev): bump cuprite from 0.14.3 to 0.15
...
Bumps [cuprite](https://github.com/rubycdp/cuprite ) from 0.14.3 to 0.15.
- [Release notes](https://github.com/rubycdp/cuprite/releases )
- [Changelog](https://github.com/rubycdp/cuprite/blob/main/CHANGELOG.md )
- [Commits](https://github.com/rubycdp/cuprite/compare/v0.14.3...v0.15 )
---
updated-dependencies:
- dependency-name: cuprite
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-11-06 09:56:52 +00:00
Gaetan Craig-Riou
c42d9d7d54
Use type="hidden" to hide input
...
It looks some CSS we use is breaking the use of "hidden"
2023-11-06 16:54:48 +11:00
Rachel Arnould
1e15d32a24
Merge pull request #11679 from abdellani/new_and_unique_invoice_template
...
New and unique invoice template
2023-11-03 16:49:19 +01:00
dependabot[bot]
01b24a8383
chore(deps): bump stripe from 10.0.0 to 10.1.0
...
Bumps [stripe](https://github.com/stripe/stripe-ruby ) from 10.0.0 to 10.1.0.
- [Release notes](https://github.com/stripe/stripe-ruby/releases )
- [Changelog](https://github.com/stripe/stripe-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/stripe/stripe-ruby/compare/v10.0.0...v10.1.0 )
---
updated-dependencies:
- dependency-name: stripe
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-11-03 09:30:15 +00:00
Sigmund Petersen
40c14c6ae3
Merge pull request #11749 from mkllnk/cuprite
...
Clarify cuprite driver configuration
2023-11-03 09:59:36 +01:00