raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-02-13 23:37:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove References to Bogus in Pending Specs

Browse Source
This commit is contained in:
Neal Chambers
2023-10-24 09:44:21 +09:00
parent 6ba8c88ea7
commit 3ddf3c05ae
2 changed files with 32 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
spec/requests/checkout/failed_checkout_spec.rb
View File

@@ -14,7 +14,7 @@ describe "checking out an order that initially fails", type: :request do
let!(:address) { create(:address) }
let!(:line_item) { create(:line_item, order:, quantity: 3, price: 5.00) }
let!(:payment_method) {
create(:bogus_payment_method, distributor_ids: [shop.id], environment: Rails.env)
create(:stripe_sca_payment_method, distributor_ids: [shop.id], environment: Rails.env)
}
let!(:check_payment_method) {
create(:payment_method, distributor_ids: [shop.id], environment: Rails.env)
@@ -63,7 +63,7 @@ describe "checking out an order that initially fails", type: :request do
it "clears shipments and payments before rendering the checkout" do
put update_checkout_path, params:, as: :json
# Checking out a BogusGateway without a source fails at :payment
# Checking out a bogus Stripe Gateway without a source fails at :payment
# Shipments and payments should then be cleared before rendering checkout
expect(response.status).to be 400
expect(flash[:error])

62
spec/system/consumer/shopping/checkout_spec.rb
View File

@@ -558,44 +558,42 @@ describe "As a consumer I want to check out my cart" do
end
describe "credit card payments" do
["Spree::Gateway::Bogus", "Spree::Gateway::BogusSimple"].each do |gateway_type|
context "with a credit card payment method using #{gateway_type}" do
let!(:check_without_fee) {
create(:payment_method, distributors: [distributor], name: "Roger rabbit",
type: gateway_type)
}
context "with a credit card payment method using Stripe" do
let!(:check_without_fee) {
create(:payment_method, distributors: [distributor], name: "Roger Rabbit",
type: "Spree::Gateway::StripeSCA")
}
it "takes us to the order confirmation page when submitted " \
"with a valid credit card" do
fill_in 'Card Number', with: "4111111111111111"
select 'February', from: 'secrets.card_month'
select (Date.current.year + 1).to_s, from: 'secrets.card_year'
fill_in 'Security Code', with: '123'
it "takes us to the order confirmation page when submitted " \
"with a valid credit card" do
fill_in 'Card Number', with: "4111111111111111"
select 'February', from: 'secrets.card_month'
select (Date.current.year + 1).to_s, from: 'secrets.card_year'
fill_in 'Security Code', with: '123'
place_order
expect(page).to have_content "Your order has been processed successfully"
place_order
expect(page).to have_content "Your order has been processed successfully"
# Order should have a payment with the correct amount
order = Spree::Order.complete.last
expect(order.payments.first.amount).to eq(11.23)
expect(order.payment_state).to eq "paid"
expect(order.shipment_state).to eq "ready"
end
# Order should have a payment with the correct amount
order = Spree::Order.complete.last
expect(order.payments.first.amount).to eq(11.23)
expect(order.payment_state).to eq "paid"
expect(order.shipment_state).to eq "ready"
end
it "shows the payment processing failed message when submitted " \
"with an invalid credit card" do
fill_in 'Card Number', with: "9999999988887777"
select 'February', from: 'secrets.card_month'
select (Date.current.year + 1).to_s, from: 'secrets.card_year'
fill_in 'Security Code', with: '123'
it "shows the payment processing failed message when submitted " \
"with an invalid credit card" do
fill_in 'Card Number', with: "9999999988887777"
select 'February', from: 'secrets.card_month'
select (Date.current.year + 1).to_s, from: 'secrets.card_year'
fill_in 'Security Code', with: '123'
place_order
expect(page).to have_content 'Bogus Gateway: Forced failure'
place_order
expect(page).to have_content 'Bogus Gateway: Forced failure'
# Does not show duplicate shipping fee
visit checkout_path
expect(page).to have_selector "th", text: "Shipping", count: 1
end
# Does not show duplicate shipping fee
visit checkout_path
expect(page).to have_selector "th", text: "Shipping", count: 1
end
end
end