David Rodríguez
d6c044fd5b
Remove unnecessary explicit sleeps
...
Capybara helpers already wait for the content to show up (and we already
have a default of 10 seconds configured), so I don't think waiting more is
actually the problem in these specs.
But if we wanted to wait more, I think it's better to pass the `:wait`
option to capybara matchers, because that's a "maximum waiting value"
but we'll still proceed earlier if the content shows up.
Using the same idea, I changed the positive assertions to happen first,
because negative assertions do spend "max wait time" waiting, while
positive assertions only wait until the content shows up.
2025-10-15 13:09:52 +02:00
Gaetan Craig-Riou
3eae329cc4
Fix shop system spec
2024-07-03 11:21:28 +10:00
Maikel Linke
6317fe1b71
Disable RSpec monkey patching
2024-05-09 12:24:41 +10:00
Maikel Linke
bd6b0ddbf3
Enforce RSpec expect(..).not_to over to_not
2024-03-07 16:57:54 +11:00
David Cook
ea0967e22e
Safely autocorrect Capybara/NegationMatcher
2024-03-06 09:20:22 +11:00
Matt-Yorkley
321047d663
Update specs
2023-08-08 11:36:31 +01:00
David Cook
6859200339
Safely autocorrect Layout/ExtraSpacing
...
Inspecting 1478 files
................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C.......................................................................................................................................................................................................................C......................................................................................................................................................................................................C......................
Offenses:
spec/lib/open_food_network/property_merge_spec.rb:22:57: C: [Corrected] Layout/ExtraSpacing: Unnecessary spacing detected.
let(:product_property) { create(:product_property, property: property) }
^
spec/services/cart_service_spec.rb:276:58: C: [Corrected] Layout/ExtraSpacing: Unnecessary spacing detected.
cart_service.instance_variable_set :@order_cycle, double(:order_cycle)
^
spec/system/consumer/shops_spec.rb:78:46: C: [Corrected] Layout/ExtraSpacing: Unnecessary spacing detected.
expect(page).to have_no_selector 'hub', text: d2.name
^^
1478 files inspected, 3 offenses detected, 3 offenses corrected
2023-07-20 14:01:44 +10:00
binarygit
c5779eff81
Do not open modal for producer's who are 'hidden'
2023-04-11 14:27:57 +02:00
Maikel Linke
cb64361096
Remove old feature spec tag
...
Nowadays all system specs are run in a real browser.
2023-02-24 15:10:19 +11:00
Maikel Linke
9da6f862cd
Stabilise pending spec
2022-10-12 16:49:29 +11:00
Maikel Linke
3eb597bff4
Fix specs which accidentally reversed relationships
2022-10-12 16:49:29 +11:00
filipefurtad0
215f3e97ad
Splits tests into existing/non-existing shops
...
Sets failing tests as pending for issues #9649 and #5467
2022-09-09 13:08:45 +01:00
Maikel Linke
b7e0d46dad
Style Layout/LineLength
2021-12-13 13:56:52 +11:00
filipefurtad0
345b9a181c
Updates/moves shops_spec into system
2021-12-10 17:48:01 +00:00
