Gaetan Craig-Riou
|
29a24b7305
|
Scope variant to hub only when inventory enabled
|
2025-07-09 11:35:26 +10:00 |
|
Gaetan Craig-Riou
|
7c31c951a1
|
Refactor spec to use instance_double
|
2025-07-09 11:35:26 +10:00 |
|
Joseph Johansen
|
5086f2d8b5
|
Fix rubocop Style/Send group
|
2024-07-23 14:18:26 +01:00 |
|
Maikel Linke
|
6317fe1b71
|
Disable RSpec monkey patching
|
2024-05-09 12:24:41 +10:00 |
|
Feruz Oripov
|
9d919938f3
|
Group Order && OrderCycle related services and specs
|
2024-03-16 19:07:08 +05:00 |
|
Neal Chambers
|
70e218d2e9
|
Fix Style/HashSyntax
|
2023-09-25 13:15:38 +09:00 |
|
David Cook
|
6859200339
|
Safely autocorrect Layout/ExtraSpacing
Inspecting 1478 files
................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................C.......................................................................................................................................................................................................................C......................................................................................................................................................................................................C......................
Offenses:
spec/lib/open_food_network/property_merge_spec.rb:22:57: C: [Corrected] Layout/ExtraSpacing: Unnecessary spacing detected.
let(:product_property) { create(:product_property, property: property) }
^
spec/services/cart_service_spec.rb:276:58: C: [Corrected] Layout/ExtraSpacing: Unnecessary spacing detected.
cart_service.instance_variable_set :@order_cycle, double(:order_cycle)
^
spec/system/consumer/shops_spec.rb:78:46: C: [Corrected] Layout/ExtraSpacing: Unnecessary spacing detected.
expect(page).to have_no_selector 'hub', text: d2.name
^^
1478 files inspected, 3 offenses detected, 3 offenses corrected
|
2023-07-20 14:01:44 +10:00 |
|
Neal Chambers
|
728926cc9a
|
Fix Layout/LineLength
|
2023-07-19 08:39:26 +09:00 |
|
Luis Ramos
|
23627c5453
|
Run rubocop -a (safe corrections) removing all exceptions so all possible fixes are applied
9290 issues fixed
|
2021-06-17 22:19:26 +01:00 |
|
Matt-Yorkley
|
47e2976fd1
|
Update CartService specs
|
2021-06-04 17:10:50 +01:00 |
|
Matt-Yorkley
|
6e8fd3c3f8
|
Simplify CartService interface
There's only one place this method is called, and the "overwrite" argument is always explicitly true. It doesn't need to be there if it's mandatory.
|
2021-06-04 17:10:50 +01:00 |
|
Luis Ramos
|
6fab8db1b0
|
Fix cart_service_spec to adapt to the actual usage of it from cart_controller, params are now sent inside a Parameters object, not as a hash
|
2021-04-14 09:18:29 -07:00 |
|
Matt-Yorkley
|
2d9d293405
|
Replace deprecated use of :reload argument
|
2021-03-16 12:04:35 +00:00 |
|
Luis Ramos
|
2b8f0abe49
|
Try some mass auto-correct adding frozen-string-literal to all specs
|
2020-12-03 06:38:24 -08:00 |
|
Luis Ramos
|
8a9dae0ee2
|
Run rubocop autocorrect
This is the result of bundle exec rubocop --auto-correct
|
2020-06-22 12:23:10 +01:00 |
|
Matt-Yorkley
|
26ba76cff9
|
Fix soft-deletion in CartService and update spec
|
2020-05-05 13:57:50 +02:00 |
|
Matt-Yorkley
|
5639b21c77
|
Add tests for current soft-deleted variant behavior in CartService
|
2020-05-05 13:57:50 +02:00 |
|
Matt-Yorkley
|
e33de8a20e
|
Update specs and refactor a bit
|
2020-04-27 19:27:07 +02:00 |
|
Luis Ramos
|
a180576c0a
|
Make cart_service spec green in rails 4 branch
|
2020-03-03 17:29:38 +00:00 |
|
luisramos0
|
86b0d71c7e
|
Result of rubocop auto-correct and rebuilding rubocop_manual_todo
|
2019-05-28 12:57:29 +01:00 |
|
luisramos0
|
59ec52babe
|
Refactor order_cycle_distributed_variants, better method names and simpler code
|
2019-04-11 22:15:24 +01:00 |
|
luisramos0
|
96ee527f0c
|
Rename distribution_change_validator to order_cycle_distributed_variants
|
2019-04-11 21:14:01 +01:00 |
|
luisramos0
|
c1d14686a6
|
Merge branch 'master' into 2-0-stable-Mar22
|
2019-03-22 10:55:17 +00:00 |
|
luisramos0
|
60ee17204b
|
Merge branch 'master' into 2-0-stable-Mar16
|
2019-03-16 16:17:38 +00:00 |
|
luisramos0
|
2de6c46834
|
Make order.order_cycle required in cart_service. There’s no more exception for that without product_distributions.
|
2019-03-13 12:24:40 +00:00 |
|
luisramos0
|
351555d4e2
|
Remove unused methods from add_to_cart helper and distribution change validator
|
2019-03-02 12:55:08 +00:00 |
|
luisramos0
|
0460e7fc6c
|
Merge branch 'master' into 2-0-stable-jan-17th
|
2019-01-17 22:51:25 +00:00 |
|
luisramos0
|
aa603c9a84
|
Make rubocop happy on cart controller, cart service and stock levels service
|
2019-01-15 13:42:51 +00:00 |
|
luisramos0
|
df36e0b344
|
In cart population, replace usage of global allow_backorders with variant.on_demand adapter
|
2018-10-18 18:37:09 +01:00 |
|
luisramos0
|
910297572e
|
Removed unnecessary currency from CartService constructor, using order.currency instead
|
2018-08-23 12:40:18 +01:00 |
|
luisramos0
|
ec069b1e3e
|
Converted specs to latest rspec syntax
|
2018-08-23 12:39:58 +01:00 |
|
luisramos0
|
05bfc098ff
|
/controllers/spree/order_populator_decorator (with a class_eval) is now /services/CartService with no dependency to Spree::OrderPopulator.
|
2018-08-23 12:39:55 +01:00 |
|