8 Commits

Author	SHA1	Message	Date
cyrillefr	cf9395f42f	Fixes RSpecRailsInferredSpecType in spree admin controllers	2025-05-20 12:45:34 +02:00
Maikel Linke	6317fe1b71	Disable RSpec monkey patching	2024-05-09 12:24:41 +10:00
Maikel Linke	bd6b0ddbf3	Enforce RSpec expect(..).not_to over to_not	2024-03-07 16:57:54 +11:00
Luis Ramos	23627c5453	Run rubocop -a (safe corrections) removing all exceptions so all possible fixes are applied ... 9290 issues fixed	2021-06-17 22:19:26 +01:00
Matt-Yorkley	3da5c0d7fd	Update TaxRate transition spec ... Setting a tax rate to included fails a validation if a default zone doesn't exist, so that's added. Also improved the tested scenarios and some of the details checked on the updated objects.	2021-02-16 13:21:57 +00:00
Matt-Yorkley	ff549fb62e	Also soft-delete tax rates when changing included_in_price ... We need to do this when the included_in_price boolean changes as well, for the same reasons.	2021-02-09 17:26:16 +00:00
Matt-Yorkley	78eb5d23f9	Update TaxRatesController spec ... BigDecimal was throwing an error here (in Rails 5) unless it received a string, but I think this is actually an issue with the way params were being passed in the relevant spec, as opposed to the controller itself.	2021-02-09 11:57:00 +00:00
Matt-Yorkley	8cc4c6a63f	Introduce soft-deprecation strategy when modifying tax rates ... If an admin changes the amount on a tax rate, and that rate has been used by adjustments in the past, we need to soft-delete and clone it to preserve the data integrity of previous adjustments that were created using that rate.	2021-01-15 13:38:03 +00:00