Ahmed Ejaz
ac06126f59
replace cvv_response_message usage with redirect_auth_url
2025-09-22 11:55:43 +05:00
cyrillefr
cf9395f42f
Fixes RSpecRailsInferredSpecType in spree admin controllers
2025-05-20 12:45:34 +02:00
cyrillefr
5063a772f0
Fixes RSpec Rails HaveHttpStatus cop in controllers
2025-05-14 10:58:04 +02:00
Maikel Linke
6317fe1b71
Disable RSpec monkey patching
2024-05-09 12:24:41 +10:00
Maikel Linke
bd6b0ddbf3
Enforce RSpec expect(..).not_to over to_not
2024-03-07 16:57:54 +11:00
Ryan Murphy
7e5ad8c8a4
9048: Fix Stripe payment flash rendering issue
2023-11-01 07:33:06 -04:00
Neal Chambers
29df80945d
Fix Style/HashSyntax
2023-09-20 23:46:26 +09:00
cyrillefr
7c24f6b26f
Remove I18n keys from Pay/Stripe/Chkout Ctrllers spec
2023-02-15 11:08:19 +01:00
Maikel Linke
ee85b9654d
Remove references to StripeConnect class
2022-01-24 12:35:45 +11:00
Filipe
b256696544
Merge pull request #8549 from mkllnk/deprecate-stripe-connect
...
Hide old "Stripe" (StripeConnect) payment method type, keep new Stripe SCA
2021-12-23 21:33:42 +00:00
Maikel Linke
178d296c9f
Adapt specs to use stripe_sca_payment_method
...
There are still some specs directly related to StripeConnect and I left
them for now.
2021-12-20 15:00:14 +11:00
Cillian O'Ruanaidh
84eaafb822
Add a :captured_at column on payments to store when they are captured
...
Fixes #8611 .
2021-12-17 14:45:47 +00:00
Luis Azcuaga
e8fd89a6d2
Run rubocop over existing todo
2021-10-25 21:28:28 -05:00
Maikel
a3c31f7d86
Revert "Kill stripe connect"
2021-09-20 08:39:34 +10:00
Nihal
98a879a0e9
Restore removed spec to profile_storer_spec
2021-09-10 14:43:34 +05:30
Luis Ramos
f90e34bb47
Adapt specs to use stripe_sca_payment_method factory and delete stripe_connect_payment_method
2021-09-10 14:43:34 +05:30
Luis Ramos
9de9b41575
Remove stripe connect spec, there's a similar spec for stripesca below
2021-09-10 14:43:34 +05:30
Matt-Yorkley
7e3b9be506
Allow StripeSCA Gateway to actually void payments
2021-07-30 11:48:57 +01:00
Andy Brett
aa8067f96b
process payments separately from completing the order
2021-06-29 11:54:48 -07:00
Andy Brett
2699e17b63
update specs to create payment in requires_authorization state
2021-06-17 14:23:59 -07:00
Matt-Yorkley
00988dc1e7
Use :order_with_totals factory in payments controller spec
...
This factory makes an order that actually has a line item 👍
2021-06-06 20:20:41 +01:00
Andy Brett
b3e08b47b9
set Stripe api key directly instead of using allow
2021-06-01 22:33:12 +01:00
Andy Brett
70ac719725
Merge pull request #7649 from andrewpbrett/payments-when-out-of-stock
...
Check stock before doing anything related to admin payments
2021-05-19 14:45:38 -07:00
Andy Brett
ca38948e21
check stock before doing anything related to admin payments
2021-05-14 17:42:37 -07:00
Matt-Yorkley
8e10f7af0e
Update payments controller test setup
...
We need to use a completed order in the test setup here or it doesn't behave correctly. `order.completed_at` is nil, for example.
2021-05-04 16:40:10 +01:00
Pau Perez
5815d1a4a4
Make #outstanding_balance return an OrderBalance
...
This will let us branch by abstraction. All existing calls to
`#outstanding_balance` will go through `OrderBalance` hence, will
check the feature toggle.
Note that by default, `OrderBalance` will end up calling
`#old_outstanding_balance`. As the name states, that's exactly what
`#outstanding_balance` was so far. This means no consumers will see any
change in behavior. We just added on item in the call stack (sort of).
2021-03-22 11:45:12 +01:00
Andy Brett
95c232dfe7
add spec for a resumed order
2021-03-08 08:54:28 -08:00
Andy Brett
a02065b66f
allow access to payments tab for canceled orders
2021-03-01 19:51:50 -08:00
Matt-Yorkley
d9bd0e8f0e
Use alternate method for setting request.referer in controller specs
...
Apparently stubbing `request.referer` is tricky business in Rails 5... :shrugs:
2021-02-09 11:57:00 +00:00
Andy Brett
903b2e7ff4
whitelist allowed events to be sent to a Payment
2021-01-21 09:18:29 -08:00
Andy Brett
ab5ffead1d
require that the redirect url be to stripe.com and over https
2021-01-21 09:18:29 -08:00
Andy Brett
d76db9ee51
update payment controller spec to move payment to pending
2021-01-21 09:18:29 -08:00
Andy Brett
802e49bed3
add PaymentMailer and send email if payment auth is required
2021-01-21 08:24:01 -08:00
Andy Brett
e866e983f6
add spec for partially refunded SCA orders
2020-12-07 14:51:47 -08:00
Andy Brett
17202ff39c
move gateway_error require to lib/spree/core.rb
2020-11-10 14:55:56 -08:00
Matt-Yorkley
f22c7fcdfb
Merge pull request #6151 from luisramos0/stripe_save_cards
...
Stripe Feature Tests: checkout with saved a card
2020-10-24 23:29:29 +02:00
Luis Ramos
b267f542d1
Merge pull request #5980 from luisramos0/spree_clean_up
...
[Bye bye spree] Some clean up fixes to make it all work without spree
2020-10-20 18:52:54 +01:00
Luis Ramos
f5f9a733fb
Fix rubocop issue, long module, by extracting StripeStubs to a separate helper module
2020-10-16 12:37:42 +01:00
Luis Ramos
d54ddacc05
Merge pull request #5887 from luisramos0/orders
...
[Bye bye Spree] Bring models order, line_item and other related from spree_core
2020-10-15 08:49:05 +01:00
Luis Ramos
ef70c1fc5c
Make helper more flexible and use it in a spec
2020-10-02 19:20:32 +01:00
Luis Ramos
83456f94e3
Simplify test by re-using helper stripe mock
2020-10-02 19:12:56 +01:00
Matt-Yorkley
70bd2161ba
Rename Stripe Connect factory for clarity
2020-09-19 12:55:31 +01:00
Luis Ramos
f81d4596aa
Use correct updater
2020-09-17 14:06:51 +01:00
Luis Ramos
e0cb7a29bf
Add helper prefix to helper calls
2020-09-17 13:58:45 +01:00
Pau Perez
c0f72f89f2
Handle #refund! as we do with #credit!
2020-07-23 20:24:31 +02:00
Pau Perez
0f0a704147
Skip source validation when applying credit
...
The original payment may not be valid because its credit card may be
expired. Stripe gives this as a valid scenario returning a success and
we should do too.
When creating the credit payment we end up validating all sources in
a chain as follows.
```
Payment being persisted -> source payment -> original credit card.
```
The source payment was valid when created (It would not be persisted
otherwise) but its source card may now be expired, and that's legit.
There was also an issue with the `#invalidate_old_payments` callback. It
was causing the original payment to be validated again and thus the
credit payment failed to be persisted due to the original credit card
being expired. Switching this callback to use `#update_column` skips
validations and so we don't validate the source payment. We only care
about the state there, so it should be fine.
2020-07-23 20:24:31 +02:00
Pau Perez
73b1b1f172
DRY specs and fix rubocop failures
2020-07-23 20:24:31 +02:00
Pau Perez
59da07de66
Handle all errors when dealing with payment event
...
This basically catches ActiveRecord::RecordInvalid caused by an invalid
credit record, for instance, but also other situations we haven't
forseen.
2020-07-23 20:24:31 +02:00
Pau Perez
26ed601996
Test the payment controller handles GatewayError
...
After that, we can TDD a second one that also handles validation errors.
2020-07-23 20:24:31 +02:00
Luis Ramos
6555f8bfba
Add specs to cover stripeSCA refunds
...
Duplication between stripe connect and stripeSCA is done on purpose so we can easily delete stripeConnect code when the migration is done
2020-07-01 18:13:27 +01:00
