Gaetan Craig-Riou
3dc7c2bf56
Fix spree product touch supplier
...
Take into account import product scenario, in this case the variant
doesn't have an assigned supplier yet.
2024-07-03 11:21:28 +10:00
Gaetan Craig-Riou
dd8f0aafab
Fix ProductImport::EntryProcessor#count_existing_items
...
Plus spec
2024-07-03 11:21:28 +10:00
Gaetan Craig-Riou
564ea0bd49
Fix enterprise touching when associated record updated
2024-07-03 11:21:28 +10:00
Gaetan Craig-Riou
5884edaa1b
Fix product import system spec
2024-07-03 11:15:10 +10:00
Gaetan Craig-Riou
b891a03468
Fix search by producer, BUU product page
2024-07-03 10:17:49 +10:00
Gaetan Craig-Riou
0c9223809b
Fix with_properties scope to accept any number of arguments
2024-07-03 10:17:49 +10:00
Gaetan Craig-Riou
ef298e3b62
Fix taxon
2024-07-03 10:17:49 +10:00
Gaetan Craig-Riou
054d967323
Fix line items
...
* fix supplier related code
* Fix associations + plus spec
2024-07-03 10:17:49 +10:00
Gaetan Craig-Riou
859f7efd02
Fix Spree:Ability
2024-07-03 10:17:49 +10:00
Gaetan Craig-Riou
d5cc60fd3a
Fix ProductImporter and related Class
2024-07-03 10:17:49 +10:00
Gaetan Craig-Riou
b86d8e1603
Fix product import entry validation
2024-07-03 10:17:49 +10:00
Gaetan Craig-Riou
50bd274715
Fix Enterprise
2024-07-03 10:17:49 +10:00
Gaetan Craig-Riou
d073a181e9
Fix EnterpriseRelationship
2024-07-03 10:17:49 +10:00
Gaetan Craig-Riou
02b9dfb517
Add after update primary taxon call back
...
It updates supplier on primary taxon update. It fixes falling
enterprise caching specs.
2024-07-03 10:17:49 +10:00
Gaetan Craig-Riou
22f4ae115a
Add missing associations and validations specs
2024-07-03 10:17:49 +10:00
Gaetan Craig-Riou
5cb59d941a
Add transient attribute supplier_id to Spree::Product
...
supplier_id transient attribute will be saved on the variant
2024-07-03 10:17:49 +10:00
Gaetan Craig-Riou
7af36510c8
Fix lambda styling
...
It follows Style/Lambda cop :
https://docs.rubocop.org/rubocop/1.60/cops_style.html#stylelambda
2024-07-03 10:17:49 +10:00
Gaetan Craig-Riou
4113880401
Move supplier to variant part 2
...
Variant model and specs
2024-07-03 10:17:49 +10:00
Gaetan Craig-Riou
d1dd563720
Move supplier to variant part 1
2024-07-03 10:17:48 +10:00
David Cook
898ab08bab
Add specs for invalid records
...
It turns out that the duplicator still raises an exception in some cases. Now I think I see why the the controller was catching the exceptions. At least now we know which exceptions to catch.
2024-06-27 11:39:49 +10:00
Ahmed Ejaz
5a259f1b91
Merge branch 'master' into task/11987-remove-SR-from-clone
2024-06-26 16:18:42 +05:00
Ahmed Ejaz
9dd427ab7f
12346 - fix rubocop rails/pluckInWhere errors
2024-06-22 01:54:54 +05:00
Ana Nunes da Silva
d2c6db0d04
Sanitize CustomTab#content
2024-06-20 11:56:09 +02:00
Ahmed Ejaz
349862c72e
11987: fix specs
2024-06-20 13:41:41 +05:00
David Cook
0e0a7d9d3e
Merge pull request #12589 from cyrillefr/FixRailsRedundantActiveRecordAllMethodIssue
...
Fixes Rails/RedundantActiveRecordAllMethod issues
2024-06-20 09:40:56 +10:00
Abdellani
0337464291
update logged message when a product is deleted
2024-06-19 15:15:04 +01:00
cyrillefr
654fda89ca
Fix Rails/RedundantActiveRecordAllMethod issues
...
- Cop: Rails/RedundantActiveRecordAllMethod
- if receiver is an Active Record object, ".all" can be safely removed
- There are 2 allowed receivers that are listed in the
styleguide file (those are defaults cf. cop documentation).
2024-06-19 14:32:21 +02:00
Maikel
8837f1caa2
Revert "Allow negative stock levels for on-demand products"
2024-06-19 15:18:57 +10:00
Filipe
e22bec014b
Merge pull request #12538 from cyrillefr/UpdateAndRecalculateFeesAfterOrderAdjustedInBackend
...
Update and Recalculate Fees after Order Adjusted in Backoffice
2024-06-13 08:53:43 -06:00
Maikel
2f173cb5c2
Merge pull request #12536 from mkllnk/stock-levels
...
Allow negative stock levels for on-demand products
2024-06-13 10:26:01 +10:00
zanetagebka
a2a670c848
Fix cops StringConcatenation
2024-06-11 15:17:32 +10:00
Gaetan Craig-Riou
a84c947d66
Merge pull request #12548 from cyrillefr/RedundantPresenceValidationOnBelongs_part_VII
...
Fix RedundantPresenceValidationOnBelongs on Spree::Order model
2024-06-11 10:37:11 +10:00
Gaetan Craig-Riou
8b31fa1ee5
Merge pull request #12541 from openfoodfoundation/dependabot/bundler/rubocop-1.64.1
...
chore(deps-dev): bump rubocop from 1.63.5 to 1.64.1
2024-06-11 10:30:28 +10:00
Filipe
5872515a35
Merge pull request #12515 from isidzukuri/12503_skip_saving_of_unchanged_products
...
Do not commit to db unchanged products in bulk save
2024-06-05 18:01:59 +02:00
Filipe
f6de15e196
Merge pull request #12518 from anansilva/12448-sanitise-html-product-description
...
Sanitise HTML in product description [read-only]
2024-06-05 11:13:56 +02:00
Maikel Linke
e6ac2f0d88
Style/SuperArguments
...
Call super without arguments and parentheses when the signature is identical.
2024-06-05 09:29:42 +10:00
cyrillefr
87f0be42e2
Fixes rubocop offenses on Spree::Order model
...
- removes old Rails 5 flag to not validating
belongs to association. Therefore optional fields must be marked so.
2024-06-04 18:17:12 +02:00
Filipe
db255b0d61
Merge pull request #12511 from chahmedejaz/task/12398-remove-reflex-from-product-variant-delete
...
Task/12398 remove reflex from product variant delete
2024-06-04 16:03:57 +02:00
Ana Nunes da Silva
5f54ea3877
Add safe trix tags to html sanitizer;
...
Use custom html sanitizer in product description.
2024-06-03 11:45:50 +01:00
Ana Nunes da Silva
a7dc243db9
Sanitize product description using rails default sanitizer
2024-06-03 11:45:49 +01:00
Gaetan Craig-Riou
5326b332ee
Merge pull request #12529 from cyrillefr/RedundantPresenceValidationOnBelongs_part_VI
...
Fix Redundant presence validation on belongs part VI
2024-06-03 12:53:35 +10:00
cyrillefr
073dfc4ab6
Update and Recalculate Fees after Order Adjusted in Backend
...
- when update on adjustment in payment, recalculation of
correct adjustment was not done
- the corresponding spec
- an id to easy the finding of the change of fees in the spec
2024-05-31 16:39:02 +02:00
Maikel Linke
ecbba894f7
Update stock levels of on-demand items
...
We weren't bothering with stock when items were on demand anyway. But we
want to track stock now so that we can backorder more when local stock
levels become negative.
2024-05-31 16:38:24 +10:00
Maikel Linke
d391faac64
Remove validation of positive stock when on demand
...
We weren't allowing negative stock to stop any bug from accidentally
drawing too much stock. But now we want to implement a backordering
logic that depends on negative stock levels to know how much is needed
to replenish stock levels.
2024-05-31 16:37:15 +10:00
Filipe
a01dcaadcf
Merge pull request #12506 from anansilva/12448-sanitise-html-enterprise-group
...
Sanitise HTML in long description of enterprise group [read-only]
2024-05-30 14:07:20 +02:00
Ahmed Ejaz
e932dabacb
12398: fix failing specs
2024-05-30 14:17:57 +05:00
cyrillefr
4bb996e77f
Fix RedundantPresenceValidationOnBelongs on some files (part VI)
...
- presence: true is redundant since Rails 5.0 BUT applies
with new default config of
belongs_to_required_by_default to true.
Lots of files with belongs_to_required_by_default = false
(backward compatibility).
So: deleting this setting implies to adding optional: true
- added 'NOT NULL' constraints so model constraints match
with contraints on DB tables.
- corresponding migration files to match AR Models &
DB tables
- rake tasks to check corrupt data (ie: NULL/nil in id fields)
(previous commit)
- updated the todo
2024-05-29 10:38:18 +02:00
David Cook
f8f0a1bf58
Update comment
...
[skip ci]
2024-05-29 10:55:29 +10:00
David Cook
90c71c6a1a
Remove unused method
2024-05-28 12:00:07 +10:00
David Cook
35c2297d55
Detect changes in price
...
Price is actually an association with lots of custom methods to make it look like a field, and so changes were ignored.
Now this issue is fixed, perhaps it should be moved to a concern..
Note, there are other delegated fields: product name and description may be assigned from the variant. But there's no hooks to save the prroduct, so I didn't include it when checking for changes.
2024-05-28 12:00:04 +10:00
