Mohamed ABDELLANI
d239beb226
remove unnecessary require instructions
2024-01-03 11:34:57 +01:00
Neal Chambers
a363f88f2c
Put Subscriptions back into Schedules Controller
2023-08-24 09:18:35 +09:00
Neal Chambers
134cbb4f04
Add Form Object to Fix Metrics/ClassLength
2023-08-24 09:17:53 +09:00
Neal Chambers
449430cabc
Indent code to be more Readable
2023-06-09 16:39:29 +09:00
Luis Ramos
e52937c113
Use rubocop auto correct to add frozen string literal to all files
...
This is an unsafe auto corection, we will need to trust our build here
2021-06-17 23:07:26 +01:00
Luis Ramos
23627c5453
Run rubocop -a (safe corrections) removing all exceptions so all possible fixes are applied
...
9290 issues fixed
2021-06-17 22:19:26 +01:00
Matt-Yorkley
0da90ab834
Update schedules controller callbacks
2021-03-21 14:06:01 +00:00
Luis Ramos
0fb9f44dda
Make all controllers use new Admin::ResourceController
2020-12-03 15:32:20 -08:00
Matt-Yorkley
91789494b0
Fix error: Unpermitted attribute: order_cycle_ids
2020-08-15 17:03:19 +01:00
Matt-Yorkley
2eda8789d1
Add user id logging to OrderCycle an Schedule PaperTrail entries
2020-08-15 14:49:08 +01:00
Luis Ramos
8a61257547
Rename all before_filter to before_action, it's the same function with a new name
2020-06-22 13:11:57 +01:00
Pau Perez
456f369b76
Fix outstanding Rubocop violations
2020-06-15 10:17:34 +02:00
Pau Perez
538c53fe9e
Improve code readability
...
Also removing an useless vars
2020-05-29 15:56:05 +02:00
Pau Perez
032dce1a88
Move OC save within success block
...
This makes more evident there are two scenarios: schedule save success
or failure. We deal with OCs failures raising an exception.
2020-05-29 10:46:29 +02:00
Pau Perez
768568c75c
Rename @object to @schedule
...
This level of abstraction makes sense in the framework-like code in
ResourceController but here it just makes things more difficult.
2020-05-29 10:44:43 +02:00
Pau Perez
4f3d01bd93
Remove unused HTML response format
2020-05-29 10:43:16 +02:00
Pau Perez
56b590a6f8
Extract #sync_subscription
...
This makes it far easier to spot what's the difference between create
and update regarding subs syncing without having to mess with `#update`
and its callbacks (for now).
2020-05-29 10:41:42 +02:00
Pau Perez
65c53df2ef
Remove unnecessary callback invocations
...
There are no registered callback methods to execute.
2020-05-29 10:25:38 +02:00
Pau Perez
f25ee8c998
Extract #editable_order_cycles
...
This makes it far easier to spot what's the difference between create
and update regarding the editable order cycles.
I stop here before a slightly deeper refactor which would make the PR
quite hard to review. This will come an upcoming one.
2020-05-29 10:25:37 +02:00
Pau Perez
4f635339e3
Fix schedule creation and subs syncing
2020-05-29 10:24:42 +02:00
Pau Perez
9a29e634fc
Deal with Schedule creation in its own controller
...
This way it can assign the order cycles to the schedule when this is
persisted. An OrderCycleSchedule (the join table) can't be created until
both schedule and order_cycle got an id.
Also, we do not call `#adapt_params` when creating the Schedule as that
assigns `order_cycle_ids` to `@object.attributes` thus, attempting to
create the OrderCycleSchedule without a schedule_id.
2020-05-28 17:49:36 +02:00
Luis Ramos
839b373b5c
Merge branch 'master' into 3-0-stable-Apr28
2020-04-28 13:40:19 +01:00
Luis Ramos
4e43535512
Add missing permitted attribute
2020-03-21 20:30:34 +00:00
Luis Ramos
5a0319213f
Fix schedules controller permitted attributes
2020-03-21 20:30:34 +00:00
Luis Ramos
8c5dfea92f
Fix strong params in order_cycles and schedules controllers
2020-03-21 20:30:34 +00:00
Luis Ramos
b99d4ab627
Permit specific params in schedules controller
2020-03-21 20:30:34 +00:00
Luis Ramos
ae0ceb61a1
Move ProxyOrderSyncer to OrderManagement engine
2020-03-16 17:20:01 +00:00
Luis Ramos
014e22a7ad
Fix problem with misssing params in schedules controller and adapt its spec
2020-03-09 16:04:59 +00:00
luisramos0
9404aacfb2
run rubocop --auto-correct
2019-11-10 18:42:43 +00:00
luisramos0
e66dea7e03
Improve query in filter_schedules_by_enterprise_id. Makes join to OCs explicity.
2019-07-05 10:37:27 +01:00
luisramos0
8b0296eae6
Use a single query to get filter_schedules_by_enterprise_id
2019-06-26 11:38:03 +01:00
luisramos0
9c539da811
Fix rubocop issue in schedules_controller.collection by extracting method
2019-06-11 21:28:55 +01:00
luisramos0
6cf705ea55
In the order cycle pages (both create and edit, both simple and normal), add OC coordinator to schedules request to the server and make the controller filter schedules of order cycles coordinated by that enterprise id.
2019-06-11 21:28:52 +01:00
Rob Harrington
a83bdf16c9
Add error message for case when schedule cannot be deleted
2018-04-04 09:21:52 +10:00
Rob Harrington
672f96b85b
Replace references to 'standing order' with 'subscription'
2018-02-09 14:44:13 +11:00
Rob Harrington
c5f3249172
Fix rubocop issues
2018-02-09 14:44:12 +11:00
Rob Harrington
84ad996ef8
Use guard clauses
2018-02-09 14:44:07 +11:00
Rob Harrington
03f1980b1b
Auto-correct rubocop offences for standing-orders
2018-02-09 14:44:07 +11:00
Rob Harrington
d6a9d63de5
Replace StandingOrderSyncJob with ProxyOrderSyncer service object
2018-02-09 14:44:06 +11:00
Rob Harrington
0a74bb8373
Running StandingOrderSyncJob when order cycles added to a schedule via SchedulesController
2018-02-09 14:43:53 +11:00
Rob Harrington
2a1ca1c206
Using angular-ui sortable instead of pure jQuery, refactoring logic around including blanks in select2s
2018-02-09 14:43:28 +11:00
Rob Harrington
357040f67a
Enterprise User can create and update schedules via OC index
2018-02-09 14:43:28 +11:00
Rob Harrington
920f52e112
Adding schedules to Order Cycles interface
2018-02-09 14:43:28 +11:00
