raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-02-09 23:06:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

Extract #sync_subscription

Browse Source 
This makes it far easier to spot what's the difference between create
and update regarding subs syncing without having to mess with `#update`
and its callbacks (for now).
This commit is contained in:
Pau Perez
2020-05-29 10:41:17 +02:00
parent 65c53df2ef
commit 56b590a6f8
1 changed files with 7 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
app/controllers/admin/schedules_controller.rb
View File

@@ -7,7 +7,7 @@ module Admin
before_filter :check_editable_order_cycle_ids_create, only: [:create]
before_filter :check_editable_order_cycle_ids_update, only: [:update]
before_filter :check_dependent_subscriptions, only: [:destroy]
update.after :sync_subscriptions
update.after :sync_subscriptions_update
respond_to :json
@@ -125,21 +125,19 @@ module Admin
@permissions = OpenFoodNetwork::Permissions.new(spree_current_user)
end
def sync_subscriptions
def sync_subscriptions_update
return unless params[:schedule][:order_cycle_ids]
removed_ids = @existing_order_cycle_ids - @schedule.order_cycle_ids
new_ids = @schedule.order_cycle_ids - @existing_order_cycle_ids
return unless removed_ids.any? || new_ids.any?
subscriptions = Subscription.where(schedule_id: @schedule)
syncer = OrderManagement::Subscriptions::ProxyOrderSyncer.new(subscriptions)
syncer.sync!
sync_subscriptions
end
def sync_subscriptions_create
return unless params[:order_cycle_ids]
sync_subscriptions
end
def sync_subscriptions
removed_ids = @existing_order_cycle_ids - @schedule.order_cycle_ids
new_ids = @schedule.order_cycle_ids - @existing_order_cycle_ids
return unless removed_ids.any? || new_ids.any?