Maikel Linke
cccd35fdf3
Remove retries from previously flaky specs
...
It's not acceptable to have flaky specs that only pass once in three
tries. Our specs might be more stable now that we use Chrome as test
browser. Otherwise we have to find out why these specs are not stable.
It might be an important bug that happens only sometimes.
2019-06-19 16:48:04 +10:00
Luis Ramos
b1d4461c77
Merge pull request #3936 from luisramos0/factories_refactor
...
Extract factories to separate files and fix rubocop issues
2019-06-14 22:28:55 +01:00
Pau Pérez Fabregat
45c77196b3
Merge pull request #3935 from mkllnk/update-rubocop-style
...
Update rubocop style
2019-06-14 19:52:22 +02:00
luisramos0
13d41dc1aa
Remove duplicate modify entry in factories
2019-06-14 13:59:24 +01:00
luisramos0
3259db69f0
Remove unnecessary code, this code as been accepted in spree code base and included in spree v1.2
2019-06-14 13:43:30 +01:00
luisramos0
6efb71d903
Fix more rubocop issues in spec/factories
2019-06-14 13:42:27 +01:00
Luis Ramos
91401446a5
Merge pull request #3915 from mkllnk/3844-permalink-conflicts
...
Consider deleted products when creating permalinks
2019-06-14 13:20:35 +01:00
luisramos0
59593c824a
Fix rubocop issues in different factories
2019-06-14 13:10:53 +01:00
luisramos0
79cf03b124
Fix rubocop issues in spec/factories
2019-06-14 13:01:08 +01:00
luisramos0
a6b3c26bbe
Extract users factories to separate file
2019-06-14 12:50:26 +01:00
luisramos0
8345765ada
Extract tag rules factories to separate file
2019-06-14 12:49:17 +01:00
luisramos0
03fb33ba86
Extract variant factory modify to separate file
2019-06-14 12:48:04 +01:00
luisramos0
2c8ce6e4e5
Extract products factories to separate file
2019-06-14 12:45:55 +01:00
luisramos0
3e10c703bf
Extract shipments factories to separate file
2019-06-14 12:43:07 +01:00
luisramos0
42f8b2efed
Fix static file path in order_cycle_factory
2019-06-14 12:30:36 +01:00
luisramos0
bd493c392a
Extract shipping_methods factories to separate file
2019-06-14 12:25:10 +01:00
luisramos0
dc701f55b3
Extract calculators factories to separate file
2019-06-14 12:23:32 +01:00
luisramos0
06e3328ce2
Extract orders factories to separate file
2019-06-14 12:17:24 +01:00
luisramos0
91fcb7c7c4
Extract enterprises factories to separate file
2019-06-14 12:12:45 +01:00
luisramos0
42f2e78b10
Extract subscriptions factories to separate file
2019-06-14 12:10:54 +01:00
luisramos0
0501859c23
Extract order_cycle factories to separate file
2019-06-14 12:10:27 +01:00
Maikel Linke
ac79e44d9a
Fix current rubocop violations
2019-06-14 11:40:09 +10:00
Luis Ramos
e15ccdbd74
Merge pull request #3840 from mkllnk/3727-default-credit-cards
...
Make only reusable credit cards the default card
2019-06-13 14:13:32 +01:00
Luis Ramos
1a2703f630
Merge pull request #3886 from luisramos0/fees_translations
...
Make a few more things translatable in the Enterprise Fees management page
2019-06-13 14:12:16 +01:00
Luis Ramos
09a5426095
Merge pull request #3880 from kristinalim/fix/3792-optimize_order_cycle_variant_updates
...
3792 Optimize saving Order Cycle changes
2019-06-13 12:33:22 +01:00
Luis Ramos
bb7a2d7a5e
Merge pull request #3252 from mllocs/fix/navbar-right-items-styles
...
Top navbar redesign and cleanup
2019-06-13 12:04:20 +01:00
Pau Pérez Fabregat
fd95ae7e41
Merge pull request #3847 from Matt-Yorkley/api_access
...
Allow unauthenticated access to OFN API endpoints
2019-06-12 09:45:11 +02:00
Maikel Linke
5c72c35060
Use better credit card factory for subs specs
...
The specs for subscriptions were creating simple one-time-use credit
cards. They should not be used for subscriptions. After this was fixed
in previous commits, these integration tests failed. Now we use a new
factory that mimics stored credit cards that can be used for
subscriptions.
2019-06-11 18:01:41 +01:00
Maikel Linke
b3b8cb778f
Make only reusable credit cards the default card
...
https://github.com/openfoodfoundation/openfoodnetwork/issues/3727
When a user didn't have a default credit card and then checked out with
a credit card it became the default even when the user didn't intend to
store it. That lead to subscriptions trying to charge a one-time card
which fails.
2019-06-11 18:01:41 +01:00
Maikel Linke
a10bb5acbd
Consider deleted products when creating permalinks
...
https://github.com/openfoodfoundation/openfoodnetwork/issues/3844
Spree's implementation and our implementation to create a unique
permalink failed to notice conflicts with soft-deleted products. This
patch looks at deleted products as well.
2019-06-11 18:20:41 +10:00
Luis Ramos
568e3003ba
Merge pull request #3882 from kristinalim/feature/3408-enable_enterprise_fee_summary_for_non_superadmin
...
3408 Remove feature flag for Enterprise Fee Summary
2019-06-06 16:28:36 +01:00
luisramos0
1d4529092f
Make fee type options in enterprise fees page translatable
2019-05-30 00:46:20 +01:00
luisramos0
c5a95dee79
Remove matching of product shipping category with shipping method's category to allow users to checkout products with categories not supported by the shipping methods.
...
See issue #3884 for more details.
2019-05-29 14:43:19 +01:00
Matt-Yorkley
c0a40c616b
Use devise's check_authorization and skip_authorization_check
2019-05-28 22:02:18 +01:00
Kristina Lim
ecea0600b6
Remove feature flag for Enterprise Fee Summary
2019-05-29 02:50:41 +08:00
luisramos0
79f16e0ea3
Run transpec in spec/features/consumer/external_services_spec.rb
2019-05-28 17:04:06 +01:00
luisramos0
7397ab4fd8
Run transpec in spec/features/admin/payment_method_spec.rb
2019-05-28 17:04:06 +01:00
luisramos0
ec7e92202b
Run transpec in spec/features/admin/enterprise_user_spec.rb and spec/features/admin/overview_spec.rb
2019-05-28 17:04:06 +01:00
luisramos0
9a21ca38e1
Run transpec in a few more spec/features/admin specs
2019-05-28 17:04:06 +01:00
luisramos0
d2f62f86a9
Run transpec in a few spec/features/admin specs
2019-05-28 16:59:51 +01:00
luisramos0
80537e7e01
Run transpec in spec/features/admin/image_settings_spec.rb
2019-05-28 16:57:11 +01:00
luisramos0
7f43a66fb3
Run transpec in spec/features/admin/adjustments_spec
2019-05-28 16:57:11 +01:00
Kristina Lim
99f163d294
Make code style changes for spec file
2019-05-28 21:32:25 +08:00
Kristina Lim
ea8d189d6c
Bulk update OC variant changes in OC form
2019-05-28 21:27:43 +08:00
Kristina Lim
bc6f14105e
Require spec_helper.rb in spec file for OC form applicator
2019-05-28 21:26:33 +08:00
luisramos0
07854cf372
Fix a few problems introduced by rubocop auto correct
2019-05-28 12:57:29 +01:00
luisramos0
86b0d71c7e
Result of rubocop auto-correct and rebuilding rubocop_manual_todo
2019-05-28 12:57:29 +01:00
Pau Pérez Fabregat
2d3bd7f471
Merge pull request #3828 from eelcodevlieger/webdrivers
...
Webdrivers
2019-05-27 11:20:04 +02:00
luisramos0
4143c50b1f
Move joyride translations to the correct path
2019-05-24 23:54:00 +01:00
luisramos0
2654db7c82
Add new menu style as per design
2019-05-24 23:53:56 +01:00
