Matt-Yorkley
1a744de37a
Improve voucher #calculate tests
2023-06-14 10:19:30 +01:00
Matt-Yorkley
93df70c0a7
Use order total excluding discounts in voucher calculations
2023-06-14 10:19:30 +01:00
Matt-Yorkley
11382a518e
Fix test setup in BOM spec
2023-06-14 10:19:30 +01:00
Matt-Yorkley
ef09492883
Update adjustment spec to use orders past delivery state
2023-06-14 10:19:30 +01:00
Matt-Yorkley
837e581c29
Reload order after cancelling it in tests that check shipment states
2023-06-14 10:19:30 +01:00
Matt-Yorkley
a0d0f8fd2f
Tidy up checkout tax spec
2023-06-14 10:19:30 +01:00
Maikel Linke
c2605b2606
Display loading spinner before quick reports
...
We had a race condition that could first display the report and then
replace it again with the "loading" spinner. That doesn't seem to happen
now that we changed the order of cable events.
2023-06-14 15:40:52 +10:00
Maikel Linke
ed231ec512
Update belongs_to default in Customer model
2023-06-14 15:08:05 +10:00
Maikel Linke
fc00a48d67
Require associations of CoordinatorFee
2023-06-14 15:08:05 +10:00
Maikel Linke
c02c90317f
Require user of column preference record
...
It doesn't make sense to have a preference without a user. And it was
already enforced in the database.
2023-06-14 15:07:43 +10:00
Maikel Linke
2d4cfd7548
Validate and enforce AdjustmentMetadata associations
2023-06-14 15:07:43 +10:00
Maikel
989a88e252
Merge pull request #10848 from mkllnk/totals-report
...
Fix error on summarising total_units in Order Cycle Supplier Totals report
2023-06-14 13:59:48 +10:00
Matt-Yorkley
074eb4b592
Move tax charge logic out of checkout controller and update payment transition
2023-06-13 17:53:46 +01:00
Matt-Yorkley
5fa81d1333
Fix invalid test setup in old tax tests
2023-06-13 14:58:16 +01:00
Matt-Yorkley
4e7fab6914
Delete dead code Checkout#find_transition
...
This method is only called from tests and nowhere else in the codebase. We may as well remove it.
2023-06-13 14:58:16 +01:00
Matt-Yorkley
8d633234f4
Set voucher specs to pending temporarily
2023-06-13 14:58:16 +01:00
Matt-Yorkley
d5a625bdeb
Fix Paypal spec
2023-06-13 14:58:16 +01:00
Matt-Yorkley
0e289a23c1
Set some legacy checkout specs that we might want to rewrite later to pending
2023-06-13 14:58:16 +01:00
Matt-Yorkley
5487aa19fc
Fix missing checkout_state_path
2023-06-13 14:58:16 +01:00
Mohamed ABDELLANI
345f540723
fix spec/models/spree/tax_rate_spec.rb
2023-06-13 14:58:16 +01:00
Mohamed ABDELLANI
78617905c6
remove spec/requests/checkout/concurrency_spec.rb
2023-06-13 14:58:16 +01:00
Mohamed ABDELLANI
56204b2315
fix ./spec/routing/stripe_spec.rb
2023-06-13 14:58:16 +01:00
Mohamed ABDELLANI
905187f3ce
fix ./spec/services/order_tax_adjustments_fetcher_spec.rb:100
2023-06-13 14:58:16 +01:00
Mohamed ABDELLANI
7e84579aa3
spec/system/consumer/shopping/checkout_stripe_spec
...
these tests are using the legacy checkout
2023-06-13 14:58:16 +01:00
Mohamed ABDELLANI
bd0e7cdfc8
remove legacy checkout tests
2023-06-13 14:58:16 +01:00
Mohamed ABDELLANI
c2aaf88e98
remove checkout controller
2023-06-13 14:58:16 +01:00
Matt-Yorkley
93c3241bb5
Add more test coverage in stripe controller spec
2023-06-13 10:14:09 +01:00
Matt-Yorkley
47df9493ae
Fix ProcessPaymentIntent service
2023-06-13 10:14:09 +01:00
Konrad
48c107bde1
Merge pull request #10974 from cillian/ignore-whitespace-in-product-import
...
Ignore leading and trailing whitespace when importing products via a spreadsheet
2023-06-12 16:32:15 +02:00
Sigmund Petersen
c2305615a6
Merge pull request #10971 from filipefurtad0/mouse_hover_spec
...
Adds spec for tooltips on orders page
2023-06-12 09:53:16 +02:00
Gaetan Craig-Riou
41b3ddae08
Merge pull request #10714 from macanudo527/fix_linelength
...
Fix Style/LineLength
2023-06-12 09:53:23 +10:00
Konrad
fc09f95fa1
Merge pull request #10961 from jibees/10946-white-label-trix-editor-changes-on-the-custom-tab-content-do-not-trigger-the-update-button
...
[WhiteLabel] Make update button active when changing custom tab content
2023-06-09 21:46:02 +02:00
Konrad
13037d2d9d
Merge pull request #10949 from jibees/10630-buu-as-an-enterprise-user-i-can-see-the-back-office-with-new-brand-colours
...
[`admin_style_v3`] As an enterprise user i can see the back office with new brand colours
2023-06-09 21:24:01 +02:00
Konrad
d0f4c44add
Merge pull request #10938 from jibees/10931-white-label-custom-tab-without-a-title-impossible-to-disable-the-custom-tab
...
[White Label] Validate the presence of a custom tab title before creating it (+ max 20 characters length)
2023-06-09 19:01:13 +02:00
Cillian O'Ruanaidh
5cde4de512
Ignore leading and trailing whitespace in spreadsheet when importing products
2023-06-09 16:23:18 +01:00
Konrad
502b5e8664
Merge pull request #10937 from jibees/10900-white-label-remove-ofn-navigation-for-small-width-screens
...
[White Label] Remove ofn navigation for small width screens as well when option is activated
2023-06-09 16:28:22 +02:00
filipefurtad0
24913476ac
Adds spec for tooltips on orders page
2023-06-09 11:23:42 +01:00
Neal Chambers
449430cabc
Indent code to be more Readable
2023-06-09 16:39:29 +09:00
Maikel Linke
ec865627d2
Wait for page setup to avoid flaky spec
...
I'm hiding a real bug here. There's a race condition when the cable event of
the finished report is sent before the loading spinner rendered. The
spinner then overwrites the report again. I added a spec for that but
don't have a solution yet.
I also noticed that the loading spinner is not displayed in testing but
we can assert on the CSS class of the container.
2023-06-09 16:22:01 +10:00
Jean-Baptiste Bellet
74fd1814e4
Create a trixeditor controller and broadcast a change event on form
...
Therefore, AngularJS can set form as dirty
+ add associated spec
2023-06-09 08:03:17 +02:00
Maikel Linke
828b2f6f44
Replace too long list of arguments with keywords
...
Rubocop was complaining about too many arguments. But
`ApplicationJob#perform` needs all arguments handled in one call. While
we could allow the `perform` method generally to have more arguments,
there could be other methods called `perform` which should still be
scrutinised. Instead, it seems acceptable to me to have more arguments
as long as they are clearly named as keyword arguments. Rails uses this
a lot to document all options including their default values, for
example in Active Storage. It's better then bundling several arguments
in an undocumented hash just to reduce the number of given arguments.
And once we upgraded to Ruby 3.1, we can clean the method calls up as
well. `call(user: user)` becomes `call(user:)` without repetition.
2023-06-09 14:44:54 +10:00
Matt-Yorkley
7caf4b03d4
Improve flakyness on report specs
2023-06-09 14:44:53 +10:00
Matt-Yorkley
b230b37284
Update report email spec
2023-06-09 14:44:53 +10:00
Maikel Linke
6803e0a8f9
Fix error on summarising total_units
2023-06-09 09:55:33 +10:00
Maikel Linke
71e4d2c6ed
Spec total_units report column
...
Current reports don't deal with invalid legacy data.
2023-06-09 09:55:33 +10:00
Maikel Linke
00e171a8f1
Reduce indentation in report spec
...
Specs should also test from the outside instead of declaring modules and
test from within those modules.
2023-06-09 09:55:33 +10:00
Filipe
ca03e1596b
Merge pull request #10952 from Matt-Yorkley/full-name
...
Improve nil-safety in variant naming methods
2023-06-08 16:26:28 +01:00
Matt-Yorkley
f4261b85b8
Merge pull request #10940 from Matt-Yorkley/order-tidyup
...
Order class tidyup
2023-06-08 15:06:59 +01:00
Filipe
7974e1eaa6
Merge pull request #10936 from abdellani/fix-order-progressing-automatically-on-BOO
...
fix Viewing an order in state "confirmation" changes the state to "complete"
2023-06-08 14:50:04 +01:00
Jean-Baptiste Bellet
d1d050e6a4
Limit size to 20 char for the custom tab title
2023-06-08 11:27:07 +02:00
