zanetagebka
a2a670c848
Fix cops StringConcatenation
2024-06-11 15:17:32 +10:00
Gaetan Craig-Riou
8b31fa1ee5
Merge pull request #12541 from openfoodfoundation/dependabot/bundler/rubocop-1.64.1
...
chore(deps-dev): bump rubocop from 1.63.5 to 1.64.1
2024-06-11 10:30:28 +10:00
Maikel Linke
d9f013abbc
Style/SendWithLiteralMethodName
...
Use method call directly instead of `public_send` with fixed argument.
The cop is declared unsafe. I think that is because it can also replace
`send` but we replace only `public_send` here.
2024-06-05 09:38:21 +10:00
Maikel Linke
e6ac2f0d88
Style/SuperArguments
...
Call super without arguments and parentheses when the signature is identical.
2024-06-05 09:29:42 +10:00
Ahmed Ejaz
ce60a2a1e0
12398: add lazylookup for translations
2024-05-30 14:44:34 +05:00
Ahmed Ejaz
c2fa993432
12398: fix lint issues
2024-05-30 14:24:51 +05:00
Ahmed Ejaz
8ee833d2d8
12398: add flash.now
2024-05-29 01:19:50 +05:00
Ahmed Ejaz
fb07794cf3
12398: add slide-out animation
2024-05-28 01:10:30 +05:00
Ahmed Ejaz
a0f290c09f
12398: add turbo stream to delete variants
2024-05-24 02:41:51 +05:00
Ahmed Ejaz
2bdf8e2853
rename destroy.turbo_stream to make it more generic
2024-05-24 02:40:34 +05:00
Ahmed Ejaz
039b0d80ee
12398: implement the destroy action for products
2024-05-24 01:55:21 +05:00
Ahmed Ejaz
53fb77eb23
12398: add destroy action with turbo stream
2024-05-24 01:16:14 +05:00
Filipe
88baf5e1de
Merge pull request #12496 from isidzukuri/12355-remove-unused-discourse
...
[12355] Remove discourse
2024-05-23 19:28:02 +01:00
Filipe
5455e68620
Merge pull request #12504 from dacook/buu/edit-image-turbo-12399
...
[BUU] Remove StimulusReflex from Image Edit
2024-05-23 17:32:59 +01:00
David Cook
665273ce2f
[wip] Attempt to update edited image in-place with Turbo Stream
...
but it doesn't quite work.
Maybe we can force it with JS (https://www.writesoftwarewell.com/process-turbo-stream-javascript/ )
2024-05-23 11:55:29 +10:00
Maikel
32eb9c5504
Merge pull request #12481 from mkllnk/connect-app-once
...
Avoid submitting duplicate Connected Apps
2024-05-23 08:50:34 +10:00
David Cook
536b5608ab
Show edit form for new images
2024-05-22 17:08:58 +10:00
isidzukuri
621a95e913
Remove discourse
2024-05-21 09:02:45 +03:00
David Cook
a9bf25244e
Merge pull request #12457 from abdellani/12452-log-who-deleted-products
2024-05-20 10:37:32 +10:00
Mohamed ABDELLANI
8ccb59a9ab
included LogDestroyPerformer on product model
2024-05-17 15:42:39 +01:00
Maikel Linke
45c164d5ae
Avoid submitting duplicate connected apps
...
Simple Rails forms prevent double-clicking on submit already. Converting
the StimulusReflex interaction to a simple form submit to a controller
solves the race condition.
The UX is slightly worse because the whole page is reloaded instead
rendering only the connected app panel. But we can solve that when we
add more apps and want to activate them independently. By then, we may
have good patterns for working with Turbo.
Technically, the new buttons are a form within a form which is invalid
HTML, but it works.
2024-05-15 17:14:52 +10:00
Ahmed Ejaz
86f88792c2
11058: add sortable products by name
2024-05-08 12:56:41 +05:00
Ahmed Ejaz
da34e7b780
11060 - fix undefined method tax_category_options error in specs
2024-05-07 14:59:14 +02:00
Ahmed Ejaz
b577a81f48
11060 - add tax category field
2024-05-07 14:59:14 +02:00
Mohamed ABDELLANI
7aad4ad652
Merge branch 'master' into prevent-generate-invoices-when-distributor-cannot-invoice
2024-04-22 10:55:39 +01:00
David Cook
f17b0d176b
Enable Turbo Drive on products page
...
Forms now load without a full page rebuild.
This is not really faster, but a bit smoother because it avoids a full page render in the browser. The default Turbo loading indicator is shown (blue line at top).
But the bulk_update form breaks... hmm
On to the next level!
2024-04-17 15:17:59 +10:00
David Cook
72ce3a01a9
Ensure search terms and filters are retained when saving
2024-04-17 15:17:59 +10:00
Konrad
31c1eee593
Merge pull request #11958 from filipefurtad0/adds_missing_keys_from_i18n_tasks_output
...
Adds missing keys from i18n tasks output
2024-04-16 13:14:29 +02:00
David Cook
2adb69edb0
Merge pull request #12334 from dacook/buu/optimise
...
[BUU] Optimisation
2024-04-16 09:53:53 +10:00
filipefurtad0
b1e10f3dd4
Replaces missing by existing key
...
I'm not sure how to trigger this error, and triggering an update error message seems appropriate too - it's sort of an edge case, perhaps this is a valid approach
2024-04-15 15:05:53 +01:00
Maikel
082b1f9411
Merge pull request #12300 from mkllnk/checkout-steps
...
Remove unnecessary method checkout_steps
2024-04-11 15:57:45 +10:00
David Cook
3318c2622d
Merge pull request #12352 from cyrillefr/FixRailsWhereEquals
...
Fix rubocop FixRailsWhereEquals
2024-04-11 11:43:03 +10:00
David Cook
32b33de707
Optimise by pre-loading required columns
...
Oh boy, that's a big change.
2024-04-11 10:31:23 +10:00
Ahmed Ejaz
ec61cff387
12332 - Fix rubocop Rails/I18nLocaleTexts errors
...
- Add en locales for the hardcodded strings
2024-04-11 10:14:50 +10:00
David Cook
1425d524b9
Fix product filtering
...
Merges change from fb09a7f1e6
2024-04-10 15:17:56 +01:00
David Cook
54d0dfb141
Prevent duplicate products in search results
...
Dunno why, but the product was appearing once for each variant.
2024-04-10 15:17:56 +01:00
David Cook
fd8be37a62
Use shared page controls on products screen
...
This has an auto submit and can potentially work with Turbo, like on the Orders screen.
2024-04-10 15:17:56 +01:00
David Cook
0fc3d39106
Ensure pagination is retained when saving or discarding
...
But we have more work to do.
2024-04-10 15:17:56 +01:00
David Cook
8696e05e66
Move index and bulk_update actions to good ol' HTTP requests
...
We've found that we just can't rely in StimulusReflex (and the underlying WebSockets stack) to guarantee a response to a request.
Because of this, there was intermittent issues when the server was overloaded with large requests, and the response never arrived, leaving an infinite loader, and a poor user wondering if anything was still happening.
2024-04-10 15:17:56 +01:00
cyrillefr
404fcf1f72
Fix FixRailsWhereEquals
...
- fixes offenses caused by RuboCop::Cop::Rails::WhereEquals cop
2024-04-09 10:44:02 +02:00
cyrillefr
84747ea064
Fix Rails::NegateInclude issues
...
- cop class: RuboCop::Cop::Rails::NegateInclude
- replaced !array.include?(2) by array.exclude?(2)
2024-04-04 14:42:42 +02:00
Matt-Yorkley
78495d0ace
Drop unnecessary params filtering
2024-04-02 09:27:37 +11:00
Maikel
4c1268b3ce
Merge pull request #12274 from mkllnk/dfc-product-import
...
Import products from DFC catalog
2024-03-22 09:25:02 +11:00
Maikel Linke
54738fc552
Remove unnecessary method checkout_steps
...
It allowed introspection of a dynamic state machine. But the only two
usages of this method only referred to the first state which is always
the same. Our complicated checkout logic needs more clarity and
introducing some hardcoded state names here can only help.
2024-03-21 13:43:54 +11:00
Anthony Musyoki
25e3f30f97
Fix Rubocop Rails issue: Rails/FindEach
2024-03-20 15:34:30 +03:00
Konrad
214f7ec23c
Merge pull request #12229 from cyrillefr/Decreasing-the-quantity-of-an-item-does-not-update-enterprise-fees-per-item
...
[BO Orders] Update Entreprise fees when decreasing quantity
2024-03-20 11:53:06 +01:00
Feruz Oripov
9d919938f3
Group Order && OrderCycle related services and specs
2024-03-16 19:07:08 +05:00
Maikel Linke
3af7fa7521
Offer nice select box for enterprise id
2024-03-15 16:46:41 +11:00
Maikel Linke
1c09b5d16c
Move DFC API request logic to service object
...
I'm planning to add more to it.
2024-03-15 16:46:41 +11:00
Maikel Linke
d6da52929f
Allow local DFC import in development
2024-03-15 16:46:41 +11:00
