David Cook
c86f7f9d50
Remove comments
2024-07-11 10:58:57 +10:00
filipefurtad0
5e933af079
Prepares spec for admin_style_v3 - replaces TODO (1)
2024-07-11 10:58:57 +10:00
filipefurtad0
f7c47fecc4
Removes the need for using overlapping_elements_helper
...
Improves the specs so we don't need to recurr to overlapping elements clicks, and removes the respective helper
2024-07-11 10:58:57 +10:00
filipefurtad0
7d1cb0c957
Sets up enterprise with payment and shipping methods
...
So that the warning does not need to be dismissed - which is not what we wish to test here
2024-07-11 10:58:57 +10:00
filipefurtad0
7f6780b5e9
Simplifies specs, by replacing selector declaration with click_button
2024-07-11 10:58:57 +10:00
filipefurtad0
dfcd9391d9
Prepares smoke_tests_spec for admin_style_v3
...
Enables admin_style_v3 for smoke_tests_spec
2024-07-11 10:58:57 +10:00
filipefurtad0
6dd4bb3e3b
Removes test case around shipped product
...
This is already covered on the v3 version of the spec, under ./spec/system/admin/products_v3/products_spec.rb:452
2024-07-11 10:58:57 +10:00
David Cook
cda2408c69
Merge pull request #12661 from chahmedejaz/task/12497-reorganize-products_v3_specs
...
[BUU] Re-Organize products_v3 Feature specs
2024-07-11 10:55:52 +10:00
Maikel
eb22bff908
Merge pull request #12647 from cyrillefr/FixRailsSkipsModelValidations
...
Fixes Rails/SkipsModelValidations offenses
2024-07-11 09:12:26 +10:00
Ahmed Ejaz
9281cd1a62
12497 - add create spec
2024-07-11 02:04:08 +05:00
Ahmed Ejaz
b99d985b75
12497 - add actions spec
2024-07-11 02:04:08 +05:00
Konrad
ecfa47cd78
Merge pull request #12574 from rioug/refactor-products-renderer
...
[Product Refactor] Refactor products renderer
2024-07-10 17:59:38 +02:00
Gaetan Craig-Riou
686fe8c028
Per review, remove flag argument from products_relation
...
products_relation is now split in two, products_relation and
products_relation_incl_supplier_properties.
It avoids using a flag argument which is not a a good practice see:
https://martinfowler.com/bliki/FlagArgument.html
2024-07-10 13:19:08 +10:00
Konrad
d60d29b685
Merge pull request #12634 from chahmedejaz/bugfix/12632-voucher-field-focus-issue
...
Fix Voucher Code Field Focus Issue
2024-07-08 12:19:19 +02:00
Gaetan Craig-Riou
c372bf746a
Refactor ProductRenderer
...
The sorting logic has been moved to
OrderCycles::DistributedProductsService#product_relations
Plus hopefully fix the spec flackiness
2024-07-08 10:35:57 +10:00
Gaetan Craig-Riou
79a22aefc3
Refactor #products_relation
...
Due to primary_taxon and supplier having moved to the variant, filtering
by_producer and by_category with a custom order involves some
complicated sql queries. So we moved the sorting logic from
ProductsRenderer to OrderCycles::DistributedProductsService so we can
keep the complicated SQL logic contained in one place
2024-07-08 10:35:57 +10:00
Gaetan Craig-Riou
17fe492bf4
Fix typo
2024-07-08 10:35:57 +10:00
cyrillefr
ce8a2b3251
Fixes Rails/SkipsModelValidations offenses
...
- increments! & decrement! skip validations
- replaced increment! method calls
- one call was for a redefined increment! method
- the other for a regular(ActiveRecord::Persistence)
- removes increments/decrements definition now useless
2024-07-05 16:35:40 +02:00
Maikel Linke
d602482d91
Fix report spec referencing distributor
2024-07-05 12:08:33 +10:00
Maikel Linke
b131c352a9
Spec backup polling of rendered invoice file
2024-07-05 09:36:50 +10:00
Rachel Arnould
2c41d065df
Merge pull request #12594 from dacook/12559-fix-orders-and-distributors-report
...
Hide customer data on orders_and_distributors report
2024-07-03 13:12:42 +02:00
Gaetan Craig-Riou
cfc51f399f
More rebase fix
2024-07-03 13:07:17 +10:00
Gaetan Craig-Riou
dfe56c1eed
Fix flacky spec
...
In practise we shouldn't have product with mutiple variant with
different supplier, so I think it's fine to not test it.
2024-07-03 11:23:02 +10:00
Gaetan Craig-Riou
1ead9208ee
Fix rebase issue
...
Fix test by creating a variant instead of relying on some random data
from the database.
2024-07-03 11:23:02 +10:00
Gaetan Craig-Riou
f60a79437e
Reworked the test to use variant factory
...
Creating a variant actually create an extra one via the associated
product, as it will create a "standard variant".
As far as I can see there is no way around it, but it should be fixed
once the Product refactor is finished, and product becomes product
group.
Added a comment on the variant factory to explain the problem.
It's not ideal as it will slow down the test suite a little, but I think
it's better to write the code the way you would expect it, and it will
eventually get fixed.
2024-07-03 11:23:02 +10:00
Gaetan Craig-Riou
448308710a
Per review, distributor are now updated via variant
...
When a product is deleted, it will delete associated variant and
in turn will touch the affected distributors
2024-07-03 11:23:02 +10:00
Gaetan Craig-Riou
f73745a803
David's first review changes
2024-07-03 11:23:02 +10:00
Gaetan Craig-Riou
3788b33eb0
First round of code review change
2024-07-03 11:23:02 +10:00
Gaetan Craig-Riou
c328ee8087
Remove stockable_by from Product and Variant
...
It's not used anymore
2024-07-03 11:23:02 +10:00
Gaetan Craig-Riou
efbec02fb9
Fix rebase issue
2024-07-03 11:23:02 +10:00
Gaetan Craig-Riou
117f6d3300
First round of code review change
2024-07-03 11:21:28 +10:00
Gaetan Craig-Riou
260211cf15
Fix Ruboxop issue
2024-07-03 11:21:28 +10:00
Gaetan Craig-Riou
7219f72ac7
Fix rebase issue
2024-07-03 11:21:28 +10:00
Gaetan Craig-Riou
891f79666d
Spree::Product remove in_supplier_or_distributor scope
...
It is not used anywhere
2024-07-03 11:21:28 +10:00
Gaetan Craig-Riou
312c240968
Fix mutilingual spec
2024-07-03 11:21:28 +10:00
Gaetan Craig-Riou
b6faa43879
Fix touching distributor callback spec
...
The original spec check if the supplier and distributor where
updated after deleting product. In reality, the supplier and the
distributor are the same, so no need to test with the supplier
2024-07-03 11:21:28 +10:00
Gaetan Craig-Riou
84197aca19
Fix the filtering by properties/supplier properties
...
- Apply OR when filtering by both product properties and supplier
properties
- Apply AND when filtering by supplier properties and taxon
Filtering by product properties and taxon is handled by ransack, so
no change there
2024-07-03 11:21:28 +10:00
Gaetan Craig-Riou
a52401107a
Order cycle API, separate properties and producer_properties
...
Due to moving the supplier to the variant, we had to add manual search
for producer properties instead of using ransack. So we need a way
for the frontend to diferenciate between product properties and producer
properties. This is the first step towards that
2024-07-03 11:21:28 +10:00
Gaetan Craig-Riou
3704b18952
Fix property filtering in shopping system spec
2024-07-03 11:21:28 +10:00
Gaetan Craig-Riou
feb7e173b1
Fix order cycle controller spec, product properties filtering
...
And fix the underlying product renderer
2024-07-03 11:21:28 +10:00
Gaetan Craig-Riou
3dc7c2bf56
Fix spree product touch supplier
...
Take into account import product scenario, in this case the variant
doesn't have an assigned supplier yet.
2024-07-03 11:21:28 +10:00
Gaetan Craig-Riou
2d707e8acb
Fix consumer producer system spec
2024-07-03 11:21:28 +10:00
Gaetan Craig-Riou
dd8f0aafab
Fix ProductImport::EntryProcessor#count_existing_items
...
Plus spec
2024-07-03 11:21:28 +10:00
Gaetan Craig-Riou
564ea0bd49
Fix enterprise touching when associated record updated
2024-07-03 11:21:28 +10:00
Gaetan Craig-Riou
b5cf47d306
Fix producer mailer
2024-07-03 11:21:28 +10:00
Gaetan Craig-Riou
8244fa7685
Fix enterprise shopfront serializer spec
2024-07-03 11:21:28 +10:00
Gaetan Craig-Riou
3eae329cc4
Fix shop system spec
2024-07-03 11:21:28 +10:00
Gaetan Craig-Riou
848144d378
Fix DFC engine
2024-07-03 11:21:28 +10:00
Gaetan Craig-Riou
d614780059
Fix product serializer spec
2024-07-03 11:21:28 +10:00
Gaetan Craig-Riou
2550f8fd80
Fix cached enterprise serializer spec
2024-07-03 11:21:28 +10:00
