James Wu
ae5f2cc19d
Fix error saving data on new Calculator
2023-04-18 09:39:39 +10:00
James Wu
41ce4fbc16
Fix cache issue with invalid form data
2023-04-18 09:39:39 +10:00
James Wu
48753df5f0
Improve input validation and error notification
2023-04-18 09:39:39 +10:00
James Wu
1f3e66316b
Modify Calculator validation error messages
2023-04-18 09:39:39 +10:00
James Wu
6b1426d0c6
Add numericality validation for PriceSack
2023-04-18 09:39:39 +10:00
James Wu
c68987c0f2
Add numericality validation for PerItem
2023-04-18 09:39:39 +10:00
James Wu
2cb25e6366
Add numericality validation for FlexiRate
2023-04-18 09:39:39 +10:00
James Wu
073f46e590
Add numericality validation for FlatRate
2023-04-18 09:39:39 +10:00
James Wu
23beea8a13
Add numericality validation for FlatPercentPerItem
2023-04-18 09:39:39 +10:00
James Wu
096e388fdf
Add numericality validation for FlatPercentItemTotal
2023-04-18 09:39:39 +10:00
James Wu
3dfaf882a3
Add translation for Active Record error message
2023-04-18 09:39:39 +10:00
James Wu
7b51f45b4d
Fix spelling in test description
2023-04-18 09:39:39 +10:00
James Wu
b9b2fa7c94
Fix error converting String to BigDecimal
2023-04-18 09:39:39 +10:00
James Wu
ee30d3d139
Fix PaymentMethodFactory creating extra Calculator
2023-04-18 09:39:39 +10:00
Filipe
871b2f8816
Merge pull request #10696 from mkllnk/login-as-admin
...
Simplify login test helpers
2023-04-17 12:14:06 +01:00
Maikel
44cc5cc665
Merge pull request #10677 from mkllnk/spec-helpers
...
Simplify spec helpers
2023-04-17 16:16:29 +10:00
Maikel Linke
5c6d9a092e
Simplify login spec helpers, avoid long lines
...
The `login_as_admin_and_visit` helper was used a lot but isn't really
shorter than:
login_as_admin
visit path_visit
Calling those methods separately reduces line length. It also removes
the potential impression that it may be more efficient to use the
helper. Now we have less indirection if one of the calls fails and see
the failing spec line straight away.
2023-04-17 11:08:32 +10:00
Maikel Linke
8d500a2c27
Remove superflouous login test helper
...
It was often used with a `visit` statement after which resulted in
unnecessary page loads. There was only one case where a `visit` was
expected but it wasn't needed either.
2023-04-17 10:56:51 +10:00
Maikel Linke
425674c4e5
Remove unused return value of admin login helper
...
Well, there was one use of the return helper. But I don't think that
it's a very intuitive method.
2023-04-17 10:56:51 +10:00
Konrad
e91e827f29
Merge pull request #10664 from abdellani/fix-remove-duplicated-cusomter-from-mailing-list-report
...
Fix Repeated customer entries on Mailing List Report
2023-04-16 21:17:33 +02:00
Konrad
8f201c830a
Merge pull request #10665 from abdellani/fix-remove-duplicated-cusomter-from-addresses-list-report
...
Fix Repeated customer entries on Addresses List Report
2023-04-16 20:40:56 +02:00
Konrad
1b536d9265
Merge pull request #10601 from abdellani/fix-v1-customers-endpoint-should-only-return-managed-enterprise-customers
...
fix: v1/customers endpoint should load customers of managed enterprises only
2023-04-16 16:22:02 +02:00
Mohamed ABDELLANI
1b8a9244a6
test when user is a non-persisted object
2023-04-15 06:16:40 +01:00
Maikel
b0211d0930
Merge pull request #10686 from filipefurtad0/truncates_product_description
...
Sets too long line truncation spec as pending
2023-04-14 15:11:31 +10:00
Maikel
0675422509
Merge pull request #10678 from dacook/show-commit-in-ci
...
Show commit in CI
2023-04-14 14:43:44 +10:00
Maikel
5ff1b0d358
Merge pull request #10676 from filipefurtad0/fix_spec_ts_and_cs
...
Adds pending test for default ToS
2023-04-14 14:00:32 +10:00
jibees
920e2564a4
Merge pull request #10692 from openfoodfoundation/dependabot/bundler/rubocop-1.50.1
...
Bump rubocop from 1.50.0 to 1.50.1
2023-04-13 13:45:28 +02:00
dependabot[bot]
2d43e32688
Bump rubocop from 1.50.0 to 1.50.1
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.50.0 to 1.50.1.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.50.0...v1.50.1 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-13 09:57:38 +00:00
David Cook
a6cd393c57
Update all locales with the latest Transifex translations
2023-04-13 16:45:38 +10:00
Filipe
b1060bf1c9
Merge pull request #10640 from openfoodfoundation/dependabot/bundler/stripe-8.5.0
...
Bump stripe from 8.3.0 to 8.5.0
2023-04-12 19:27:18 +01:00
Filipe
1bf5fbaf3a
Merge pull request #10449 from macanudo527/fix_ER
...
Update OCs after ER Permissions are Revoked
2023-04-12 18:59:20 +01:00
Konrad
2ace3afd67
Merge pull request #10606 from thejwuscript/10116-improve-bom-sorting
...
Sort orders by last name
2023-04-12 16:36:45 +02:00
Konrad
0bfceb877d
Merge pull request #10666 from jibees/9723-admin-missing-translation-in-payment-report
...
Admin, Payment reports: add missing translation for payment state
2023-04-12 15:47:23 +02:00
Filipe
c1d28b2e8f
Merge pull request #10119 from binarygit/donot-hide-producers-name-in-products
...
Display producer's name in products inspite of hide all refs option
2023-04-12 13:07:52 +01:00
Jean-Baptiste Bellet
2841b42296
Specify truncate parameter as we don't always truncate description
...
Only when too long.
2023-04-12 10:34:30 +02:00
jibees
98e44e7a40
Merge pull request #10687 from openfoodfoundation/dependabot/bundler/nokogiri-1.14.3
...
Bump nokogiri from 1.14.2 to 1.14.3
2023-04-12 10:25:56 +02:00
jibees
51c6c19f80
Merge pull request #10669 from openfoodfoundation/dependabot/bundler/sidekiq-7.0.8
...
Bump sidekiq from 7.0.7 to 7.0.8
2023-04-12 10:24:59 +02:00
dependabot[bot]
75b7a1864b
Bump nokogiri from 1.14.2 to 1.14.3
...
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri ) from 1.14.2 to 1.14.3.
- [Release notes](https://github.com/sparklemotion/nokogiri/releases )
- [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md )
- [Commits](https://github.com/sparklemotion/nokogiri/compare/v1.14.2...v1.14.3 )
---
updated-dependencies:
- dependency-name: nokogiri
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-12 06:24:59 +00:00
Maikel Linke
496f5199c9
Use DatabaseCleaner recommendation of late cleaning
...
https://github.com/DatabaseCleaner/database_cleaner#rspec-with-capybara-example
2023-04-12 14:24:07 +10:00
Maikel Linke
f13c0e1dca
Bring all Rspec config for database cleaning together
2023-04-12 14:23:09 +10:00
David Cook
f801d4a4cb
Move single-used variables to their own example
...
They were created three times each, but only used once.
2023-04-12 11:05:11 +10:00
David Cook
d94da8df1e
Update comment
2023-04-12 11:04:00 +10:00
filipefurtad0
70d9cfa08e
Sets too long line truncation spec as pending
2023-04-11 19:46:11 +01:00
jibees
193ae7936e
Merge pull request #10681 from openfoodfoundation/dependabot/bundler/rubocop-1.50.0
...
Bump rubocop from 1.49.0 to 1.50.0
2023-04-11 20:40:55 +02:00
Filipe
0971e8d9b5
Merge pull request #10644 from mkllnk/report-timeout-message
...
[Hidden] Display a friendly message when a background report times out
2023-04-11 19:40:42 +01:00
Jean-Baptiste Bellet
e78b44b9ca
Do not shows <a /> if producers is hidden
...
Different style as it does not open any modal
2023-04-11 14:27:57 +02:00
binarygit
c5779eff81
Do not open modal for producer's who are 'hidden'
2023-04-11 14:27:57 +02:00
Jean-Baptiste Bellet
b616c14f63
Don't hide producer's name in products despite hide all refs opt selected
2023-04-11 14:26:47 +02:00
Mohamed ABDELLANI
03cb14c926
define manage_by scope on customer model
2023-04-11 12:18:15 +01:00
Mohamed ABDELLANI
da78e06a39
load customers of managed enterprises only
2023-04-11 12:10:07 +01:00
