Matt-Yorkley
dfbd384c95
Refactor embedding to a Concern
2022-01-18 12:22:06 +00:00
Matt-Yorkley
4649698fc4
Remove #set_response_headers
2022-01-18 12:19:54 +00:00
Matt-Yorkley
05abb63036
Remove X-Frame-Options header
...
This header is largely deprecated, and is functionally replaced here by use of the frame-ancestors CSP configuration
2022-01-18 12:19:54 +00:00
Matt-Yorkley
ce9b64a848
Set Angular CSP
...
If you don't set this flag, Angular helpfully attempts to check if this is disabled by *triggering* a CSP violation just to see what happens... 🙈
2022-01-18 12:19:54 +00:00
Matt-Yorkley
7c2b3cdf51
Fix param whitelisting
...
Co-authored-by: Maikel <maikel@email.org.au >
2022-01-18 09:14:55 +00:00
Filipe
067f90b17c
Merge pull request #8712 from Matt-Yorkley/oc-mails
...
OC notifications
2022-01-17 20:30:40 +00:00
Filipe
8114eb1c9f
Merge pull request #8666 from openfoodfoundation/stripe-controller
...
Extract new StripeController
2022-01-17 20:21:40 +00:00
Filipe
62f0de75ee
Merge pull request #8679 from Matt-Yorkley/drop-jquery-ujs
...
Drop jquery_ujs
2022-01-17 16:30:25 +00:00
Jean-Baptiste Bellet
c22f3ec1db
Add locale to stripe elements options to display messages in right language
...
List of supported language by stripe elements:
https://stripe.com/docs/js/appendix/supported_locales
2022-01-17 15:10:51 +01:00
Matt-Yorkley
31b4c06ea3
Update rendering and shipping_type_selector directive
2022-01-16 11:30:58 +00:00
Matt-Yorkley
a6ef7ca17f
Move shipping_type_selector template to views
2022-01-16 11:05:17 +00:00
Matt-Yorkley
f06ec94b30
Render shop_variant partial normally and remove shop_variant directive
2022-01-16 10:46:26 +00:00
Matt-Yorkley
e5009432c3
Render regular partials
2022-01-16 10:45:26 +00:00
Matt-Yorkley
3afd6c273a
Move shop_variant templates to views
2022-01-16 10:41:55 +00:00
filipefurtad0
e7aa19c95d
Fixes translation/rendering inconsistency on Country label(step 3)
2022-01-15 19:43:57 +00:00
Matt-Yorkley
26ac59fbba
Move Matomo event tracking for login modal into Autherntication service
2022-01-15 16:21:33 +00:00
Matt-Yorkley
18ac9b5335
Add support for generating valid/unique permalinks for Enterprises with non-roman characters in their name
2022-01-15 13:21:09 +00:00
Matt-Yorkley
2063bffad6
Replace use of Stringex#to_url with (encapsulated) UrlGenerator#to_url
2022-01-15 13:21:09 +00:00
Matt-Yorkley
0ef35b319c
Create UrlGenerator service
2022-01-15 13:21:09 +00:00
Matt-Yorkley
3f5e5d52ad
Improve concern syntax and definition
2022-01-15 12:31:43 +00:00
Matt-Yorkley
ea312c78b0
Move PermalinkGenerator out of lib directory
2022-01-15 12:31:43 +00:00
Matt-Yorkley
7062cab31f
Replace unnecessary uses of StringEx#to_url with ActiveSupport#parameterize
2022-01-15 10:22:10 +00:00
Matt-Yorkley
c209be9c17
Clarify params
...
Spree::Order.to_param outputs the order *number* (not the id) when used to build URLs. This makes it a bit more explicit.
2022-01-14 19:41:08 +00:00
Matt-Yorkley
12f7fc98fa
Move payment authorization to StripeController
...
This Stripe-payment-authorizing logic is used by backoffice and subscriptions orders (but not the checkout), and was previously being handled by the #show action in Spree::OrdersController. It involves the user being redirected back to OFN after visiting a Stripe URL.
2022-01-14 19:41:08 +00:00
Matt-Yorkley
6c2b623f8b
Tidy up OrderController
2022-01-14 19:41:08 +00:00
Matt-Yorkley
c65beae869
Extract some methods and move to simpler callbacks with guard clauses
2022-01-14 19:41:08 +00:00
Matt-Yorkley
c4d55feac8
Extract #last_payment
2022-01-14 19:41:08 +00:00
Matt-Yorkley
ddf6e7eadd
Use proper module/namespace
2022-01-14 19:41:08 +00:00
Matt-Yorkley
410485fbf4
Use #order_failed_route in #process_order_completion!
2022-01-14 19:41:08 +00:00
Matt-Yorkley
072f4f4c60
Use new stripe confirm path and remove dead code
2022-01-14 19:41:08 +00:00
Matt-Yorkley
3f3bfadb59
Simplify StripeScaPaymentAuthorize and clarify both return URL types (checkout and off-session)
2022-01-14 19:41:08 +00:00
Matt-Yorkley
789c29f678
Extract #load_checkout_order
2022-01-14 19:41:08 +00:00
Matt-Yorkley
daee5b49b5
Extract #process_payment_completion!
2022-01-14 19:41:08 +00:00
Matt-Yorkley
76647863e8
Add new Stripe controller
2022-01-14 19:41:08 +00:00
Matt-Yorkley
28d89103eb
Extract #gateway_error
2022-01-14 19:41:08 +00:00
Matt-Yorkley
7633255bea
Extract #order_failed_route
2022-01-14 19:41:08 +00:00
Matt-Yorkley
414e1eb299
Tidy up OrdersController#load_order
2022-01-14 19:41:08 +00:00
Matt-Yorkley
6385d9a782
Simplify interface of #order_completion_route
2022-01-14 19:41:08 +00:00
Matt-Yorkley
7cbdb7c1a2
Remove paypal-specific workaround from OrdersController
...
The previous commit means this is no longer needed here.
2022-01-14 19:41:08 +00:00
Matt-Yorkley
1b459b2491
Extract #processing_failed
2022-01-14 19:41:08 +00:00
Matt-Yorkley
c1defdb1ff
Extract #order_processing_error
2022-01-14 19:41:08 +00:00
Matt-Yorkley
5c44614a8d
Extract and standardise payment/checkout #processing_succeeded
2022-01-14 19:41:08 +00:00
Matt-Yorkley
96f30133a7
Don't reset order for split checkout
...
The various places where we "reset" an order to cart state if a checkout submission does not succeed are an artifact of the process-all-the-steps-at-once approach of the current checkout.
2022-01-14 19:41:08 +00:00
Matt-Yorkley
1e21a6a32f
Extract and standardise use of #handle_insufficient_stock
2022-01-14 19:41:08 +00:00
Matt-Yorkley
b6cf6483f2
Extract and standardise use of order loading around checkout processing
2022-01-14 19:41:08 +00:00
Matt-Yorkley
4d6c4f850f
Remove pointless callbacks in CheckoutController
...
These exact same checks are already made in #load_order (and #order_invalid_for_checkout?), which is called before these other two (later) callbacks.
2022-01-14 19:41:08 +00:00
Matt-Yorkley
77d89ec7d0
Extract and standardise use of #order_completion_route
2022-01-14 19:41:08 +00:00
Matt-Yorkley
4c1fc2b326
Standardise use of #order_completion_reset
2022-01-14 19:41:08 +00:00
Matt-Yorkley
124b63fad0
Remove unused flash assignment
2022-01-14 19:41:08 +00:00
Matt-Yorkley
01bd77e437
Remove duplicate translation key
2022-01-14 19:41:08 +00:00
