Mohamed ABDELLANI
9a22cdc5e7
test scenario: 'multiple orders, same enterprise fee, different tax rates'
2023-09-13 19:09:55 +02:00
Mohamed ABDELLANI
624b4c8ad2
fix calculation of the summary row's total excl tax
2023-09-13 19:09:55 +02:00
Mohamed ABDELLANI
a3f012c9fe
calculate tax total using existing rows
2023-09-13 19:09:55 +02:00
Mohamed ABDELLANI
f0c3d7685e
replace string reference with the translated string
2023-09-13 19:09:55 +02:00
David Cook
420494715f
Tighten up spec
...
I noticed that the tests don't check if the right totals are shown for each section. Now we can be certain.
2023-09-13 19:09:55 +02:00
David Cook
b7e1a660c3
Rename supplier to be more specific
...
To ensure specs are matching the right supplier.
2023-09-13 19:09:55 +02:00
David Cook
e934bc7cb9
Ignore ClassLength
...
I'm never quite sure the best way to deal with these, so I added a comment to at least explain my justification.
2023-09-13 19:09:55 +02:00
David Cook
93cca56e68
Style/HashSyntax
2023-09-13 19:09:55 +02:00
filipefurtad0
019c7b3e71
Splits filtering tests between orders
...
Sets pending test case for orders with more than one supplier
2023-09-13 19:09:55 +02:00
filipefurtad0
e43661fd3c
Adds/corrects comments around Added tax section
2023-09-13 19:09:55 +02:00
Mohamed ABDELLANI
080e81e0fe
optimize join_supplier
2023-09-13 19:09:55 +02:00
Mohamed ABDELLANI
44e8d2d735
fix pending lint issues
2023-09-13 19:09:55 +02:00
Mohamed ABDELLANI
219c581f9a
remove pending from "should filter by producer"
2023-09-13 19:09:55 +02:00
Mohamed ABDELLANI
6dd70d310c
fix the calculation of the cost of produce
...
we want the cost of produce to only include the items produced by the supplier used to group the rows.
2023-09-13 19:09:55 +02:00
filipefurtad0
9837a4fcf2
Removes pending (3)
...
Reverts Included Tax values
2023-09-13 19:09:55 +02:00
filipefurtad0
1b4235eb1d
Extends tests to inclusive tax scenario
2023-09-13 19:09:55 +02:00
filipefurtad0
bb0f9a6758
Adds pending test
...
on fees from order with line items from different suppliers
Adds pending test on producer filter
2023-09-13 19:09:55 +02:00
filipefurtad0
928337c3fd
Adds a second supplier and product to the setup
2023-09-13 19:09:55 +02:00
Mohamed ABDELLANI
7a875723ca
fix order_cycle summary row.
...
the summary row has to only include the line items coming from the supplier used in the grouping key
2023-09-13 19:09:55 +02:00
Mohamed ABDELLANI
7b0a99c652
fix enterprise fees listing
...
For every producer, we want to only show the enterprise fees that are applied to at lease one of his products.
To do that, we use the order cycle to build a list of the enterprise fees for every variant.
Every variant will have coordinator fee + additional fees coming from incoming/outgoing exchanges.
2023-09-13 19:09:55 +02:00
Mohamed ABDELLANI
1cd0f88c1e
fix supplier filter
2023-09-13 19:09:55 +02:00
David Cook
9ae65e135b
Rails/Pick
...
Prefer pick("sum(amount)") over pluck("sum(amount)").first
2023-09-13 19:09:55 +02:00
David Cook
55742f40d1
Show a line for cost of produce
...
Utilising a second group_by rule, we can add a second summary_row. The cost of produce is also inserted into the TOTALS row as per requirements.
2023-09-13 19:09:55 +02:00
David Cook
cc54e2e6c7
Add long report class to .rubocop_todo.yml
...
Long classes are a problem that would be good to resolve one day. But it's hard to resolve with the current reports framework.
2023-09-13 19:09:55 +02:00
Mohamed ABDELLANI
ee7668e713
implement enterprise fee report filters
...
squash Reformat/Refactor spec
2023-09-13 19:09:55 +02:00
Mohamed ABDELLANI
481b09edda
test enterprise summary fee with tax report by producer
...
Reformat/Refactor spec
2023-09-13 19:09:55 +02:00
Mohamed ABDELLANI
2880fd5a87
implement EnterpriseFeesWithTaxReportByProducer
...
squash Re-format code
squash Apply suggestions from code review
Co-authored-by: Maikel <maikel@email.org.au >
squash More refactor
squash Update lib/reporting/reports/enterprise_fee_summary/enterprise_fees_with_tax_report_by_producer.rb
2023-09-13 19:09:55 +02:00
Filipe
0f47ec0094
Merge pull request #11525 from jibees/11524-enlarged-unit-price-tooltip-image-on-variant-edit-page
...
BUU: Fix question mark icon for tooltip
2023-09-13 16:52:15 +01:00
Filipe
dae05e31ab
Merge pull request #11501 from jibees/9146-improve-user-feedback-in-oc-edit-page-for-hidden-inventory
...
Improve user feedback in oc edit page for hidden inventory
2023-09-13 16:26:39 +01:00
jibees
9f675fed32
Merge pull request #11534 from openfoodfoundation/dependabot/bundler/faraday-2.7.11
...
chore(deps): bump faraday from 2.7.10 to 2.7.11
2023-09-13 15:02:29 +02:00
jibees
f7dd94268e
Merge pull request #11536 from openfoodfoundation/dependabot/bundler/sidekiq-7.1.4
...
chore(deps): bump sidekiq from 7.1.3 to 7.1.4
2023-09-13 14:59:06 +02:00
dependabot[bot]
2c79a8be3c
chore(deps): bump sidekiq from 7.1.3 to 7.1.4
...
Bumps [sidekiq](https://github.com/sidekiq/sidekiq ) from 7.1.3 to 7.1.4.
- [Changelog](https://github.com/sidekiq/sidekiq/blob/main/Changes.md )
- [Commits](https://github.com/sidekiq/sidekiq/compare/v7.1.3...v7.1.4 )
---
updated-dependencies:
- dependency-name: sidekiq
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-09-13 10:02:05 +00:00
dependabot[bot]
8adc0a9144
chore(deps): bump faraday from 2.7.10 to 2.7.11
...
Bumps [faraday](https://github.com/lostisland/faraday ) from 2.7.10 to 2.7.11.
- [Release notes](https://github.com/lostisland/faraday/releases )
- [Changelog](https://github.com/lostisland/faraday/blob/main/CHANGELOG.md )
- [Commits](https://github.com/lostisland/faraday/compare/v2.7.10...v2.7.11 )
---
updated-dependencies:
- dependency-name: faraday
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-09-13 09:59:46 +00:00
Maikel
ead4f784ba
Merge pull request #11528 from macanudo527/fix_stylehash_1
...
Fix Style/HashSyntax 2/13
2023-09-13 17:17:26 +10:00
Maikel
463ecf2880
Merge pull request #11508 from mkllnk/dfc-enterprise-groups
...
[DFC API] Add endpoint for enterprise groups
2023-09-13 16:50:05 +10:00
Maikel Linke
7e222ad83e
Include address when showing group
...
It may be nice to show more data like social media URLs but the DFC
Connector hasn't implemented that yet and it's not specified in the
current issue.
2023-09-13 16:36:36 +10:00
Maikel Linke
88a3615de7
List groups when showing DFC Enterprise
2023-09-13 16:36:36 +10:00
Maikel Linke
cf18229e5b
Avoid loading DFC catalog for Person or Groups endpoint
2023-09-13 16:36:36 +10:00
Maikel Linke
95d3987752
List enterprise groups on DFC API
2023-09-13 16:36:36 +10:00
Maikel Linke
a03fb01a8c
List enterprises within groups on DFC API
2023-09-13 16:36:36 +10:00
Maikel Linke
2d91a61dcb
Add DFC API EnterpriseGroups#show
2023-09-13 16:36:36 +10:00
David Cook
ae72158e87
Merge pull request #11494 from mkllnk/dfc-swagger-config
...
Group DFC API operations by endpoint in documentation
2023-09-13 14:57:14 +10:00
Neal Chambers
7c3e61104a
Update .rubocop_todo.yml
2023-09-12 23:19:25 +09:00
Neal Chambers
4ffd3759cc
Fix Style/HashSyntax
2023-09-12 23:19:05 +09:00
jibees
0ebdc8abca
Merge pull request #11526 from openfoodfoundation/dependabot/bundler/sidekiq-7.1.3
...
chore(deps): bump sidekiq from 7.1.2 to 7.1.3
2023-09-12 15:54:25 +02:00
dependabot[bot]
1d430265a2
chore(deps): bump sidekiq from 7.1.2 to 7.1.3
...
Bumps [sidekiq](https://github.com/sidekiq/sidekiq ) from 7.1.2 to 7.1.3.
- [Changelog](https://github.com/sidekiq/sidekiq/blob/main/Changes.md )
- [Commits](https://github.com/sidekiq/sidekiq/compare/v7.1.2...v7.1.3 )
---
updated-dependencies:
- dependency-name: sidekiq
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-09-12 09:32:05 +00:00
Gaetan Craig-Riou
57f563f4bc
Merge pull request #11516 from macanudo527/fix_rubocop_9
...
Fix Style/HashSyntax 1
2023-09-12 18:56:47 +10:00
Jean-Baptiste Bellet
637096534f
Implement spec for #9146 issue
2023-09-12 10:20:26 +02:00
Jean-Baptiste Bellet
ff8b9465c7
Display info on outgoing products panel when some variants hidden
2023-09-12 10:20:26 +02:00
Jean-Baptiste Bellet
ff7629ba2c
Display information on outgoing product when variant aren't available
...
Update en.yml
2023-09-12 10:20:26 +02:00