4480 Commits

Author	SHA1	Message	Date
luisramos0	8970131685	In restart checkout spec, create failed payment before the valid payment otherwise the failed payment will invalidate the previous payment, even if it is a good one ... In spree 2, every new payment will invalidate all previous payments in the order See here: c9eebba4f7	2018-12-21 15:13:52 +00:00
luisramos0	7155f28acf	Remove shipping_method_id from RestartCheckout, destroying shipments is now enough as order.shipping_method_id is no longer used and will be dropped. See #2683 for more details	2018-12-21 15:13:43 +00:00
luisramos0	c0a095ffaf	Improve variant_overrides_spec variable names	2018-12-21 11:33:07 +00:00
luisramos0	4f79fd5be0	Improve availability validator spec readability and remove unnecessary expect statements	2018-12-21 11:19:12 +00:00
luisramos0	c1aeb2e9a3	Improve naming in availability_validator_decorator and cover it with tests	2018-12-20 14:26:34 +00:00
luisramos0	3085e15961	Fix order factory by making line_item.skip_stock_check work in spree 2	2018-12-20 14:26:34 +00:00
luisramos0	88b1bb61d6	Fix availability validator to include inventory_units in it's validation	2018-12-20 14:26:34 +00:00
Luis Ramos	0aaa41ced0	Merge pull request #3228 from luisramos0/2-0-stable-dec-18th ... [Spree Upgrade] Merging master into 2-0-stable (third run in Dec2018)	2018-12-19 09:30:57 +00:00
Maikel	4201549992	Merge pull request #3219 from luisramos0/2-0-payment-ctrl ... [Spree Upgrade] Adapt payment controller spec to spree 2	2018-12-19 15:23:11 +11:00
luisramos0	6fc3562a73	Merge branch 'master' into 2-0-stable-dec-18th	2018-12-18 23:32:45 +00:00
Pau Pérez Fabregat	2deffb9c9f	Merge pull request #3076 from Matt-Yorkley/orders_checkboxes ... Fix checkbox values on orders page	2018-12-17 10:35:46 +01:00
luisramos0	a5bf7a1f35	Adapt payment controller spec to spree 2 ... In spree 2, since 5ed6015916, to fire a payment event the order needs to be in either payment or complete state	2018-12-14 16:04:19 +00:00
Pau Perez	51e277a183	Make test setup more readable	2018-12-14 15:12:41 +01:00
Maikel	1ed880e353	Merge pull request #3206 from coopdevs/fix-redirection-on-admin-products-specs ... [Spree Upgrade] Fix redirection on admin products specs	2018-12-14 11:59:21 +11:00
Maikel	f0d3992511	Merge pull request #3203 from luisramos0/2-0-fix-prod-images-delete ... [Spree Upgrade] Fix product properties and images deletion	2018-12-14 11:54:05 +11:00
Pau Pérez Fabregat	64e41712c6	Merge pull request #3130 from coopdevs/extract-restart-checkout ... Extract restart checkout	2018-12-12 17:12:53 +01:00
Pau Perez	43cacfc2fc	Fix redirection on admin/products controller specs ... In Spree v2.0 the product attributes being sent were no longer valid. Providing a shipping category and setting a stock location on the DB so that a stock item can be created fixes them. Remember `Variant#create_stock_item`, which is defined as an `after_create` callback, relies on `StockLocation` to create the item.	2018-12-12 13:10:39 +01:00
luisramos0	66e69edca4	Rename ProductOnDemand to ProductStock; move product.on_hand into it; add product.on_demand; and remove unnecessary on_demand=	2018-12-12 12:10:25 +00:00
luisramos0	181915c63a	Fix deletion of product properties	2018-12-11 15:53:40 +00:00
Maikel	1819fc8493	Merge pull request #3199 from luisramos0/2-0-stable-dec-10th ... [Spree Upgrade] Merging master into 2-0-stable (second run in Dec2018)	2018-12-11 18:50:24 +11:00
Pau Pérez Fabregat	7834fa4d00	Merge pull request #3190 from luisramos0/2-0-new-product ... [Spree Upgrade] Fix "new product" page specs and an html issue	2018-12-11 08:35:26 +01:00
Maikel	d63ae792b3	Merge pull request #2775 from luisramos0/2-0-checkout-ship-method ... [Spree Upgrade] Handle shipping_method_id in checkout	2018-12-11 11:59:03 +11:00
Matt-Yorkley	e711c5ed03	Add spec for search filters	2018-12-10 20:48:53 +00:00
luisramos0	cdee7c0422	Merge branch 'master' into 2-0-stable-dec-10th	2018-12-10 16:41:29 +00:00
Pau Pérez Fabregat	b8a61257da	Merge pull request #3188 from luisramos0/2-0-ctrl-specs ... [Spree Upgrade] Fix line_item_controller spec by adpating to new spree 2 factories	2018-12-10 12:31:26 +01:00
luisramos0	4f4fc00549	Improve code, specs and comments in the shipping_method selection process in the checkout controller	2018-12-09 20:05:10 +00:00
luisramos0	7ecce51b8b	Create default stock location and set required product.shipping_category in specs that create products	2018-12-08 14:52:50 +00:00
luisramos0	7df869bd35	Fix line_item_controller spec by adpating to new spree 2 factories	2018-12-05 22:22:15 +00:00
luisramos0	afd243c548	Replace stub with allow in checkout_controller_spec	2018-12-05 15:40:14 +00:00
Pau Perez	6af8544c52	Restore perform_deliveries value in tests	2018-12-05 10:20:13 +01:00
Pau Perez	25eb297215	Perform delivery when checking deliveries in specs	2018-12-05 10:05:39 +01:00
Pau Perez	064d9cf183	Do not hide flaky tests under endless retries ... If it fails, needs fixing, not hiding the problem and making the test suite longer.	2018-12-05 10:05:39 +01:00
Pau Perez	6594529cda	Fix manager invitation controller spec	2018-12-05 10:05:39 +01:00
Pau Perez	25567d6bd6	Do not clean DB twice on feature specs ... It turns out that we were executing `DatabaseCleaner.clean` on two `after(:each)` blocks. One for all specs and another one for `js: true` specs. As a result feature specs were hitting both which slows them down considerably. On my machine this changes consistently saves 2sec on `spec/features/consumer/shops_spec.rb` but chances are it has an accumulative effect when run on the whole test suite.	2018-12-05 09:58:14 +01:00
Pau Pérez Fabregat	3b56212290	Merge pull request #3151 from coopdevs/remove-frontoffice-enterprises-n+1 ... Remove frontoffice enterprises n+1	2018-12-05 08:12:19 +01:00
Maikel	a2c8bea147	Merge pull request #3147 from luisramos0/2-0-vos ... [Spree Upgrade] Adapt variant overrides to spree 2	2018-12-05 10:50:20 +11:00
Pau Pérez Fabregat	30e7d32cea	Merge pull request #3157 from coopdevs/fix-producer-mailer-specs ... [Spree Upgrade] Specify :mailer type in specs	2018-12-04 15:21:17 +01:00
luisramos0	7dc208fb8c	Temporarily move 2 broken specs to pending (shops and producers search by url) due to google maps api changes	2018-12-04 13:20:20 +00:00
Maikel	60c8147391	Merge pull request #3164 from luisramos0/2-0-stable-dec-3rd ... [Spree Upgrade] Merging master into 2-0-stable (first run in Dec2018)	2018-12-04 13:38:02 +11:00
Maikel	214235d8dd	Merge pull request #3152 from coopdevs/fix-product-spec ... [Spree Upgrade] Fix product spec	2018-12-04 12:07:33 +11:00
luisramos0	3776b891ce	Merge branch 'master' into 2-0-stable-dec-3rd	2018-12-03 15:30:16 +00:00
Pau Perez	46bf4c9eea	Specify :mailer type in specs ... According to RSpec docs we need to specify type: :mailer for mails to work. Check it out: https://relishapp.com/rspec/rspec-rails/v/3-8/docs/mailer-specs. This fixes all specs in producer_mailer_spec.rb.	2018-12-03 15:41:58 +01:00
luisramos0	258287b88d	Add tests to cover CheckoutController#update with shipping_method_id	2018-11-30 17:04:46 +00:00
luisramos0	e23c4dda68	Add order_shipping_method specs to cover select_shipping_method	2018-11-30 12:58:27 +00:00
luisramos0	d962358f15	Fix rubocop and transpec models/variant_override and its spec	2018-11-30 00:43:55 +00:00
luisramos0	0577011f5b	Refactor variant override model and its spec: simplify move_stock and remove unused methods	2018-11-30 00:22:04 +00:00
Pau Pérez Fabregat	08297863be	Merge pull request #3047 from mllocs/feature/expand-all-steps-in-checkout-page ... Expand all steps in the checkout page by default	2018-11-29 16:28:42 +01:00
Pau Perez	957c38e4f2	Add missing translations causing a test failure	2018-11-28 18:38:09 +01:00
Pau Perez	7834b1d3f3	Fix test case for invalid product master	2018-11-28 17:39:59 +01:00
Pau Perez	e0f43191e2	Make helper methods private ... Otherwise next dev might think these are attributes of the resulting JSON serialized object. They just made the refactoring a bit easier.	2018-11-28 16:21:40 +01:00