Remove shipping_method_id from RestartCheckout, destroying shipments is now enough as order.shipping_method_id is no longer used and will be dropped. See #2683 for more details

This commit is contained in:
luisramos0
2018-12-21 14:58:03 +00:00
parent 1007addddb
commit 7155f28acf
2 changed files with 0 additions and 3 deletions

View File

@@ -23,7 +23,6 @@ class RestartCheckout
end
def clear_shipments
order.update_attributes!(shipping_method_id: nil)
order.shipments.with_state(:pending).destroy_all
end

View File

@@ -17,7 +17,6 @@ describe RestartCheckout do
let!(:payment_failed) { create(:payment, order: order, state: 'failed') }
before do
order.shipping_method_id = shipment_pending.shipping_method_id
order.update_attribute(:state, "payment")
end
@@ -28,7 +27,6 @@ describe RestartCheckout do
RestartCheckout.new(order).call
expect(order.state).to eq 'cart'
expect(order.shipping_method_id).to eq nil
expect(order.shipments.count).to eq 0
expect(order.adjustments.shipping.count).to eq 0
expect(order.payments.count).to eq 1