Gaetan Riou
d3943bc92a
refactor error handling of CSV::MalformedCSVError and fix some typos
2020-06-11 16:47:58 +10:00
Luis Ramos
113533e3b1
Merge pull request #5557 from Matt-Yorkley/reports-improvement
...
Improve performance in various reports
2020-06-10 18:54:51 +01:00
Maikel Linke
7d53b12baf
Preserve sorting by completion date
2020-06-10 10:19:15 +10:00
Maikel Linke
680ee3dc86
Check the bulk invoice rendering order
...
As it turns out, our performance optimisation with `find_each` overrides
or custom sorting.
2020-06-10 10:05:47 +10:00
Luis Ramos
0c1ed1731d
Add more specs to ship method controller
2020-06-09 12:33:55 +01:00
Luis Ramos
87292a8ce5
Refactor spec to add more similar specs
2020-06-09 12:15:52 +01:00
Luis Ramos
f05b0d1a57
Add missing fields to ship method controller permitted params list
2020-06-09 12:02:59 +01:00
Luis Ramos
fd5062429a
Add context to delete specs so we can add other specs
2020-06-09 12:02:59 +01:00
Luis Ramos
7924330321
Fix problem with stub_const, we need auto load the controller before the const is stubbed otherwise the controller will be broken
...
See details here: https://github.com/rspec/rspec-mocks/issues/1079#issuecomment-215620243
2020-06-09 10:52:53 +01:00
François Turbelin
795106aaa2
Use real orders inside spec to extend coverage
2020-06-09 10:11:11 +02:00
Luis Ramos
88896b7730
Merge branch 'master' into 3-0-stable-jun-2
2020-06-08 19:17:11 +01:00
jeffrey s hill md
c4e910a7c8
Make clear filters fetch products automatically without filters
...
The spec change is needed: fetchProducts() makes cleared filters values undefined in removeClearedValues.
2020-06-08 18:27:10 +01:00
Gaetan Riou
9b8a97aadd
Add handling of CSV::MalformedCSVError for product_importer
2020-06-08 16:21:02 +10:00
Matt-Yorkley
9e278d5b2f
Improve performance in various reports
2020-06-05 16:39:01 +02:00
Matt-Yorkley
78fc6b7138
Rename "Geo" service to "GmapsGeo" for clarity.
...
This service directly calls methods in the google maps javascript included in the darkswarm layout. If we're moving away from it, we should clarify where it's used.
2020-06-05 08:35:15 +02:00
Luis Ramos
cce26cb453
Merge branch '3-0-stable' into 3-0-stable-jun-2
2020-06-03 19:51:43 +01:00
Lucas Hiago
bfe17f54d7
Change minimal amount in price sack calculator to float
2020-06-03 08:51:41 -03:00
Pau Pérez Fabregat
8a62c8aeb5
Merge pull request #5544 from luisramos0/api_ctrl
...
[Spree 2.1] Fix specs in Api::EnterprisesController and Api::ShopsController
2020-06-03 09:34:43 +02:00
Pau Pérez Fabregat
833e2ff9c4
Merge pull request #5543 from luisramos0/product_stock
...
[Spree 2.1] Fix product_stock spec
2020-06-03 09:18:52 +02:00
Luis Ramos
f9d86eb7ed
Join module and describe declaration so that rspec picks up correct controller under Api namespace and not the controller with the same name in the base namespace
2020-06-02 20:17:46 +01:00
Luis Ramos
251c04f2d9
Make all tests in enterprises_controller_spec use api_post instead of spree_post
2020-06-02 20:17:07 +01:00
Luis Ramos
ff0c93a76b
Join module and describe declaration so that rspec picks up correct
...
controller under Api namespace and not the controller with the same name
in the base namespace
2020-06-02 20:15:25 +01:00
Luis Ramos
c68459f212
Make enterprises_controller_spec use api_post instead of spree_post
2020-06-02 20:06:52 +01:00
Luis Ramos
53a80de503
Improve method names and set use_route with reverse_merge so it can be overridden
2020-06-02 17:32:46 +01:00
Luis Ramos
4438f620e9
Merge pull request #5421 from luisramos0/more_strong_params
...
[Spree 2.1] Add missing strong params to less important controllers missed by specs
2020-06-02 16:59:27 +01:00
Luis Ramos
23b677f547
Merge pull request #5388 from luisramos0/reg_proc
...
[Spree 2.1] Fix enterprise package selection submit button
2020-06-02 16:23:52 +01:00
Luis Ramos
beb1b3f3bc
Replay 02d46b7c51 lost in the last merge from master
2020-06-02 16:11:03 +01:00
Luis Ramos
c9a7a6e897
Merge branch 'master' into 3-0-stable-jun-2
2020-06-02 16:00:45 +01:00
Luis Ramos
7b89f4d6c5
Switch controller helper calls routes from spree to main_app, this will include all routes all the time
2020-06-02 15:00:57 +01:00
Luis Ramos
13836a62bb
Rename parameters to params and change default from nil to {}
2020-06-02 14:36:06 +01:00
Luis Ramos
3136aa5a8b
Make api_process use process_spree_action
2020-06-02 14:00:24 +01:00
Luis Ramos
2f76e0b15b
Bring methods from Spree::TestingSupport::ControllerRequests to our ControllerRequestsHelper so we can merge them later
2020-06-02 13:54:33 +01:00
Luis Ramos
5d0856e5a3
Rename ControllerHacks to ControllerRequestsHelper and move it's configuration to spec_helper
2020-06-02 13:47:59 +01:00
Luis Ramos
cd3bc54c37
Remove resource_scoping to make things more simple
2020-06-02 13:43:33 +01:00
Luis Ramos
2c2263ab78
Fix rubocop issues in shipments_controller_spec
2020-06-02 13:41:50 +01:00
Luis Ramos
092e047b44
Remove resource_scoping from api/shipments_controller spec
2020-06-02 13:35:48 +01:00
Luis Ramos
a0aa42cd58
Remove resource_scoping from api/variants spec
2020-06-02 13:26:12 +01:00
Luis Ramos
2d7f1ce283
Delete all variants from test product not just the first one
2020-06-01 21:21:26 +01:00
Luis Ramos
e7828e107b
Delete dead methods from product_decorator
2020-06-01 14:07:34 +01:00
Luis Ramos
a4a6431faf
Fix strong params problem where order object is not sent to controller
2020-06-01 13:42:22 +01:00
Luis Ramos
48985bbcd1
Use patch instead of put, because it's rails 4
...
Extend the registration process spec to cover package selection
2020-06-01 13:41:37 +01:00
Luis Ramos
bae128738b
Add spec for return authorizations controller
2020-06-01 13:40:59 +01:00
Luis Ramos
583b4a1df7
Add spec to countries_controller
2020-06-01 13:40:59 +01:00
Luis Ramos
73f2844fe3
Add spec for shipping categories
2020-06-01 13:40:59 +01:00
Matt-Yorkley
1e3bf7fec4
Merge pull request #5487 from coopdevs/fix-schedule-factory
...
[Spree 2.1] Allow to create order_cycle_schedules
2020-05-30 13:49:47 +02:00
Pau Pérez Fabregat
c0ad992352
Merge pull request #5465 from luisramos0/rename_accessible_by
...
[Rails 4.1] Rename order_cycle.accessible_by to remove name clash with active record
2020-05-29 12:04:19 +02:00
Pau Perez
862364ebbb
Fix schedule destroy spec
2020-05-29 10:24:50 +02:00
Maikel
2f82a58055
Merge pull request #5365 from mbudm/task/orderCycleSpecSplit
...
Split order_cycle_spec into smaller specs grouped by theme
2020-05-29 13:46:42 +10:00
Luis Ramos
bb8401a0fc
Merge pull request #5444 from luisramos0/dead_js_code
...
Remove some dead JS code related to admin sub menus
2020-05-28 19:54:42 +01:00
Cillian O'Ruanaidh
1fba998b9e
Drop Blockenspiel and use :rules/:columns methods instead of :organise/:summary_columns DSL.
...
For https://github.com/openfoodfoundation/openfoodnetwork/issues/3231
2020-05-28 19:04:18 +01:00