raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-01-24 20:36:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #5444 from luisramos0/dead_js_code

Browse Source 
Remove some dead JS code related to admin sub menus
This commit is contained in:
Luis Ramos
2020-05-28 19:54:42 +01:00
committed by GitHub
parent 83edfbd1dd 6c81c19f00
commit bb8401a0fc
2 changed files with 0 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
app/assets/javascripts/admin/side_menu/services/side_menu.js.coffee
View File

@@ -4,7 +4,6 @@ angular.module("admin.side_menu")
items: []
selected: null
# Checks for path and uses it to set the view
# If no path, loads first view
init: =>
@@ -31,11 +30,3 @@ angular.module("admin.side_menu")
for item in @items when item.name is name
return item
null
hide_item_by_name: (name) =>
item = @find_by_name(name)
item.visible = false if item
show_item_by_name: (name) =>
item = @find_by_name(name)
item.visible = true if item

22
spec/javascripts/unit/admin/side_menu/services/side_menu.js.coffee
View File

@@ -69,25 +69,3 @@ describe "SideMenu service", ->
it "returns null if no items are found", ->
SideMenu.items = [ { name: "Name 1"}, { name: "Name 2"} ]
expect(SideMenu.find_by_name("Name 3")).toBe null
describe "hiding an item by name", ->
it "sets visible to false on the response from find_by_name", ->
mockItem = { visible: true }
spyOn(SideMenu, 'find_by_name').and.returnValue mockItem
SideMenu.hide_item_by_name()
expect(mockItem.visible).toBe false
it "doesn't crash if null is returned from find_by_name", ->
spyOn(SideMenu, 'find_by_name').and.returnValue null
SideMenu.hide_item_by_name()
describe "showing an item by name", ->
it "sets visible to false on the response from find_by_name", ->
mockItem = { visible: false }
spyOn(SideMenu, 'find_by_name').and.returnValue mockItem
SideMenu.show_item_by_name()
expect(mockItem.visible).toBe true
it "doesn't crash if null is returned from find_by_name", ->
spyOn(SideMenu, 'find_by_name').and.returnValue null
SideMenu.show_item_by_name()