Gaetan Craig-Riou
85e0da8aeb
Improve concurrency spec
...
Add checks to see if breakpoint is actually reach and if we have a race
condition.
2026-03-10 16:07:43 +11:00
Gaetan Craig-Riou
628810eb33
Fix spec to work with the internal payment method
2026-03-10 16:07:42 +11:00
Gaetan Craig-Riou
3e2e7f1799
Add button to credit customer when order is credit owed state
...
It will add a negative payment, matching the amount credited in the
customer_account_transaction
2026-03-10 16:07:42 +11:00
Gaetan Craig-Riou
5bdb6e6d69
Clean up spec
2026-03-10 16:07:42 +11:00
Gaetan Craig-Riou
fec5516fce
Backoffice customer, Add pop up to list customer payments
2026-03-10 16:07:42 +11:00
Gaetan Craig-Riou
1b468522e6
Add concurrency spec
...
Make sure two transactions cannot be processed at the same time
2026-03-10 16:07:41 +11:00
Gaetan Craig-Riou
be7be9bbc6
Add api endpoing to create customer transactions
...
Plus specs and documentation
2026-03-10 16:07:41 +11:00
Cillian O'Ruanaidh
f1071575cd
Remove Angular from Enterprise > Settings > Users section
2026-03-04 10:28:36 +11:00
Rachel Arnould
fb0f379c43
Merge pull request #13823 from chahmedejaz/bugfix/13625-enterprise-fee-reports-throws-504
...
Some Enterprise Fee reports are unusable when managing big shops
2026-02-18 15:22:21 +01:00
Ahmed Ejaz
461fd00ccd
Add specs for non-linked fees by introducing specs for non-admin users. Plus include specs refactoring
2026-02-08 18:06:54 +05:00
Ahmed Ejaz
99e238d92d
Improve reports AJAX search safety, permissions, and TomSelect UX
...
- Sanitize AJAX search queries to safely support wildcard searches (ILIKE)
- Centralize reports search actions in Spree::Ability and reuse across roles
- Fix TomSelect remote loading to fetch on dropdown open and typing
- Surface HTTP errors in TomSelect via showHttpError and improve error handling
- Update dropdown behavior to show proper “no results” feedback
- Move reports AJAX specs to request specs and expand pagination coverage
- Simplify searchable dropdown component attribute passing
2026-02-04 02:25:41 +05:00
Maikel Linke
b9c7925008
Complete Taler payment success scenario
2026-01-29 15:07:28 +11:00
Maikel Linke
c11b93a4dc
Demo Taler flow without validating payment yet
2026-01-29 15:07:28 +11:00
Maikel Linke
dcb6f4676d
Remove all unnecessary spec_helper require statements
...
The `.rspec` file is doing this for us.
2026-01-21 12:35:34 +11:00
David Cook
368da19993
Display more specific invalid_voucher message to customer
...
It was implemented with error code 409 in https://github.com/openfoodfoundation/vine/pull/112
2026-01-12 17:14:57 +11:00
David Cook
4852ee2c6e
Merge pull request #13587 from mkllnk/json-response
...
Clean up request specs testing JSON
2025-10-13 14:24:26 +11:00
Maikel Linke
d3319cfd69
Replace global spec helpers with faster let
2025-10-10 16:44:50 +11:00
Maikel Linke
9460d17417
Publish DFC endpoints as JSON
2025-10-10 16:18:22 +11:00
Maikel Linke
404c07a590
Spec DFC endpoint configuration
...
It looks like puma finds the file only under `/.well-known/dfc` and not
`/.well-known/dfc/` with a slash in staging environment while it works
here in dev and test.
And in any case, just placing the file in `public/` doesn't produce the
right content type.
2025-10-10 16:18:22 +11:00
Ahmed Ejaz
ac06126f59
replace cvv_response_message usage with redirect_auth_url
2025-09-22 11:55:43 +05:00
Maikel Linke
ef22269324
Clarify voucher code not found can mean fully redeemed
2025-05-29 14:18:32 +10:00
cyrillefr
758d78bfe4
Fixes RSpecRailsInferredSpecType
2025-05-21 09:43:24 +02:00
cyrillefr
529f3b85eb
Fixes RSpec Rails HttpStatus offenses
2025-05-15 08:46:02 +02:00
cyrillefr
8135aeaeda
Fixes RSpec Rails HaveHttpStatus cop in requests
2025-05-14 11:04:01 +02:00
cyrillefr
42daf314c4
Fixes variable number naming offenses in spec variables
2025-05-08 09:28:01 +02:00
piyush828-design
0bb6860343
Merge branch 'master' into pagy_upgrade
2025-04-28 11:23:44 +05:30
cyrillefr
8d5292c4ed
Rename set method in spec helper and calls
2025-04-24 09:29:40 +02:00
piyush828-design
da5cef26db
upgraded pagy to latest version
2025-04-16 17:46:31 +05:30
David Cook
176e33d6bf
Rubocop fixes
2025-04-01 09:29:27 +11:00
Tresor11
507705a4eb
Update method name to require
...
This commit updates the method name to be called required_enterprise
since we only expect it to raise an error when the enterprise is not found.
2025-03-31 22:28:38 +03:00
Maikel Linke
2043d1f8df
Remove custom syntactical sugar
...
It just makes Rswag specs look more different to other request specs and
I found that discouraging. It's good to know that the parameter is just
specified with `let` and that it works exactly in the same way as `let`
in other specs.
The downside is maybe that it's not obvious that those `let` statements
have to correspond with the parameters for the request but error
messages will tell you if you got it wrong. And there's also the
`parameter` declaration to make that clear.
2025-02-18 12:58:10 +11:00
David Cook
13f5009563
Refactor
...
Co-authored-by: Maikel <maikel@email.org.au >
2025-02-13 09:34:19 +11:00
David Cook
f6f1a005cb
Add spec
...
Oh, and a transaction block. Because the controller after hooks tried to update the DB which resulted in
PG::InFailedSqlTransaction: ERROR: current transaction is aborted, commands ignored until end of transaction block
Even for a small rescue statement, it's worth adding a spec. You never know what might not be working!
2025-02-12 16:10:36 +11:00
Gaetan Craig-Riou
d102652c03
Fix Vine::VoucherValidatorService to handle exceptions
2024-11-28 13:35:01 +01:00
Gaetan Craig-Riou
9ab2a3ae3d
Per review, fix a some minor issues
2024-11-28 13:35:01 +01:00
Gaetan Craig-Riou
d413a142c9
Update various voucher related file to use the new Vouchers::Vine
2024-11-28 13:35:01 +01:00
Gaetan Craig-Riou
b42cba8c37
Add vine_voucher factory
2024-11-28 13:35:01 +01:00
Gaetan Craig-Riou
7726c7d129
Per review, rename not_vine scope to local
...
- use IS DISTINCT FROM instead of two conditions
- added spec for scope
2024-11-28 13:35:01 +01:00
Gaetan Craig-Riou
12cf62c2ff
Refactor, add OrderManagement::Order::Updater#update_voucher
...
Move the logic to update a voucher and associated order to
`OrderManagement`
2024-11-28 13:35:01 +01:00
Gaetan Craig-Riou
0569b30e0d
Refactor Vine related services
...
Move them under Vine module to keep the code nicely organised
2024-11-28 13:35:01 +01:00
Gaetan Craig-Riou
9f3da1af4f
Reddeem VINE voucher when firing "capture_and_complete_order"o
...
'Spree::Payment#capture_and_complete!' will try to complete the order,
so we want to redeem any VINE voucher associated with the order first.
2024-11-28 13:35:01 +01:00
Gaetan Craig-Riou
afb336d789
Add spec for fire event "capture_and_complete_order"
2024-11-28 13:35:01 +01:00
Gaetan Craig-Riou
92c4cb9b7f
Redeem VINE voucher when creating a new payment
...
Creating a new payment will try to complete the order, so we want to
redeem any VINE voucher associated with the order first
2024-11-28 13:35:01 +01:00
Gaetan Craig-Riou
724d5a2ca0
Add spec for creating a payment from admin page
2024-11-28 13:35:01 +01:00
Gaetan Craig-Riou
3a367ceb6e
Handle adding a VINE voucher to an order
...
Plus specs
2024-11-28 13:35:01 +01:00
Rachel Arnould
f54552f939
Merge pull request #12886 from rioug/12855-VINE-connected-app
...
[Citi OFN Voucher] Add VINE connected app
2024-10-14 15:32:09 +02:00
Gaetan Craig-Riou
08308ba08e
Fix spec checking if VINE api is set up
...
The condition for checking the error now match a real scenario
2024-10-08 16:15:35 +11:00
Gaetan Craig-Riou
df67b53971
Re add VINE_API_URL env variable
...
And add error handling if the variable is not set
2024-10-08 13:26:57 +11:00
Gaetan Craig-Riou
b14a1e72f3
Handle api secret
...
The VINE Api require a secret and an API key to be used. The secret is
used to sign the request. The secret is linked to the API key so we need
to store it along side the key.
2024-10-07 15:09:58 +11:00
Gaetan Craig-Riou
224738e0a1
Per review, clean up code
2024-10-07 15:09:51 +11:00
