Matt-Yorkley
7924865ff8
Set clearer version
2021-03-11 12:19:55 +00:00
Matt-Yorkley
8d8df447c6
Remove debugging
2021-03-11 12:19:55 +00:00
Matt-Yorkley
25139178b5
Fix appending to collection (take 2)
2021-03-11 12:19:55 +00:00
Matt-Yorkley
c827d77236
Fix reloading completed_order_with_fees factory
2021-03-11 12:19:55 +00:00
Matt-Yorkley
4542a3464e
Fix params in Admin::ProductsController
2021-03-11 12:19:55 +00:00
Matt-Yorkley
4c2871e572
Refactor and fix params issues in Admin::OrderCyclesController
2021-03-11 12:19:55 +00:00
Matt-Yorkley
64b52527fd
Fix params issues in Admin::SubsciptionsController
2021-03-11 12:19:55 +00:00
Matt-Yorkley
bbbce4e6c9
Fix params issues in Api::EnterprisesController
2021-03-11 12:19:55 +00:00
Matt-Yorkley
c2c8dbfb38
Add strong params in Api::ExchangeProductsController and deal with boolean issue
2021-03-11 12:19:55 +00:00
Matt-Yorkley
9e83cb65db
Set concurrency spec to pending
...
It's not working at all in Rails 5. There's new concurrency modules in Rails 5, we should investigate them...
2021-03-11 12:19:55 +00:00
Matt-Yorkley
3748d92bc8
Fix modifying taxons in ShopsCaching spec
...
This was triggering an error via the callback Spree::Product#remove_previous_primary_taxon_from_taxons
2021-03-11 12:19:55 +00:00
Matt-Yorkley
aea8d1dc99
Fix appending to Relation in in EnterpriseFeesController
2021-03-11 12:19:55 +00:00
Matt-Yorkley
95b5586f9b
Using strings for keys in FormAdapter spec
2021-03-11 12:19:55 +00:00
Matt-Yorkley
e11d1e6cdb
Add strong params to Spree::Admin::SearchController
2021-03-11 12:19:55 +00:00
Matt-Yorkley
6087a4b969
Fix rendering of javascript template
...
The erb tags in this partial were not being parsed as erb, breaking various other things on the page.
2021-03-11 12:19:55 +00:00
Matt-Yorkley
688b3c98d7
Use strong params in variants search
2021-03-11 12:19:55 +00:00
Matt-Yorkley
4ff56ce625
Update deprecated use of #uniq in OrderCyle scopes
2021-03-11 12:19:55 +00:00
Matt-Yorkley
ccf0556711
Fix params mangling in Admin::EnterprisesController
2021-03-11 12:19:55 +00:00
Matt-Yorkley
83278b17db
Fix test controller issue
2021-03-11 12:19:55 +00:00
Matt-Yorkley
190770b9df
Update query filter params handling
2021-03-11 12:19:55 +00:00
Matt-Yorkley
bd408e02b0
Update OrderCyclesController params usage
2021-03-11 12:19:55 +00:00
Matt-Yorkley
0393ea4219
Update variant params in CartController
2021-03-11 12:19:55 +00:00
Matt-Yorkley
ec597aab1a
Fix params issue in ReportsController expectation
2021-03-11 12:19:55 +00:00
Matt-Yorkley
e46fe3735b
Fix params issue in controller specs
2021-03-11 12:19:54 +00:00
Matt-Yorkley
1911d25959
Fix Sets::ModelSet spec
2021-03-11 12:19:54 +00:00
Matt-Yorkley
29c34060e9
Add tight pinning on wkhtmltopdf-binary gem version
2021-03-11 12:19:54 +00:00
Matt-Yorkley
2ac4ace3e8
Fix params issues in UserPasswordsController
2021-03-11 12:19:54 +00:00
Matt-Yorkley
dcecfaea87
Fix params issues in OrderCyclescontroller spec
2021-03-11 12:19:54 +00:00
Matt-Yorkley
31df28b348
Fix params mangling in Api::ProductController
2021-03-11 12:19:54 +00:00
Matt-Yorkley
304da48d50
Remove dual boot
2021-03-11 12:19:54 +00:00
Matt-Yorkley
f28cd4a4e5
Adapt checkout FormDataAdapter
2021-03-11 12:06:00 +00:00
Matt-Yorkley
fd1b14ca4a
Fix string/integer issues in states controller spec
2021-03-11 12:06:00 +00:00
Matt-Yorkley
ff722e6969
Fix cookie issues in i18n helper spec
2021-03-11 12:06:00 +00:00
Matt-Yorkley
5e3d646f8c
Fix params access in reports views
2021-03-11 12:06:00 +00:00
Matt-Yorkley
dcf982c1c3
Fix params mangling issues in SubscriptionsController
2021-03-11 12:06:00 +00:00
Matt-Yorkley
af8d497433
Fix handling of params in variant overrides bulk update actions
2021-03-11 12:06:00 +00:00
Matt-Yorkley
7bf4f88034
Fix params issues in Api::TaxonsController
2021-03-11 12:06:00 +00:00
Matt-Yorkley
c5feb19e5b
Fix use of ActiveRecord::Type::Boolean#type_cast_from_database
...
This method longer exists.
2021-03-11 12:06:00 +00:00
Matt-Yorkley
009844bfe7
Update expected params in reports controller tests
2021-03-11 12:06:00 +00:00
Matt-Yorkley
0f1142b5c4
Fix more broken specs related to accessing params hash
2021-03-11 12:06:00 +00:00
Matt-Yorkley
ed09db6003
Fix broken specs related to accessing params hash
2021-03-11 12:06:00 +00:00
Matt-Yorkley
2fdb1861a6
Fix uses of ActionController::TestResponse in specs
...
This class has moved / changed slightly.
2021-03-11 12:06:00 +00:00
Matt-Yorkley
5bd1e9c37c
Add rails-controller-testing gem
...
```
Spree::Admin::PaymentMethodsController#create and #update can create a payment method of a valid type
Failure/Error: expect(response).to redirect_to spree.edit_admin_payment_method_path(assigns(:payment_method))
NoMethodError:
assigns has been extracted to a gem. To continue using it,
add `gem 'rails-controller-testing'` to your Gemfile.
# ./spec/controllers/spree/admin/payment_methods_controller_spec.rb:41:in `block (3 levels) in <module:Spree>'
```
2021-03-11 12:06:00 +00:00
Matt-Yorkley
120a2c4f3a
Merge pull request #7036 from Matt-Yorkley/adjustments-callbacks
...
[Adjustments] Reduce adjustments callbacks
2021-03-11 12:59:34 +01:00
Matt-Yorkley
29c5703161
Improve OrdersHelper spec and delete dead code
...
The removed test here was checking for adjustments that have an amount of zero and are eligible. If the amount is zero, it will already be marked as ineligible.
2021-03-11 11:22:35 +00:00
Matt-Yorkley
c5a47b51a6
Update order totals during CheckoutController#update
2021-03-11 11:20:01 +00:00
Matt-Yorkley
714e4f7896
Update test setup in checkout helper spec
2021-03-11 11:20:01 +00:00
Matt-Yorkley
90712647b1
Update totals when processing a return
2021-03-11 11:20:01 +00:00
Matt-Yorkley
4c64aaed77
Remove callbacks in Adjustment that call order.update!
2021-03-11 11:20:01 +00:00
Matt-Yorkley
791a47d170
Merge pull request #6858 from Matt-Yorkley/adjustments-shipping-cost
...
[Adjustments] Move shipping adjustment from order to shipment
2021-03-11 12:17:14 +01:00
