Maikel Linke
7783b28ca2
Update concurrency spec after refactor
...
In order to make the spec fail if the controller was not thread safe, it
uses breakpoints. One of those breakpoints was set for a method that has
now been removed.
I changed the method that is used for the breakpoint and changed `allow`
to `expect` so that this spec will fail if we remove that method as
well. Future version of Rspec will check if a mocked method actually
exists but our version just mocks it anyway. This is one way how specs
can become invalid after refactoring.
2020-02-07 17:46:42 +11:00
Luis Ramos
c38c7c35bc
Add spec for user default address setter
2020-02-05 14:49:17 +00:00
luisramos0
2663f74767
Add specs for new services
2020-02-05 14:49:17 +00:00
luisramos0
b41de52012
Moved checkout services into a specific folder under app/services
2020-02-05 14:49:17 +00:00
luisramos0
214eb43122
Add frozen string literal magic comment
2020-02-05 14:49:17 +00:00
luisramos0
01fc4e0513
Add Spree::CheckoutController only to redirect to CheckoutController
...
I have not managed to make the spree checkout route, that paypal express uses, go to CheckoutController directly. According to the rails docs "to: '/checkout#edit'" should do it, but it doesnt work here.
2020-02-05 14:49:17 +00:00
luisramos0
6ce50a5fa5
Extract paypal redirect logic to service class
2020-02-05 14:49:17 +00:00
luisramos0
4fbd2cfa52
Extract UserDefaultAddress logic into separate class to take more 30 lines out of CheckoutController
2020-02-05 14:49:17 +00:00
luisramos0
383b28e170
Add order and current_user to checkout_form_data_adapter where they are required
...
Also re-add order.state condition to update_result: in some tests, the order state is complete but no completion data (completed?) is present
2020-02-05 14:49:17 +00:00
luisramos0
bf55a15f81
Extract checkout params adaptation logic into a service class
2020-02-05 14:49:17 +00:00
luisramos0
eb7e6dc5b8
Remove spree checkout controller spec, it is no longer necessary
2020-02-05 14:49:17 +00:00
luisramos0
139ecfe604
Remove rubocop exceptions resolved so far in checkout controller
2020-02-05 14:49:17 +00:00
luisramos0
43a6798db2
Move methods around in checkout controller into a more logical organisation: first the filters code and then support code for the update action
2020-02-05 14:49:17 +00:00
luisramos0
06d6579486
Refactor construct_saved_card_attributes to fix rubocop issues
2020-02-05 14:49:17 +00:00
luisramos0
76df526002
Remove dead code from construct_saved_card_attributes
2020-02-05 14:49:17 +00:00
luisramos0
06569ea24c
Refactor load_order to fix rubocop issues
2020-02-05 14:49:17 +00:00
luisramos0
25431f851b
Refactor object_params to fix rubocop issues
2020-02-05 14:49:17 +00:00
luisramos0
bab2420bb3
Break up default address methods to fix rubocop issues
2020-02-05 14:49:17 +00:00
luisramos0
0b2acb3a76
Extracted two methods from checkout_workflow to fix rubocop issues
2020-02-05 14:49:17 +00:00
luisramos0
27db9e604f
Extract respond_to_update_succeeded from update_succeeded
2020-02-05 14:49:17 +00:00
luisramos0
c4e58ebb9e
Extract update_succeeded from checkout#update
2020-02-05 14:49:17 +00:00
luisramos0
9a0ee254af
Extract checkout_workflow from checkout#update
2020-02-05 14:49:17 +00:00
luisramos0
5ce3e1e0d2
Fix some rubocop issues in checkout controller
2020-02-05 14:49:17 +00:00
luisramos0
4b345d928c
Remove old code to detect Phantom Fees, no bugsnag events detected at all
2020-02-05 14:49:17 +00:00
luisramos0
52b1e6c71a
Move all logic required in Spree::CheckoutController to CheckoutController
2020-02-05 14:49:17 +00:00
Maikel
747be81aec
Link to new release template
2020-02-05 15:21:26 +11:00
Maikel
fd124daf50
Add task to notify instance managers of upcoming changes
2020-02-05 14:58:57 +11:00
Luis Ramos
81103f3f71
Merge pull request #4742 from CSCI-462-01-2020/Issue4109
...
Edit new_resource partial
2020-02-04 19:44:16 +00:00
Luis Ramos
a8b48a561f
Merge pull request #4733 from lin-d-hop/master
...
Fixing incorrect payment and balance calculation
2020-02-04 18:11:48 +00:00
Luis Ramos
c7038f6ac9
Merge pull request #4620 from luisramos0/spree_backend_css
...
Bring basic CSS rules from spree backend
2020-02-04 18:06:15 +00:00
Luis Ramos
ea75714561
Merge pull request #4635 from luisramos0/main_app_routes
...
Replace use of spree.root_path and root_url with main_app.root_path and main_app.root_url
2020-02-04 16:02:48 +00:00
luisramos0
f48ab57782
Add explicit css import statements where they are needed
2020-02-04 14:52:44 +00:00
luisramos0
8b6ebfb351
Add imports for new css files from spree_backend
2020-02-04 14:52:44 +00:00
luisramos0
9c0788c3e0
Bring shared css rules from spree_backend
2020-02-04 14:52:17 +00:00
luisramos0
f61258d0b4
Bring components css from spree_backend
...
pagination and navigation rules were merged
2020-02-04 14:52:17 +00:00
luisramos0
289f62f115
Bring and require date picker css from spree_backend
2020-02-04 14:52:17 +00:00
luisramos0
c3a98d5a4f
Bring css dependencies from spree_backend
...
These dependencies are in spree_core so we dont need to bring them to ofn right now
2020-02-04 14:52:17 +00:00
Luis Ramos
d8374e9caa
Merge pull request #4614 from luisramos0/base_admin_js
...
Bring some basic js functions and dependencies from spree_backend
2020-02-04 14:48:38 +00:00
luisramos0
0648f23e94
Move css dependencies to specific css files and add some required dependencies from spree_backend
2020-02-04 14:47:51 +00:00
luisramos0
e37cb2d63f
Remove underscope from select2 css file name
2020-02-04 14:47:51 +00:00
luisramos0
ee64238bdd
Add jquery.adaptivemenu require but commeent out the activation for now because it is already called in spree_backend
...
This can be reverted when spree_backend is removed
2020-02-04 14:47:51 +00:00
luisramos0
d3130e111f
Remove on click events
...
These events can only be added to OFN when spree_backend is removed otherwise the evetns will be registered twice
2020-02-04 14:47:51 +00:00
luisramos0
93f4eee887
Make newly imported js files compatible with the karma build
2020-02-04 14:47:51 +00:00
luisramos0
408ada9097
Remove unnecessary build exception
2020-02-04 14:47:51 +00:00
luisramos0
e14ebd9503
Add required variables from spree_backend
2020-02-04 14:47:51 +00:00
luisramos0
289b99c30e
Bring and require equalize from spree_backend
2020-02-04 14:47:26 +00:00
luisramos0
f85c36a17e
Bring and require select2 from spree_backend
2020-02-04 14:47:26 +00:00
luisramos0
4715df3258
Bring and require jquery.horizontalNav.js from spree_backend
2020-02-04 14:47:26 +00:00
luisramos0
b20be101cc
Bring and require spin from spree_backend and respective progress indicator js and css
2020-02-04 14:47:26 +00:00
luisramos0
d424987587
Bring and require jquery.vAlign.js from spree_backend
2020-02-04 14:47:26 +00:00
