Enrico Stano
2f3f20e433
Remove html_safe and add spec
2017-09-08 23:55:50 +10:00
Pau Perez
85fefcd946
Replace helper with service object
2017-09-08 23:55:50 +10:00
Pau Perez
e087a008c2
Reduce coupling from controller
2017-09-08 23:55:50 +10:00
Pau Perez
4c4969e86b
Do not couple with controller's ivar and session
2017-09-08 23:55:50 +10:00
Pau Perez
f6c8a11b7b
Move ResetOrderService to new app/services
2017-09-08 23:55:50 +10:00
Pau Perez
1ef4bf5da0
Refactor tests and remove duplicated ones
2017-09-08 23:55:50 +10:00
Pau Perez
a18bf4b666
Add unit tests for service object
2017-09-08 23:55:50 +10:00
Pau Perez
bdfd718c51
Use service object directly from controller
2017-09-08 23:55:50 +10:00
Pau Perez
3c73282d57
Manually reset the order once completed
...
Spree does not call after_<order.state> methods any more as of
https://github.com/spree/spree/pull/2557 , so our #after_complete method
is never triggered and thus the order never reset.
This makes the condition:
```ruby
if current_order.andand.distributor == @order.distributor
```
in app/views/spree/orders/form/_update_buttons.html.haml return false
and as a result the "Back To Cart" button is not shown.
This commit resets the order (emptying the session[:order_id] and
creating a new order, aka. cart) right from the
CheckoutController#update rather than relying on infernal callbacks (of
what the Spree core team itself was unhappy about since long ago
https://github.com/spree/spree/issues/2488 ). There is the first place
where we know the order has been successfully completed.
2017-09-08 23:55:50 +10:00
Enrico Stano
d09e0cd44a
Deal with both JS and JSON format
2017-09-08 23:55:50 +10:00
Enrico Stano
d581fc4863
Fix specs to contemplate XHR requests and more coverage
2017-09-08 23:55:50 +10:00
Enrico Stano
7874d96003
Set MailMethod for test environment when needed
2017-09-08 23:55:50 +10:00
Enrico Stano
8e5b94b5ca
Fixing orders controller issue by setting data up correctly
2017-09-08 23:55:49 +10:00
Enrico Stano
4a989f705b
No more order.payment
2017-09-08 23:55:49 +10:00
Rob Harrington
3e6e3173ee
Fixing line item controller issue by setting data up correctly
2017-09-08 23:55:49 +10:00
enricostano
6816061915
Fix confirmation email subject
...
c38537173f
2017-09-08 23:55:49 +10:00
enricostano
cf4bd8d755
WIP Preparing to get rid of MailMethod model
...
Please give a look at the following links:
- http://guides.spreecommerce.org/release_notes/spree_2_0_0.html#mailmethod-model-no-longer-exists
- https://github.com/spree/spree/pull/2643
2017-09-08 23:55:49 +10:00
enricostano
5ad0f8bb2e
Fix module namespace
2017-09-08 23:55:49 +10:00
Em-AK
b5bac722ca
Fix: make rspec run
2017-09-08 23:55:49 +10:00
Em-AK
31f2551116
Update the JS unit spec to the new endpoint
2017-09-08 23:55:49 +10:00
enricostano
513330cfff
Add JSON api for products clone
2017-09-08 23:55:49 +10:00
Rohan Mitchell
0a8e8dfbbb
Add specs and fix line items HTML response
2017-09-08 23:55:49 +10:00
Rohan Mitchell
0446b8d72f
TestingSupport moved out of Core namespace
2017-09-08 23:55:48 +10:00
Rohan Mitchell
38da4c8e12
Adjustments now have state instead of locked/unlocked
2017-09-08 23:55:48 +10:00
leandroalemao
c70de9f73c
Fix i18n translation keys for Edit Product Page
2017-09-08 09:27:20 +01:00
Matt-Yorkley
a76b64b80b
Spec for missing password confirmation
2017-08-18 13:59:54 +10:00
Pau Perez
1f2820f6d4
Add #delivery? in ShippingMethod
2017-08-11 14:41:02 +10:00
Pau Perez
22f018f2bc
Fix all specs of LastUsedAddress
2017-08-11 14:41:02 +10:00
Julius Pabrinkis
ec6a365227
Add test coverage for switching language in darkswarm and admin
2017-08-02 09:57:33 +10:00
Julius Pabrinkis
c6f6f5bc55
Adapt karma js tests for i18n-js
2017-08-02 09:57:33 +10:00
Rob Harrington
7c0feab08f
Fix #1526 : add descriptions for reports *before* they are filtered
2017-07-28 17:15:57 +10:00
Maikel
6e57f917d2
Merge pull request #1736 from oeoeaio/fix-zeus-crash
...
Fix zeus issue caused by location of iframe_test.html
2017-07-28 16:31:41 +10:00
Rob Harrington
66a85bb99f
Revert translations of Xero report headers
2017-07-28 12:07:52 +10:00
Rob Harrington
9f6931ba18
Move embedded shopfronts iframe view into spec/support/views
...
Was causing issues with zeus where it was (in spec/dummy)
Didn't get to the bottom of what was happening, this was
just a quick, simple and zero-cost solution
2017-07-28 11:54:48 +10:00
Matt-Yorkley
6215777986
Shopfront review adjustments
2017-07-26 13:56:36 +10:00
Matt-Yorkley
782a812596
Basic Embedded Shopfronts
2017-07-26 13:56:36 +10:00
Matt-Yorkley
113f6565be
Enable iframes for embedded shopfronts
2017-07-26 13:56:36 +10:00
Maikel Linke
b8c2e54194
Fix i18n key and spec
2017-07-21 12:17:14 +10:00
Julius Pabrinkis
9971c9f923
Extract translations from models
2017-07-21 12:17:12 +10:00
Julius Pabrinkis
974099747b
Fix failing specs after text extraction
2017-07-21 12:17:12 +10:00
Julius Pabrinkis
55b2c19b64
Extract translations from lib folder
2017-07-21 12:17:12 +10:00
Duende13
705295049e
Improved test for variant serializer
2017-07-21 10:18:55 +10:00
Duende13
a07fd854f6
New test for variant serializer
2017-07-21 10:18:55 +10:00
François Turbelin
a0595bc45a
Add missing translations on views
2017-07-19 09:45:11 +10:00
Pau Perez
cee24dcca7
Use indented style for multiline method calls
...
This enables the Rubocop's Style/MultilineMethodCallIndentation cop with
indentend enforced style. Which makes you split multiline method calls like:
orders = Spree::Order
.an_scope
.another_scope
.where(id: list_of_ids)
It also autofixes the current violations and updates the
rubocop_todo.yml
2017-07-12 10:40:53 +02:00
Pau Perez
1028b49719
Stop using Order#shipment as it will be deprecated
...
Spree 2.0 adds a deprecation warning to it and Spree 2.1 removes it.
2017-07-05 16:33:04 +10:00
Diogo Matsubara
386d651678
Fix #1611 (Rephrase error message for people logging in with an existing user email)
...
update test to use new rspec syntax
2017-06-28 15:35:21 +10:00
Rob Harrington
c7ed27286a
Rubocop: Correct Lint/ParenthesesAsGroupedExpression offences
2017-06-23 17:02:20 +10:00
Rob Harrington
28ea23965b
Rubocop: Correct Lint/AmbiguousOperator offences
2017-06-23 16:49:08 +10:00
Rob Harrington
7bb58342fc
Rubocop: Auto-correct Style/EmptyLineBetweenDefs offences
2017-06-23 16:49:08 +10:00
