luisramos0
c33ca508f7
Add guard clause on variant overrides filter in case hub id is not present in the hubPermissions
2018-12-06 15:35:44 +11:00
Maikel
1b94b10bb0
Merge pull request #3171 from luisramos0/2-0-var-over-hide
...
[Spree Upgrade] Remove hide class from the hide button in the inventory list
2018-12-06 15:21:34 +11:00
Maikel
3a3c9f3847
Merge pull request #3177 from coopdevs/dont-clean-db-twice-in-feature-specs
...
Do not clean DB twice on feature specs
2018-12-06 12:36:34 +11:00
luisramos0
7df869bd35
Fix line_item_controller spec by adpating to new spree 2 factories
2018-12-05 22:22:15 +00:00
haseleyi
75277e92e4
Lazy-load the translations for images step of registration
2018-12-05 11:36:27 -08:00
dependabot[bot]
727cc9d578
Bump rspec-rails from 3.7.2 to 3.8.1
...
Bumps [rspec-rails](https://github.com/rspec/rspec-rails ) from 3.7.2 to 3.8.1.
- [Release notes](https://github.com/rspec/rspec-rails/releases )
- [Changelog](https://github.com/rspec/rspec-rails/blob/master/Changelog.md )
- [Commits](https://github.com/rspec/rspec-rails/compare/v3.7.2...v3.8.1 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2018-12-05 19:19:50 +00:00
dependabot[bot]
ebff8be996
Bump oj from 3.6.10 to 3.7.4
...
Bumps [oj](https://github.com/ohler55/oj ) from 3.6.10 to 3.7.4.
- [Release notes](https://github.com/ohler55/oj/releases )
- [Changelog](https://github.com/ohler55/oj/blob/master/CHANGELOG.md )
- [Commits](https://github.com/ohler55/oj/compare/v3.6.10...v3.7.4 )
Signed-off-by: dependabot[bot] <support@dependabot.com >
2018-12-05 19:16:55 +00:00
luisramos0
afd243c548
Replace stub with allow in checkout_controller_spec
2018-12-05 15:40:14 +00:00
luisramos0
bbc61b4eda
Bump roadie-rails to 1.1.1
2018-12-05 15:11:45 +00:00
Pau Pérez Fabregat
1052d98255
Merge pull request #3175 from haseleyi/patch-1
...
Fix link to Mac setup guide in Getting Started
2018-12-05 12:52:08 +01:00
luisramos0
460e010408
Removed shipments from orders tab. This option is removed in spree 2
2018-12-05 11:38:16 +00:00
Pau Pérez Fabregat
72a4b4f8e2
Merge pull request #3158 from luisramos0/2-0-vos-scoping
...
[Spree Upgrade] Scopes variants on order completion and on changes to completed orders
2018-12-05 12:12:49 +01:00
Kristina Lim
842a8e3654
Move null option for VO use_producer_settings to JS
2018-12-05 17:40:32 +08:00
Kristina Lim
802e3bb447
Refactor choosing VO on_demand in feature specs
...
We are still using the Rails view I18n scope for :use_producer_settings.
Angular requires this replacement of the default blank option, which we
use for nil on_demand, to be in the template itself.
If we eventually move this template to a JS template, we can move it to
the same I18n scope as the :yes and :no options.
2018-12-05 17:40:31 +08:00
Kristina Lim
d8908bdf4b
Remove unused translation keys js.yes and js.no
2018-12-05 17:40:31 +08:00
Kristina Lim
47d51ca525
Prefer guard clause in updateCountOnHand for VOs
2018-12-05 17:40:31 +08:00
Kristina Lim
34c34b94d1
Describe method countOnHandPlaceholder for VOs
2018-12-05 17:40:30 +08:00
Kristina Lim
cff4eb0005
Improve and simplify VO count on hand suggestions
...
Set variant override count_on_hand in UI to variant count_on_hand value
if on_demand is changed and both specify limited stock.
2018-12-05 17:40:30 +08:00
Kristina Lim
4f2d96d763
Use correct placeholders for VO count_on_hand
2018-12-05 17:40:29 +08:00
Kristina Lim
f5dc03e118
Style disabled text fields in admin pages
2018-12-05 17:40:29 +08:00
Kristina Lim
09b9f968b7
Make VO count on hand readonly unless limited stock
2018-12-05 17:40:29 +08:00
Kristina Lim
cc003c99d5
Ensure in UI compatible VO count and on demand
2018-12-05 17:40:28 +08:00
Kristina Lim
a32bb0445f
Change translation for variant override use_producer_settings
2018-12-05 17:40:28 +08:00
Kristina Lim
7ae555cd9c
Translate variant override on_demand yes and no
2018-12-05 17:40:27 +08:00
Kristina Lim
4b3198a2b4
Allow reset of "on demand" for variant overrides
...
Change the UI control for "on demand" in the Inventory page from a
checkbox to a SELECT field with three options: nil, true, and false.
This resolves the following issues:
* There is no way to tell between nil and false - both are represented
by an unticked checkbox.
* There is no way to go back to nil.
2018-12-05 17:40:24 +08:00
Pau Perez
6af8544c52
Restore perform_deliveries value in tests
2018-12-05 10:20:13 +01:00
Pau Perez
25eb297215
Perform delivery when checking deliveries in specs
2018-12-05 10:05:39 +01:00
Pau Perez
064d9cf183
Do not hide flaky tests under endless retries
...
If it fails, needs fixing, not hiding the problem and making the test
suite longer.
2018-12-05 10:05:39 +01:00
Pau Perez
5845f80af0
Remove commented out code
...
Because git keeps it for you.
2018-12-05 10:05:39 +01:00
Pau Perez
6594529cda
Fix manager invitation controller spec
2018-12-05 10:05:39 +01:00
Pau Perez
25567d6bd6
Do not clean DB twice on feature specs
...
It turns out that we were executing `DatabaseCleaner.clean` on two
`after(:each)` blocks. One for all specs and another one for `js: true`
specs. As a result feature specs were hitting both which slows them down
considerably.
On my machine this changes consistently saves 2sec on
`spec/features/consumer/shops_spec.rb` but chances are it has an
accumulative effect when run on the whole test suite.
2018-12-05 09:58:14 +01:00
Pau Pérez Fabregat
3b56212290
Merge pull request #3151 from coopdevs/remove-frontoffice-enterprises-n+1
...
Remove frontoffice enterprises n+1
2018-12-05 08:12:19 +01:00
Pau Pérez Fabregat
e5a267f4c2
Merge pull request #2735 from luisramos0/cookies_colors
...
Moved definition of colors in the cookies modal and banner colors to common darkswarm/base/colors
2018-12-05 08:06:58 +01:00
haseleyi
94d12217de
Fix untranslated buttons at image step of registration modal
2018-12-04 21:30:42 -08:00
Isaac Haseley
76e5d281bf
Fix link for Mac setup guide
2018-12-04 20:37:23 -08:00
Maikel
609a4fde4d
Merge pull request #3173 from openfoodfoundation/transifex
...
Transifex
2018-12-05 11:55:29 +11:00
Maikel
a2c8bea147
Merge pull request #3147 from luisramos0/2-0-vos
...
[Spree Upgrade] Adapt variant overrides to spree 2
2018-12-05 10:50:20 +11:00
Transifex-Openfoodnetwork
18a5f53330
Updating translations for config/locales/fr.yml
2018-12-05 09:17:00 +11:00
haseleyi
e863c3dec8
Fix broken link in register call partial
2018-12-04 10:23:46 -08:00
Pau Pérez Fabregat
24415226bf
Merge pull request #3168 from luisramos0/google-maps-comment-specs
...
Temporarily xit 2 broken specs (shops and producers search by url)
v1.23.1
2018-12-04 19:13:40 +01:00
Transifex-Openfoodnetwork
9bedc69df8
Updating translations for config/locales/en_GB.yml
2018-12-05 04:52:44 +11:00
luisramos0
02d0b7e88c
Improve comment on VariantStock#move
2018-12-04 15:25:38 +00:00
Pau Pérez Fabregat
30e7d32cea
Merge pull request #3157 from coopdevs/fix-producer-mailer-specs
...
[Spree Upgrade] Specify :mailer type in specs
2018-12-04 15:21:17 +01:00
luisramos0
7dc208fb8c
Temporarily move 2 broken specs to pending (shops and producers search by url) due to google maps api changes
2018-12-04 13:20:20 +00:00
luisramos0
7f7e7ea65e
Remove hide class from the hide button in the inventory list
...
The hide button should not be hidden. The hide css class was no active in v1 but it is in v2, so we need to remove it
2018-12-04 10:55:55 +00:00
Maikel Linke
66585e93a8
Update all locales with the latest Transifex translations
2018-12-04 14:48:03 +11:00
Maikel
60c8147391
Merge pull request #3164 from luisramos0/2-0-stable-dec-3rd
...
[Spree Upgrade] Merging master into 2-0-stable (first run in Dec2018)
2018-12-04 13:38:02 +11:00
Maikel
214235d8dd
Merge pull request #3152 from coopdevs/fix-product-spec
...
[Spree Upgrade] Fix product spec
2018-12-04 12:07:33 +11:00
luisramos0
3776b891ce
Merge branch 'master' into 2-0-stable-dec-3rd
2018-12-03 15:30:16 +00:00
Pau Perez
46bf4c9eea
Specify :mailer type in specs
...
According to RSpec docs we need to specify type: :mailer for mails to
work. Check it out:
https://relishapp.com/rspec/rspec-rails/v/3-8/docs/mailer-specs .
This fixes all specs in producer_mailer_spec.rb.
2018-12-03 15:41:58 +01:00