luisramos0
14c03ead31
Extract CardCloner to separate class
2020-02-21 10:56:32 +00:00
luisramos0
4480c2f0f0
Add logic to stripe_sca gateway to handle cards stored in the platform account with the stripe Charges API: card_*
2020-02-21 10:56:32 +00:00
luisramos0
b3ac5d8f41
Improve code readability a little
2020-02-21 10:52:56 +00:00
luisramos0
6fb74c88cd
Fix a typo
2020-02-21 10:52:56 +00:00
luisramos0
38fd028a9f
Fix some rubocop issues from previous commit
2020-02-21 10:52:56 +00:00
luisramos0
4e84310d63
Add StripeSCA where StripeConnect is treated as an exception in the setting up of process of a payment method and subscriptions
...
Here we are copy pasting and adding stripe SCA because we are planning to delete the StripeConnect that will be replaced by the stripe sca implementation
2020-02-21 10:52:56 +00:00
luisramos0
66440f9e4c
Add missing translations for new payment method stripe sca
2020-02-21 10:52:56 +00:00
luisramos0
b8457ebece
Make profile storer a bit easier to read
2020-02-21 10:52:56 +00:00
Luis Ramos
668fd1c7c0
Add spec for profile storer to cover happy path for both response attribute cases: existin stripe integration and new stripe sca
2020-02-21 10:52:55 +00:00
Luis Ramos
aff934c814
Remove unnecessary test setup code
2020-02-21 10:52:55 +00:00
Luis Ramos
6bb04f6cc6
Adapt stripe_sca_spec to actual stripe SCA API
2020-02-21 10:52:55 +00:00
luisramos0
0e815439b3
Duplicate stripe_connect_spec and adapt to new stripe_sca
...
stripe_connect_spec will be deleted at some point when all users are migrated to the sca api
2020-02-21 10:52:55 +00:00
luisramos0
c7b01c37af
Fix a problem in credit cards controller spec and test case where stripe_account_id must be included in the stripe api call
2020-02-21 10:52:55 +00:00
luisramos0
ac8f3c811f
Fix rubocop issues in some stripe integration related files
2020-02-21 10:52:55 +00:00
luisramos0
1b820ea85c
Fix rubocop issues in credit_cards_controller
2020-02-21 10:52:55 +00:00
luisramos0
ec7b91bb68
Make ProfileStorer a bit easier to read
2020-02-21 10:52:29 +00:00
luisramos0
c773cde191
Add admin payment template for stripe sca and respective js code to make it work
2020-02-21 10:52:29 +00:00
luisramos0
db1065a69e
Make saving a card on checkout work with the payment intents api by making profile storer work with the slightly different api responses from stripe
2020-02-21 10:52:29 +00:00
luisramos0
9fa4bad0b4
Add stripe SCA checkotu payment template and move stripe object definition to it and the other stripe template
...
We need to set the stripe object with the stripe account id to work with the payment intents api but we cannot set it to work with the stripe charges api
This makes the two payment methods incompatible: a given enterprise cannot use both the old stripe integration and this new one at the same time.
2020-02-21 10:52:29 +00:00
luisramos0
a52c4b542c
Make destroy stored cards work for stripe SCA by setting stripe account id before making the call to the stripe api
...
This account id cannot be sent when dealing with the old StripeConnect gateway
2020-02-21 10:52:29 +00:00
luisramos0
283abf9a88
Remove dead code from Stripe connect gateway
...
Update Source is dead since a74c502fd9
2020-02-21 10:52:29 +00:00
luisramos0
f691d1aafd
Add new payment method StripeSCA that will use the Stripe Payment Intents API instead of the Stripe Charges API that the current StripeConnect gatreway uses
2020-02-21 10:52:29 +00:00
luisramos0
5724c3bb0a
Add code from ActiveMerchant v1.98.0 that supports the Stripe Payment Intents API
...
This commit can be reverted once we upgrade to v1.98.0
2020-02-21 10:52:29 +00:00
Transifex-Openfoodnetwork
49ba83da6d
Updating translations for config/locales/en_GB.yml
2020-02-21 05:32:39 +11:00
Transifex-Openfoodnetwork
19d1497c4b
Updating translations for config/locales/en_GB.yml
2020-02-21 05:29:31 +11:00
Luis Ramos
06200c9d3c
Add new cops (disabled) to rubocop config
2020-02-20 18:04:43 +00:00
Luis Ramos
2412658e51
Update db/schema timestamp according to last change
2020-02-20 11:41:49 +00:00
Luis Ramos
0c4f22f847
Fix images/new.js path and add simple spec to verify the page loads correctly
...
Testing the file upload would be a bit more complicated
2020-02-20 11:18:22 +00:00
Luis Ramos
1803ea3c38
Add traling breakline to case where errors come in a array
2020-02-20 10:06:10 +00:00
Pau Pérez Fabregat
93fda02e43
Merge pull request #4803 from openfoodfoundation/dependabot/bundler/rubocop-0.80.0
...
Bump rubocop from 0.79.0 to 0.80.0
2020-02-20 09:34:10 +01:00
Pau Pérez Fabregat
77958f9afe
Merge pull request #4796 from openfoodfoundation/dependabot/bundler/i18n-js-3.6.0
...
Bump i18n-js from 3.5.1 to 3.6.0
2020-02-20 09:32:02 +01:00
Maikel Linke
82e402f31a
Update translations from Transifex
v2.7.6
2020-02-20 16:20:06 +11:00
Maikel Linke
03fa3e2269
Find last payment deterministically
2020-02-20 15:59:57 +11:00
Maikel Linke
11fbe7d5c9
Show last payment method in order confirmations
2020-02-20 15:59:57 +11:00
Maikel Linke
799c1f08de
Optimise finding last payment
...
Suggested by Rubocop.
2020-02-20 15:59:56 +11:00
Maikel Linke
6b66458bfd
Replace andand with new Ruby syntax
2020-02-20 15:59:56 +11:00
Maikel Linke
3e0a5bac6a
Move helper to service for re-use
2020-02-20 15:59:56 +11:00
Maikel Linke
2c2023df03
Show last payment method in order confirmation
...
If we had multiple failed payments and then a successful payment, the
order confirmation was displaying the payment method of the first failed
payment. That was confusing and is now changed to the last payment
method.
2020-02-20 15:59:56 +11:00
Maikel Linke
7306d379a5
Display payment method literally
...
Don't allow for HTML and potentially bad scripts. But this also prevents
accidental display errors. If someone wrote, "We only take <cash>", it
would mess with the site.
2020-02-20 15:59:56 +11:00
Maikel Linke
e15c61d862
Add spec for order confirmation view
2020-02-20 15:59:56 +11:00
Maikel
35aeb98d45
Merge pull request #4792 from openfoodfoundation/transifex
...
Transifex
2020-02-20 10:43:45 +11:00
Luis Ramos
d99cba3b6e
Merge pull request #4709 from mkllnk/4172-js-pluralize
...
Pluralize common variant unit names
2020-02-19 22:28:54 +00:00
dependabot-preview[bot]
4c6fd96bcc
Bump rubocop from 0.79.0 to 0.80.0
...
Bumps [rubocop](https://github.com/rubocop-hq/rubocop ) from 0.79.0 to 0.80.0.
- [Release notes](https://github.com/rubocop-hq/rubocop/releases )
- [Changelog](https://github.com/rubocop-hq/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop-hq/rubocop/compare/v0.79.0...v0.80.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
2020-02-18 19:18:53 +00:00
Luis Ramos
1eba17f048
Make select column explicit to avoid too many columns sql error
2020-02-18 18:32:52 +00:00
dependabot-preview[bot]
ff088c6203
Bump stripe from 5.11.0 to 5.15.0
...
Bumps [stripe](https://github.com/stripe/stripe-ruby ) from 5.11.0 to 5.15.0.
- [Release notes](https://github.com/stripe/stripe-ruby/releases )
- [Changelog](https://github.com/stripe/stripe-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/stripe/stripe-ruby/compare/v5.11.0...v5.15.0 )
Signed-off-by: dependabot-preview[bot] <support@dependabot.com >
2020-02-18 12:01:10 +00:00
Luis Ramos
a1cb6928db
Merge pull request #4793 from openfoodfoundation/dependabot/bundler/webmock-3.8.2
...
Bump webmock from 3.8.1 to 3.8.2
2020-02-18 11:59:14 +00:00
Luis Ramos
40a5b60dcb
Merge pull request #4794 from openfoodfoundation/dependabot/bundler/oauth2-1.4.4
...
Bump oauth2 from 1.4.3 to 1.4.4
2020-02-18 11:58:58 +00:00
Luis Ramos
2711736004
Use Array#join and make code simpler
2020-02-18 10:49:41 +00:00
Luis Ramos
18c165e893
Merge pull request #4784 from CSCI-462-01-2020/Issue4731
...
Add Order Cycle Button Tooltips
2020-02-17 19:32:39 +00:00
Luis Ramos
0aaa04295b
Improve and unit test errorsParser
2020-02-17 11:21:21 +00:00