Luis Ramos
e52937c113
Use rubocop auto correct to add frozen string literal to all files
...
This is an unsafe auto corection, we will need to trust our build here
2021-06-17 23:07:26 +01:00
Luis Ramos
23627c5453
Run rubocop -a (safe corrections) removing all exceptions so all possible fixes are applied
...
9290 issues fixed
2021-06-17 22:19:26 +01:00
Matt-Yorkley
c1c69b00b4
Update order explicitly in OrderSyncer
2021-06-04 17:10:50 +01:00
Luis Ramos
f848a89a00
Rename update_attributes to update #rails4
2020-06-22 16:51:43 +01:00
luisramos0
9404aacfb2
run rubocop --auto-correct
2019-11-10 18:42:43 +00:00
luisramos0
d0c246c345
Fix some rubocop issues
2019-07-14 12:28:32 +01:00
luisramos0
0f3404ca27
Rename order_syncer.future_and_undated_orders to explicitly include completed orders from current OC: orders_in_order_cycles_not_closed
2019-07-12 22:20:09 +01:00
Kristina Lim
19726061e4
Make Order#address_from_distributor public
2019-05-01 07:17:50 +08:00
Kristina Lim
92dc43d7a2
Make OrderUpdater#shipping_address_from_distributor public
2019-05-01 07:16:56 +08:00
Kristina Lim
0933d53134
Extract method OrderSyncer#update_ship_address_for
2019-05-01 07:16:56 +08:00
Kristina Lim
14d407879c
Rename method OrderSyncer#update_ship_address_for
...
This method has become only a small part of the logic for updating the
order's ship address. This no longer follows the method naming
convention within OrderSyncer where update_*_for describes almost the
complete logic for updating the association.
This is renamed in preparation for extraction of the complete update
logic for ship_address. The new method will be named
update_ship_address_for.
2019-05-01 07:16:56 +08:00
Kristina Lim
6952f4ecd1
Improve readability of conditions in OrderSyncer
2019-05-01 07:16:55 +08:00
Kristina Lim
78aa9da2cf
Uncomment and update OrderSyncer failing specs
...
This still achieves a logic issue before the Spree upgrade, where
switching from pick-up to delivery affects whether simultaneous changes
to shipping address are ignored or not.
This behaviour can be fixed in a separate PR.
2019-05-01 07:16:54 +08:00
Kristina Lim
7505dd0410
Make order sync for shipping methods readable
2019-03-15 07:59:54 +11:00
Kristina Lim
a261d912ea
Simplify order sync logic for shipping methods
2019-03-13 12:45:54 +08:00
Kristina Lim
9316096d4d
Fix updating of the shipping method for an order
2019-03-13 12:45:54 +08:00
Kristina Lim
5b5d1967fd
Fix queries for pending order shipment in OrderSyncer
2019-03-13 12:45:53 +08:00
Pau Perez
b23cb55525
Fix current violations of Style/Send cop
2018-09-05 12:05:05 +02:00
Rob Harrington
c59b172348
Fix typo
2018-02-09 14:44:15 +11:00
Rob Harrington
7017c8540c
Replace references to 'standing line item' with 'subscription line item'
2018-02-09 14:44:15 +11:00
Rob Harrington
71370e0bce
Replace references to 'standing order' with 'subscription' (cleanup)
2018-02-09 14:44:14 +11:00
Rob Harrington
672f96b85b
Replace references to 'standing order' with 'subscription'
2018-02-09 14:44:13 +11:00
Rob Harrington
224249d66b
Reduce cognitive complexity of OrderSyncer
2018-02-09 14:44:11 +11:00
Rob Harrington
3e68973812
Rename StandingOrderUpdater to OrderSyncer
2018-02-09 14:44:11 +11:00
