raggedstaff/openfoodnetwork
1
0
Fork 0
mirror of https://github.com/openfoodfoundation/openfoodnetwork synced 2026-01-24 20:36:49 +00:00
Code Issues Packages Projects Releases Wiki Activity

Simplify order sync logic for shipping methods

Browse Source
This commit is contained in:
Kristina Lim
2019-03-12 16:08:17 +08:00
parent 9316096d4d
commit a261d912ea
1 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
app/services/order_syncer.rb
View File

@@ -67,13 +67,12 @@ class OrderSyncer
def update_shipment_for(order)
shipment = order.shipment
return track_shipping_method_issue(order) if shipment.blank?
if shipment.andand.state == "pending" && shipment.shipping_method.id == shipping_method_id_was
if shipment.state == "pending" && shipment.shipping_method.id == shipping_method_id_was
order.select_shipping_method(shipping_method_id)
else
unless shipment.andand.state == "pending" && shipment.shipping_method.id == shipping_method_id
order_update_issues.add(order, I18n.t('admin.shipping_method'))
end
elsif !(shipment.state == "pending" && shipment.shipping_method.id == shipping_method_id)
track_shipping_method_issue(order)
end
end
@@ -106,4 +105,8 @@ class OrderSyncer
order.ship_address[attr] == distributor_address[attr]
end
end
def track_shipping_method_issue(order)
order_update_issues.add(order, I18n.t('admin.shipping_method'))
end
end