David Cook
55ece0553c
Revert. JS is still required for most specs
...
But models can still run without.
Half of the controller runs also succeeded, so we could potentially separate those ones out.
Hmm, yes only 7 of them. It would save 20s, or 16% of controller CI runtimesi which are 2min. let's try..
2024-04-29 17:02:09 +10:00
David Cook
1a55ae2035
Skip JS setup for non-JS tests
...
These tests don't run in the browser, therefore shouldn't need JavaScript at all.
2024-04-29 17:02:09 +10:00
David Cook
ce36b81f15
Run multiple rake tasks in one process
...
It saves the second unnecessary Rails boot-up (multiple seconds).
2024-04-29 17:02:09 +10:00
David Cook
6eaf0a00a0
Revert. Rails is required for the Karma rake script
...
But surely we could convert it to a shell or node script. Maybe next time..
2024-04-29 17:01:22 +10:00
David Cook
7c53c25aaf
Skip Ruby setup for non-Ruby tests
...
Conversely, these tests are JS-only.
2024-04-29 17:00:56 +10:00
Gaetan Craig-Riou
442991ac7b
Merge pull request #12413 from rioug/check-invalid-address-task
...
Add task to check for invalid address
2024-04-29 10:13:30 +10:00
David Cook
1dc5a1ab56
Merge pull request #12410 from mkllnk/dfc-website-url
...
Publish enterprise website with https://
2024-04-29 10:12:16 +10:00
David Cook
2e10948fff
Merge pull request #12391 from kellyzhangg/8633-payments-controller-test
...
Add payments controller test
2024-04-29 10:09:03 +10:00
Gaetan Craig-Riou
a977bd633b
Move rake file to the correct folder
2024-04-29 09:58:13 +10:00
kellyzhangg
f1f60a0a00
Merge branch 'master' into 8633-payments-controller-test
2024-04-25 12:24:31 -04:00
Kelly
ccf3d5873a
style fix - remove type
2024-04-25 12:24:19 -04:00
Kelly
6b5be213a3
changed location - now in requests folder
2024-04-25 12:10:32 -04:00
filipefurtad0
57f148564c
Update all locales with the latest Transifex translations
2024-04-25 16:32:56 +01:00
Filipe
e99b072442
Merge pull request #12313 from anthonyms/11482-fix-rubocop-rails-issue-has_many
...
Fix Rubocop Rails: Rails/HasManyOrHasOneDependent
2024-04-25 16:24:47 +01:00
Filipe
f269584b8e
Merge pull request #12392 from sergioosouzaa/fix/duplicate-language-display-new-user-11513
...
Fix Duplicate Language Display on New User Creation
2024-04-25 16:01:09 +01:00
Filipe
4ff832693c
Merge pull request #12412 from dacook/buu/fix-non-admin-saving-12403
...
[BUU] Fix non-admin saving
2024-04-25 12:37:11 +01:00
Rachel Arnould
09354dc80e
Merge pull request #12219 from abdellani/prevent-generate-invoices-when-distributor-cannot-invoice
...
prevent generating invoices when order's distributor can't generate invoices
2024-04-25 12:18:49 +02:00
Gaetan Craig-Riou
77a8e4d29a
Print code to run to delete address if needed
2024-04-24 16:49:47 +10:00
Gaetan Craig-Riou
9583bef0d8
Per review, handle case where a model can be linked to invalid addresses
2024-04-24 16:42:13 +10:00
Gaetan Craig-Riou
040e09414b
Add ofn:data:check_invalid_address_used task
...
It checks for invalid addresses, ie address with address1, city, phone
or country_id set to null.
It will return:
- a list of invalid address in use (associated to another
model)
- a list of invalid address not in use, ie that we can delete
2024-04-24 15:34:33 +10:00
Kelly
eda97ef3f7
fixed path
2024-04-23 22:18:45 -04:00
kellyzhangg
00742f6f0b
Merge branch 'openfoodfoundation:master' into 8633-payments-controller-test
2024-04-23 22:15:58 -04:00
Kelly
64a1fd9270
removed changes to routes.rb
2024-04-23 22:15:43 -04:00
David Cook
b846d0f517
Add ability to bulk update products for product managers
...
I forgot to do this in #12328 [BUU] Remove Stimulus Reflex from Products screen
2024-04-24 10:56:30 +10:00
Maikel
f083e851c0
Merge pull request #12408 from filipefurtad0/stripe_registered_customer
...
[VCR/Stripe] Tests payment intents for offline payments
2024-04-24 10:14:28 +10:00
Maikel Linke
2acda6af74
Ignore empty string websites on DFC API
2024-04-24 09:19:11 +10:00
Kelly
c64519ae2f
rewrote payments_controller_spec to be of request spec format
2024-04-23 12:02:32 -04:00
filipefurtad0
85e3d5d858
Tests payment intents for offline payments
...
Moves let variables outside shared examples block
Re-records cassettes
2024-04-23 12:24:00 +01:00
Anthony Musyoki
0d03cdf815
Fix Rubocop: Delete dependent stock_movements
2024-04-23 13:13:26 +03:00
Anthony Musyoki
434afb73cd
Fix Rubocop: Update handling of enterprise associations
2024-04-23 12:40:58 +03:00
Anthony Musyoki
c2cbe4f0bf
Fix Rubocop: Hard delete paranoid associations
...
As much as the associated models act_as_paranoid, it
doesnt make sense to keep them around after deleting the enterprise
2024-04-23 12:31:43 +03:00
Anthony Musyoki
645cb10864
Fix Rubocop: Do not delete Spree::Variant associations
...
Spree::Variant acts_as_paranoid and is thus not hard deleted
2024-04-23 12:31:43 +03:00
Anthony Musyoki
4140257fa1
Fix Rubocop: Do not delete dependent adjustments
...
TaxRate acts_as_paranoid iand is thus not hard_deleted
2024-04-23 12:31:43 +03:00
Anthony Musyoki
4f851bbe1f
Fix Rubocop: Do not delete dependent stock_movements
2024-04-23 12:31:43 +03:00
Anthony Musyoki
1ec453df4d
Fix Rubocop issue: Do not delete addresses having shipments
...
The reasoning is that we should not delete an address that has
ever received a shipment
2024-04-23 12:31:43 +03:00
Anthony Musyoki
5559816e12
Fix Rubocop Rails issue: Rails/HasManyOrHasOneDependent
2024-04-23 12:31:41 +03:00
Maikel Linke
5a9b9a065b
DRY website fix
2024-04-23 16:49:45 +10:00
David Cook
574e8f0135
Show error message when turbo:frame-missing
...
Instead of replacing frame contents with unhelpful text 'Content missing'.
2024-04-23 16:48:52 +10:00
David Cook
b5cdee3d65
Rename translation key
...
So that it can be used for more general purposes.
2024-04-23 16:48:52 +10:00
David Cook
d0f683d279
Spec for bug
2024-04-23 16:48:52 +10:00
kellyzhangg
d875ea044d
Merge branch 'openfoodfoundation:master' into 8633-payments-controller-test
2024-04-23 02:41:19 -04:00
Maikel Linke
64d633c64e
Publish enterprise website with https://
2024-04-23 13:50:46 +10:00
Gaetan Craig-Riou
8d166ed3e1
Merge pull request #12407 from cyrillefr/RedundantPresenceValidationOnBelongs_part_I
...
Fix RedundantPresenceValidationOnBelongs on some files
2024-04-23 10:29:48 +10:00
cyrillefr
9ae064a24f
Fix RedundantPresenceValidationOnBelongs on some files
...
- presence: true is redundant since Rails 5.0 BUT applies
with new default config of
belongs_to_required_by_default to true
Lots of files with belongs_to_required_by_default = false
(backward compatibility)
So: deleting this setting implies to adding optional: true
- added 'NOT NULL' constraints so model constraints match
with contraints on DB tables.
- updated the todo
2024-04-22 17:36:47 +02:00
Mohamed ABDELLANI
7aad4ad652
Merge branch 'master' into prevent-generate-invoices-when-distributor-cannot-invoice
2024-04-22 10:55:39 +01:00
David Cook
4a3f4136df
Merge pull request #12393 from mkllnk/lint-rubocop
...
Test all files with Rubocop, not just added code in the diff
2024-04-22 15:07:54 +10:00
Konrad
8e7f4ff908
Merge pull request #12333 from chahmedejaz/bugfix/12294-wrong-tax-category-display
...
[BUU] Fix Wrong Tax Category Display
2024-04-20 11:42:05 +02:00
Rachel Arnould
2090bc1b47
Merge pull request #12361 from dacook/buu/add-turbo
...
[BUU] Add Turbo for dynamic page loading
2024-04-19 11:44:17 +02:00
David Cook
38a4bfe98b
Update all locales with the latest Transifex translations
2024-04-18 16:54:16 +10:00
David Cook
5b043574a2
Merge pull request #12384 from mkllnk/mail-config
...
Don't pass invalid auth method "None" to net-smtp
2024-04-18 16:51:51 +10:00
