Maikel Linke
407fca17cb
Style Rails/IndexWith
2023-04-14 16:19:21 +10:00
Maikel Linke
33409725a5
Run rubocop-rails with current Rails version 7.0
...
This adds three new issues I will address in the next commits.
```
Offenses:
app/json_schemas/json_api_schema.rb:40:7: C: [Correctable] Rails/IndexWith: Prefer index_with over to_h { ... }.
relationships.to_h { |name| [name, relationship_schema(name)] }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/reporting/reports/enterprise_fee_summary/base.rb:18:11: C: [Correctable] Rails/IndexWith: Prefer index_with over map { ... }.to_h.
data_attributes.map { |attr| [attr, I18n.t("header.#{attr}", scope: i18n_scope)] }.to_h
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
lib/reporting/reports/sales_tax/sales_tax_totals_by_order.rb:140:14: C: [Correctable] Rails/Pick: Prefer pick('sum(amount)') over pluck('sum(amount)').first.
.pluck('sum(amount)').first || 0
^^^^^^^^^^^^^^^^^^^^^^^^^^
1404 files inspected, 3 offenses detected, 3 offenses autocorrectable
```
2023-04-14 16:15:13 +10:00
Maikel Linke
c70a694111
Style line length - rubocop passes completely
2023-04-14 16:12:14 +10:00
Maikel Linke
9c88c77066
Style empty lines
2023-04-14 16:05:50 +10:00
Maikel Linke
42585bb074
Remove redundant cop disable directive
2023-04-14 16:04:57 +10:00
Maikel
b0211d0930
Merge pull request #10686 from filipefurtad0/truncates_product_description
...
Sets too long line truncation spec as pending
2023-04-14 15:11:31 +10:00
Maikel
0675422509
Merge pull request #10678 from dacook/show-commit-in-ci
...
Show commit in CI
2023-04-14 14:43:44 +10:00
Maikel
5ff1b0d358
Merge pull request #10676 from filipefurtad0/fix_spec_ts_and_cs
...
Adds pending test for default ToS
2023-04-14 14:00:32 +10:00
jibees
920e2564a4
Merge pull request #10692 from openfoodfoundation/dependabot/bundler/rubocop-1.50.1
...
Bump rubocop from 1.50.0 to 1.50.1
2023-04-13 13:45:28 +02:00
dependabot[bot]
2d43e32688
Bump rubocop from 1.50.0 to 1.50.1
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.50.0 to 1.50.1.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.50.0...v1.50.1 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-13 09:57:38 +00:00
David Cook
a6cd393c57
Update all locales with the latest Transifex translations
v4.3.3
2023-04-13 16:45:38 +10:00
Filipe
b1060bf1c9
Merge pull request #10640 from openfoodfoundation/dependabot/bundler/stripe-8.5.0
...
Bump stripe from 8.3.0 to 8.5.0
2023-04-12 19:27:18 +01:00
Filipe
1bf5fbaf3a
Merge pull request #10449 from macanudo527/fix_ER
...
Update OCs after ER Permissions are Revoked
2023-04-12 18:59:20 +01:00
Konrad
2ace3afd67
Merge pull request #10606 from thejwuscript/10116-improve-bom-sorting
...
Sort orders by last name
2023-04-12 16:36:45 +02:00
Konrad
0bfceb877d
Merge pull request #10666 from jibees/9723-admin-missing-translation-in-payment-report
...
Admin, Payment reports: add missing translation for payment state
2023-04-12 15:47:23 +02:00
Filipe
c1d28b2e8f
Merge pull request #10119 from binarygit/donot-hide-producers-name-in-products
...
Display producer's name in products inspite of hide all refs option
2023-04-12 13:07:52 +01:00
Jean-Baptiste Bellet
2841b42296
Specify truncate parameter as we don't always truncate description
...
Only when too long.
2023-04-12 10:34:30 +02:00
jibees
98e44e7a40
Merge pull request #10687 from openfoodfoundation/dependabot/bundler/nokogiri-1.14.3
...
Bump nokogiri from 1.14.2 to 1.14.3
2023-04-12 10:25:56 +02:00
jibees
51c6c19f80
Merge pull request #10669 from openfoodfoundation/dependabot/bundler/sidekiq-7.0.8
...
Bump sidekiq from 7.0.7 to 7.0.8
2023-04-12 10:24:59 +02:00
dependabot[bot]
75b7a1864b
Bump nokogiri from 1.14.2 to 1.14.3
...
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri ) from 1.14.2 to 1.14.3.
- [Release notes](https://github.com/sparklemotion/nokogiri/releases )
- [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md )
- [Commits](https://github.com/sparklemotion/nokogiri/compare/v1.14.2...v1.14.3 )
---
updated-dependencies:
- dependency-name: nokogiri
dependency-type: indirect
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-12 06:24:59 +00:00
filipefurtad0
70d9cfa08e
Sets too long line truncation spec as pending
2023-04-11 19:46:11 +01:00
jibees
193ae7936e
Merge pull request #10681 from openfoodfoundation/dependabot/bundler/rubocop-1.50.0
...
Bump rubocop from 1.49.0 to 1.50.0
2023-04-11 20:40:55 +02:00
Filipe
0971e8d9b5
Merge pull request #10644 from mkllnk/report-timeout-message
...
[Hidden] Display a friendly message when a background report times out
2023-04-11 19:40:42 +01:00
Jean-Baptiste Bellet
e78b44b9ca
Do not shows <a /> if producers is hidden
...
Different style as it does not open any modal
2023-04-11 14:27:57 +02:00
binarygit
c5779eff81
Do not open modal for producer's who are 'hidden'
2023-04-11 14:27:57 +02:00
Jean-Baptiste Bellet
b616c14f63
Don't hide producer's name in products despite hide all refs opt selected
2023-04-11 14:26:47 +02:00
dependabot[bot]
f4c351febf
Bump rubocop from 1.49.0 to 1.50.0
...
Bumps [rubocop](https://github.com/rubocop/rubocop ) from 1.49.0 to 1.50.0.
- [Release notes](https://github.com/rubocop/rubocop/releases )
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop/compare/v1.49.0...v1.50.0 )
---
updated-dependencies:
- dependency-name: rubocop
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-11 10:05:30 +00:00
Maikel Linke
30184ac6aa
Background reports time out earlier than nginx
...
This allows us to display a friendly message before nginx displays its
default error.
2023-04-11 16:44:13 +10:00
David Cook
a123d45eca
Fix spec
...
It's worth noting that this page hasn't been updated by this PR.
I honestly don't know why it broke, but don't care anymore. It seems the extra `login_as_admin_and_visit` was causing a race condition on one spec. It's not necessary so I've removed this context.
Best viewed with whitespace ignored.
2023-04-11 16:38:49 +10:00
James Wu
a75f16e23c
Implement full_name_for_sorting
2023-04-11 15:25:20 +10:00
James Wu
546e90b286
Sort orders by last names
2023-04-11 15:25:20 +10:00
David Cook
bf9f47a000
Show commit in CI
...
actions/checkout@v3 actually creates a merge commit into master, to ensure you're testing the latest as close to master as possible.
That's all well and good, but quite confusing when you see errors in CI that aren't present in the actual PR branch. Hopefully this will be a clue when such confusions arise.
2023-04-11 15:22:19 +10:00
David Cook
3da6e6b5ed
Link to CI page
2023-04-11 15:22:12 +10:00
Konrad
15058299d8
Merge pull request #10641 from openfoodfoundation/dependabot/npm_and_yarn/babel/preset-env-7.21.4
...
Bump @babel/preset-env from 7.18.2 to 7.21.4
2023-04-10 20:00:06 +02:00
filipefurtad0
4e92f33b1c
DRYes spec; adds pending test for default ToS
2023-04-10 12:08:35 +01:00
Jean-Baptiste Bellet
c7cb982c9a
Update browser list
...
```
npx update-browserslist-db@latest
```
2023-04-10 11:20:19 +02:00
Jean-Baptiste Bellet
34e9112c0a
Fix dependencies warning: adds core and `plugin-transform-runtime
2023-04-10 11:20:19 +02:00
dependabot[bot]
28eb11bda5
Bump @babel/preset-env from 7.20.2 to 7.21.4
...
Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env ) from 7.20.2 to 7.21.4.
- [Release notes](https://github.com/babel/babel/releases )
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md )
- [Commits](https://github.com/babel/babel/commits/v7.21.4/packages/babel-preset-env )
---
updated-dependencies:
- dependency-name: "@babel/preset-env"
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-10 11:20:19 +02:00
jibees
d8e82d9c88
Merge pull request #10668 from openfoodfoundation/dependabot/bundler/aws-sdk-s3-1.120.1
...
Bump aws-sdk-s3 from 1.120.0 to 1.120.1
2023-04-10 11:12:45 +02:00
jibees
5192a08082
Merge pull request #10673 from openfoodfoundation/dependabot/bundler/rubocop-rails-2.19.0
...
Bump rubocop-rails from 2.18.0 to 2.19.0
2023-04-07 14:33:31 +02:00
jibees
94d3f136e2
Merge pull request #10672 from openfoodfoundation/dependabot/npm_and_yarn/floating-ui/dom-1.2.6
...
Bump @floating-ui/dom from 1.2.5 to 1.2.6
2023-04-07 14:32:45 +02:00
dependabot[bot]
db3a923ea7
Bump rubocop-rails from 2.18.0 to 2.19.0
...
Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails ) from 2.18.0 to 2.19.0.
- [Release notes](https://github.com/rubocop/rubocop-rails/releases )
- [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md )
- [Commits](https://github.com/rubocop/rubocop-rails/compare/v2.18.0...v2.19.0 )
---
updated-dependencies:
- dependency-name: rubocop-rails
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-07 09:59:34 +00:00
dependabot[bot]
619eb43c57
Bump @floating-ui/dom from 1.2.5 to 1.2.6
...
Bumps [@floating-ui/dom](https://github.com/floating-ui/floating-ui/tree/HEAD/packages/dom ) from 1.2.5 to 1.2.6.
- [Release notes](https://github.com/floating-ui/floating-ui/releases )
- [Commits](https://github.com/floating-ui/floating-ui/commits/@floating-ui/dom@1.2.6/packages/dom )
---
updated-dependencies:
- dependency-name: "@floating-ui/dom"
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-07 09:58:01 +00:00
filipefurtad0
680b6a7122
Update all locales with the latest Transifex translations
v4.3.2
2023-04-07 10:17:13 +01:00
Filipe
d9e9add78b
Merge pull request #10527 from vviekk/10456
...
Fixing 'unsaved' alert behaviour for order cycle edit forms
2023-04-06 17:05:49 +01:00
Filipe
8893824b06
Merge pull request #10635 from jibees/fix-content-security-policy-for-local-images
...
Fix content security policy: authorize `ENV["SITE_URL"]` as trusted domain for images
2023-04-06 11:25:05 +01:00
dependabot[bot]
5c221621d3
Bump sidekiq from 7.0.7 to 7.0.8
...
Bumps [sidekiq](https://github.com/sidekiq/sidekiq ) from 7.0.7 to 7.0.8.
- [Release notes](https://github.com/sidekiq/sidekiq/releases )
- [Changelog](https://github.com/sidekiq/sidekiq/blob/main/Changes.md )
- [Commits](https://github.com/sidekiq/sidekiq/compare/v7.0.7...v7.0.8 )
---
updated-dependencies:
- dependency-name: sidekiq
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-06 09:58:23 +00:00
dependabot[bot]
60d7ed5036
Bump aws-sdk-s3 from 1.120.0 to 1.120.1
...
Bumps [aws-sdk-s3](https://github.com/aws/aws-sdk-ruby ) from 1.120.0 to 1.120.1.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases )
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-s3/CHANGELOG.md )
- [Commits](https://github.com/aws/aws-sdk-ruby/commits )
---
updated-dependencies:
- dependency-name: aws-sdk-s3
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-04-06 09:57:53 +00:00
Filipe
e71a747925
Merge pull request #10667 from jibees/10662-flaky-specqueriescustomers_with_balance_specrb26
...
Flaky: Avoid flaky spec by sorting array before comparing on `spec/queries/customers_with_balance_spec.rb:26`
2023-04-06 10:47:32 +01:00
Jean-Baptiste Bellet
eedd421055
Avoid flaky spec by sorting array before comparing
2023-04-06 10:41:42 +02:00