Gaetan Craig-Riou
3ec58d8791
Add #vouchers, return an array of voucher adjustments
2023-05-15 13:42:37 +10:00
Gaetan Craig-Riou
9b680e1a92
Add CalculatedAdjustments to Voucher
...
Vouchers are only flat rate of 10 for now, so we add a FlatRate
calculator in a before_validation callback
2023-05-15 13:42:37 +10:00
Gaetan Craig-Riou
f7ee01b9f8
Add voucher input on checkout payment's step
...
Voucher input is displayed only if the distributor has any voucher
2023-05-15 13:42:37 +10:00
Maikel
4f7059d0c7
Merge pull request #10838 from filipefurtad0/fix_negative_adjustment_error
...
Adds minus sign to validation criteria
v4.3.8
2023-05-15 11:07:45 +10:00
Gaetan Craig-Riou
d715b6b3bb
Spec fix LocalisedNumber validation to allow negative number
...
As part of this PR https://github.com/openfoodfoundation/openfoodnetwork/pull/10329
LocalisedNumber validation was tightened, but that means negative number
were not valid anymore.
This commit has been cherry-picked after this fix has already been
applied. Now we just change the order of characters in the regex because
humans are used to reading the minus at the beginning of the number. But
this change doesn't change the logic at all.
2023-05-15 10:55:59 +10:00
Maikel
5045e26792
Merge pull request #10834 from mkllnk/variant-spec
...
Improve readability and performance of variant spec
2023-05-15 09:48:06 +10:00
filipefurtad0
0442f2da7e
Fixes spec warning
...
An example was being ignored due to legacy syntax - WARNING: ignoring the provided expectation message argument since it is not a string or a proc.
2023-05-14 23:02:44 +01:00
filipefurtad0
e7ab839fb3
Adds minus sign as validation criteria
...
Removes pending from passing examples
2023-05-14 23:02:44 +01:00
filipefurtad0
596b318778
Adds spec on negative adjustment
...
with different localization settings
Using shared examples and setting failing
ones as pending
2023-05-14 23:02:00 +01:00
Filipe
3c7337b53a
Merge pull request #10836 from jibees/10835-on-small-width-screen-the-cart-element-is-missplaced
...
Fix bad indentation (and hierarchy) of DOM elements causing bad rendering on small width screens
v4.3.7
2023-05-12 11:24:49 +01:00
Jean-Baptiste Bellet
60edb4363e
Fix bad indentation (and hierarchy)
...
`%section` must be siblings each others
introduced by https://github.com/openfoodfoundation/openfoodnetwork/pull/10772
2023-05-12 09:30:37 +02:00
Maikel Linke
87c4c5373b
Spec more variant naming with realistic data
2023-05-12 14:10:54 +10:00
Maikel Linke
f70607259a
Spec Variant#product_and_full_name with real data
...
Mocking skips a lot of code execution which we want to test as well.
2023-05-12 13:34:34 +10:00
Maikel Linke
ce180caad9
Test with in-memory data when possible
...
This should speed up specs but I observed only one second less run time.
2023-05-12 13:21:58 +10:00
Maikel Linke
01be934caf
Reduce spec run time by not creating unused subject
...
The `variant` instance isn't used in all specs and doesn't need to be
created every time. This reduced run time from 1min5sec to 43sec on my
machine.
2023-05-12 13:21:58 +10:00
Maikel Linke
54c6559b97
Move Spree::Variant spec out of Spree module
...
I also discovered that some specs were just in the Spee module and not
within the `describe Variant` block. I moved them inside the block.
2023-05-12 13:21:19 +10:00
Maikel
93c0a06403
Merge pull request #10829 from filipefurtad0/flaky_order_spec_error
...
Splits assertions to allow JS table populate
2023-05-12 11:49:06 +10:00
Filipe
1bdb668cd3
Merge pull request #10769 from Matt-Yorkley/visible-line-items-query
...
Improve `Permissions::Order#visible_line_items` querying
2023-05-11 15:36:32 +01:00
filipefurtad0
d035d4bb87
Update all locales with the latest Transifex translations
2023-05-11 15:25:39 +01:00
filipefurtad0
f5eb72c804
Adds sleep(1)
2023-05-11 11:29:24 +01:00
Konrad
2836751698
Merge pull request #10805 from jibees/10717-bo-orders-changing-customer-does-not-update-customer_id
...
Admin, Edit customer details for an order: when changing to another customer, update `customer_id` as well
2023-05-10 19:08:57 +02:00
Filipe
bf7a559a32
Merge pull request #10772 from Matt-Yorkley/view-caching
...
Locale-aware Fragment Caching
2023-05-10 11:18:08 +01:00
Matt-Yorkley
d90653c682
Merge pull request #10793 from jibees/fix-webpack-configuration-use-the-default-one
...
Use the default webpack configuration for dev env
2023-05-10 10:09:28 +01:00
jibees
ca5300284c
Merge pull request #10820 from Matt-Yorkley/js-dependencies
...
Remove indirect JS dependencies
2023-05-10 09:57:05 +02:00
Matt-Yorkley
406cb572ea
Remove indirect JS dependencies
2023-05-10 09:27:00 +02:00
jibees
ca90b5cee2
Merge pull request #10810 from openfoodfoundation/dependabot/bundler/aws-sdk-s3-1.122.0
...
Bump aws-sdk-s3 from 1.121.0 to 1.122.0
2023-05-10 09:23:44 +02:00
jibees
760860a06d
Merge pull request #10811 from openfoodfoundation/dependabot/bundler/knapsack_pro-3.11.0
...
Bump knapsack_pro from 3.10.0 to 3.11.0
2023-05-10 09:21:46 +02:00
jibees
189207f751
Merge pull request #10822 from openfoodfoundation/dependabot/bundler/debug-1.8.0
...
Bump debug from 1.7.2 to 1.8.0
2023-05-10 09:20:34 +02:00
Matt-Yorkley
1bd9182cea
Update menu cache blocks
2023-05-09 16:46:09 +01:00
dependabot[bot]
969d0b6687
Bump debug from 1.7.2 to 1.8.0
...
Bumps [debug](https://github.com/ruby/debug ) from 1.7.2 to 1.8.0.
- [Release notes](https://github.com/ruby/debug/releases )
- [Commits](https://github.com/ruby/debug/compare/v1.7.2...v1.8.0 )
---
updated-dependencies:
- dependency-name: debug
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-09 10:03:20 +00:00
David Cook
8fe20ecfbe
Merge pull request #10794 from openfoodfoundation/dependabot/npm_and_yarn/babel/core-7.21.8
...
Bump @babel/core from 7.21.5 to 7.21.8
2023-05-09 16:37:42 +10:00
Maikel
83141ec05c
Merge pull request #10818 from mkllnk/schema-order
...
Fixup order of statements in db schema
2023-05-09 14:21:03 +10:00
Matt-Yorkley
4b707b9310
Extract locale file digest logic to a separate class and add tests
2023-05-08 14:09:00 +01:00
Matt-Yorkley
1c277e5547
Cache some html fragments
2023-05-08 14:07:50 +01:00
Matt-Yorkley
be48a6c295
Implement cache_with_locale helper for fragment caching with locales
2023-05-08 14:07:50 +01:00
Matt-Yorkley
11f45dc2f8
Give ContentConfig an updated_at attribute and a usable cache_key
2023-05-08 14:07:50 +01:00
Konrad
4303cabe56
Merge pull request #10792 from mkllnk/feature-deletion
...
Remove unknown (deleted) feature toggles at boot
2023-05-08 14:49:42 +02:00
Maikel Linke
f1f3ecc4f7
Fixup order of statements in db schema
...
It looks like the resolution of a merge conflict introduced the wrong
ordering of schema statements. Rails wants to sort tables alphabetically
and running `./bin/rails db:migrate` on a fresh database altered the
schema.rb file. This should be fixed here.
Rails also omits the default setting of `precision: 6` since Rails 7.
The vouchers feature was developed during the upgrade to Rails 7.
2023-05-08 14:37:33 +10:00
Maikel
ad033e8d44
Merge pull request #10767 from Matt-Yorkley/remove-session-cookie-upgrader
...
Remove SessionCookieUpgrader from middleware
2023-05-08 12:50:42 +10:00
Gaetan Craig-Riou
f25a3650bd
Merge pull request #10802 from openfoodfoundation/dependabot/bundler/ddtrace-1.11.1
...
Bump ddtrace from 1.11.0 to 1.11.1
2023-05-08 11:45:07 +10:00
Konrad
e4d8dd9f87
Merge pull request #10780 from dacook/enable-prettier-css
...
Enable prettier for Admin SCSS
2023-05-06 18:24:58 +02:00
dependabot[bot]
b29d38f3fb
Bump knapsack_pro from 3.10.0 to 3.11.0
...
Bumps [knapsack_pro](https://github.com/KnapsackPro/knapsack_pro-ruby ) from 3.10.0 to 3.11.0.
- [Changelog](https://github.com/KnapsackPro/knapsack_pro-ruby/blob/master/CHANGELOG.md )
- [Commits](https://github.com/KnapsackPro/knapsack_pro-ruby/compare/v3.10.0...v3.11.0 )
---
updated-dependencies:
- dependency-name: knapsack_pro
dependency-type: direct:development
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-05 10:01:08 +00:00
dependabot[bot]
1c52fe1648
Bump aws-sdk-s3 from 1.121.0 to 1.122.0
...
Bumps [aws-sdk-s3](https://github.com/aws/aws-sdk-ruby ) from 1.121.0 to 1.122.0.
- [Release notes](https://github.com/aws/aws-sdk-ruby/releases )
- [Changelog](https://github.com/aws/aws-sdk-ruby/blob/version-3/gems/aws-sdk-s3/CHANGELOG.md )
- [Commits](https://github.com/aws/aws-sdk-ruby/commits )
---
updated-dependencies:
- dependency-name: aws-sdk-s3
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-05 09:59:02 +00:00
David Cook
a170b93cc1
Simplify further
...
Co-authored-by: Maikel <maikel@email.org.au >
2023-05-05 15:34:23 +10:00
Maikel Linke
2a943ecafb
Spec setting up all feature toggle names
2023-05-05 11:09:10 +10:00
Jean-Baptiste Bellet
3a1579104f
Submit customer_id as params when updating customer details on order
2023-05-04 16:40:58 +02:00
jibees
ec4c7b79bf
Merge pull request #10803 from openfoodfoundation/dependabot/bundler/rspec-rails-6.0.2
...
Bump rspec-rails from 6.0.1 to 6.0.2
2023-05-04 13:55:37 +02:00
dependabot[bot]
9f12295a89
Bump rspec-rails from 6.0.1 to 6.0.2
...
Bumps [rspec-rails](https://github.com/rspec/rspec-rails ) from 6.0.1 to 6.0.2.
- [Release notes](https://github.com/rspec/rspec-rails/releases )
- [Changelog](https://github.com/rspec/rspec-rails/blob/main/Changelog.md )
- [Commits](https://github.com/rspec/rspec-rails/compare/v6.0.1...v6.0.2 )
---
updated-dependencies:
- dependency-name: rspec-rails
dependency-type: direct:development
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-04 09:58:54 +00:00
dependabot[bot]
46fd6b1a3a
Bump ddtrace from 1.11.0 to 1.11.1
...
Bumps [ddtrace](https://github.com/DataDog/dd-trace-rb ) from 1.11.0 to 1.11.1.
- [Release notes](https://github.com/DataDog/dd-trace-rb/releases )
- [Changelog](https://github.com/DataDog/dd-trace-rb/blob/master/CHANGELOG.md )
- [Commits](https://github.com/DataDog/dd-trace-rb/compare/v1.11.0...v1.11.1 )
---
updated-dependencies:
- dependency-name: ddtrace
dependency-type: direct:production
update-type: version-update:semver-patch
...
Signed-off-by: dependabot[bot] <support@github.com >
2023-05-04 09:58:25 +00:00
Jean-Baptiste Bellet
8a5608435c
Update all locales with the latest Transifex translations
v4.3.6
2023-05-03 17:30:48 +02:00